[Bug 1982619] Review Request: php-fgrosse-phpasn1 - A PHP Framework that allows you to encode and decode arbitrary ASN.1 structures
https://bugzilla.redhat.com/show_bug.cgi?id=1982619 --- Comment #8 from Tomas Hrcka --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/php-fgrosse-phpasn1 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1982619] Review Request: php-fgrosse-phpasn1 - A PHP Framework that allows you to encode and decode arbitrary ASN.1 structures
https://bugzilla.redhat.com/show_bug.cgi?id=1982619 --- Comment #7 from Christopher Engelhard --- (In reply to Otto Urpelainen from comment #6) > If you get in touch with upstream about phpunit 9 support, > you could take care of this warning that is currently emitted: Will do. > I will take one more of your php requests when I find the time, > assuming there are still some left. that would be great, thank you. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1982619] Review Request: php-fgrosse-phpasn1 - A PHP Framework that allows you to encode and decode arbitrary ASN.1 structures
https://bugzilla.redhat.com/show_bug.cgi?id=1982619 Otto Urpelainen changed: What|Removed |Added Flags|fedora-review? |fedora-review+ |needinfo?(otu...@iki.fi)| --- Comment #6 from Otto Urpelainen --- Thank you for packaging this, everything looks good, so review passed. It is good if you can discuss the naming scheme with upstream. For now, the current naming scheme is ok as discussed above. Fedora actually has phpunit available from major version 6 onwards, so even staying with 7 would have been acceptable, it is not a huge deal to use an end-of-life test runner. Of course it is much better that you patched the tests so a newer version can be used. If you get in touch with upstream about phpunit 9 support, you could take care of this warning that is currently emitted: > Warning - The configuration file did not pass validation! > The following problems have been detected: > > Line 12: > - Element 'phpunit', attribute 'syntaxCheck': The attribute 'syntaxCheck' is > not allowed. > > Test results may not be as expected. Apparently, the warning is harmless in itself, but that attribute could and should just be removed [1]. [1]: https://stackoverflow.com/a/44331140 I will take one more of your php requests when I find the time, assuming there are still some left. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1982619] Review Request: php-fgrosse-phpasn1 - A PHP Framework that allows you to encode and decode arbitrary ASN.1 structures
https://bugzilla.redhat.com/show_bug.cgi?id=1982619 --- Comment #5 from Christopher Engelhard --- Spec URL: https://download.copr.fedorainfracloud.org/results/lcts/nextcloud/fedora-rawhide-x86_64/02363088-php-fgrosse-phpasn1/php-fgrosse-phpasn1.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/lcts/nextcloud/fedora-rawhide-x86_64/02363088-php-fgrosse-phpasn1/php-fgrosse-phpasn1-2.3.0-1.fc35.src.rpm Sorry, new build, the previous one failed on 32bit arches due to problems with the tests. I've worked around those and opened an issue upstream: https://github.com/fgrosse/PHPASN1/issues/84 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1982619] Review Request: php-fgrosse-phpasn1 - A PHP Framework that allows you to encode and decode arbitrary ASN.1 structures
https://bugzilla.redhat.com/show_bug.cgi?id=1982619
Christopher Engelhard changed:
What|Removed |Added
Flags|needinfo?(c...@lcts.de) |needinfo?(otu...@iki.fi)
--- Comment #4 from Christopher Engelhard ---
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/lcts/nextcloud/fedora-rawhide-x86_64/02358089-php-fgrosse-phpasn1/php-fgrosse-phpasn1.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/lcts/nextcloud/fedora-rawhide-x86_64/02358089-php-fgrosse-phpasn1/php-fgrosse-phpasn1-2.3.0-1.fc35.src.rpm
Sorry for the delay, $DAYJOB intervened.
(In reply to Otto Urpelainen from comment #1)
> 1.
> > Summary:Thin assertion library for input validation in business
> > models
>
> In composer.json it is:
> "A PHP Framework that allows you to encode and decode arbitrary ASN.1
> structures using the ITU-T X.690 Encoding Rules."
> "
Fixed.
> 2.
> > Autoloader: %{_datadir}/php/%{ns_dir}/autoload.php
>
> You may want to use the less specfile tag looking formatting here.
Changed it to the same format as in php-league-uri-interfaces
> 3.
> > : Create a PSR-0 tree
> > mkdir -p %{buildroot}%{_datadir}/php/%{ns_dir}
> > cp -pr lib/* %{buildroot}%{_datadir}/php/%{ns_dir}
>
> In another review it was suggested
> that %{ns_dir} should have two components: vendor and project [1].
> Should the same logic apply here?
> That would create a path fgrosse/FG, with FG being the project name.
> That sounds strange, but perhaps that is just because
> upstream chose a strange namespace name for this project?
>
> [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1982616#c2
As Remi pointed out, this library is a bit of a mess. It's also the only
library the vendor has, so I think it's unlikely there will be any conflict
anytime soon. I left it at php/FG/.. for now, but I'll see if upstream is
interested in bringing a bit more order into this.
> 4.
> > %if 0%{?with_tests}
> > : Run tests
> > : No tests implemented
> > %endif
>
> Upstream has them. I suppose makesrc.sh needs to be introduced.
Did that. I added a small patch to make the tests work with PHPUnit 8 since 7
is EOL. They can also be made compatible with PHPUnit 9, but that patch is
quite extensive. If you're OK with that I'd prefer to take that upstream since
PHPUnit 8 is still fully supported.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1982619] Review Request: php-fgrosse-phpasn1 - A PHP Framework that allows you to encode and decode arbitrary ASN.1 structures
https://bugzilla.redhat.com/show_bug.cgi?id=1982619 --- Comment #3 from Otto Urpelainen --- (In reply to Remi Collet from comment #2) > Looks like FG is really the "vendor" part, and this library is in fact 3 > libraries... (ASN1, Utility and X509)... uggly > > So ns_dir FG is probably fine... conflicts will have to be fixed later, if > happen (ex if another FG library also have a Utility sub project...) Thank you Remi. I am fine with using this interpretation. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1982619] Review Request: php-fgrosse-phpasn1 - A PHP Framework that allows you to encode and decode arbitrary ASN.1 structures
https://bugzilla.redhat.com/show_bug.cgi?id=1982619 --- Comment #2 from Remi Collet --- Looks like FG is really the "vendor" part, and this library is in fact 3 libraries... (ASN1, Utility and X509)... uggly So ns_dir FG is probably fine... conflicts will have to be fixed later, if happen (ex if another FG library also have a Utility sub project...) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1982619] Review Request: php-fgrosse-phpasn1 - A PHP Framework that allows you to encode and decode arbitrary ASN.1 structures
https://bugzilla.redhat.com/show_bug.cgi?id=1982619 Didik Supriadi changed: What|Removed |Added Status|NEW |ASSIGNED CC||didiksupriad...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1982619] Review Request: php-fgrosse-phpasn1 - A PHP Framework that allows you to encode and decode arbitrary ASN.1 structures
https://bugzilla.redhat.com/show_bug.cgi?id=1982619
Otto Urpelainen changed:
What|Removed |Added
CC||otu...@iki.fi
Assignee|nob...@fedoraproject.org|otu...@iki.fi
Flags||fedora-review?
||needinfo?(c...@lcts.de)
--- Comment #1 from Otto Urpelainen ---
Reviewed.
1.
> Summary:Thin assertion library for input validation in business models
In composer.json it is:
"A PHP Framework that allows you to encode and decode arbitrary ASN.1
structures using the ITU-T X.690 Encoding Rules."
"
2.
> Autoloader: %{_datadir}/php/%{ns_dir}/autoload.php
You may want to use the less specfile tag looking formatting here.
3.
> : Create a PSR-0 tree
> mkdir -p %{buildroot}%{_datadir}/php/%{ns_dir}
> cp -pr lib/* %{buildroot}%{_datadir}/php/%{ns_dir}
In another review it was suggested
that %{ns_dir} should have two components: vendor and project [1].
Should the same logic apply here?
That would create a path fgrosse/FG, with FG being the project name.
That sounds strange, but perhaps that is just because
upstream chose a strange namespace name for this project?
[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1982616#c2
4.
> %if 0%{?with_tests}
> : Run tests
> : No tests implemented
> %endif
Upstream has them. I suppose makesrc.sh needs to be introduced.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1982619] Review Request: php-fgrosse-phpasn1 - A PHP Framework that allows you to encode and decode arbitrary ASN.1 structures
https://bugzilla.redhat.com/show_bug.cgi?id=1982619 Christopher Engelhard changed: What|Removed |Added Blocks|1982651 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1982651 [Bug 1982651] Review Request: php-web-auth-metadata-service - Metadata Service for FIDO2/Webauthn -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1982619] Review Request: php-fgrosse-phpasn1 - A PHP Framework that allows you to encode and decode arbitrary ASN.1 structures
https://bugzilla.redhat.com/show_bug.cgi?id=1982619 Christopher Engelhard changed: What|Removed |Added Blocks||1982648, 1982651, 1982652 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1982648 [Bug 1982648] Review Request: php-web-auth-cose-lib - CBOR Object Signing and Encryption (COSE) For PHP https://bugzilla.redhat.com/show_bug.cgi?id=1982651 [Bug 1982651] Review Request: php-web-auth-metadata-service - Metadata Service for FIDO2/Webauthn https://bugzilla.redhat.com/show_bug.cgi?id=1982652 [Bug 1982652] Review Request: php-web-auth-webauthn-lib - FIDO2/Webauthn Support For PHP -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1982619] Review Request: php-fgrosse-phpasn1 - A PHP Framework that allows you to encode and decode arbitrary ASN.1 structures
https://bugzilla.redhat.com/show_bug.cgi?id=1982619 Christopher Engelhard changed: What|Removed |Added Summary|Review Request: |Review Request: |php-fgrosse-phpasn1 - Thin |php-fgrosse-phpasn1 - A PHP |assertion library for input |Framework that allows you |validation in business |to encode and decode |models |arbitrary ASN.1 structures Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
