[Bug 1989386] Review Request: golang-github-jwt - A go implementation of JSON Web Tokens.
https://bugzilla.redhat.com/show_bug.cgi?id=1989386 Ondřej Budai changed: What|Removed |Added Resolution|--- |RAWHIDE Status|NEW |CLOSED Last Closed||2021-08-16 17:00:24 --- Comment #5 from Ondřej Budai --- We now have builds in all supported Fedora versions, closing this. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989386] Review Request: golang-github-jwt - A go implementation of JSON Web Tokens.
https://bugzilla.redhat.com/show_bug.cgi?id=1989386 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-jwt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989386] Review Request: golang-github-jwt - A go implementation of JSON Web Tokens.
https://bugzilla.redhat.com/show_bug.cgi?id=1989386 Link Dupont changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Link Dupont --- > I think it's reasonable to create a 2nd `golang-github-jwt-v4` package. Yes. I didn't notice they added the modules and appended the version to the module path. That's perfect. I think that the go2rpm tool even supports that correctly, and if given the /v4 import path, it will generate a golang-github-jwt-4 package for you. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989386] Review Request: golang-github-jwt - A go implementation of JSON Web Tokens.
https://bugzilla.redhat.com/show_bug.cgi?id=1989386 Sanne Raymaekers changed: What|Removed |Added CC||sraym...@redhat.com Flags|needinfo?(obu...@redhat.com | |) | --- Comment #2 from Sanne Raymaekers --- Thank you for the review! I updated the spec according to your notes: https://download.copr.fedorainfracloud.org/results/obudai/golang-github-jwt/fedora-rawhide-x86_64/02517463-golang-github-jwt/golang-github-jwt.spec result directory: https://download.copr.fedorainfracloud.org/results/obudai/golang-github-jwt/fedora-rawhide-x86_64/02517463-golang-github-jwt/ > [NOTE] A new upstream version (4.0.0) was released 7 days ago, as of this > writing. Indeed, v4 introduces go module support, but also requires all users to update their import paths. Most projects still depend on v3.2.2, which is also only 12 days old, and which will still receive security updates. Somewhere down the line this package should switch to v4, if support is needed by anyone now, I think it's reasonable to create a 2nd `golang-github-jwt-v4` package. (Fedora Account System Username: gundersanne) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989386] Review Request: golang-github-jwt - A go implementation of JSON Web Tokens.
https://bugzilla.redhat.com/show_bug.cgi?id=1989386 Link Dupont changed: What|Removed |Added Assignee|nob...@fedoraproject.org|l...@sub-pop.net CC||l...@sub-pop.net Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989386] Review Request: golang-github-jwt - A go implementation of JSON Web Tokens.
https://bugzilla.redhat.com/show_bug.cgi?id=1989386
Link Dupont changed:
What|Removed |Added
Flags||needinfo?(obu...@redhat.com
||)
--- Comment #1 from Link Dupont ---
[FIX] Your name has some unicode character encoding issue in the %changelog
[FIX] The %changelog includes the %{?dist} macro; over time, that macro will
update what it expands to, causing the historical entries in %changelog
to
change too. I suggest removing %{dist} from the %changelog entries.
They're not necessary or required.
[FIX] Two separate README.md files are listed in %docs. These will conflict
with
each other and cause a warning in the build logs.
"warning: File listed twice:
/usr/share/doc/golang-github-jwt-devel/README.md"
If both README files are needed, one should be manually installed into
the
doc dir under a different name (i.e. README-jwt.md).
[NOTE] Lots of other packages own /usr/share/gocode/src/github.com. If this is
incorrect, it's a bug in the golang macros that needs to be addressed.
It's not something that can be fixed here.
[NOTE] A new upstream version (4.0.0) was released 7 days ago, as of this
writing.
[NOTE] The -devel subpackage does not explicitly require the main package, but
that is not a problem. The main package is not required when compiling a
project that uses the "jwt" Go package.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package does not contain duplicates in %files.
Note: warning: File listed twice: /usr/share/doc/golang-github-
jwt/README.md
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_duplicate_files
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "MIT License", "Unknown or
generated". 54 files have unknown license. Detailed output of
licensecheck in /home/link/1989386-golang-github-jwt/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by other packages:
/usr/share/gocode/src/github.com
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
