needinfo canceled: [Bug 2060621] Review Request: python-abstract - Create and draw computer science graph data structures

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Jakub Kadlčík  has canceled Package Review
's request for Jakub Kadlčík
's needinfo:
Bug 2060621: Review Request: python-abstract - Create and draw computer science
graph data structures
https://bugzilla.redhat.com/show_bug.cgi?id=2060621



--- Comment #4 from Jakub Kadlčík  ---
> If you're not interested in reviewing this ticket anymore

I am interested in reviewing this ticket but there is no response from the
contributor.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2060621] Review Request: python-abstract - Create and draw computer science graph data structures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=2060621

Jakub Kadlčík  changed:

   What|Removed |Added

  Flags|needinfo?(jkadlcik@redhat.c |
   |om) |



--- Comment #4 from Jakub Kadlčík  ---
> If you're not interested in reviewing this ticket anymore

I am interested in reviewing this ticket but there is no response from the
contributor.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2060621

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202060621%23c4
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2060621] Review Request: python-abstract - Create and draw computer science graph data structures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=2060621



--- Comment #2 from Jakub Kadlčík  ---
> Mock - 
> https://fedoraproject.org/wiki/Using_Mock_to_test_package_builds#How_do_I_use_Mock?
> (Don't worry about the document length, using mock is quite simple. The only
> important section for you is the "How do I use Mock?")

I couldn't find any simple-enough Mock tutorial, that isn't part of a longer
article. 
So I wrote this one http://frostyx.cz/posts/using-mock-is-easy


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2060621
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2060621] Review Request: python-abstract - Create and draw computer science graph data structures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=2060621

Jakub Kadlčík  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   | -   |graph data structures




-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2060621
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2060621] Review Request: -

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=2060621

Jakub Kadlčík  changed:

   What|Removed |Added

  Flags||fedora-review?
   Assignee|nob...@fedoraproject.org|jkadl...@redhat.com




-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2060621
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2060621] Review Request: -

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=2060621

Jakub Kadlčík  changed:

   What|Removed |Added

   Doc Type|--- |If docs needed, set a value
 CC||jkadl...@redhat.com



--- Comment #1 from Jakub Kadlčík  ---
Hello Robert,
thank you very much for the package.

Overall, the spec file looks very good, but there is a couple of things that we
need to fix. 


> Spec URL: 
> 
> SRPM URL: 
> 

It's a bit unusual to have the < pointy brackets > there, but it's okay.
However,
the links need to point directly to the raw file / file download. In the case
of the spec, you want to go to the link you posted, click the "Raw" button, and
use that URL. For the SRPM, you want to "Copy link address" for the "Download"
button and use that.

There are tools that we use for the review, that download those files, so they
need direct links. 


> Summary: Python library for creating and drawing graphs and taking advantage 
> of graph properties

I think there is no such rule (packaging guidelines don't say so) but
generally, it is a good idea to make the summary at max 80 characters long.

When you imagine searching packages in GUI package managers or in DNF, they
typically show package name and summary on the same line, also people often
don't
have the window maximalized, so we want to display all the information in some
reasonable width. 

I would probably drop the "python library for", that's obvious from the package
name and change the verbs from -ing form to their simple form, e.g. "Create and
draw graphs and take ...". Just a suggestion, we can go with anything else that
works for you better.


> Prefix: %{_prefix}

Does some tutorial recommend this? I believe this is a historical thing. I
think
you can safely remove it now.


> %description
> Abstract is a Python library for creating and drawing graphs
> and taking advantage of graph properties.

This is basically a copy-pasted summary, we try to avoid that. Can you please
write a few sentences describing the package, what it is good for and what it
can do? There is a lot of text in the project README, I think we can condense
it
into a short description paragraph.


> %build
> %py3_build

The package builds correctly on your system because you already have some
python
dependencies installed, but if you try to build it in a minimal chroot (that's
how it is going to be done in Fedora), it fails with

+ %py3_build
/var/tmp/rpm-tmp.GUgMDY: line 42: fg: no job control
error: Bad exit status from /var/tmp/rpm-tmp.GUgMDY (%build)

That's because of a missing BuildRequires for python3-devel.

It is a good idea to build your package in Copr or Mock, they will reveal all
the missing BuildRequires that you forgot.

Copr - https://docs.pagure.org/copr.copr/screenshots_tutorial.html

Mock -
https://fedoraproject.org/wiki/Using_Mock_to_test_package_builds#How_do_I_use_Mock?
(Don't worry about the document length, using mock is quite simple. The only
important section for you is the "How do I use Mock?")


> %changelog
> * Sat Feb 26 2022 Robert Santos  and Ali Dia 
> 
> * - First abstract package

The changelog is in an unexpected format, please take a look here
https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs

I haven't seen any changelog entries by two authors at the same time, but I
believe in giving people the credit that they deserve for their work. Maybe
let's
have only one of you in the changelog entry and appreciate the other in a
comment above? (each line that starts with # is a comment)

Also, the second line shouldn't start with *, see the link above.


---

Sorry for a lengthy comment, in fact, all of those things are easy-fixes and
overall the package looks really good.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2060621
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 2060621] Review Request: -

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=2060621

Robert Santos  changed:

   What|Removed |Added

Comment|0   |updated



--- Comment #0 has been edited ---

Spec URL:

SRPM URL:

Description: 
Fedora Account System Username: rs78

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2060621
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure