[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
https://bugzilla.redhat.com/show_bug.cgi?id=739416 Robert Scheck red...@linuxnetz.de changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #18 from Robert Scheck red...@linuxnetz.de --- Package Change Request == Package Name: php-php-gettext New Branches: epel7 Owners: robert -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
https://bugzilla.redhat.com/show_bug.cgi?id=739416 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
https://bugzilla.redhat.com/show_bug.cgi?id=739416 --- Comment #19 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739416 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|php-php-gettext-1.0.11-3.el |php-php-gettext-1.0.11-4.el |5 |4 --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2011-10-18 15:32:31 EDT --- php-php-gettext-1.0.11-4.el4 has been pushed to the Fedora EPEL 4 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739416 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|php-php-gettext-1.0.11-3.fc |php-php-gettext-1.0.11-3.el |14 |6 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2011-10-11 15:26:15 EDT --- php-php-gettext-1.0.11-3.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739416 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|php-php-gettext-1.0.11-3.el |php-php-gettext-1.0.11-3.el |6 |5 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2011-10-11 15:27:01 EDT --- php-php-gettext-1.0.11-3.el5 has been pushed to the Fedora EPEL 5 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739416 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2011-10-04 17:16:34 EDT --- php-php-gettext-1.0.11-3.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739416 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||php-php-gettext-1.0.11-3.fc ||16 Resolution||ERRATA Last Closed||2011-10-04 17:16:46 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739416 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2011-10-04 23:54:31 EDT --- php-php-gettext-1.0.11-3.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739416 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2011-10-04 23:58:03 EDT --- php-php-gettext-1.0.11-3.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739416 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|php-php-gettext-1.0.11-3.fc |php-php-gettext-1.0.11-3.fc |15 |14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739416 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|php-php-gettext-1.0.11-3.fc |php-php-gettext-1.0.11-3.fc |16 |15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739416 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2011-09-26 12:47:59 EDT --- php-php-gettext-1.0.11-3.fc16 has been pushed to the Fedora 16 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739416 --- Comment #4 from Jon Ciesla l...@jcomserv.net 2011-09-25 16:31:08 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739416 --- Comment #5 from Fedora Update System upda...@fedoraproject.org 2011-09-25 17:24:25 EDT --- php-php-gettext-1.0.11-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/php-php-gettext-1.0.11-3.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739416 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2011-09-25 17:24:31 EDT --- php-php-gettext-1.0.11-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/php-php-gettext-1.0.11-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739416 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2011-09-25 17:24:49 EDT --- php-php-gettext-1.0.11-3.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/php-php-gettext-1.0.11-3.el4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739416 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2011-09-25 17:24:27 EDT --- php-php-gettext-1.0.11-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/php-php-gettext-1.0.11-3.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739416 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2011-09-25 17:24:36 EDT --- php-php-gettext-1.0.11-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-php-gettext-1.0.11-3.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739416 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2011-09-25 17:24:41 EDT --- php-php-gettext-1.0.11-3.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/php-php-gettext-1.0.11-3.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739416 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739416 Remi Collet fed...@famillecollet.com changed: What|Removed |Added CC||fed...@famillecollet.com AssignedTo|nob...@fedoraproject.org|fed...@famillecollet.com Flag||fedora-review? --- Comment #1 from Remi Collet fed...@famillecollet.com 2011-09-24 12:12:23 EDT --- Taking -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739416
Remi Collet fed...@famillecollet.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #2 from Remi Collet fed...@famillecollet.com 2011-09-24 12:26:42
EDT ---
=== FORMAL REVIEW ===
-=N/A x=Check !=Problem, ?=Not evaluated
=== REQUIRED ITEMS ===
[!] Rpmlint output:
php-php-gettext.noarch: E: incorrect-fsf-address
/usr/share/php/gettext/streams.php
php-php-gettext.noarch: E: incorrect-fsf-address
/usr/share/doc/php-php-gettext-1.0.11/COPYING
php-php-gettext.noarch: E: incorrect-fsf-address
/usr/share/php/gettext/gettext.php
php-php-gettext.noarch: E: incorrect-fsf-address
/usr/share/php/gettext/gettext.inc
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines including the PHP specific items
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type: GPLv2+
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
md5sum : c085ef92974358adb0faf9350f7973ec php-gettext-1.0.11.tar.gz
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: f15 x86_64
[x] Package is not known to require ExcludeArch
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[-] Packages don't bundle copies of system librarie
[-] Package is not relocatable.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -static subpackage, if present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages with %{?_isa}, if present.
[-] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
[x] All filenames in rpm packages must be valid UTF-8
[x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS ===
[x] Final requires
php-common
php-mbstring
[x] Final provides
php-php-gettext = 1.0.11-3.fc15
[x] Latest version is packaged.
[-] If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[-] The description and summary sections in the package spec file should
contain
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: Koji f16
http://koji.fedoraproject.org/koji/taskinfo?taskID=3373578
[-] The package should compile and build into binary rpms on all supported
architectures.
Tested on:
[x] Package functions as described.
[-] If scriptlets are used, those scriptlets must be sane.
[-] If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin
consider requiring the package which provides the file instead of the file
itself.
[-] your package should contain man pages for binaries/scripts.
If it doesn't, work with upstream to add them where they make sense.
[-] The placement of pkgconfig(.pc) files is correct.
[-] %check is present and the tests pass
SHOULD:
report incorrect-fsf-address upstream, and add a link in the spec for memory.
NOTE:
Obsolete php-gettext 1.0.11-3 which is ok.
No provides fir php-gettext, which is ok, as this is the goal of the rename.
yum upgrade from php-gettext to php-php-gettext is ok.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739416 Robert Scheck red...@linuxnetz.de changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Robert Scheck red...@linuxnetz.de 2011-09-24 13:48:44 EDT --- Thank you very much for the review. New Package SCM Request === Package Name: php-php-gettext Short Description: Gettext emulation in PHP Owners: robert Branches: f14 f15 f16 el4 el5 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 739416] Review Request: php-php-gettext - Gettext emulation in PHP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=739416 Robert Scheck redhat-bugzi...@linuxnetz.de changed: What|Removed |Added Blocks||727000 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
