[Bug 794988] Review Request: perl-Crypt-Blowfish_PP - Blowfish encryption algorithm implemented purely in Perl
https://bugzilla.redhat.com/show_bug.cgi?id=794988 Alec Leamas leamas.a...@gmail.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #15 from Alec Leamas leamas.a...@gmail.com --- Package Change Request == Package Name: perl-Crypt-Blowfish_PP New Branches: el6 Owners: georgiou InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794988] Review Request: perl-Crypt-Blowfish_PP - Blowfish encryption algorithm implemented purely in Perl
https://bugzilla.redhat.com/show_bug.cgi?id=794988 --- Comment #16 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794988] Review Request: perl-Crypt-Blowfish_PP - Blowfish encryption algorithm implemented purely in Perl
https://bugzilla.redhat.com/show_bug.cgi?id=794988 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794988] Review Request: perl-Crypt-Blowfish_PP - Blowfish encryption algorithm implemented purely in Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794988 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2012-04-11 23:09:52 EDT --- perl-Crypt-Blowfish_PP-1.12-2.fc17 has been pushed to the Fedora 17 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794988] Review Request: perl-Crypt-Blowfish_PP - Blowfish encryption algorithm implemented purely in Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794988 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2012-03-30 23:17:03 EDT --- perl-Crypt-Blowfish_PP-1.12-2.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794988] Review Request: perl-Crypt-Blowfish_PP - Blowfish encryption algorithm implemented purely in Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794988 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2012-03-20 10:40:41 EDT --- perl-Crypt-Blowfish_PP-1.12-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Crypt-Blowfish_PP-1.12-2.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794988] Review Request: perl-Crypt-Blowfish_PP - Blowfish encryption algorithm implemented purely in Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794988 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2012-03-20 10:41:37 EDT --- perl-Crypt-Blowfish_PP-1.12-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-Crypt-Blowfish_PP-1.12-2.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794988] Review Request: perl-Crypt-Blowfish_PP - Blowfish encryption algorithm implemented purely in Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794988 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2012-03-20 10:42:46 EDT --- perl-Crypt-Blowfish_PP-1.12-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-Crypt-Blowfish_PP-1.12-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794988] Review Request: perl-Crypt-Blowfish_PP - Blowfish encryption algorithm implemented purely in Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794988 Petr Šabata psab...@redhat.com changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794988] Review Request: perl-Crypt-Blowfish_PP - Blowfish encryption algorithm implemented purely in Perl
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=794988
--- Comment #3 from Petr Šabata psab...@redhat.com 2012-02-23 10:10:33 EST ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[!]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint output is silent.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/contyk/src/review/794988/Crypt-Blowfish_PP-1.12.tar.gz :
MD5SUM this package : 6bf7dc80967eaf3047b67b26b015267d
MD5SUM upstream package : 6bf7dc80967eaf3047b67b26b015267d
[!]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[?]: SHOULD Package functions as described.
[x]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: SHOULD Package should compile and build into binary rpms on all supported
architectures.
[x]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
files.
[-]: SHOULD Spec use %global instead of %define.
Issues:
TODO: Remove the %clean section. This is no longer needed in Fedora.
TODO: Remove the 'rm -rf $RPM_BUILD_ROOT' from your %install section. This is
no longer needed.
FIX: Remove the 'x' from the beginning of the 4th line of your %description.
Generated by fedora-review 0.1.1
External plugins:
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794988] Review Request: perl-Crypt-Blowfish_PP - Blowfish encryption algorithm implemented purely in Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794988 --- Comment #4 from Alec Leamas leamas.a...@gmail.com 2012-02-23 10:20:47 EST --- (In reply to comment #3) Issues: TODO: Remove the %clean section. This is no longer needed in Fedora. Done TODO: Remove the 'rm -rf $RPM_BUILD_ROOT' from your %install section. This is no longer needed. Done FIX: Remove the 'x' from the beginning of the 4th line of your %description. Done Updated in-place without bumping release-nr, commented in changelog. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794988] Review Request: perl-Crypt-Blowfish_PP - Blowfish encryption algorithm implemented purely in Perl
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=794988
--- Comment #5 from Petr Šabata psab...@redhat.com 2012-02-23 10:33:42 EST ---
Um, nope, nope, and nope.
--- a/perl-Crypt-Blowfish_PP.spec
+++ b/perl-Crypt-Blowfish_PP.spec
@@ -1,13 +1,12 @@
Name: perl-Crypt-Blowfish_PP
Version:1.12
-Release:2%{?dist}
+Release:1%{?dist}
Summary:Blowfish encryption algorithm implemented purely in Perl
Group: Development/Libraries
License:GPL+ or Artistic
URL:
http://search.cpan.org/~mattbm/Crypt-Blowfish_PP-1.12/Blowfish_PP.pm
Source0:
http://search.cpan.org/CPAN/authors/id/M/MA/MATTBM/Crypt-Blowfish_PP-1.12.
BuildArch: noarch
-
BuildRequires: perl(ExtUtils::MakeMaker)
Requires: perl(:MODULE_COMPAT_%(eval `%{__perl} -V:version`; echo
$version))
@@ -48,15 +47,14 @@ rm -rf $RPM_BUILD_ROOT
%files
-%doc README CHANGELOG
+%defattr(-,root,root,-)
+%doc README
%{perl_vendorlib}/*
%{_mandir}/man3/*.3*
%changelog
-* Wed Feb 22 2012 Alec Leamas a...@nowhere.com 1.12-2
-- Re-enabling Requires: perl(:MODULE_COMPAT...)
-* Tue Feb 21 2012 Alec Leamas a...@nowhere.com 1.12-2
-- Removing defattr
* Sat Jan 31 2012 Alec Leamas a...@nowhere.com 1.12-1
- Intial packaging
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794988] Review Request: perl-Crypt-Blowfish_PP - Blowfish encryption algorithm implemented purely in Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794988 --- Comment #6 from Alec Leamas leamas.a...@gmail.com 2012-02-23 11:05:15 EST --- New attempt, in place, no changelog (just forget that one...). Sorry :( -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794988] Review Request: perl-Crypt-Blowfish_PP - Blowfish encryption algorithm implemented purely in Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794988 Petr Šabata psab...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #7 from Petr Šabata psab...@redhat.com 2012-02-23 11:43:28 EST --- Ok, fixed. Approving. Please, add perl-sig to the InitialCC in your SCM request. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794988] Review Request: perl-Crypt-Blowfish_PP - Blowfish encryption algorithm implemented purely in Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794988 Alec Leamas leamas.a...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Alec Leamas leamas.a...@gmail.com 2012-02-23 13:48:36 EST --- New Package SCM Request === Package Name: perl-Crypt-Blowfish_PP Short Description: Blowfish encryption algorithm implemented purely in Perl Owners: leamas Branches: f15 f16 f17 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794988] Review Request: perl-Crypt-Blowfish_PP - Blowfish encryption algorithm implemented purely in Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794988 --- Comment #9 from Jon Ciesla limburg...@gmail.com 2012-02-23 14:04:18 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794988] Review Request: perl-Crypt-Blowfish_PP - Blowfish encryption algorithm implemented purely in Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794988 Alec Leamas leamas.a...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2012-02-23 14:25:47 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794988] Review Request: perl-Crypt-Blowfish_PP - Blowfish encryption algorithm implemented purely in Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794988 Petr Šabata psab...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||psab...@redhat.com AssignedTo|nob...@fedoraproject.org|psab...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794988] Review Request: perl-Crypt-Blowfish_PP - Blowfish encryption algorithm implemented purely in Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794988 --- Comment #2 from Alec Leamas leamas.a...@gmail.com 2012-02-21 13:41:29 EST --- Updated after review of perl-Data-AMF. spec: http://dl.dropbox.com/u/17870887/perl-Crypt-Blowfish_PP-2/perl-Crypt-Blowfish_PP.spec srpm: http://dl.dropbox.com/u/17870887/perl-Crypt-Blowfish_PP-2/perl-Crypt-Blowfish_PP-1.12-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794988] Review Request: perl-Crypt-Blowfish_PP - Blowfish encryption algorithm implemented purely in Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794988 Alec Leamas leamas.a...@gmail.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) --- Comment #1 from Alec Leamas leamas.a...@gmail.com 2012-02-18 09:59:50 EST --- I don't have a package, and thus need a sponsor -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794988] Review Request: perl-Crypt-Blowfish_PP - Blowfish encryption algorithm implemented purely in Perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794988 Alec Leamas leamas.a...@gmail.com changed: What|Removed |Added Blocks||794990 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
