[Bug 800526] Review Request: seahorse-sharing - Sharing of PGP public keys via DNS-SD and HKP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800526 --- Comment #17 from Kalev Lember kalevlem...@gmail.com 2012-04-12 17:33:18 EDT --- Added the self-obsoletes in seahorse-3.4.0-2.fc17: http://pkgs.fedoraproject.org/gitweb/?p=seahorse.git;a=commit;h=7b450ab5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800526] Review Request: seahorse-sharing - Sharing of PGP public keys via DNS-SD and HKP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800526 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||seahorse-sharing-3.4.0-1.fc ||17 Resolution||ERRATA Last Closed||2012-04-11 22:11:40 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2012-04-11 22:11:40 EDT --- seahorse-sharing-3.4.0-1.fc17 has been pushed to the Fedora 17 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800526] Review Request: seahorse-sharing - Sharing of PGP public keys via DNS-SD and HKP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800526 --- Comment #15 from Kalev Lember kalevlem...@gmail.com 2012-04-04 19:02:43 EDT --- Yes, I agree, adding self-obsoletes to seahorse sounds like the right thing to do here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800526] Review Request: seahorse-sharing - Sharing of PGP public keys via DNS-SD and HKP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800526 Kalev Lember kalevlem...@gmail.com changed: What|Removed |Added CC||kalevlem...@gmail.com --- Comment #11 from Kalev Lember kalevlem...@gmail.com 2012-04-01 06:52:08 EDT --- I am pretty uncomfortable seeing Obsoletes: seahorse 3.1.4 in this spec file. What this does on upgrades is removing seahorse and installing seahorse-sharing instead. Is this behaviour intended? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800526] Review Request: seahorse-sharing - Sharing of PGP public keys via DNS-SD and HKP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800526 --- Comment #12 from Michael Scherer m...@zarb.org 2012-04-01 08:45:43 EDT --- From what I understand, if I have the old seahorse, and if I install the new seahorse-sharing , it will remove the old seahorse, that's all. If I do a upgrade from one fedora version to another one, it should also install a new seahorse, and so the Obsoletes should not apply on it. But I do not know enough yum to be sure -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800526] Review Request: seahorse-sharing - Sharing of PGP public keys via DNS-SD and HKP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800526 --- Comment #13 from Kalev Lember kalevlem...@gmail.com 2012-04-01 13:59:25 EDT --- (In reply to comment #12) From what I understand, if I have the old seahorse, and if I install the new seahorse-sharing , it will remove the old seahorse, that's all. Exactly, and this will also happen on package update: seahorse gets removed and replaced with seahorse-sharing. Yum has a nice wiki page that describes behaviour with Obsoletes: http://yum.baseurl.org/wiki/YumPackageUpdates If we consider a system with seahorse-3.0.0-1.fc15 installed and a repo with seahorse-3.4.0-1.fc17 and seahorse-sharing-3.4.0-1.fc17 available, there are 3 different ways to do the upgrade: a) Installed: seahorse-3.0.0-1.fc15 After distro update: seahorse-3.4.0-1.fc17 b) Installed: seahorse-3.0.0-1.fc15 After distro update: seahorse-3.4.0-1.fc17 seahorse-sharing-3.4.0-1.fc17 c) Installed: seahorse-3.0.0-1.fc15 After distro update: seahorse-sharing-3.4.0-1.fc17 Which one of these is desired here? What currently happens with the way Obsoletes are used in this package is option (c). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800526] Review Request: seahorse-sharing - Sharing of PGP public keys via DNS-SD and HKP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800526 --- Comment #14 from Michael Scherer m...@zarb.org 2012-04-01 15:32:28 EDT --- If we want A, that's indeed incorrect. But since the feature was present in seahorse before, I assume that's B. According to the page you gave, this should requires adding Obsoletes to seahorse and seahorse-sharing is correct. So i think a new bug should be opened against seahorse for that. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800526] Review Request: seahorse-sharing - Sharing of PGP public keys via DNS-SD and HKP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800526 Rui Matos tiagoma...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Rui Matos tiagoma...@gmail.com 2012-03-30 08:27:56 EDT --- New Package SCM Request === Package Name: seahorse-sharing Short Description: Sharing of PGP public keys via DNS-SD and HKP Owners: rtcm Branches: f17 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800526] Review Request: seahorse-sharing - Sharing of PGP public keys via DNS-SD and HKP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800526 --- Comment #8 from Jon Ciesla limburg...@gmail.com 2012-03-30 08:50:38 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800526] Review Request: seahorse-sharing - Sharing of PGP public keys via DNS-SD and HKP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800526 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800526] Review Request: seahorse-sharing - Sharing of PGP public keys via DNS-SD and HKP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800526 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2012-03-30 09:24:10 EDT --- seahorse-sharing-3.4.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/seahorse-sharing-3.4.0-1.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800526] Review Request: seahorse-sharing - Sharing of PGP public keys via DNS-SD and HKP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800526 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2012-03-30 14:00:35 EDT --- seahorse-sharing-3.4.0-1.fc17 has been pushed to the Fedora 17 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800526] Review Request: seahorse-sharing - Sharing of PGP public keys via DNS-SD and HKP
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=800526
Michael Scherer m...@zarb.org changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flag|fedora-review? |fedora-review+
--- Comment #6 from Michael Scherer m...@zarb.org 2012-03-29 16:45:02 EDT ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
C/C++
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Package is not relocatable.
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains a properly installed %{name}.desktop using desktop-
file-install file if it is a GUI application.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST The spec file handles locales properly.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
rpmlint seahorse-sharing-3.4.0-1.fc18.i686.rpm
seahorse-sharing.i686: W: obsolete-not-provided seahorse
seahorse-sharing.i686: W: non-conffile-in-etc
/etc/xdg/autostart/seahorse-sharing.desktop
seahorse-sharing.i686: E: incorrect-fsf-address
/usr/share/doc/seahorse-sharing-3.4.0/COPYING
1 packages and 0 specfiles checked; 1 errors, 2 warnings.
rpmlint seahorse-sharing-debuginfo-3.4.0-1.fc18.i686.rpm
seahorse-sharing-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/seahorse-sharing-3.4.0/daemon/seahorse-hkp-server.c
seahorse-sharing-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/seahorse-sharing-3.4.0/daemon/seahorse-sharing.c
seahorse-sharing-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/seahorse-sharing-3.4.0/daemon/seahorse-daemon.c
seahorse-sharing-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/seahorse-sharing-3.4.0/daemon/seahorse-unix-signal.h
seahorse-sharing-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/seahorse-sharing-3.4.0/libegg/eggdesktopfile.h
seahorse-sharing-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/seahorse-sharing-3.4.0/daemon/seahorse-unix-signal.c
seahorse-sharing-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/seahorse-sharing-3.4.0/daemon/seahorse-daemon.h
seahorse-sharing-debuginfo.i686: E:
[Bug 800526] Review Request: seahorse-sharing - Sharing of PGP public keys via DNS-SD and HKP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800526 --- Comment #5 from Rui Matos tiagoma...@gmail.com 2012-03-27 08:13:58 EDT --- Ok, here it is, updated to the latest upstream as well: Spec URL: http://glua.ua.pt/~rmatos/seahorse-sharing.spec SRPM URL: http://glua.ua.pt/~rmatos/seahorse-sharing-3.4.0-1.fc17.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=3936205 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800526] Review Request: seahorse-sharing - Sharing of PGP public keys via DNS-SD and HKP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800526 Matthias Clasen mcla...@redhat.com changed: What|Removed |Added CC||mcla...@redhat.com --- Comment #4 from Matthias Clasen mcla...@redhat.com 2012-03-22 10:05:37 EDT --- Yeah, I don't think we have any bundled() provides in desktop packages, currently. So why not make a start here ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800526] Review Request: seahorse-sharing - Sharing of PGP public keys via DNS-SD and HKP
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=800526
Michael Scherer m...@zarb.org changed:
What|Removed |Added
CC||m...@zarb.org
AssignedTo|nob...@fedoraproject.org|m...@zarb.org
Flag||fedora-review?
--- Comment #1 from Michael Scherer m...@zarb.org 2012-03-19 09:09:28 EDT ---
Hi,
a few comments :
- %{_datadir}/pixmaps/seahorse/*/seahorse-share-keys.*
this will create unowned directory, this should be corrected ( I think )
- there is libegg bundled, and so this requires to have a specific provides :
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Packages_granted_exceptions
-
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800526] Review Request: seahorse-sharing - Sharing of PGP public keys via DNS-SD and HKP
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=800526
--- Comment #2 from Rui Matos tiagoma...@gmail.com 2012-03-19 13:07:08 EDT ---
Thanks for the review!
(In reply to comment #1)
- %{_datadir}/pixmaps/seahorse/*/seahorse-share-keys.*
this will create unowned directory, this should be corrected ( I think )
Should be fixed now.
- there is libegg bundled, and so this requires to have a specific provides :
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Packages_granted_exceptions
Does this make sense when there's no official libegg.so on the filesystem
provided by any package? Consumers of this library usually just use some files
from it and statically link them into their binaries. From a quick glance at
both evince.spec and eog.spec neither lists this bundled(egglib) Provides
although both use libegg files.
I also updated to the latest release:
Spec URL: http://glua.ua.pt/~rmatos/seahorse-sharing.spec
SRPM URL: http://glua.ua.pt/~rmatos/seahorse-sharing-3.3.92-1.fc16.src.rpm
http://koji.fedoraproject.org/koji/taskinfo?taskID=3910422
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800526] Review Request: seahorse-sharing - Sharing of PGP public keys via DNS-SD and HKP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800526 --- Comment #3 from Michael Scherer m...@zarb.org 2012-03-19 14:07:28 EDT --- I think the goal is to be able to see where we should push fixes if there is a security issue with libegg. And I think that both evince and eog where in the repository long before this policy have been created, so I guess no one spotted it before. And indeed, that's because this is statically linked that there is a exception for the policy. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
