[Bug 806517] Review Request: pycscope - Generates a cscope index of Python source trees
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806517 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|pycscope-0.3-3.fc16 |pycscope-0.3-3.fc17 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2012-04-11 22:08:08 EDT --- pycscope-0.3-3.fc17 has been pushed to the Fedora 17 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806517] Review Request: pycscope - Generates a cscope index of Python source trees
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806517 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|pycscope-0.3-3.fc15 |pycscope-0.3-3.fc16 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2012-04-03 15:54:00 EDT --- pycscope-0.3-3.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806517] Review Request: pycscope - Generates a cscope index of Python source trees
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806517 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||pycscope-0.3-3.fc15 Resolution||ERRATA Last Closed||2012-04-03 15:52:23 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2012-04-03 15:52:23 EDT --- pycscope-0.3-3.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806517] Review Request: pycscope - Generates a cscope index of Python source trees
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806517 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2012-03-25 17:28:31 EDT --- pycscope-0.3-3.fc17 has been pushed to the Fedora 17 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806517] Review Request: pycscope - Generates a cscope index of Python source trees
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806517 Michael Scherer m...@zarb.org changed: What|Removed |Added CC||m...@zarb.org --- Comment #1 from Michael Scherer m...@zarb.org 2012-03-24 10:21:43 EDT --- Hi, you should use python2-devel or python3-devel https://fedoraproject.org/wiki/Packaging:Python#BuildRequires -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806517] Review Request: pycscope - Generates a cscope index of Python source trees
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806517 --- Comment #2 from Ankur Sinha sanjay.an...@gmail.com 2012-03-24 11:38:59 EDT --- Ah, looks like rpmdev-newspec needs to be updated :/ Updated spec/srpm: http://ankursinha.fedorapeople.org/pycscope/pycscope.spec http://ankursinha.fedorapeople.org/pycscope/pycscope-0.3-2.fc16.src.rpm Thanks for pointing it out Michael, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806517] Review Request: pycscope - Generates a cscope index of Python source trees
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806517 --- Comment #3 from Michael Scherer m...@zarb.org 2012-03-24 11:47:59 EDT --- I also forgot, are the 2 macros in the beginning still needed ? They are defined on my fedora 16, not sure about fedora 15. ( if not needed, i guess they can be removed ). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806517] Review Request: pycscope - Generates a cscope index of Python source trees
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806517 Praveen Kumar kumarpraveen.nit...@gmail.com changed: What|Removed |Added CC||kumarpraveen.nitdgp@gmail.c ||om AssignedTo|nob...@fedoraproject.org|kumarpraveen.nitdgp@gmail.c ||om Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806517] Review Request: pycscope - Generates a cscope index of Python source trees
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=806517
--- Comment #4 from Praveen Kumar kumarpraveen.nit...@gmail.com 2012-03-24
13:20:39 EDT ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf is only needed if supporting EPEL5
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
rpmlint -i pycscope.spec ../SRPMS/pycscope-0.3-2.fc16.src.rpm
../RPMS/noarch/pycscope-0.3-2.fc16.noarch.rpm
pycscope.src: W: spelling-error Summary(en_US) cscope - scope, c scope, cs
cope
The value of this tag appears to be misspelled. Please double-check.
pycscope.src: W: spelling-error %description -l en_US cscope - scope, c scope,
cs cope
The value of this tag appears to be misspelled. Please double-check.
pycscope.noarch: W: spelling-error Summary(en_US) cscope - scope, c scope, cs
cope
The value of this tag appears to be misspelled. Please double-check.
pycscope.noarch: W: spelling-error %description -l en_US cscope - scope, c
scope, cs cope
The value of this tag appears to be misspelled. Please double-check.
pycscope.noarch: W: no-manual-page-for-binary pycscope.py
Each executable in standard binary directories should have a man page.
2 packages and 1 specfiles checked; 0 errors, 5 warnings.
looks like source doesn't contain manual information.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/daredevil/rpmbuild/SOURCES/pycscope-0.3.tar.gz
MD5SUM this package : ec83c70bce31909cb3cdeae233c00374
MD5SUM upstream package : ec83c70bce31909cb3cdeae233c00374
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[Bug 806517] Review Request: pycscope - Generates a cscope index of Python source trees
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806517 --- Comment #5 from Ankur Sinha sanjay.an...@gmail.com 2012-03-24 13:23:03 EDT --- (In reply to comment #3) I also forgot, are the 2 macros in the beginning still needed ? They are defined on my fedora 16, not sure about fedora 15. ( if not needed, i guess they can be removed ). Agh, another thing rpmdev-newspec put in. I'll get rid of it! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806517] Review Request: pycscope - Generates a cscope index of Python source trees
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806517 --- Comment #6 from Ankur Sinha sanjay.an...@gmail.com 2012-03-24 13:45:11 EDT --- Updated spec/srpm: http://ankursinha.fedorapeople.org/pycscope/pycscope.spec http://ankursinha.fedorapeople.org/pycscope/pycscope-0.3-3.fc16.src.rpm * Sat Mar 24 2012 Ankur Sinha ankursinha AT fedoraproject DOT org 0.3-3 - Removed rm commands https://bugzilla.redhat.com/show_bug.cgi?id=806517#c4 Thanks, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806517] Review Request: pycscope - Generates a cscope index of Python source trees
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=806517
Praveen Kumar kumarpraveen.nit...@gmail.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #7 from Praveen Kumar kumarpraveen.nit...@gmail.com 2012-03-24
13:52:16 EDT ---
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Issues:
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf is only needed if supporting EPEL5
looks good
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806517] Review Request: pycscope - Generates a cscope index of Python source trees
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806517 Ankur Sinha sanjay.an...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Flag||fedora-cvs? --- Comment #8 from Ankur Sinha sanjay.an...@gmail.com 2012-03-24 13:58:06 EDT --- New Package SCM Request === Package Name: pycscope Short Description: Generates a cscope index of Python source trees Owners: ankursinha Branches: f15 f16 f17 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806517] Review Request: pycscope - Generates a cscope index of Python source trees
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806517 --- Comment #9 from Jon Ciesla limburg...@gmail.com 2012-03-24 14:46:13 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806517] Review Request: pycscope - Generates a cscope index of Python source trees
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806517 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2012-03-24 16:12:55 EDT --- pycscope-0.3-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/pycscope-0.3-3.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806517] Review Request: pycscope - Generates a cscope index of Python source trees
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806517 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806517] Review Request: pycscope - Generates a cscope index of Python source trees
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806517 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2012-03-24 16:12:34 EDT --- pycscope-0.3-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/pycscope-0.3-3.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806517] Review Request: pycscope - Generates a cscope index of Python source trees
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806517 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2012-03-24 16:12:44 EDT --- pycscope-0.3-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/pycscope-0.3-3.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
