[Bug 823334] Review Request: rubygem-mixlib-config - class-based config mixin for ruby scripts
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823334 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- rubygem-mixlib-config-1.1.2-3.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rbHPkpKMw2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823334] Review Request: rubygem-mixlib-config - class-based config mixin for ruby scripts
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823334 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2013-01-23 11:06:32 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=msCYBFULdma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823334] Review Request: rubygem-mixlib-config - class-based config mixin for ruby scripts
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823334 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- rubygem-mixlib-config-1.1.2-3.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CVdbabsVnva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823334] Review Request: rubygem-mixlib-config - class-based config mixin for ruby scripts
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823334 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- rubygem-mixlib-config-1.1.2-3.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CjLUyCmw22a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823334] Review Request: rubygem-mixlib-config - class-based config mixin for ruby scripts
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823334 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xkThtWzRB1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823334] Review Request: rubygem-mixlib-config - class-based config mixin for ruby scripts
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823334 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- rubygem-mixlib-config-1.1.2-3.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zgI0KjUKHMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823334] Review Request: rubygem-mixlib-config - class-based config mixin for ruby scripts
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823334 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cx89znZ5ona=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823334] Review Request: rubygem-mixlib-config - class-based config mixin for ruby scripts
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823334 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- rubygem-mixlib-config-1.1.2-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-mixlib-config-1.1.2-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9suLXZCfWLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823334] Review Request: rubygem-mixlib-config - class-based config mixin for ruby scripts
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823334 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- rubygem-mixlib-config-1.1.2-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-mixlib-config-1.1.2-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SZWjI5sVpOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823334] Review Request: rubygem-mixlib-config - class-based config mixin for ruby scripts
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823334 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- rubygem-mixlib-config-1.1.2-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/rubygem-mixlib-config-1.1.2-3.fc16 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lCmstcXr8aa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823334] Review Request: rubygem-mixlib-config - class-based config mixin for ruby scripts
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823334 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- rubygem-mixlib-config-1.1.2-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-mixlib-config-1.1.2-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7InkZsavdqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823334] Review Request: rubygem-mixlib-config - class-based config mixin for ruby scripts
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823334 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- rubygem-mixlib-config-1.1.2-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-mixlib-config-1.1.2-3.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NDY2DpE12Za=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823334] Review Request: rubygem-mixlib-config - class-based config mixin for ruby scripts
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823334 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pvSByZ8cxfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823334] Review Request: rubygem-mixlib-config - class-based config mixin for ruby scripts
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823334 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Unretired, submit Package Change for additional branches. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hQgVRMEO7Ia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823334] Review Request: rubygem-mixlib-config - class-based config mixin for ruby scripts
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823334 Julian C. Dunn jd...@aquezada.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Julian C. Dunn jd...@aquezada.com --- Package Change Request == Package Name: rubygem-mixlib-config New Branches: f16 f17 f18 Owners: jdunn InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=h8VZm8emuUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823334] Review Request: rubygem-mixlib-config - class-based config mixin for ruby scripts
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823334 Michael Scherer m...@zarb.org changed: What|Removed |Added CC||m...@zarb.org Assignee|nob...@fedoraproject.org|m...@zarb.org Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NSZ8ESSaH4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823334] Review Request: rubygem-mixlib-config - class-based config mixin for ruby scripts
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=823334
Michael Scherer m...@zarb.org changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #3 from Michael Scherer m...@zarb.org ---
So except the patch not documented, the package is good and approved. Can you
make sure this is documented before importing ?
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- The patch should be documented in the spec, if ti come from upstream, etc
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0), Unknown or generated. 2 files have unknown license.
Detailed output of licensecheck in
/home/misc/checkout/git/FedoraReview/823334-rubygem-mixlib-
config/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Ruby:
[x]: Platform dependent files must all go under %{gem_extdir}, platform
independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package contains Requires: ruby(abi).
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[Bug 823334] Review Request: rubygem-mixlib-config - class-based config mixin for ruby scripts
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823334 --- Comment #4 from Julian C. Dunn jd...@aquezada.com --- Yes, I will document it. Thanks Michael. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nrGzkCrt5Da=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823334] Review Request: rubygem-mixlib-config - class-based config mixin for ruby scripts
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823334 Julian C. Dunn jd...@aquezada.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Julian C. Dunn jd...@aquezada.com --- New Package SCM Request === Package Name: rubygem-mixlib-config Short Description: Class-based config mixin for Ruby scripts Owners: jdunn Branches: f16 f17 f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yzuU7l4f7Wa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823334] Review Request: rubygem-mixlib-config - class-based config mixin for ruby scripts
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823334 --- Comment #2 from Julian C. Dunn jd...@aquezada.com --- Hi Josef, I have fixed the package in accordance with your suggestions and the revised one is here: http://jdunn.fedorapeople.org/rubygem-mixlib-config/rubygem-mixlib-config-1.1.2-2.fc19.src.rpm http://jdunn.fedorapeople.org/rubygem-mixlib-config/rubygem-mixlib-config.spec The chatty test output was already fixed upstream in master but not yet released. I have applied the same patch. Could you review at your convenience? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Qi4K5wW7Vxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823334] Review Request: rubygem-mixlib-config - class-based config mixin for ruby scripts
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=823334
Josef Stribny jstri...@redhat.com changed:
What|Removed |Added
CC||jd...@aquezada.com,
||jstri...@redhat.com
--- Comment #1 from Josef Stribny jstri...@redhat.com ---
* Remove Requires: ruby for other Ruby interpretations to be used with in f19
* Rakefile, NOTICE and README.rdoc are not require during runtime
- Please consider moving them into the -doc subpackage
* Please consider moving specs into the -doc subpackage rather than exclude
them
* I would suggest you to also exclude %{gem_cache} as it's not needed
* Running rspec -Ilib spec/mixlib/config_spec.rb prints a lot (a lot!) of
stuff.
- I believe it would be nice to supress it [1]
[1]
http://stackoverflow.com/questions/1496019/suppresing-output-to-console-with-ruby
@Julian C. Dunn: Adding you to CC. Would you mind to take over this package?
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=HEFg3eRj6va=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823334] Review Request: rubygem-mixlib-config - class-based config mixin for ruby scripts
https://bugzilla.redhat.com/show_bug.cgi?id=823334 Jonas Courteau r...@courteau.org changed: What|Removed |Added Blocks|177841 |823344 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823334] Review Request: rubygem-mixlib-config - class-based config mixin for ruby scripts
https://bugzilla.redhat.com/show_bug.cgi?id=823334 Jonas Courteau r...@courteau.org changed: What|Removed |Added Summary|Review Request: |Review Request: |rubygem-mixlib-config |rubygem-mixlib-config - ||class-based config mixin ||for ruby scripts -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
