[Bug 865371] Review Request: scid - A collection of numerical routines using Blas/Lapack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=865371

Susi Lehtola  changed:

   What|Removed |Added

 Blocks|505154 (FE-SCITECH) |





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=505154
[Bug 505154] Tracker: Review Requests for Science and Technology related
packages
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 865371] Review Request: scid - A collection of numerical routines using Blas/Lapack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=865371

Dmitrij S. Kryzhevich  changed:

   What|Removed |Added

  Flags|fedora-review?  |



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 865371] Review Request: scid - A collection of numerical routines using Blas/Lapack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=865371

Dmitrij S. Kryzhevich  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NOTABUG
  Flags|needinfo?(bioinfornatics@gm |
   |ail.com)|
Last Closed||2017-03-22 06:15:38



--- Comment #22 from Dmitrij S. Kryzhevich  ---
This review is stalled. Anybody could feel free to make new review request.
Don't forget to mark this one as DUPLICATE.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 865371] Review Request: scid - A collection of numerical routines using Blas/Lapack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=865371

Dmitrij S. Kryzhevich  changed:

   What|Removed |Added

  Flags||needinfo?(bioinfornatics@gm
   ||ail.com)



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 865371] Review Request: scid - A collection of numerical routines using Blas/Lapack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=865371



--- Comment #21 from Dmitrij S. Kryzhevich  ---
Package Review
==

Issues.

Must be fixed:
1. Latest Changelog version is for 0.1 and current version is 0.3.
2. First Changelog entry is for version 1. Misspell?
3. Script to obtain upstream should be fixed. Your script is for lates
available version. Must be: packed version.
4. Summary and Description for -devel should represent -devel package.
5. Anowned dirs: /usr/share/geany and /usr/share/geany/tags. May be split-out
that geany file and make it Require: geany?

Should be fixed:
1. shared-lib-calls-exit from libscid-ldc.so.0.3.0
2. unstripped-binary-or-object libscid-ldc.so.0.3.0. Is it normal for D
libraris?
3. /usr/share/doc/scid is already processed in %{doc} macros. You could drop
%{_defaultdocdir}/scid.
4. Requires: lapack -- is not neccessary. It would be pulled by auto-requires:
liblapack.so.3
5. ldc already require ldc-druntime-devel and ldc-phobos-devel. If there is a
reason to left them - good, otherwise they should be removed.
6. The same as for 5, but for -devel.



Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable

= MUST items =

C/C++:
[-]: Package does not contain kernel modules.
[-]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[!]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[!]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[!]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[!]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest 

[Bug 865371] Review Request: scid - A collection of numerical routines using Blas/Lapack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=865371

Dmitrij S. Kryzhevich  changed:

   What|Removed |Added

   Assignee|i...@cicku.me  |kryz...@ispms.ru
  Flags|needinfo?(i...@cicku.me)   |



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 865371] Review Request: scid - A collection of numerical routines using Blas/Lapack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=865371

MERCIER Jonathan  changed:

   What|Removed |Added

  Flags||needinfo?(i...@cicku.me)



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 865371] Review Request: scid - A collection of numerical routines using Blas/Lapack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=865371



--- Comment #18 from MERCIER Jonathan  ---
SRPMS: http://www.bioinfornatics.eu/packages/scid-20150909gitccdc560.tar.xz
SPEC: http://www.bioinfornatics.eu/packages/scid.spec
PATCH: http://www.bioinfornatics.eu/packages/scid_install_header.patch

Note ldc had some critical bug and i was not able anymore to build this
package. Now all is fixed. we can to continue the review

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 865371] Review Request: scid - A collection of numerical routines using Blas/Lapack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=865371



--- Comment #19 from MERCIER Jonathan  ---
was wrong link to SRPMS


SRPMS:
http://www.bioinfornatics.eu/packages/scid-0.3-0.20150909gitccdc560.fc22.3.src.rpm
SPEC: http://www.bioinfornatics.eu/packages/scid.spec
PATCH: http://www.bioinfornatics.eu/packages/scid_install_header.patch

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 865371] Review Request: scid - A collection of numerical routines using Blas/Lapack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=865371



--- Comment #17 from Dmitrij S. Kryzhevich kr...@land.ru ---
Fri Jul 18 13:38:29 UTC 2014? *Sigh*
Anyway, right, waiting for respond.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 865371] Review Request: scid - A collection of numerical routines using Blas/Lapack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=865371



--- Comment #13 from Eduardo Mayorga e...@mayorgalinux.com ---
(In reply to Christopher Meng from comment #12)
 (In reply to Eduardo Mayorga from comment #11)
  Any news from this?
 
 What do you mean?

You assigned the review to yourself, and there's not been any progress since
then.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 865371] Review Request: scid - A collection of numerical routines using Blas/Lapack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=865371



--- Comment #14 from Christopher Meng i...@cicku.me ---
(In reply to Eduardo Mayorga from comment #13)
 (In reply to Christopher Meng from comment #12)
  (In reply to Eduardo Mayorga from comment #11)
   Any news from this?
  
  What do you mean?
 
 You assigned the review to yourself, and there's not been any progress since
 then.

What?

You'd better figure out who is absent first. Then you will understand it
figures.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 865371] Review Request: scid - A collection of numerical routines using Blas/Lapack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=865371

Dmitrij S. Kryzhevich kr...@land.ru changed:

   What|Removed |Added

 CC||kr...@land.ru



--- Comment #15 from Dmitrij S. Kryzhevich kr...@land.ru ---
I see srpm and spec here, no needinfo flags, not any requests. And no review
(review flag set to ? in 2013-12-23 with no actual review).

Christopher, please, me too is who not understand.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 865371] Review Request: scid - A collection of numerical routines using Blas/Lapack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=865371



--- Comment #16 from Christopher Meng i...@cicku.me ---
https://lists.fedoraproject.org/pipermail/devel/2014-July/201139.html

I won't review this until Mercier has addressed the issue mentioned by Susi.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 865371] Review Request: scid - A collection of numerical routines using Blas/Lapack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=865371

Eduardo Mayorga e...@mayorgalinux.com changed:

   What|Removed |Added

 CC||e...@mayorgalinux.com



--- Comment #11 from Eduardo Mayorga e...@mayorgalinux.com ---
Any news from this?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 865371] Review Request: scid - A collection of numerical routines using Blas/Lapack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=865371



--- Comment #12 from Christopher Meng i...@cicku.me ---
(In reply to Eduardo Mayorga from comment #11)
 Any news from this?

What do you mean?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 865371] Review Request: scid - A collection of numerical routines using Blas/Lapack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=865371

Dominik 'Rathann' Mierzejewski domi...@greysector.net changed:

   What|Removed |Added

 Blocks||505154 (FE-SCITECH)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=505154
[Bug 505154] Tracker: Review Requests for Science and Technology related
packages
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 865371] Review Request: scid - A collection of numerical routines using Blas/Lapack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=865371

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|cicku...@gmail.com
Summary|Review Request : scid - A   |Review Request: scid - A
   |collection of numerical |collection of numerical
   |routines using Blas/Lapack  |routines using Blas/Lapack
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 865371] Review Request: scid - A collection of numerical routines using Blas/Lapack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=865371

Susi Lehtola susi.leht...@iki.fi changed:

   What|Removed |Added

 CC||susi.leht...@iki.fi



--- Comment #10 from Susi Lehtola susi.leht...@iki.fi ---
Summary:It is a collection of numerical routines for D language
Summary(fr):Est une collection de routine pour le calcul numérique pour le
langage D

%package devel
Summary:It is a collection of numerical routines for D language
Summary(fr):Est une collection de routine pour le calcul numérique pour le
langage D

Avoid using it is or scid is, it's superfluous. Also, use the plural
because there are more than one routine. So:

Summary:A collection of numerical routines for D language
Summary(fr):Une collection de routines pour le calcul numérique pour le
langage D

%package devel
Summary:A collection of numerical routines for D language
Summary(fr):Une collection de routines pour le calcul numérique pour le
langage D

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review