[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 Bug 866156 depends on bug 866154, which changed state. Bug 866154 Summary: Review Request: rtaudio - a realtime audio I/O library (re-review orphaned package) https://bugzilla.redhat.com/show_bug.cgi?id=866154 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LWWeHBu1jHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2013-01-11 18:26:37 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Qld7lKTIcpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 --- Comment #26 from Fedora Update System upda...@fedoraproject.org --- giada-0.5.4-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1xaExqfjara=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MdIXDMlTWda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 --- Comment #24 from Fedora Update System upda...@fedoraproject.org --- giada-0.5.4-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/giada-0.5.4-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rzPLMc7rV0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 --- Comment #25 from Fedora Update System upda...@fedoraproject.org --- giada-0.5.4-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nnG3oWPIGFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WfYkPmn8Xta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 --- Comment #17 from Ismael Olea ism...@olea.org --- You forgot to upload the src.rpm :-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3aFrQd7pWKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 --- Comment #18 from Brendan Jones brendan.jones...@gmail.com --- Opps so I did SPEC: http://bsjones.fedorapeople.org/reviews/giada.spec SRPM: http://bsjones.fedorapeople.org/reviews/giada-0.5.4-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=02D4bPhQiza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 Ismael Olea ism...@olea.org changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #19 from Ismael Olea ism...@olea.org --- I can't build it with mock as it downloads rtaudio-devel-4.0.7-2.fc15.i686 but installing rtaudio-devel-4.0.11-3 by hand builds as expected. I checked the last version is at http://koji.fedoraproject.org/koji/packageinfo?packageID=7855 then I suppose repo is not yet updated. so... package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SOoy0QJeewa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #20 from Brendan Jones brendan.jones...@gmail.com --- Thanks so much for the review! Package Change Request == Package Name: giada Short Description: audio looping machine and sequencer Owners: bsjones Branches:f16 f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EMZeb1IHVba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 --- Comment #21 from Jon Ciesla limburg...@gmail.com --- Misformatted request. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=N3R2TEaD7wa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #22 from Brendan Jones brendan.jones...@gmail.com --- My apologies! Thanks New Package SCM Request === Package Name: giada Short Description: audio looping machine and sequencer Owners: bsjones Branches:f16 f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NkxDgrFmPca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 --- Comment #23 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QO66zKBbvla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 --- Comment #15 from Brendan Jones brendan.jones...@gmail.com --- Thanks for the desktop patch, attributed and sent up stream here: https://github.com/monocasual/giada/issues/5 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xpJCu9y2LEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 --- Comment #16 from Brendan Jones brendan.jones...@gmail.com --- Thanks for the review - issues should be addressed here. rtaudio has also been unblocked in rawhide SPEC: http://bsjones.fedorapeople.org/reviews/giada.spec SRPM: http://bsjones.fedorapeople.org/reviews/giada-0.5.4-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fadaTTu3OIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 --- Comment #9 from Ismael Olea ism...@olea.org --- You are right, I've been using the r2 one. Using r3 I got this: /usr/bin/ld: cannot find -lXext after: mock init -r fedora-rawhide-i386 mock --install -r fedora-rawhide-i386 rtaudio-devel-4.0.11-3.fc19.i686.rpm rtaudio-4.0.11-3.fc19.i686.rpm mock --no-clean giada-0.5.2-3.fc18.src.rpm -r fedora-rawhide-i386 I can build it with: mock --install -r fedora-rawhide-i386 libXext-devel mock --no-clean giada-0.5.2-3.fc18.src.rpm -r fedora-rawhide-i386 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 --- Comment #10 from Brendan Jones brendan.jones...@gmail.com --- Thats' strange because traditionally libXpm has pulled in libXext as a dependancy. See http://koji.fedoraproject.org/koji/rpminfo?rpmID=3227992 Updated here (and tested in mock!) SPEC: http://bsjones.fedorapeople.org/reviews/giada.spec SRPM: http://bsjones.fedorapeople.org/reviews/giada-0.5.2-4.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 --- Comment #11 from Ismael Olea ism...@olea.org --- (In reply to comment #10) Thats' strange because traditionally libXpm has pulled in libXext as a dependancy. See http://koji.fedoraproject.org/koji/rpminfo?rpmID=3227992 but not libXext-devel, as I can see Updated here (and tested in mock!) works fine now. Please notice there is probably a typo in description: «giada is an audio looper or ALSA/JACK using the FLTK toolit» should be «giada is an audio looper for ALSA/JACK using the FLTK toolit», I suppose. I'm not into audio but the word «machine» in Summary is inexact, isn't it? Next is my full review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 --- Comment #13 from Ismael Olea ism...@olea.org --- Summarizing: [?]: Package functions as described. * Seems my pulseaudio system is not compatible with rtaudio [!]: Latest version is packaged. * last upstream is 0.5.4 [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. * you should contribute desktop file, and the patch if considered useful to upstream and provide the links to those See https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment [!]: Scriptlets must be sane, if used. * as desktop file doesn't include a MimeType key it not needs the update-destkop-database calls See https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 --- Comment #14 from Ismael Olea ism...@olea.org --- Other issues: Maybe you'll want to accept this enhancement for the desktop file: --- srpm-unpacked/giada.desktop2012-11-26 12:36:35.515736117 +0100 +++ giada.desktop2012-11-26 14:04:20.306506516 +0100 @@ -1,6 +1,8 @@ [Desktop Entry] Name=Giada -Comment=Realtime software looping sampler +Name[es]=Giada +GenericName=Drum machine and loop sequencer +GenericName[es]=Caja de ritmos y sequenciador de loops Icon=giada Type=Application Exec=giada After a fast watch at Giada website I think you could add more info into the descrption to be more descriptive, something like: Features Ultra-lightweight internal design Multi-thread/multi-core support 32 bit floating point audio engine Experimental VST support Up to 32 audio channels controlled via computer keyboard Different playback modes and combinations Bpm and beat sync with sample-accurate loop engine Live sampler from external inputs Live quantizer Action recorder Patch-based systemBuilt-in wave editor Support for all major uncompressed file formats at your own consideration. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 Ismael Olea ism...@olea.org changed: What|Removed |Added Status|NEW |ASSIGNED CC||ism...@olea.org -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 Ismael Olea ism...@olea.org changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 --- Comment #3 from Ismael Olea ism...@olea.org --- It doesn't build in Rawhide: checking RtAudio.h usability... no checking RtAudio.h presence... no checking for RtAudio.h... no configure: error: library 'rtAudio' not found! Did you tried to build it with mock? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 --- Comment #4 from Brendan Jones brendan.jones...@gmail.com --- Apologies, rtaudio is blocked in rawhide. I have a releng ticket for here: https://fedorahosted.org/rel-eng/ticket/5395 See bug #866154 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 --- Comment #5 from Ismael Olea ism...@olea.org --- If I can rebuild rtaudio in my own mock please give me a link to a SRPM to test with it. In anycase, you know, you should explicit the buildrequires at the spec. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 --- Comment #6 from Brendan Jones brendan.jones...@gmail.com --- (In reply to comment #5) If I can rebuild rtaudio in my own mock please give me a link to a SRPM to test with it. In anycase, you know, you should explicit the buildrequires at the spec. Of course - my mistake. Updated SPEC and SRPM below. SPEC: http://bsjones.fedorapeople.org/reviews/giada.spec SRPM: http://bsjones.fedorapeople.org/reviews/giada-0.5.2-3.fc18.src.rpm rtaudio scratch build for rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=4726275 http://kojipkgs.fedoraproject.org//work/tasks/6275/4726275/rtaudio-4.0.11-3.fc19.src.rpm thanks -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 --- Comment #7 from Ismael Olea ism...@olea.org --- Some troubles: Seems you forgot to add the buildrequires for libXpm-devel Build doesn't complete, seems other requires are needed too: /usr/bin/ld: cannot find -lXext /usr/bin/ld: cannot find -ljack /usr/bin/ld: cannot find -lasound Please test with mock first to check all build dependencies are set. Probably you now you can do a full mock build adding the rtaudio packages manually. Let me know here when you're ready. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 --- Comment #8 from Brendan Jones brendan.jones...@gmail.com --- I think you must not have the right SPEC. Package does build in mock The link above has all of those dependendancies (note the reviews directory) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
https://bugzilla.redhat.com/show_bug.cgi?id=866156
Fabian Affolter m...@fabian-affolter.ch changed:
What|Removed |Added
CC||m...@fabian-affolter.ch
--- Comment #1 from Fabian Affolter m...@fabian-affolter.ch ---
Some quick comments:
- URL with macro is not copy--paste friendly for humans ;-)
- %description seams to be from another package
- Why not use 'make %{?_smp_mflags}' instead of only 'make' as stated in the
guidelines.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
https://bugzilla.redhat.com/show_bug.cgi?id=866156 --- Comment #2 from Brendan Jones brendan.jones...@gmail.com --- Thanks for the comments! Addressed and updated: SPEC: http://bsjones.fedorapeople.org/giada.spec SRPM: http://bsjones.fedorapeople.org/giada-0.5.2-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866156] Review Request: giada - audio looper for JACK
https://bugzilla.redhat.com/show_bug.cgi?id=866156 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added Blocks||805236 (FedoraAudio) Depends On||866154 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
