[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 Petr Viktorin pvikt...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #25 from Petr Viktorin pvikt...@redhat.com --- New Package SCM Request === Package Name: python-pyglet Short Description: A cross-platform windowing and multimedia library for Python Owners: pviktori Branches: f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PfPARhdZYea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #26 from Jon Ciesla limburg...@gmail.com --- WARNING: Requested package name python-pyglet doesn't match bug summary pyglet, please correct. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kWg8ZQVGhTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QoRoWuRMvaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added Status|ON_QA |ASSIGNED --- Comment #24 from Miro Hrončok mhron...@redhat.com --- (Sorry for messing up with the bug status) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UOgDepMlNia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #17 from Petr Viktorin pvikt...@redhat.com --- I've fixed the license, and added a Python 3 build. For this I needed to rename the package to python-pyglet python3-pyglet. Unfortunately the Python 3 support is not really ready upstream, so I disabled it for now. In the next version should work. Spec URL: http://fedorapeople.org/~pviktori/rpms/python-pyglet.spec SRPM URL: http://fedorapeople.org/~pviktori/rpms/python-pyglet-1.2-0.4.alpha1.fc19.src.rpm Koji rawhide build (includes the Python 3 package): http://koji.fedoraproject.org/koji/taskinfo?taskID=5479283 Miro: According to the mailing list announcement (http://groups.google.com/group/pyglet-users/msg/b848b4e1fb2a059c?hl=en), the reason for not putting this on pip was to not “break people using pip install or similar tools”. Since pyglet-1.1.4 is not packaged for Fedora, pyglet-1.2 can't really break existing packages. Hopefully printrun upstream can support pyglet-1.2 soon. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7zvLCLQg8fa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #18 from Miro Hrončok mhron...@redhat.com --- Taking it into account. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qYadj4Pvbga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 Jerry James loganje...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #19 from Jerry James loganje...@gmail.com --- OK, license appears correct and I don't see any other issues. I hope that printrun can be adapted to this version, too. Thanks for attempting python3 support, Petr. This package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uK6PUBpKK9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ugKkBGGXCma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- printrun-0.0-24.20130123git71e5da0.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/printrun-0.0-24.20130123git71e5da0.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XaurrLkAn9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #21 from Fedora Update System upda...@fedoraproject.org --- printrun-0.0-24.20130123git71e5da0.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/printrun-0.0-24.20130123git71e5da0.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SHjcRUgMzoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #22 from Fedora Update System upda...@fedoraproject.org --- printrun-0.0-24.20130123git71e5da0.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/printrun-0.0-24.20130123git71e5da0.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vUEWMejFhka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added Status|MODIFIED|ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uArYGvUdNGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #23 from Fedora Update System upda...@fedoraproject.org --- Package printrun-0.0-24.20130123git71e5da0.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing printrun-0.0-24.20130123git71e5da0.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-10337/printrun-0.0-24.20130123git71e5da0.fc19 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UAaTvFRklFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #15 from Petr Viktorin pvikt...@redhat.com --- Originally (after a discussion on a packaging workshop) I went to package the latest greatest. But if printrun needs the 1.2 version I guess it would make sense to package that. I should find some time for it next week. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gpQcmXh4Uia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #16 from Miro Hrončok mhron...@redhat.com --- Actually, we might not understand each other, printrun needs pyglet 1.1.4 (as a optional dependency). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wVGqXZ72wFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #14 from Miro Hrončok mhron...@redhat.com --- According to pyglet website, These packages [1.2alpha1] are provided for testing purposes, and are not suitable for production use. I'd rather see stable 1.1.4 in stable Fedora releases. That is the version on pypi and most likely the version most apps would use nowadays. For example my package printrun enables some features, when pyglet is present and it counts on stable version of pyglet, pyglet 1.2alpha1 simply breaks it (as it brings some backward incompatible changes) and I would need to patch printrun to not use pyglet based features even if pyglet is present. I'm currently working with printrun upstream on supporting pyglet 1.2, but it doesn't change my opinion on this. Does pyglet have long pauses in releases? Yes it does. But is that a reason to bring possible unstable and untested versions? I don't think so. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=A6ArAi6dUua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #12 from Petr Viktorin pvikt...@redhat.com --- Yes. Here are updated files: Spec URL: http://fedorapeople.org/~pviktori/rpms/pyglet.spec SRPM URL: http://fedorapeople.org/~pviktori/rpms/pyglet-1.2-0.3.alpha1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4gI3xA5YsCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=868266
--- Comment #13 from Jerry James loganje...@gmail.com ---
The only issue that I see is the license tag. Shouldn't it be just BSD now
that pypng is not bundled? Also, this is not required, but have you considered
also building a python3 version? The package seems to support that.
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
BSD (3 clause), BSD (3 clause) MIT/X11 (BSD like), Unknown or
generated. 3 files have unknown license. Detailed output of licensecheck
in /home/jamesjer/868266-pyglet/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 40960 bytes in 5 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #10 from Petr Viktorin pvikt...@redhat.com --- Unfortunately, upstream pypng is not usable with pyglet, there are API changes. A viable workaround is to remove the pypng plugin, and depend on python-imaging to provide the PNG support. It's faster, it supports more formats, but it's an additional (and less portable) dependency. I've updated the package to do that. Here are the updated files: Spec URL: http://fedorapeople.org/~pviktori/rpms/pyglet.spec SRPM URL: http://fedorapeople.org/~pviktori/rpms/pyglet-1.2-0.2.alpha1.fc18.src.rpm Rawhide scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5259868 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zOEHw2JymUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #11 from Jerry James loganje...@gmail.com --- Hmmm, but python-imaging has been dropped from F-19 and Rawhide in favor of python-pillow. Can pyglet be made to work with python-pillow, and does it have the same advantages? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2Kr4XzraYva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868266 Miroslav Lichvar mlich...@redhat.com changed: What|Removed |Added CC||mlich...@redhat.com --- Comment #8 from Miroslav Lichvar mlich...@redhat.com --- I'm looking at the older reviews and there was a problem with patented S3TC. Is that no longer a problem in the package reviewed here? https://bugzilla.redhat.com/show_bug.cgi?id=468298#c18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IW2MAcp5k6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #9 from Petr Viktorin pvikt...@redhat.com --- No, it's removed from the trarball, disabling support for DirectX texture files. More details are in the SRPM, or look here: curl http://fedorapeople.org/~pviktori/rpms/pyglet-get-tarball.sh -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FNrA1HuLjja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #7 from Petr Viktorin pvikt...@redhat.com --- Not likely, the fork uses pyglet's modules. Looking at them again, though, they are mostly efforts to port to Python 3. Given that pypng upstream supports Python 3, it might be possible to use the upstream version after all. I'll test while waiting on pypng to clear the licensing. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LPiFCezYAJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #6 from Jerry James loganje...@gmail.com --- Ah, I didn't realize we are dealing with a forked pypng here. Are the changes such that pypng upstream might possibly be interested in them? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WAhThmCsFKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #5 from Petr Viktorin pvikt...@redhat.com --- Thanks for reviewing! Packaging pypng is one thing, but pyglet's copy changed since it was forked, and the upstream (with a new maintainer) has also changed extensively. I'll try to see if I can make them work together. I'll also try to get PyPNG upstream to include a proper license, as it seems only png.py has license text; then I'll request a review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=O76fcgPWwea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #4 from Jerry James loganje...@gmail.com --- I don't think pypng should be bundled. The pure Python version runs several times more slowly than the version that uses a C interface. I took a look at how hard it would be to package, and it doesn't look too bad. Here's how I did it: http://jjames.fedorapeople.org/pypng/ If you want to own that package, feel free to take what I did and replace my changelog entry in the spec file with your own. Seriously. If you don't want to own it, let me know; I may be willing. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9H88sPSNN5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868266 Jerry James loganje...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||loganje...@gmail.com Assignee|nob...@fedoraproject.org|loganje...@gmail.com Flags||fedora-review? --- Comment #2 from Jerry James loganje...@gmail.com --- I'll take this review. My initial attempt at using fedora-review is failing for reasons I don't understand. The initial build succeeds, but then it does this: Installing built package(s) Mock command returned error code 1 Cannot run mock --shell rpmbuild -bp: INFO: mock.py version 1.1.29 starting... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: lock buildroot Start: device setup Finish: device setup Start: shell Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.pAn4Ho + umask 022 + cd /builddir/build/BUILD + cd /builddir/build/BUILD + rm -rf pyglet-1.2alpha1 + /usr/bin/gzip -dc /builddir/build/SOURCES/pyglet-1.2alpha1-repacked.tar.gz + /usr/bin/tar -xf - + STATUS=0 + '[' 0 -ne 0 ']' + cd pyglet-1.2alpha1 + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . + find . -name '*.py' + xargs dos2unix xargs: dos2unix: No such file or directory error: Bad exit status from /var/tmp/rpm-tmp.pAn4Ho (%prep) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.pAn4Ho (%prep) Finish: shell Finish: lock buildroot ... which makes no sense at all, since the spec file BuildRequires: dos2unix. I'll see if I can figure out what is going on. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ow9P5Gp9wFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #3 from Jerry James loganje...@gmail.com --- FWIW, dos2unix isn't necessary anyway. You're already using sed on all of the source files, so you might as well make it do the extra work. I replaced the two lines in %prep starting with find with this: # Get rid of hashbang lines. This is a library, it has no executable scripts. # Also remove Windows newlines find . -name '*.py' | xargs sed -i -e 's|#!/usr/bin/\(env \)\?python||;s/\r//' and now fedora-review likes it. I don't know that there is anything wrong with the original; it is probably a bug in mock. But this lets me move forward with the review (and the dos2unix BR can be removed). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wZdrh7mvbWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 868266] Review Request: pyglet - A cross-platform windowing and multimedia library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=868266 --- Comment #1 from Petr Viktorin pvikt...@redhat.com --- Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4606622 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
