[Bug 874249] Review Request: rubygem-inifile - INI file reader and writer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874249 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2013-01-04 10:25:43 --- Comment #12 from Mamoru TASAKA mtas...@fedoraproject.org --- Closing. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wqoHWWqZMLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874249] Review Request: rubygem-inifile - INI file reader and writer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874249 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4V2WwM6F1Xa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874249] Review Request: rubygem-inifile - INI file reader and writer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874249 Darryl L. Pierce dpie...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from Darryl L. Pierce dpie...@redhat.com --- Thank you. New Package SCM Request === Package Name: rubygem-inifile Short Description: INI file reader and writer Owners: mcpierce Branches: f16 f17 f18 InitialCC: mcpierce -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iFY9nB2uIja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874249] Review Request: rubygem-inifile - INI file reader and writer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874249 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Flags||fedora-review+ --- Comment #9 from Mamoru TASAKA mtas...@fedoraproject.org --- Okay. This package (rubygem-inifile) is APPROVED by mtasaka -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Lf6JuC5KCka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874249] Review Request: rubygem-inifile - INI file reader and writer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874249 --- Comment #8 from Darryl L. Pierce dpie...@redhat.com --- (In reply to comment #7) (In reply to comment #6) * Enabling test suite - As this package contains test/ directory, please execute some tests in %check (like ruby -Ilib test/test_inifile.rb) Their tests require a separate gem be installed called bones. I would prefer not to package that as it's not useful to me and isn't a runtime requirement for inifile. - That is needed when you try to execute test suite using rake (bones is used only in Rakefile). See: https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/ Ruby#Running_test_suites the line The tests should not be run using Rake. As I said before, it seems that ruby -Ilib test/test_inifile.rb does some test program, so please consider to enable %check section. One of the author's tests is consistently failing. I will work with the upstream to fix this, and will enable tests after that is done. Since they're not required, this shouldn't be considered a blocker. * Documentation - Current ruby guideline says test/ directory should not be shipped in binary rpm https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/ Ruby#Running_test_suites Hrm, that should be in the -doc package. Looking in the packages built the test directory is with the docs, per the specfile. - So the current guideline says test/ directory should not be included also in -doc subpackage (see Do not ship tests in https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/ Ruby#Running_test_suites ) (If you think test/ directory in this gem is useful for users, I won't treat this as a blocker) The tests and Rakefile are no longer shipping with either package. Updated SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-inifile.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/rubygem-inifile-2.0.2-1.3.fc17.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4802664 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UbYFugvaWka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874249] Review Request: rubygem-inifile - INI file reader and writer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874249 --- Comment #7 from Mamoru TASAKA mtas...@fedoraproject.org --- (In reply to comment #6) * Enabling test suite - As this package contains test/ directory, please execute some tests in %check (like ruby -Ilib test/test_inifile.rb) Their tests require a separate gem be installed called bones. I would prefer not to package that as it's not useful to me and isn't a runtime requirement for inifile. - That is needed when you try to execute test suite using rake (bones is used only in Rakefile). See: https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites the line The tests should not be run using Rake. As I said before, it seems that ruby -Ilib test/test_inifile.rb does some test program, so please consider to enable %check section. * Documentation - Current ruby guideline says test/ directory should not be shipped in binary rpm https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/ Ruby#Running_test_suites Hrm, that should be in the -doc package. Looking in the packages built the test directory is with the docs, per the specfile. - So the current guideline says test/ directory should not be included also in -doc subpackage (see Do not ship tests in https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites ) (If you think test/ directory in this gem is useful for users, I won't treat this as a blocker) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Lq1fnX9eAua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874249] Review Request: rubygem-inifile - INI file reader and writer
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=874249
--- Comment #6 from Darryl L. Pierce dpie...@redhat.com ---
(In reply to comment #5)
For -1.1:
* Versioning
- Please don't use .1 for release unless needed.
Please use just integer (and %{?dist})
c.f.
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning
* License
- README.md says that this is under MIT.
Fixed.
* Documentation
- Current ruby guideline says test/ directory should not be
shipped in binary rpm
https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/
Ruby#Running_test_suites
Hrm, that should be in the -doc package. Looking in the packages built the test
directory is with the docs, per the specfile.
- Also, Rakefile is something like Makefile, which is usually not
not needed for binary rpm.
Same here.
* Enabling test suite
- As this package contains test/ directory, please execute
some tests in %check (like ruby -Ilib test/test_inifile.rb)
Their tests require a separate gem be installed called bones. I would prefer
not to package that as it's not useful to me and isn't a runtime requirement
for inifile.
Updated SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-inifile.spec
Updated SRPM:
http://mcpierce.fedorapeople.org/rpms/rubygem-inifile-2.0.2-1.2.fc17.src.rpm
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4796678
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=fTWgLWnHbra=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874249] Review Request: rubygem-inifile - INI file reader and writer
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=874249
--- Comment #5 from Mamoru TASAKA mtas...@fedoraproject.org ---
For -1.1:
* Versioning
- Please don't use .1 for release unless needed.
Please use just integer (and %{?dist})
c.f.
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning
* License
- README.md says that this is under MIT.
* Documentation
- Current ruby guideline says test/ directory should not be
shipped in binary rpm
https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites
- Also, Rakefile is something like Makefile, which is usually not
not needed for binary rpm.
* Enabling test suite
- As this package contains test/ directory, please execute
some tests in %check (like ruby -Ilib test/test_inifile.rb)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=4PQxqhMVOta=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874249] Review Request: rubygem-inifile - INI file reader and writer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874249 --- Comment #4 from Darryl L. Pierce dpie...@redhat.com --- (In reply to comment #3) Darryl, would you update this ticket first? (because this review request blocks bug 836368 , I cannot approve bug 836368 unless this one gets approved). Done. Sorry for the delay. Updated SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-inifile.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/rubygem-inifile-2.0.2-1.1.fc17.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4783102 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yUzSy84wdOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874249] Review Request: rubygem-inifile - INI file reader and writer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874249 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Blocks||836368 --- Comment #3 from Mamoru TASAKA mtas...@fedoraproject.org --- Darryl, would you update this ticket first? (because this review request blocks bug 836368 , I cannot approve bug 836368 unless this one gets approved). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TE09sBD7Iba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874249] Review Request: rubygem-inifile - INI file reader and writer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874249 --- Comment #2 from Mamoru TASAKA mtas...@fedoraproject.org --- First of all, please take a look at https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#RubyGems and change your spec file to match the current gem related packaging guidelines. (Especially, current guideline requests that gem is unpacked first using gem unpack) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3I46XwjMyPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874249] Review Request: rubygem-inifile - INI file reader and writer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874249 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Assignee|nob...@fedoraproject.org|mtas...@fedoraproject.org --- Comment #1 from Mamoru TASAKA mtas...@fedoraproject.org --- Taking I would appreciate it if you would review my review request bug 872909 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Pp8fsWG2Z4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874249] Review Request: rubygem-inifile - INI file reader and writer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874249 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bANSFm9HZWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
