[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
https://bugzilla.redhat.com/show_bug.cgi?id=875506 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
https://bugzilla.redhat.com/show_bug.cgi?id=875506 --- Comment #20 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
https://bugzilla.redhat.com/show_bug.cgi?id=875506 Philippe Makowski changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #19 from Philippe Makowski --- Package Change Request == Package Name: python-fdb Owners: makowski New Branches: EPEL-7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875506 --- Comment #18 from Fedora Update System --- python-fdb-0.9.9-1.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xAo2KscTvA&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875506 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-12-10 20:22:01 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UHJvtOfw0J&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875506 --- Comment #17 from Fedora Update System --- python-fdb-0.9.9-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-fdb-0.9.9-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875506 --- Comment #16 from Fedora Update System --- python-fdb-0.9.1-1.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875506 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875506 --- Comment #15 from Fedora Update System --- python-fdb-0.9.1-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-fdb-0.9.1-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875506 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875506 --- Comment #14 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875506 Philippe Makowski changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875506 --- Comment #13 from Philippe Makowski --- New Package SCM Request === Package Name: python-fdb Short Description: Firebird RDBMS bindings for Python Owners: makowski Branches: f17 f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875506 --- Comment #12 from Philippe Makowski --- thanks -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=875506
Mario Blättermann changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
||m
Flags||fedora-review+
--- Comment #11 from Mario Blättermann ---
$ rpmlint -i -v *
python3-fdb.noarch: I: checking
python3-fdb.noarch: W: spelling-error Summary(en_US) Firebird -> Fire bird,
Fire-bird, Redbird
The value of this tag appears to be misspelled. Please double-check.
python3-fdb.noarch: I: checking-url http://www.firebirdsql.org/ (timeout 10
seconds)
python-fdb.src: I: checking
python-fdb.src: W: spelling-error Summary(en_US) Firebird -> Fire bird,
Fire-bird, Redbird
The value of this tag appears to be misspelled. Please double-check.
python-fdb.src: I: checking-url http://www.firebirdsql.org/ (timeout 10
seconds)
python-fdb.src: I: checking-url
http://pypi.python.org/packages/source/f/fdb/fdb-0.9.1.tar.gz (timeout 10
seconds)
python-fdb.noarch: I: checking
python-fdb.noarch: W: spelling-error Summary(en_US) Firebird -> Fire bird,
Fire-bird, Redbird
The value of this tag appears to be misspelled. Please double-check.
python-fdb.noarch: I: checking-url http://www.firebirdsql.org/ (timeout 10
seconds)
python-fdb-doc.noarch: I: checking
python-fdb-doc.noarch: I: checking-url http://www.firebirdsql.org/ (timeout 10
seconds)
python-fdb.spec: I: checking-url
http://pypi.python.org/packages/source/f/fdb/fdb-0.9.1.tar.gz (timeout 10
seconds)
4 packages and 1 specfiles checked; 0 errors, 3 warnings.
OK so far.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
BSD
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
01dffb6a4638d980f2cbc7c785c48435919d88361b3472c1c9758ae8145daf65
fdb-0.9.1.tar.gz
01dffb6a4638d980f2cbc7c785c48435919d88361b3472c1c9758ae8145daf65
fdb-0.9.1.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in th
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875506 --- Comment #10 from Philippe Makowski --- Spec URL: http://makowski.fedorapeople.org/python-fdb/python-fdb.spec SRPM URL: http://makowski.fedorapeople.org/python-fdb/python-fdb-0.9.1-2.fc17.src.rpm both updated Koji build : http://koji.fedoraproject.org/koji/taskinfo?taskID=4705368 thanks -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=875506
--- Comment #9 from Philippe Makowski ---
the problem is the same with python-sphynx.spec than I took as example
the problematic line is :
%{!?python3_version: %global python3_version %(%{__python3} -c "import sys;
sys.stdout.write(sys.version[:3])")}
since I don't really need all that, I will only put in my spec a line like :
%global with_python3 0%{?fedora} >= 17
will publish new spec soon
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875506 --- Comment #8 from Mario Blättermann --- (In reply to comment #6) > sorry, what version of rpmlint are you using ? $ rpm -qi rpmlint Name: rpmlint Version : 1.4 Release : 11.fc17 ... The following change in rpmlint could cause the error: 2012-09-06 - Tom Callaway - 1.4-10 - fix handling of ruby RI files as text files (they are binary files) - apply upstream fix for macro regexp BTW, I get the same error for a spec taken from your own srpm or taken from Koji's srpm. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875506 --- Comment #7 from Philippe Makowski --- and result under a rawhide mock chroot and with this build : http://koji.fedoraproject.org/koji/taskinfo?taskID=4692636 $ rpmlint -i -v * python3-fdb.noarch: I: checking python3-fdb.noarch: W: spelling-error Summary(en_US) Firebird -> Fire bird, Fire-bird, Redbird The value of this tag appears to be misspelled. Please double-check. python3-fdb.noarch: I: checking-url http://www.firebirdsql.org/ (timeout 10 seconds) python-fdb.noarch: I: checking python-fdb.noarch: W: spelling-error Summary(en_US) Firebird -> Fire bird, Fire-bird, Redbird The value of this tag appears to be misspelled. Please double-check. python-fdb.noarch: I: checking-url http://www.firebirdsql.org/ (timeout 10 seconds) python-fdb.src: I: checking python-fdb.src: W: spelling-error Summary(en_US) Firebird -> Fire bird, Fire-bird, Redbird The value of this tag appears to be misspelled. Please double-check. python-fdb.src: I: checking-url http://www.firebirdsql.org/ (timeout 10 seconds) python-fdb.src: I: checking-url http://pypi.python.org/packages/source/f/fdb/fdb-0.9.1.tar.gz (timeout 10 seconds) python-fdb-doc.noarch: I: checking python-fdb-doc.noarch: I: checking-url http://www.firebirdsql.org/ (timeout 10 seconds) python-fdb.spec: I: checking-url http://pypi.python.org/packages/source/f/fdb/fdb-0.9.1.tar.gz (timeout 10 seconds) 4 packages and 1 specfiles checked; 0 errors, 3 warnings. Warnings are false and there is no errors -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875506 --- Comment #6 from Philippe Makowski --- sorry, what version of rpmlint are you using ? here what I get : rpmlint -i -v * python-fdb.noarch: I: checking python-fdb.noarch: I: checking-url http://www.firebirdsql.org/ (timeout 10 seconds) python3-fdb.noarch: I: checking python3-fdb.noarch: I: checking-url http://www.firebirdsql.org/ (timeout 10 seconds) python-fdb-doc.noarch: I: checking python-fdb-doc.noarch: I: checking-url http://www.firebirdsql.org/ (timeout 10 seconds) /home/philippe/rpmbuild/SPECS/python-fdb.spec: I: checking-url http://pypi.python.org/packages/source/f/fdb/fdb-0.9.1.tar.gz (timeout 10 seconds) python-fdb.src: I: checking python-fdb.src: I: checking-url http://www.firebirdsql.org/ (timeout 10 seconds) python-fdb.src: I: checking-url http://pypi.python.org/packages/source/f/fdb/fdb-0.9.1.tar.gz (timeout 10 seconds) 4 packages and 1 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=875506 --- Comment #5 from Mario Blättermann --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4690912 $ rpmlint -i -v * python3-fdb.noarch: I: checking python3-fdb.noarch: W: spelling-error Summary(en_US) Firebird -> Fire bird, Fire-bird, Redbird The value of this tag appears to be misspelled. Please double-check. python3-fdb.noarch: I: checking-url http://www.firebirdsql.org/ (timeout 10 seconds) python-fdb.src: I: checking python-fdb.src: W: spelling-error Summary(en_US) Firebird -> Fire bird, Fire-bird, Redbird The value of this tag appears to be misspelled. Please double-check. python-fdb.src: I: checking-url http://www.firebirdsql.org/ (timeout 10 seconds) python-fdb.src: E: specfile-error sh: line 0: fg: no job control This error occurred when rpmlint used rpm to query the specfile. The error is output by rpm and the message should contain more information. python-fdb.noarch: I: checking python-fdb.noarch: W: spelling-error Summary(en_US) Firebird -> Fire bird, Fire-bird, Redbird The value of this tag appears to be misspelled. Please double-check. python-fdb.noarch: I: checking-url http://www.firebirdsql.org/ (timeout 10 seconds) python-fdb-doc.noarch: I: checking python-fdb-doc.noarch: I: checking-url http://www.firebirdsql.org/ (timeout 10 seconds) python-fdb.spec: E: specfile-error sh: line 0: fg: no job control This error occurred when rpmlint used rpm to query the specfile. The error is output by rpm and the message should contain more information. 4 packages and 1 specfiles checked; 2 errors, 3 warnings. The last error from rpmlint (no job control) usually happens when you are using a macro which is not defined anywhere. I can't see such a macro, but the error message needs to be investigated in any case. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
https://bugzilla.redhat.com/show_bug.cgi?id=875506 --- Comment #4 from Philippe Makowski --- ok, noted, will do next time if need can you finish the review ? thanks -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
https://bugzilla.redhat.com/show_bug.cgi?id=875506 --- Comment #3 from Mario Blättermann --- Please bump the release tag each time you change anything, even in the current pre-Git state. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
https://bugzilla.redhat.com/show_bug.cgi?id=875506 --- Comment #2 from Philippe Makowski --- Thanks Spec URL: http://makowski.fedorapeople.org/python-fdb/python-fdb.spec SRPM URL: http://makowski.fedorapeople.org/python-fdb/python-fdb-0.9.1-1.fc17.src.rpm both updated -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
https://bugzilla.redhat.com/show_bug.cgi?id=875506
Mario Blättermann changed:
What|Removed |Added
CC||mario.blaetterm...@gmail.co
||m
--- Comment #1 from Mario Blättermann ---
BuildRequires: python-devel
You need either python2-devel or python3-devel. That's why it has to be
python2-devel in this case.
%description -n python3-fdb
Set of Firebird RDBMS bindings for Python. It works on Python 2.6+ and Python
3.
%description
Set of Firebird RDBMS bindings for Python. It works on Python 2.6+ and Python
3.
The last sentence doesn't make sense for the packages. Actually, due to that we
have separate packages for v2 or v3, such an info is useless.
Why does -doc require the python2 base package? It is actually not needed at
runtime. Vice versa, perhaps each of the base packages should require the -doc
package.
%description doc
Set of Firebird RDBMS bindings for Python. It works on Python 2.6+ and Python
3.
For the -doc package, the last sentence is OK, but please be more specific.
Suggestion:
%description doc
Documentation files for %{name}. It works on Python 2.6+ and Python 3.
rm -rf $RPM_BUILD_ROOT
is obsolete for ages. It is only needed if you want to provide your package for
EPEL 5.
The source tarball contains a bundled egg-info. Please remove it before
building your package (in the %prep section):
rm -rf %{upstream_name}.egg-info
See https://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Eggs for more
information.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
