[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=878188

Kevin Kofler  changed:

   What|Removed |Added

  Alias||qt5-qtbase



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=878188

Rex Dieter  changed:

   What|Removed |Added

  Alias||qt5-qtbase-review



--- Comment #62 from Rex Dieter  ---
It is possible, but not in some circumstances.

That said, I prefer for the packages I maintain to keep these aliases in place,
it is how *I* find their original reviews.  I'll consider a different workflow
in the future, maybe adopting something like alias "pkg_review" (assuming alias
length limits allow).

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=878188

Raphael Groner  changed:

   What|Removed |Added

 CC||projects...@smart.ms
  Alias|qt5-qtbase  |



--- Comment #61 from Raphael Groner  ---
Removing alias, otherwise it's not possible to search for bugs related to this
component.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=878188



--- Comment #58 from Rex Dieter rdie...@math.unl.edu ---
whoa, slow down. :)

I've been meaning to work on epel-6 builds, but only *after* all the reviews
were done.

So, now that the deed is done, be aware I made some el6-related commits to
master branch recently, if it all possible, please do make a best effort to
keep master/el6 branches merged or mergeable.

If branch-specific commits are required, please try to discuss it first. 
Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=sSaUz68fbGa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=878188



--- Comment #59 from Richard Shaw hobbes1...@gmail.com ---
No problem :)

I noticed the spec updates! I only need the four components at this time.

Build is failing on ppc64 though :(

In file included from tools/qcryptographichash.cpp:74:
tools/../../3rdparty/sha3/KeccakF-1600-opt64.c: In function 'void
KeccakAbsorb576bits(unsigned char*, const unsigned char*)':
tools/../../3rdparty/sha3/KeccakF-1600-opt64.c:348: error: 'fromBytesToWord'
was not declared in this scope

http://koji.fedoraproject.org/koji/getfile?taskID=5905860name=build.log

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=VYsz4wHVKya=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=878188



--- Comment #57 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=esdvHlx8eYa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=878188

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=hwvUaqAWL6a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=878188

Richard Shaw hobbes1...@gmail.com changed:

   What|Removed |Added

 CC||hobbes1...@gmail.com
  Flags|fedora-cvs+ |fedora-cvs?



--- Comment #56 from Richard Shaw hobbes1...@gmail.com ---
Package Change Request
==
Package Name: qt5-qtbase
New Branches: el6
Owners: hobbes1069
InitialCC: 

Needed for future review request.
Co-maintainers welcomed!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=jfreIdQQzqa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=878188

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 CC|package-review@lists.fedora |
   |project.org |



--- Comment #60 from Rex Dieter rdie...@math.unl.edu ---
I guess there's also:

tools/qregularexpression.cpp: In member function
'QRegularExpressionMatchPrivate* QRegularExpressionPrivate::doMatch(const
QString, int, QRegularExpression::MatchType, QRegularExpression::MatchOptions,
bool, const QRegularExpressionMatchPrivate*) const':
tools/qregularexpression.cpp:1241: error: passing 'const
QAtomicPointerpcre16_extra' as 'this' argument of 'T*
QBasicAtomicPointerT::loadAcquire() [with T = pcre16_extra]' discards
qualifiers

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=QYF56uzcE2a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2013-04-15 19:54:43

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=eHBHvz2Fdza=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #55 from Fedora Update System upda...@fedoraproject.org ---
qt5-qtbase-5.0.2-2.fc18 has been pushed to the Fedora 18 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=tPB9UBQxx0a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Blocks||928937 (qt-reviews)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=hA4Y98yZo7a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=lxLmNuGSMda=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #54 from Fedora Update System upda...@fedoraproject.org ---
qt5-qtbase-5.0.1-6.fc18 has been pushed to the Fedora 18 testing repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=SGMF8NpQ8da=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #48 from Ngo Than t...@redhat.com ---
= MUST items =

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Rpath absent or only used for internal libs.
[x]: Static libraries in -static subpackage, if present.

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package requires other packages for directories it uses.
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package is not known to require ExcludeArch.
[ ]: Fully versioned dependency in subpackages, if present.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in qt5-qtbase-
 static
[ ]: Package complies to the Packaging Guidelines
[ ]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 Public domain, Unknown or generated, MIT/X11 (BSD like), LGPL (v2
 or later) (with incorrect FSF address), zlib/libpng, ISC, BSD (3
 clause), BSD (2 clause), libpng, MPL (v1.1) GPL
 (unversioned/unknown version). 10 files have unknown license. Detailed
 output of licensecheck in /home/than/qt5-qtbase/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package consistently uses macro is (instead of hard-coded directory
 names).
[ ]: If the package is under multiple licenses, the licensing breakdown must
 be documented in the spec.
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[ ]: Package must own all directories that it creates.
[ ]: Package does not own files or directories owned by other packages.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Large documentation must go in a -doc subpackage.
 Note: Documentation size is 245760 bytes in 45 files.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Each %files section contains %defattr if rpm  4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).

= SHOULD items =

Generic:
[!]: Spec use %global instead of %define.
 Note: %define multilib_archs x86_64 %{ix86} ppc64 ppc s390x s390 sparc64
 sparcv9 %define multilib_basearchs x86_64 ppc64 s390x sparc64 %define
 _qt5 qt5 %define _qt5_prefix %{_libdir}/qt5 %define _qt5_archdatadir
 %{_libdir}/qt5 %define _qt5_bindir %{_qt5_prefix}/bin %define
 _qt5_datadir %{_datadir}/qt5 %define _qt5_docdir %{_docdir}/qt5 %define
 _qt5_examplesdir %{_qt5_prefix}/examples %define _qt5_headerdir
 %{_includedir}/qt5 %define _qt5_importdir %{_qt5_archdatadir}/imports
 %define _qt5_libdir %{_libdir} %define _qt5_libexecdir
 %{_qt5_archdatadir}/libexec %define _qt5_plugindir
 %{_qt5_archdatadir}/plugins 

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Ngo Than t...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-review?  |
  Flags||fedora-review+

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=NUrxSDjfOwa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #49 from Rex Dieter rdie...@math.unl.edu ---
New Package SCM Request
===
Package Name: qt5-qtbase
Short Description: Qt5 - QtBase components
Owners: than rdieter jreznik kkofler ltinkl rnovacek
Branches: f17 f18 f19
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Px734mqkgFa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #50 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=xK9XbUIqsPa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

--- Comment #51 from Rex Dieter rdie...@math.unl.edu ---
imported

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=EH84qg34mPa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #52 from Fedora Update System upda...@fedoraproject.org ---
qt5-qtbase-5.0.1-6.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/qt5-qtbase-5.0.1-6.fc17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=VCeK0Yj301a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #53 from Fedora Update System upda...@fedoraproject.org ---
qt5-qtbase-5.0.1-6.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/qt5-qtbase-5.0.1-6.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=2Fv6UhBljWa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

  Flags|needinfo?(rdie...@math.unl. |
   |edu)|

--- Comment #46 from Rex Dieter rdie...@math.unl.edu ---
Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtbase.spec
SRPM URL: 
Description:
http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtbase-5.0.1-6.fc18.src.rpm

%changelog
* Sat Mar 16 2013 Rex Dieter rdie...@fedoraproject.org 5.0.1-6
- pull in upstream gcc-4.8.0 buildfix

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=tTifJWBuc6a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #47 from Rex Dieter rdie...@math.unl.edu ---
f19 scratch build,
https://koji.fedoraproject.org/koji/taskinfo?taskID=5130856

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=wc7fODcnBLa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Ngo Than t...@redhat.com changed:

   What|Removed |Added

  Flags||needinfo?(rdie...@math.unl.
   ||edu)

--- Comment #40 from Ngo Than t...@redhat.com ---
qt5-qtbase-5.0.1-5.fc18.src.rpm doesn't build in current rawhide, you can
reproduce this build failure with fedora-review tool everytime.

part of the build.log:

g++ -c -m64 -pipe -pthread -I/usr/include/glib-2.0
-I/usr/lib64/glib-2.0/include -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -O2 -std=c++0x
-fvisibility=hidden -fvisibility-inlines-hidden -Wall -W -D_REENTRANT -fPIC
-DQT_NO_LIBUDEV -DQT_NO_USING_NAMESPACE -DQT_BUILD_CORE_LIB -DQT_BUILDING_QT
-DQT_NO_CAST_TO_ASCII -DQT_ASCII_CAST_WARNINGS -DQT_MOC_COMPAT
-DQT_USE_QSTRINGBUILDER -DQT_DEPRECATED_WARNINGS
-DQT_DISABLE_DEPRECATED_BEFORE=0x05
-DELF_INTERPRETER=\/lib64/ld-linux-x86-64.so.2\ -DQT_USE_ICU
-DHB_EXPORT=Q_CORE_EXPORT -DQT_CORE_LIB -D_LARGEFILE64_SOURCE
-D_LARGEFILE_SOURCE -DQT_NO_DEBUG -I../../mkspecs/linux-g++-64 -I.
-I../../include -I../../include/QtCore -I../../include/QtCore/5.0.1
-I../../include/QtCore/5.0.1/QtCore -Iglobal -I../3rdparty/md5
-I../3rdparty/md4 -I.moc/release-shared -o .obj/release-shared/qisciicodec.o
codecs/qisciicodec.cpp
kernel/qtimerinfo_unix.cpp:98:30: error: redeclaration 'constexpr T qAbs(const
T) [with T = timeval]' differs in 'constexpr'
 timeval qAbs(const timeval t)
  ^
In file included from ../../include/QtCore/qglobal.h:1:0,
 from
../../include/QtCore/../../src/corelib/tools/qelapsedtimer.h:45,
 from ../../include/QtCore/qelapsedtimer.h:1,
 from kernel/qtimerinfo_unix.cpp:42:
../../include/QtCore/../../src/corelib/global/qglobal.h:483:20: error: from
previous declaration 'constexpr T qAbs(const T) [with T = timeval]'
 Q_DECL_CONSTEXPR inline T qAbs(const T t) { return t = 0 ? t : -t; }
^
kernel/qtimerinfo_unix.cpp: In function 'constexpr T qAbs(const T) [with T =
timeval]':
kernel/qtimerinfo_unix.cpp:109:1: error: body of constexpr function 'constexpr
T qAbs(const T) [with T = timeval]' not a return-statement
 }
 ^
In file included from ../../include/QtCore/qglobal.h:1:0,
 from
../../include/QtCore/../../src/corelib/tools/qelapsedtimer.h:45,
 from ../../include/QtCore/qelapsedtimer.h:1,
 from kernel/qtimerinfo_unix.cpp:42:
../../include/QtCore/../../src/corelib/global/qglobal.h: In instantiation of
'constexpr T qAbs(const T) [with T = timeval]':
kernel/qtimerinfo_unix.cpp:147:44:   required from here
../../include/QtCore/../../src/corelib/global/qglobal.h:483:48: error: no match
for 'operator=' (operand types are 'const timeval' and 'int')
 Q_DECL_CONSTEXPR inline T qAbs(const T t) { return t = 0 ? t : -t; }
^
../../include/QtCore/../../src/corelib/global/qglobal.h:483:48: note:
candidates are:
In file included from ../../include/QtCore/qpair.h:1:0,
 from ../../include/QtCore/../../src/corelib/tools/qhash.h:48,
 from ../../include/QtCore/qhash.h:1,
 from
../../include/QtCore/../../src/corelib/tools/qsharedpointer_impl.h:63,
 from ../../include/QtCore/qsharedpointer_impl.h:1,


rpmlint qt5-qtbase-5.0.1-5.fc18.src.rpm
spelling-error %description -l en_US xml - XML, ml, x ml
qt5-qtbase.src:33: W: macro-in-comment %{_bindir}
qt5-qtbase.src:177: W: configure-without-libdir-spec
qt5-qtbase.src:276: W: macro-in-comment %{_bindir}
qt5-qtbase.src: W: %ifarch-applied-patch Patch1:
qtbase-opensource-src-5.0.1-lowmem.patch
1 packages and 0 specfiles checked; 0 errors, 5 warnings.

the rpmlint looks fine for me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=2htXamO4Q5a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #41 from Ngo Than t...@redhat.com ---
qt5-qtbase-5.0.1-5.fc18.src.rpm built fine on lastest f18. 

rpmlint qt5-qtbase-5.0.1-5.fc18.x86_64.rpm
qt5-qtbase-devel-5.0.1-5.fc18.x86_64.rpm
qt5-qtbase-static-5.0.1-5.fc18.x86_64.rpm \
 qt5-qtbase-ibase-5.0.1-5.fc18.x86_64.rpm
qt5-qtbase-mysql-5.0.1-5.fc18.x86_64.rpm \
 qt5-qtbase-odbc-5.0.1-5.fc18.x86_64.rpm
qt5-qtbase-postgresql-5.0.1-5.fc18.x86_64.rpm \
 qt5-qtbase-tds-5.0.1-5.fc18.x86_64.rpm
qt5-qtbase-x11-5.0.1-5.fc18.x86_64.rpm

qt5-qtbase.x86_64: W: spelling-error %description -l en_US xml - XML, ml, x ml
qt5-qtbase.x86_64: W: unstripped-binary-or-object
/usr/lib64/qt5/plugins/bearer/libqnmbearer.so
qt5-qtbase.x86_64: W: unstripped-binary-or-object
/usr/lib64/libQt5Test.so.5.0.1
qt5-qtbase.x86_64: W: shared-lib-calls-exit /usr/lib64/libQt5Test.so.5.0.1
exit@GLIBC_2.2.5
qt5-qtbase.x86_64: W: shared-lib-calls-exit /usr/lib64/libQt5Test.so.5.0.1 exit
qt5-qtbase.x86_64: W: unstripped-binary-or-object /usr/lib64/libQt5Xml.so.5.0.1
qt5-qtbase.x86_64: W: unstripped-binary-or-object /usr/lib64/libQt5Sql.so.5.0.1
qt5-qtbase.x86_64: W: unstripped-binary-or-object
/usr/lib64/qt5/plugins/sqldrivers/libqsqlite.so
qt5-qtbase.x86_64: W: unstripped-binary-or-object
/usr/lib64/libQt5Core.so.5.0.1
qt5-qtbase.x86_64: W: unstripped-binary-or-object
/usr/lib64/libQt5Concurrent.so.5.0.1
qt5-qtbase.x86_64: W: unstripped-binary-or-object
/usr/lib64/libQt5DBus.so.5.0.1
qt5-qtbase.x86_64: W: unstripped-binary-or-object
/usr/lib64/qt5/plugins/bearer/libqconnmanbearer.so
qt5-qtbase.x86_64: W: unstripped-binary-or-object
/usr/lib64/qt5/plugins/bearer/libqgenericbearer.so
qt5-qtbase.x86_64: W: unstripped-binary-or-object
/usr/lib64/libQt5Network.so.5.0.1
qt5-qtbase.x86_64: W: spurious-executable-perm
/usr/share/doc/qt5/global/template/images/feedbackground.png
qt5-qtbase.x86_64: W: spurious-executable-perm
/usr/share/doc/qt5/global/template/images/horBar.png
qt5-qtbase.x86_64: W: spurious-executable-perm
/usr/share/doc/qt5/global/template/images/bullet_sq.png
qt5-qtbase.x86_64: W: spurious-executable-perm
/usr/share/doc/qt5/global/template/images/bg_l_blank.png
qt5-qtbase.x86_64: W: spurious-executable-perm
/usr/share/doc/qt5/global/template/images/blu_dot.png
qt5-qtbase.x86_64: W: spurious-executable-perm
/usr/share/doc/qt5/global/template/images/home.png
qt5-qtbase.x86_64: W: spurious-executable-perm
/usr/share/doc/qt5/global/template/images/box_bg.png
qt5-qtbase.x86_64: W: spurious-executable-perm
/usr/share/doc/qt5/global/template/images/page_bg.png
qt5-qtbase.x86_64: W: spurious-executable-perm
/usr/share/doc/qt5/global/template/images/bg_r.png
qt5-qtbase.x86_64: W: spurious-executable-perm
/usr/share/doc/qt5/global/template/images/bullet_gt.png
qt5-qtbase.x86_64: W: spurious-executable-perm
/usr/share/doc/qt5/global/template/images/ico_note_attention.png
qt5-qtbase.x86_64: W: spurious-executable-perm
/usr/share/doc/qt5/global/template/images/ico_note.png
qt5-qtbase.x86_64: W: spurious-executable-perm
/usr/share/doc/qt5/global/template/images/sprites-combined.png
qt5-qtbase.x86_64: W: spurious-executable-perm
/usr/share/doc/qt5/global/template/images/bgrContent.png
qt5-qtbase.x86_64: W: spurious-executable-perm
/usr/share/doc/qt5/global/template/images/arrow.png
qt5-qtbase.x86_64: W: spurious-executable-perm
/usr/share/doc/qt5/global/template/images/breadcrumb.png
qt5-qtbase.x86_64: W: spurious-executable-perm
/usr/share/doc/qt5/global/template/images/ico_out.png
qt5-qtbase.x86_64: W: spurious-executable-perm
/usr/share/doc/qt5/global/template/images/bg_l.png
qt5-qtbase-devel.x86_64: W: unstripped-binary-or-object
/usr/bin/qdbuscpp2xml-qt5
qt5-qtbase-devel.x86_64: W: unstripped-binary-or-object /usr/bin/qmake-qt5
qt5-qtbase-devel.x86_64: W: unstripped-binary-or-object /usr/bin/uic-qt5
qt5-qtbase-devel.x86_64: W: unstripped-binary-or-object /usr/bin/rcc-qt5
qt5-qtbase-devel.x86_64: W: unstripped-binary-or-object /usr/bin/moc-qt5
qt5-qtbase-devel.x86_64: W: unstripped-binary-or-object
/usr/bin/qdbusxml2cpp-qt5
qt5-qtbase-devel.x86_64: W: unstripped-binary-or-object /usr/bin/qdoc
qt5-qtbase-devel.x86_64: W: no-documentation
qt5-qtbase-devel.x86_64: E: script-without-shebang
/usr/lib64/qt5/mkspecs/macx-xcode/Info.plist.app
qt5-qtbase-devel.x86_64: W: non-conffile-in-etc /etc/rpm/macros.qt5
qt5-qtbase-devel.x86_64: W: no-manual-page-for-binary moc-qt5
qt5-qtbase-devel.x86_64: W: no-manual-page-for-binary uic-qt5
qt5-qtbase-devel.x86_64: W: no-manual-page-for-binary qdbusxml2cpp-qt5
qt5-qtbase-devel.x86_64: W: no-manual-page-for-binary qdbuscpp2xml-qt5
qt5-qtbase-devel.x86_64: W: no-manual-page-for-binary qdoc
qt5-qtbase-devel.x86_64: W: no-manual-page-for-binary syncqt-qt5
qt5-qtbase-devel.x86_64: W: no-manual-page-for-binary rcc-qt5
qt5-qtbase-devel.x86_64: W: no-manual-page-for-binary qmake-qt5
qt5-qtbase-static.x86_64: W: no-documentation
qt5-qtbase-ibase.x86_64: W: 

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #42 from Rex Dieter rdie...@math.unl.edu ---
FYI, those unstripped binary warnings and lack of -debuginfo pkg may mean you
built without redhat-rpm-config installed.

Re: licensing of examples.  We don't package those (see '-nomake examples'
build option), so that should be a non-issue.  That said, I don't recall why
those are ommitted, and probably should be re-added at some point (and I'll
make note of the licensing).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=aSWAfG3tEsa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #43 from Ngo Than t...@redhat.com ---
(In reply to comment #42)
 FYI, those unstripped binary warnings and lack of -debuginfo pkg may mean
 you built without redhat-rpm-config installed.
 

i only mentioned W: spurious-executable-perm which we should fix and the rest
warnings can be ignored

 Re: licensing of examples.  We don't package those (see '-nomake examples'
 build option), so that should be a non-issue.  That said, I don't recall why
 those are ommitted, and probably should be re-added at some point (and I'll
 make note of the licensing).

i'm not sure if we can omit the BSD license independent if we package those
or not.
we need to check it with Spot!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=wodLjIRRVUa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #44 from Rex Dieter rdie...@math.unl.edu ---
See: 
https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#Does_the_License:_tag_cover_the_SRPM_or_the_binary_RPM.3F

License tag covers what is shipped in binary/built rpm's.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ux8ezcq2Hma=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #45 from Ngo Than t...@redhat.com ---
(In reply to comment #44)
 See: 
 https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/
 FAQ#Does_the_License:_tag_cover_the_SRPM_or_the_binary_RPM.3F
 
 License tag covers what is shipped in binary/built rpm's.

thanks, it looks then ok!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=A1Fscvl0Taa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #38 from Rex Dieter rdie...@math.unl.edu ---
I'd highly recommend taking your issue upstream,
http://lists.qt-project.org/mailman/listinfo/development

so this review can focus on *review blockers*.  thanks. :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=StPIbYckeMa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #39 from Kevin Kofler ke...@tigcc.ticalc.org ---
There are several things in those CMake files which need to be edited. This one
looks like a clear bug in what upstream ships though. But still, we need to go
through the whole file and change everything that needs changing, also for the
parallel-installation stuff.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=A0F6owqVbwa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Adam Batkin a...@batkin.net changed:

   What|Removed |Added

 CC||a...@batkin.net

--- Comment #37 from Adam Batkin a...@batkin.net ---
Something is weird with the cmake files that are built with the qt5 RPMs. They
all set their respective _qt5MODULE_instal_prefix to ${CMAKE_CURRENT_LIST_DIR}/
(which evaluates to the /usr/lib*/cmake/MODULE)

A really horrible hack (in case anyone wants to just play around) is to create
a symbolic link from each of the cmake directories (/usr/lib*/cmake/Qt5*/bin)
to /usr/lib*/qt5/bin

Obviously a better solution might be to set that CMake variable to
/usr/lib*/qt5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Ll5EVyV8Yla=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #36 from Rex Dieter rdie...@math.unl.edu ---
Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtbase.spec
SRPM URL: 
Description:
http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtbase-5.0.1-5.fc18.src.rpm

%changelog
* Tue Feb 26 2013 Rex Dieter rdie...@fedoraproject.org 5.0.1-5
- -static subpkg, Requires: fontconfig-devel,glib2-devel,zlib-devel
- -devel: Requires: pkgconfig(gl)

* Mon Feb 25 2013 Rex Dieter rdie...@fedoraproject.org 5.0.1-4
- create/own %%{_qt5_plugindir}/iconengines
- -devel: create/own %%{_qt5_archdatadir}/mkspecs/modules
- cleanup .prl

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=nG9Qiw0Oela=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Blocks||915902 (qt5-qtscript)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=MzjG9izh96a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Blocks||915903 (qt5-qtjsbackend)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Fuc8wbxCiea=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Blocks||915907 (qt5-qtquick1)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=AyGcQNPL9ma=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Blocks||915909 (qt5-qtdeclarative)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=2AyiWDsP9la=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Blocks||915910 (qt5-qtmultimedia)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=HHsqRcwSn3a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Blocks||915913 (qtgraphicaleffects)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=cdeJBowCuDa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Blocks||915916 (qt5-qtimageformats)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=l4BVp7XD3Na=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Blocks||915920 (qt5-qtsvg)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=TJtWCkAqjta=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Blocks||915923 (qt5-qtxmlpatterns)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Xh5ljLnABza=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Kevin Kofler ke...@tigcc.ticalc.org changed:

   What|Removed |Added

  Alias|qtbase  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=vREZGdsepJa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #35 from Rex Dieter rdie...@math.unl.edu ---
Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtbase.spec
SRPM URL: 
Description:
http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtbase-5.0.1-3.fc18.src.rpm

%changelog
* Sat Feb 23 2013 Rex Dieter rdie...@fedoraproject.org 5.0.1-3
- +%%_qt5_libexecdir

* Sat Feb 23 2013 Rex Dieter rdie...@fedoraproject.org 5.0.1-2
- macros.qt5: fix %%_qt5_headerdir, %%_qt5_datadir, %%_qt5_plugindir

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=atqjn5oo4Xa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Blocks||915005

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=kGR9CG78ZTa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Blocks||915006

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=wZLwlde45pa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Ngo Than t...@redhat.com changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|t...@redhat.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=dp16FzFNxda=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Ngo Than t...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||fedora-review?

--- Comment #33 from Ngo Than t...@redhat.com ---
qtchooser is enable by default in qt5-base, do we really want it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=cw6HqAr8nCa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #34 from Rex Dieter rdie...@math.unl.edu ---
It's an optional feature, but enabling it only includes a qtchooser .conf file
and should cause no harm either.  If you want to keep things simpler for review
purposes, I can disable it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=a2cxv8WfWGa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Dan Horák d...@danny.cz changed:

   What|Removed |Added

 Blocks||907398

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=7k4roR3DqZa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #32 from Kevin Kofler ke...@tigcc.ticalc.org ---
Sigh, according to upstream (Lars Knoll in QTBUG-18980), actually using the
system version of HarfBuzz rather than an ancient forked copy of an
unmaintained (non-)library was Not important for Qt 5.0. :-(

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=G8CxKH1x1ba=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #27 from Dan Horák d...@danny.cz ---
and the results are

s390
- the -O1 override is ineffective, the build system sets -O2 later on the
command line
g++ -c -pipe -O1 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector
--param=ssp-buffer-size=4 -m31 -march=z9-109 -mtune=z10 -O2 -std=c++0x
-fvisibility=hidden -fvisibility-inlines-hidden -Wall -W -D_REENTRANT
-fno-exceptions -fPIC -DQT_NO_LIBUDEV -DQT_NO_USING_NAMESPACE
-DQT_BUILD_GUI_LIB -DQT_BUILDING_QT -DQT_NO_CAST_TO_ASCII
-DQT_ASCII_CAST_WARNINGS -DQT_MOC_COMPAT -DQT_USE_QSTRINGBUILDER
-DQT_DEPRECATED_WARNINGS -DQT_DISABLE_DEPRECATED_BEFORE=0x05 -DQT_NO_DEBUG
-DQT_CORE_LIB -DQT_NO_EXCEPTIONS -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE
-I../../mkspecs/linux-g++ -I. -I../../include -I../../include/QtGui
-I../../include/QtGui/5.0.0 -I../../include/QtGui/5.0.0/QtGui -Iimage
-I/usr/include/libdrm -I../../include/QtCore -I../../include/QtCore/5.0.0
-I../../include/QtCore/5.0.0/QtCore -I.moc/release-shared -o
.obj/release-shared/qdrawhelper.o painting/qdrawhelper.cpp
- -O3 is used from the #pragma anyway
- builds fine with the #pragma commented out

s390x
- fails with 3 GB of memory (1G ram + 2G swap), but succeeds with 8 GB (3 + 5)

ppc/ppc64
- fails with error in dialogs/qprintdialog_unix.cpp:54
- http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=886976

arm
- http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=1409787 - no results
yet


I think the huge memory requirements with -O3 on s390/s390x prove Jakub's
statement that -O3 can't be enabled globally as it is not safe and the quality
varies between arches

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=yDtCYuCoYVa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #28 from Dan Horák d...@danny.cz ---
arm
- OOM in cc1plus same as on s390

my suggestion would be to patch out the -O3 #pragma for the low-memory arches
starting with %{arm} s390

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Ka67GnZE8Ca=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #29 from Rex Dieter rdie...@math.unl.edu ---
agreed, will do.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=zsKOKsMrtPa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #30 from Rex Dieter rdie...@math.unl.edu ---
Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtbase.spec
SRPM URL: 
Description:
http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtbase-5.0.1-1.fc18.src.rpm

%changelog
* Thu Jan 31 2013 Rex Dieter rdie...@fedoraproject.org 5.0.1-1
- 5.0.1
- lowmem patch for %%arm, s390

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=CksJvhbnvMa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #31 from Rex Dieter rdie...@math.unl.edu ---
Wrt bundled harfbuzz,
http://lists.qt-project.org/pipermail/development/2013-January/009637.html

It appears that qt (4 and 5) both bundle the older non-system-provided harfbuzz
as referenced here,
http://www.freedesktop.org/wiki/Software/HarfBuzz

So, including it in packaging is almost certainly acceptable.  I can and will
go through the formal exceptions process if any potential reviewer insists.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Y2aB1U4P6Pa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Dan Horák d...@danny.cz changed:

   What|Removed |Added

 CC||d...@danny.cz

--- Comment #19 from Dan Horák d...@danny.cz ---
seems bundled copies of pcre and harfbuzz are built ...

PCRE auto-detection... ()
g++ -c -m64 -pipe -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector
--param=ssp-buffer-size=4 -m64 -march=z9-109 -mtune=z10 -O2 -Wall -W -fPIE 
-I../../../
mkspecs/linux-g++-64 -I. -o pcre.o pcre.cpp
pcre.cpp:42:18: fatal error: pcre.h: No such file or directory
compilation terminated.
gmake: *** [pcre.o] Error 1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=HR0EPnBxDna=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #20 from Dan Horák d...@danny.cz ---
also the build needs a LOT of memory, it fails on s390 with 2GB of address
space with
...
cc1plus: out of memory allocating 285056 bytes after a total of 1320124416
bytes
make[2]: *** [.obj/release-shared/qdrawhelper.o] Error 1
make[2]: *** Waiting for unfinished jobs

so please apply the s/-O2/-O1/ hack

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=aCENGMUPbVa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #21 from Rex Dieter rdie...@math.unl.edu ---
thanks for pcre, harfbuz... looks like is used only building for mac.

As for s390 hack, you mean modifiying %optflags?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=jTjv67vlIxa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #22 from Dan Horák d...@danny.cz ---
(In reply to comment #21)
 thanks for pcre, harfbuz... looks like is used only building for mac.

hm, I'll better recheck the logs for harfbuzz presence

 As for s390 hack, you mean modifiying %optflags?

yes, I think it already was in qt4. Or was the reason out of memory during
linking?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=45OmG3kv1Ca=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #23 from Rex Dieter rdie...@math.unl.edu ---
yeah, qt4 includes a patch for reduced memory wrt libQtWebKit linking.  (I
assume we'll likely need something similar when we package/review qt5-qtwebkit)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=syszzprGvZa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #24 from Rex Dieter rdie...@math.unl.edu ---
Hrm, seems bundled harfbuzz is indeed still used somehow :(

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=cmn3xhIieGa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #25 from Rex Dieter rdie...@math.unl.edu ---
Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtbase.spec
SRPM URL: 
Description:
http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtbase-5.0.0-4.fc18.src.rpm

%changelog
* Wed Jan 30 2013 Rex Dieter rdie...@fedoraproject.org 5.0.0-4
- %%build: -system-pcre, BR: pkgconfig(libpcre)
- use -O1 optimization on lowmem (s390) arch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=IsZshfi1xoa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #26 from Dan Horák d...@danny.cz ---
I'm still getting c++ killed by the kernel's oom killer even on s390x, but I
guess it's because src/gui/painting/qdrawhelper.cpp (200+ KB file) has
#  pragma GCC optimize O3

I'll do some more tests on both s390 and s390x ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ZjOU84FMNQa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

greg.helli...@gmail.com changed:

   What|Removed |Added

 CC||greg.helli...@gmail.com

--- Comment #12 from greg.helli...@gmail.com ---
Has no one taken this for review? I'd like to see Qt5 make it out the door both
in native and the MinGW world.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=vDOUkRHbTDa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #13 from Rex Dieter rdie...@math.unl.edu ---
so far, no.  you're welcome to help. :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=18P5fnkD7Ta=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #14 from greg.helli...@gmail.com ---
Other than your URL above returning 404 (-2 replacing -1), everything looks OK
to me. I don't feel at all qualified to give you an official review on
something this big, though, as I'm new to the packager world and this is a very
complex suite of libraries. I would be happy to see it out in the wild, though,
as I am working on a project that requires some Qt5-only features.

Just a side note: the installed PNG files in
/usr/share/doc/qt5/global/template/images are picked up by rpmlint as having +x
permissions, which is probably unnecessary.

I'll start using the build of them I have created in testing, though, and let
you know if any problems come up.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=9rQM0MUHoKa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #15 from Rex Dieter rdie...@math.unl.edu ---
indeed, sorry for not updating the links, here we go:

Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtbase.spec
SRPM URL: 
Description:
http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtbase-5.0.0-2.fc18.src.rpm


%changelog
* Wed Jan 09 2013 Rex Dieter rdie...@fedoraproject.org 5.0.0-2
- add qtchooser support (disabled by default)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=SbLUZn7KPOa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Depends On||895149 (qtchooser)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=e5goupHO9La=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #16 from Kevin Kofler ke...@tigcc.ticalc.org ---
If you want my opinion: Yank the qtchooser nonsense! (Also from the Qt 4
qt.spec you polluted in Rawhide with this junk.) Set this up the same way as Qt
4 instead, and make changes to the CMake configuration and/or to QMake if and
as needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=KnFND9ZOyKa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #17 from Rex Dieter rdie...@math.unl.edu ---
the -qt5 postfix stuff can mostly coexist with qtchooser, and i've been
brainstorming ideas on how to make it even less intrusive if needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=z2NYunmkIAa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #11 from Rex Dieter rdie...@math.unl.edu ---
Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtbase.spec
SRPM URL: 
Description:
http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtbase-5.0.0-1.fc18.src.rpm

%changelog
* Wed Dec 19 2012 Rex Dieter rdie...@fedoraproject.org 5.0.0-1
- 5.0 (final)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ieuacqEBKba=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #10 from Kevin Kofler ke...@tigcc.ticalc.org ---
FWIW, IMHO, qtchooser is a totally insane and unsupportable solution, I don't
think we should even try to support that. The apparently same executable ends
up actually spawning a completely different binary based on one or more of:
* yet another nonstandard environment variable (why not use PATH for that?),
* one or more config file(s) (WTF? Which binary gets run depends on CONFIG
FILES?) and/or
* a command-line argument, whose use will spit errors when an actual binary
gets found instead (thus totally unreliable for build systems to use, yet it's
the only of the 3 mechanisms which would make any sense at all for a build
system to use).
Your build system finds a qmake, thinks it is a Qt 5 qmake, and suddenly, the
user changes a config file on you in the background and your build ends up
calling the Qt 4 (or even Qt 3) qmake instead? What the f***?

But even if we do end up supporting qtchooser, having the suffixed binaries
(with appropriate CMake adjustments to search for them instead of the
unsuffixed ones, it's fairly trivial (just change the find_program lines), a
sample patch was posted to kde-packager) is only going to help and not conflict
with qtchooser.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=fRXkt2qkNAa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #8 from Erik van Pienbroek erik-fed...@vanpienbroek.nl ---
Is there any particular reason why you've added a custom Qt5.pc file? Upstream
doesn't provide this and other distros like Ubuntu also don't provide this
file. From the looks of it, upstream is expecting developers to use one of the
other pkg-config files which is bundled with Qt5, like Qt5Core.pc. If its only
purpose is to provide variables like the installation paths and the location of
qmake and moc then I guess it would make more sense to ask upstream to add this
information to one of the already bundled pkg-config files like Qt5Core.pc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=0zBdP6PkARa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #9 from Rex Dieter rdie...@math.unl.edu ---
Sure, upstreaming it makes sense (we do the same in our qt(4) packaging too),
just never got around to it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=s3hi7TjnSna=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #5 from Rex Dieter rdie...@math.unl.edu ---
Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtbase.spec
SRPM URL: 
Description:
http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtbase-5.0.0-0.4.rc2.fc18.src.rpm

%changelog
* Thu Dec 13 2012 Rex Dieter rdie...@fedoraproject.org 5.0.0-0.4.rc2
- 5.0-rc2
- initial try at putting non-conflicting binaries in %%_bindir

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=twCR909wcua=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Erik van Pienbroek erik-fed...@vanpienbroek.nl changed:

   What|Removed |Added

 CC||erik-fed...@vanpienbroek.nl

--- Comment #6 from Erik van Pienbroek erik-fed...@vanpienbroek.nl ---
Hi Rex,

Upstream developers recently started a thread on the Qt development mailing
list about things us downstream packagers should take into account:
http://www.mail-archive.com/development@qt-project.org/msg08471.html

In the same thread another Qt developer (Thiago) points out that renaming the
tools shouldn't be done at all as a new tool will be introduced by the end of
this week called 'qtchooser':
http://www.mail-archive.com/development@qt-project.org/msg08533.html
This tool will act as a centralized qmake wrapper and will support multiple Qt
installations (like the native Fedora Linux one and the Fedora MinGW one).
There still isn't much known about this tool yet, but I expect it to become
available any moment now

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=xUOxNuruKMa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

--- Comment #7 from Rex Dieter rdie...@math.unl.edu ---
I know, though Kevin (on irc) had a fairly strong opinion to do to it this way
too.  We've been careful to follow the mailing list discussion, and are fairly
certain that our modifications here won't conflict with use of qtchooser.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=gUkShEWBBBa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

Summary|Review Request: qtbase -|Review Request: qt5-qtbase
   |Qt5 - QtBase components |- Qt5 - QtBase components
  Alias||qt5-base

--- Comment #4 from Rex Dieter rdie...@math.unl.edu ---
Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtbase.spec
SRPM URL: 
Description:
http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtbase-5.0.0-0.2.beta2.fc18.src.rpm

%changelog
* Wed Nov 28 2012 Rex Dieter rdie...@fedoraproject.org 5.0.0-0.2.beta2
- qtbase -- qt5-qtbase

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878188

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

  Alias|qt5-base|qt5-qtbase

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review