[Bug 880155] Review Request: PackageKit-Qt - Qt support library for PackageKit
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880155 Richard Hughes rhug...@redhat.com changed: What|Removed |Added Last Closed||2012-11-27 03:11:47 Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE --- Comment #8 from Richard Hughes rhug...@redhat.com --- Thanks guys! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880155] Review Request: PackageKit-Qt - Qt support library for PackageKit
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880155 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Status|NEW |ASSIGNED CC||rdie...@math.unl.edu Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu Flags||fedora-review? --- Comment #1 from Rex Dieter rdie...@math.unl.edu --- I can help with the review, it's fairly small and should be pretty simple and straight-forward... -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880155] Review Request: PackageKit-Qt - Qt support library for PackageKit
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=880155
--- Comment #2 from Rex Dieter rdie...@math.unl.edu ---
$ rpmlint *.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
naming: ok
sources: ok
41f6fa67e980733d7d8a2cd881bbe5b4 PackageKit-Qt-0.8.6.tar.gz
license: ok
$ licensecheck -r src
src/daemonprivate.h: LGPL (v2 or later)
src/transactionprivate.h: LGPL (v2 or later)
src/common.h: LGPL (v2 or later)
src/bitfield.cpp: *No copyright* UNKNOWN
src/daemonprivate.cpp: LGPL (v2 or later)
src/daemon.cpp: LGPL (v2 or later)
src/transaction.h: LGPL (v2 or later)
src/bitfield.h: *No copyright* UNKNOWN
src/transaction.cpp: LGPL (v2 or later)
src/transactionprivate.cpp: LGPL (v2 or later)
src/daemon.h: LGPL (v2 or later)
macros: ok
builds/installs: mostly ok, but...
1. MUST: need some Obsoletes (and at least a temporary Provides) here to
handle upgrade from older PackageKit-qt...
Obsoletes: PackageKit-qt 0.8.6
Provides: PackageKit-qt = %{version}-%{release}
Provides: PackageKit-qt%{?_isa} = %{version}-%{release}
and for -devel subpkg:
Obsoletes: PackageKit-qt-devel 0.8.6
Provides: PackageKit-qt-devel = %{version}-%{release}
that seems to be the only review blocker i see. there's a handful of smaller
SHOULD things we can do, but i'll be happy to wait until after import to help
implement that.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880155] Review Request: PackageKit-Qt - Qt support library for PackageKit
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=880155
--- Comment #3 from Richard Hughes rhug...@redhat.com ---
(In reply to comment #2)
1. MUST: need some Obsoletes (and at least a temporary Provides) here to
handle upgrade from older PackageKit-qt...
Obsoletes: PackageKit-qt 0.8.6
Provides: PackageKit-qt = %{version}-%{release}
Provides: PackageKit-qt%{?_isa} = %{version}-%{release}
and for -devel subpkg:
Obsoletes: PackageKit-qt-devel 0.8.6
Provides: PackageKit-qt-devel = %{version}-%{release}
Fixed in:
Spec URL: http://people.freedesktop.org/~hughsient/temp/PackageKit-Qt.spec
SRPM URL:
http://people.freedesktop.org/~hughsient/temp/PackageKit-Qt-0.8.6-1.fc18.src.rpm
Thanks for the super-speedy review.
Richard.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880155] Review Request: PackageKit-Qt - Qt support library for PackageKit
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880155 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #4 from Rex Dieter rdie...@math.unl.edu --- invert the order of your changelog (newest first), and we have a winner. :) please add me (rdieter) as comaintainer. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880155] Review Request: PackageKit-Qt - Qt support library for PackageKit
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880155 --- Comment #5 from Richard Hughes rhug...@redhat.com --- (In reply to comment #4) invert the order of your changelog (newest first), and we have a winner. :) Gahh, Monday :) Sorry about that. Fixed. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880155] Review Request: PackageKit-Qt - Qt support library for PackageKit
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880155 --- Comment #6 from Richard Hughes rhug...@redhat.com --- New Package SCM Request === Package Name: PackageKit-Qt Short Description: Qt support library for PackageKit Owners: rhughes rdieter Branches: f17 f18 InitialCC: rdieter -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880155] Review Request: PackageKit-Qt - Qt support library for PackageKit
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880155 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880155] Review Request: PackageKit-Qt - Qt support library for PackageKit
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880155 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
