[Bug 880179] Review Request: libnetfilter_cthelper - User-space infrastructure for connection tracking helpers
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880179 Peter Lemenkov changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2012-12-21 05:30:06 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=K9EZE4Ct3f&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880179] Review Request: libnetfilter_cthelper - User-space infrastructure for connection tracking helpers
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880179 --- Comment #12 from Fedora Update System --- libnetfilter_cthelper-1.0.0-3.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PahWpSU2WY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880179] Review Request: libnetfilter_cthelper - User-space infrastructure for connection tracking helpers
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880179 --- Comment #11 from Fedora Update System --- libnetfilter_cthelper-1.0.0-3.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VEOQq6rB7U&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880179] Review Request: libnetfilter_cthelper - User-space infrastructure for connection tracking helpers
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880179 --- Comment #10 from Fedora Update System --- libnetfilter_cthelper-1.0.0-3.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eS3Li181F3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880179] Review Request: libnetfilter_cthelper - User-space infrastructure for connection tracking helpers
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880179 --- Comment #9 from Fedora Update System --- libnetfilter_cthelper-1.0.0-3.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6yOVxVJjCO&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880179] Review Request: libnetfilter_cthelper - User-space infrastructure for connection tracking helpers
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880179 --- Comment #8 from Fedora Update System --- libnetfilter_cthelper-1.0.0-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/libnetfilter_cthelper-1.0.0-3.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880179] Review Request: libnetfilter_cthelper - User-space infrastructure for connection tracking helpers
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880179 --- Comment #7 from Fedora Update System --- libnetfilter_cthelper-1.0.0-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libnetfilter_cthelper-1.0.0-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880179] Review Request: libnetfilter_cthelper - User-space infrastructure for connection tracking helpers
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880179 --- Comment #6 from Fedora Update System --- libnetfilter_cthelper-1.0.0-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/libnetfilter_cthelper-1.0.0-3.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880179] Review Request: libnetfilter_cthelper - User-space infrastructure for connection tracking helpers
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880179 --- Comment #5 from Fedora Update System --- libnetfilter_cthelper-1.0.0-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/libnetfilter_cthelper-1.0.0-3.el6 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880179] Review Request: libnetfilter_cthelper - User-space infrastructure for connection tracking helpers
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880179 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880179] Review Request: libnetfilter_cthelper - User-space infrastructure for connection tracking helpers
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880179 --- Comment #4 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880179] Review Request: libnetfilter_cthelper - User-space infrastructure for connection tracking helpers
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880179 Paul P Komkoff Jr changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Paul P Komkoff Jr --- New Package SCM Request === Package Name: libnetfilter_cthelper Short Description: User-space infrastructure for connection tracking helpers Owners: stingray Branches: f16 f17 f18 el5 el6 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880179] Review Request: libnetfilter_cthelper - User-space infrastructure for connection tracking helpers
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=880179
Peter Lemenkov changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #2 from Peter Lemenkov ---
REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
+ rpmlint is mostly silent (except few false positives):
sulaco ~/rpmbuild/SPECS: rpmlint ../RPMS/ppc/libnetfilter_cthelper-*
../SRPMS/libnetfilter_cthelper-1.0.0-1.fc19.src.rpm
libnetfilter_cthelper.ppc: E: incorrect-fsf-address
/usr/share/doc/libnetfilter_cthelper-1.0.0/COPYING
libnetfilter_cthelper-debuginfo.ppc: W: spelling-error Summary(en_US)
libnetfilter -> filibusterer
libnetfilter_cthelper-debuginfo.ppc: W: spelling-error Summary(en_US) cthelper
-> ct helper, ct-helper, helper
libnetfilter_cthelper-debuginfo.ppc: W: spelling-error %description -l en_US
libnetfilter -> filibusterer
libnetfilter_cthelper-debuginfo.ppc: W: spelling-error %description -l en_US
cthelper -> ct helper, ct-helper, helper
libnetfilter_cthelper-devel.ppc: W: spelling-error Summary(en_US) libnetfilter
-> filibusterer
libnetfilter_cthelper-devel.ppc: W: spelling-error Summary(en_US) cthelper ->
ct helper, ct-helper, helper
libnetfilter_cthelper-devel.ppc: W: spelling-error %description -l en_US
libnetfilter -> filibusterer
libnetfilter_cthelper-devel.ppc: W: spelling-error %description -l en_US
cthelper -> ct helper, ct-helper, helper
4 packages and 0 specfiles checked; 1 errors, 8 warnings.
sulaco ~/rpmbuild/SPECS:
+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
- The License field in the package spec file MUST matche the actual license
(GPLv2 or later). A correct License tag is GPLv2+.
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided
in the spec URL.
sulaco ~/rpmbuild/SOURCES: sha256sum libnetfilter_cthelper-1.0.0.tar.bz2*
07618e71c4d9a6b6b3dc1986540486ee310a9838ba754926c7d14a17d8fccf3d
libnetfilter_cthelper-1.0.0.tar.bz2
07618e71c4d9a6b6b3dc1986540486ee310a9838ba754926c7d14a17d8fccf3d
libnetfilter_cthelper-1.0.0.tar.bz2.1
sulaco ~/rpmbuild/SOURCES:
+ The package successfully compiles and builds into binary rpms on at least one
primary architecture.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
+ The package stores shared library files in some of the dynamic linker's
default paths, and it calls ldconfig in %post and %postun.
+ The package does NOT bundle copies of system libraries.
0 The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
0 The package DOESN'T have a %clean section, so it won't build cleanly on
systems with old rpm (EL-4 and EL-5, not sure about EL-6). Beware.
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
+ Header files are stored in a -devel package.
0 No static libraries.
+ The pkgconfig(.pc) file is stored in a -devel package.
+ The library file(s) that end in .so (without suffix) is(are) stored in a
-devel package.
+ The -devel package requires the base package using a fully versioned
dependency: Requires: %{name}%{?_isa} = %{version}-%{release}
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does not own files or directories already owned by other
packages.
0 At the beginning of %install, the package does not run rm -rf %{buildroot}
(or $RPM_BUILD_ROOT) so it won't build cleanly on systems with old rpm (EL-4
and EL-5, not sure about EL-6). Beware.
+ All filenames in rpm packages are valid UTF-8.
Assuming that you set License tag to GPLv2+ I don't see any issues and this
package is
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880179] Review Request: libnetfilter_cthelper - User-space infrastructure for connection tracking helpers
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880179 Peter Lemenkov changed: What|Removed |Added Status|NEW |ASSIGNED CC||lemen...@gmail.com Assignee|nob...@fedoraproject.org|lemen...@gmail.com Flags||fedora-review? --- Comment #1 from Peter Lemenkov --- I'll review it. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
