[Bug 880203] Review Request: rubygem-strong_parameters - Permitted and required parameters for Action Pack
https://bugzilla.redhat.com/show_bug.cgi?id=880203 Ken Dreyer ktdre...@ktdreyer.com changed: What|Removed |Added Flags|fedora-review? | -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880203] Review Request: rubygem-strong_parameters - Permitted and required parameters for Action Pack
https://bugzilla.redhat.com/show_bug.cgi?id=880203 Josef Stribny jstri...@redhat.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Flags|needinfo?(jstribny@redhat.c | |om) | --- Comment #4 from Josef Stribny jstri...@redhat.com --- Hi Ken, thanks for taking the review! Would you mind unmarking tests as %doc? Sure, this is a mistake. you should run gem unpack and gem spec in %prep, gem build in %build, etc. I will disagree with you here, %gem_install macro is completely sufficient and it's used this way in some gems. I am not patching anything, so those steps are redundant. But I moved it to %build, where it originally belongs. update to the latest upstream Done. and update the License field to MIT Good catch, changed. Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5921913 SRPM: http://kojipkgs.fedoraproject.org//work/tasks/1914/5921914/rubygem-strong_parameters-0.2.1-1.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PlPqofgCo5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880203] Review Request: rubygem-strong_parameters - Permitted and required parameters for Action Pack
https://bugzilla.redhat.com/show_bug.cgi?id=880203 Ken Dreyer ktdre...@ktdreyer.com changed: What|Removed |Added CC||ktdre...@ktdreyer.com Assignee|nob...@fedoraproject.org|ktdre...@ktdreyer.com Flags||fedora-review? --- Comment #2 from Ken Dreyer ktdre...@ktdreyer.com --- Hi Josef, I can take this review. Would you mind unmarking tests as %doc? Also it looks like this package should be updated for the latest Ruby guidelines. For example, you should run gem unpack and gem spec in %prep, gem build in %build, etc. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JuKZvqlMQFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880203] Review Request: rubygem-strong_parameters - Permitted and required parameters for Action Pack
https://bugzilla.redhat.com/show_bug.cgi?id=880203 Ken Dreyer ktdre...@ktdreyer.com changed: What|Removed |Added CC||jstri...@redhat.com Flags||needinfo?(jstribny@redhat.c ||om) --- Comment #3 from Ken Dreyer ktdre...@ktdreyer.com --- Also, please update to the latest upstream (0.2.1), and update the License field to MIT. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3AyS3uJEgGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880203] Review Request: rubygem-strong_parameters - Permitted and required parameters for Action Pack
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880203 --- Comment #1 from Josef Stribny jstri...@redhat.com --- Updated regarding Ruby 2 [1] and to the latest version: SPEC: http://data-strzibny.rhcloud.com/rubygem-strong_parameters.spec SRPM: http://data-strzibny.rhcloud.com/rubygem-strong_parameters-0.2.0-1.fc20.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5287420 [1] https://fedoraproject.org/wiki/Features/Ruby_2.0.0 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=46UAvqcudta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880203] Review Request: rubygem-strong_parameters - Permitted and required parameters for Action Pack
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880203 Josef Stribny jstri...@redhat.com changed: What|Removed |Added Summary|rubygem-strong_parameters - |Review Request: |Permitted and required |rubygem-strong_parameters - |parameters for Action Pack |Permitted and required ||parameters for Action Pack -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
