[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=885038

Andrew Toskin  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
Last Closed||2018-03-06 18:20:05



--- Comment #24 from Andrew Toskin  ---
I'm going to go ahead and close this. But, Christophe, if you decide you want
to resume work on this package, you could just go ahead and reopen this issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=885038



--- Comment #23 from Andrew Toskin  ---
It's been almost a year since the last comment on this thread, and before that
there was a three year gap. Is it safe to call this an abandoned package
review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=885038

terrycloth  changed:

   What|Removed |Added

 CC||and...@tosk.in



--- Comment #22 from terrycloth  ---
This is an old thread, so I dunno if Christophe is even still interested in
maintaining this package.

But blocking pentobi on trademark grounds seems a little paranoid, when the
trademarked name is only referenced in the package description and not used in
the application's name. The "Pomodoro Technique" is trademarked, but we still
have gnome-shell-extension-pomodoro. Or try doing `dnf search microsoft` and
see how many results come up.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=885038

Ben Rosser  changed:

   What|Removed |Added

 Blocks||1364745




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1364745
[Bug 1364745] (FE-GAMESIG) Games SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=885038

--- Comment #21 from Tom spot Callaway tcall...@redhat.com ---
We want to err on the side of caution here, especially since the Blokus
trademark is registered for use in computer games. Hopefully, this patch will
not be too intrusive (but we need to carry it even if upstream is not
interested).

To be pedantic, this is a grey area. The use might be considered fair use, or a
judge might find that the use is infringing because people would confuse
Pentobi for the Blokus computer game. We just want to eliminate the risk.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=eVw7GrysVga=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=885038

--- Comment #20 from Christophe Burgun linuxed_fed...@yahoo.fr ---
Hi, thanks for the help

I have write on mailing list of pentobi and the answer :

http://jouty.fedorapeople.org/trademark

So need i do a patch to replace this occurrences or like Markus says in spec
description is it enough ?

In my opinion like Tom says all the places it is visible to the end-user but
just want a confirmation to start the patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=gDtsnriag1a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=885038

Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

 CC||tcall...@redhat.com

--- Comment #19 from Tom spot Callaway tcall...@redhat.com ---
I concur. You will need to replace the Blokus trademark with a popular
block-based abstract strategy board game in all the places it is visible to
the end-user, including in the .spec description.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=uW4rYyDcAla=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=885038

--- Comment #18 from Jason Tibbitts ti...@math.uh.edu ---
I'm pretty sure that Blokus is a registered trademark, and it looks to me that
it's not being used correctly in this package. 
http://fedoraproject.org/wiki/Packaging:Guidelines#Trademarks_in_Summary_or_Description

Blocking FE-Legal for an opinion.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=me8LThvQqJa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=885038

Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

 Blocks||182235 (FE-Legal)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=gDUlJXCPN9a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885038

--- Comment #17 from Christophe Burgun linuxed_fed...@yahoo.fr ---
Updating spec file with new pentobi version

See changelog

Spec URL: http://jouty.fedorapeople.org/pentobi.spec
SRPM URL: http://jouty.fedorapeople.org/pentobi-6.0-1.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=t40Rn0EjUua=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885038

--- Comment #16 from Christophe Burgun jo...@fedoraproject.org ---
Hi michael,

Changelog Updated

Spec URL: http://jouty.fedorapeople.org/pentobi.spec
SRPM URL: http://jouty.fedorapeople.org/pentobi-5.0-4.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=XaHAU0AMpDa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885038

--- Comment #14 from Christophe Burgun jo...@fedoraproject.org ---
Hi Antonio, Hi Michael,

Thanks for the feedback and sorry for the long delay i takke for answer

 Note: Cannot find license.html in rpm(s)

This is a fedora-review bug 
%doc COPYING contain license

For package name i have take default to lowercase naming.

 BuildRequires and Requires entries should be listed one-by-one.
I have changed each buildrequires and requires entries one-by-one

 [-]: %check is present and all tests pass.
I have add 
%check
ctest cmake_install.cmake

but :

Exécution_de(%check) : /bin/sh -e /var/tmp/rpm-tmp.PryLyS
+ umask 022
+ cd /builddir/build/BUILD
+ cd pentobi-5.0
+ ctest cmake_install.cmake
Test project /builddir/build/BUILD/pentobi-5.0
No tests were found!!!

so in check section i have only the desktop-file-validate

 Requires: boost,qt
in Install notes it is written for this requirements
Are you sure that i need put away requires ?

 %{_prefix}/games/pentobi
 %dir %{_datadir}/games/%{name}
 | Data files (maps, pixmaps, sounds) go in  %{_datadir}/%{name} ,
 | not %{_datadir}/games/%{name} . Binaries go in  %{_bindir} and
 | not /usr/games. According to the FHS, the use of /usr/share/games
 | and /usr/games is optional, and we recommend not using either for
 | consistency, so that games are packaged like all other applications. 

https://sourceforge.net/p/pentobi/bugs/7/

for moment i apply the patch and this will be better in the next pentobi
version

 %{_datadir}/mime/packages/pentobi-mime.xml
%post and %postun have been added

 %{_datadir}/icons/hicolor/16x16/apps/pentobi.png
%post and %postun have been added

 %{_datadir}/thumbnailers/pentobi.thumbnailer
%dir %{_datadir}/thumbnailers has been added
and bugreport has been open https://bugzilla.redhat.com/show_bug.cgi?id=893988
http://lists.fedoraproject.org/pipermail/packaging/2013-January/008850.html

Changelog Updated

Spec URL: http://jouty.fedorapeople.org/pentobi.spec
SRPM URL: http://jouty.fedorapeople.org/pentobi-5.0-3.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=GnLWCzCx67a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885038

--- Comment #15 from Michael Schwendt mschwe...@gmail.com ---
 Requires: boost,qt

https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires


 No tests were found!!!

What about building with -DPENTOBI_BUILD_TESTS=ON and running make test in
%check? Would that make sense for this program?

(Generally, there are different opinions about running test-suites at RPM
package build-time. Some think only the software developers should run those
test-suites. But often enough the target environment -- libs, compiler,
options, bugs in libs -- differs and results in issues, so running test-suites
more often, e.g. during automatic rebuilds, can be helpful.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=7Z7A0rr3WAa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885038

--- Comment #13 from Antonio Trande trp...@katamail.com ---
(In reply to comment #12)
 Which is what I've just tried, because I was curious to figure out how much
 effort would be needed to adhere to the Games SIG's packaging guidelines.
 

If you have not already seen, this is reported in NEWS file in the original
source:


Version 1.0 (1 Jan 2012)

...

* Changed installation directories according to Filesystem
  Hierarchy Standard (/usr/bin to /usr/games, /usr/share to
  /usr/share/games)

...

Maintainer could already have a reverse patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=cSd5ZqhlUia=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885038

--- Comment #6 from Michael Schwendt mschwe...@gmail.com ---
 by compiling this software manually, its binaries are located precisely
 in those paths. 

That would be an interesting exercise to examine further. How did your
compilation commands differ from the spec file's %build and %install sections?

pentobi-5.0/CMakeLists.txt  contains several hardcoded install paths, which are
the default.

The file also does the things RPM packages need to do in their scriptlets
instead (GConf2 stuff, update-mime-database, update-desktop-database).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=2LI5owPEg8a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885038

--- Comment #7 from Antonio Trande trp...@katamail.com ---
(In reply to comment #6)
  by compiling this software manually, its binaries are located precisely
  in those paths. 
 
 That would be an interesting exercise to examine further. How did your
 compilation commands differ from the spec file's %build and %install
 sections?
 
 pentobi-5.0/CMakeLists.txt  contains several hardcoded install paths, which
 are the default.

All data files hardcoded-install-paths point to {_datadir}/games/%{name} which
are not correct according to packaging guidelines; I'm compiling manually so
they become /usr/local/share/games/{name}.
Therefore let's change paths in CMakeLists.txt or we edit .spec file properly
in order to change them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=xDI7lLaKIOa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885038

--- Comment #8 from Michael Schwendt mschwe...@gmail.com ---
/usr/local/share/games is not different, because /usr/local/share is just the
local (site-specific) datadir, which you get when installing software below
/usr/local due to defaults.

$ rpm --eval %_datadir
/usr/share
$ rpm --eval %_prefix
/usr

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=mrZ8DokplSa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885038

--- Comment #9 from Antonio Trande trp...@katamail.com ---
(In reply to comment #8)
 /usr/local/share/games is not different, because /usr/local/share is just
 the local (site-specific) datadir, which you get when installing software
 below /usr/local due to defaults.
 
 $ rpm --eval %_datadir
 /usr/share
 $ rpm --eval %_prefix
 /usr

Yes, this is what I mean. :)

Now, I don't know if another easiest way exists, I would change .spec file so:

...

%install
make install DESTDIR=%{buildroot}

# Make the correct binaries and data file paths according to the packaging
guidelines for games
mkdir -p %{buildroot}%{_bindir}
cp -p %{buildroot}%{_prefix}/games/%{name} %{buildroot}%{_bindir}/%{name}
cp -p %{buildroot}%{_prefix}/games/%{name}-thumbnailer
%{buildroot}%{_bindir}/%{name}-thumbnailer
rm%{buildroot}%{_prefix}/games/%{name}*

mkdir -p %{buildroot}%{_datadir}/%{name}
cp -r -p %{buildroot}%{_datadir}/games/%{name}/*
%{buildroot}%{_datadir}/%{name}
rm -rf   %{buildroot}%{_datadir}/games/%{name}

#check desktop file
desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop

%post
/usr/bin/update-mime-database %{_datadir}/mime  /dev/null || :
/bin/touch --no-create %{_datadir}/icons/hicolor /dev/null || :

%postun
/usr/bin/update-mime-database %{_datadir}/mime  /dev/null || :
if [ $1 -eq 0 ] ; then
/bin/touch --no-create %{_datadir}/icons/hicolor /dev/null
/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor /dev/null || :
fi

%posttrans
/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor /dev/null || :

 $ rpm -qf /usr/share/thumbnailers
 file /usr/share/thumbnailers is not owned by any package
 
 https://fedoraproject.org/wiki/Packaging:UnownedDirectories


%files
%doc COPYING NEWS README
%{_bindir}/%{name}
%{_bindir}/%{name}-thumbnailer
%{_datadir}/applications/%{name}.desktop
%{_datadir}/icons/hicolor/16x16/apps/%{name}.png
%{_datadir}/icons/hicolor/16x16/mimetypes/application-x-blokus-sgf.png
%{_datadir}/icons/hicolor/32x32/apps/%{name}.png
%{_datadir}/icons/hicolor/48x48/apps/%{name}.png
%{_datadir}/icons/hicolor/48x48/mimetypes/application-x-blokus-sgf.png
%{_datadir}/icons/hicolor/scalable/apps/%{name}.svg
%{_datadir}/icons/hicolor/scalable/mimetypes/application-x-blokus-sgf.svg
%{_datadir}/mime/packages/%{name}-mime.xml

%dir %{_datadir}/thumbnailers
%{_datadir}/thumbnailers/%{name}.thumbnailer

%dir %{_datadir}/%{name}
%{_datadir}/%{name}/books/
%{_datadir}/%{name}/translations/

%lang(de) %{_datadir}/%{name}/manual/de/
%lang(en) %{_datadir}/%{name}/manual/en/
%lang(en_CA) %{_datadir}/%{name}/manual/en_CA/
%lang(en_GB) %{_datadir}/%{name}/manual/en_GB/

%{_mandir}/man6/%{name}-thumbnailer.6.*
%{_mandir}/man6/%{name}.6.*


$ rpm -qf /usr/share/thumbnailers
thunar-vfs-1.2.0-7.fc18.x86_64
pentobi-5.0-2.fc18.x86_64

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ObFf9fJ80za=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885038

--- Comment #10 from Michael Schwendt mschwe...@gmail.com ---
Simply moving the files in %install will break, because some of the paths get
built/compiled into the program. For example:

  $ grep PENTOBI_ pentobi-5.0/src/* -R|grep DIR
  pentobi-5.0/src/pentobi/Main.cpp:#ifdef PENTOBI_MANUAL_DIR
  pentobi-5.0/src/pentobi/Main.cpp:manualDir = PENTOBI_MANUAL_DIR;
  pentobi-5.0/src/pentobi/Main.cpp:#ifdef PENTOBI_BOOKS_DIR
  pentobi-5.0/src/pentobi/Main.cpp:booksDir = PENTOBI_BOOKS_DIR;

For some of those paths, it should be enough to define several of the CMake
variables to use non-default dirs at build-time already. From CMakeLists.txt:

if(NOT DEFINED PENTOBI_BOOKS_DIR)
  if(UNIX AND NOT APPLE)
set(PENTOBI_BOOKS_DIR
  ${CMAKE_INSTALL_PREFIX}/share/games/pentobi/books)
  endif()
endif()
if(NOT DEFINED PENTOBI_MANUAL_DIR)
  if(UNIX AND NOT APPLE)
set(PENTOBI_MANUAL_DIR
  ${CMAKE_INSTALL_PREFIX}/share/games/pentobi/manual)
  endif()
endif()
if(NOT DEFINED PENTOBI_TRANSLATIONS)
  if(UNIX AND NOT APPLE)
set(PENTOBI_TRANSLATIONS
  ${CMAKE_INSTALL_PREFIX}/share/games/pentobi/translations)
  endif()
endif()

For installation of the executables (also the thumbnailer), it looks different.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=OBjNi6hlcna=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885038

--- Comment #11 from Antonio Trande trp...@katamail.com ---
To put an end to the matter, it seems me that it needs a patch at the root
cause (CMakeLists.txt).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=LxdYF1HStfa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885038

--- Comment #12 from Michael Schwendt mschwe...@gmail.com ---
Which is what I've just tried, because I was curious to figure out how much
effort would be needed to adhere to the Games SIG's packaging guidelines.

I had started with adding

-DPENTOBI_BOOKS_DIR=%{_datadir}/%{name}/books \
-DPENTOBI_MANUAL_DIR=%{_datadir}/%{name}/manual \
-DPENTOBI_TRANSLATIONS=%{_datadir}/%{name}/translations \

to the cmake invocation in the spec file. Then I built locally with rpmbuild
-bi pentobi.spec to check what of the %files section would need to be
adjusted.
For subsequent tests I've modified the files directly in the builddir and ran
rpm --short-circuit -bi pentobi.spec to reinstall without recompiling. I've
had to modify these

  ./src/books/CMakeLists.txt
  ./src/pentobi/CMakeLists.txt
  ./src/pentobi_thumbnailer/CMakeLists.txt
  ./src/libpentobi_gui/CMakeLists.txt

in trivial ways in their install … lines, since they contain hardcoded paths
and don't use the PENTOBI_* variables defined above. One also cannot install
into /usr/bin instead of /usr/games without patching out a hardcoded games
destination value. Finally, I had to modify the spec to use

-DPENTOBI_MANUAL_DIR=%{_datadir}/%{name}/ \

instead, because the cmake files install a full directory manual into that
directory and ended up with a double manual/manual/.

Shipping a patch upstream for the four CMakeLists.txt files is a package
maintenance task that will need to be handled.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=HIKoBg8AAra=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885038

--- Comment #4 from Michael Schwendt mschwe...@gmail.com ---
 Note: Cannot find license.html in rpm(s)

That could be a bug in fedora-review, because the file _is_ included, and the
package also includes a COPYING as %doc.

fedora-review is not 100% safe. It certainly doesn't know all of the packaging
guidelines to tell whether a package meets them or not. I wouldn't trust it too
much, but suggest using it only to see where it complains and then double-check
those items.


 [!]: Macros in Summary, %description expandable at SRPM build time.
 
 You can use: %{name} is a computer program to play the board game Blokus

If fedora-review flagged that as '[!]', that's strange. The guidelines say:
https://fedoraproject.org/wiki/Packaging:Guidelines#Source_RPM_Buildtime_Macros

But this package doesn't use any macros in %summary or %description, so I don't
understand what should be wrong here.

Btw, on the web page the game is named Pentobi with an upper-case first
character. The package is named pentobi, because more often than not we write
everything in lower-case. If %name were used here, the %description would start
the sentence with a lower-case character, which would look unusual.

The Naming Guidelines _try_ to explain when it may make sense to use a specific
case in the package name,

  https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Case_Sensitivity

but I think there are only very few examples where developers have tried to
influence the naming of RPM packages actually.

Conclusively, Name: pentobi is fine, and not using %{name} in the summary or
description is fine, too.


 [x]: Package uses nothing in %doc for runtime.

This isn't trivial to check. And it's hard to tell how many packagers/reviewers
examine it at all. For this package, it would be sufficient to check whether it
wants to display the manual (not in a docdir, however) or the three %doc files
via its Help menu. = It doesn't seem to do that.


 BuildRequires and Requires entries should be listed one-by-one.

Packager is free to disagree, however. ;-)


 [-]: %check is present and all tests pass.

Remains to be examined. Are the unit tests suitable for %check section?


[...]


A few findings:

 Requires: boost,qt

https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires


 %{_prefix}/games/pentobi
 %dir %{_datadir}/games/%{name}

http://fedoraproject.org/wiki/SIGs/Games
http://fedoraproject.org/wiki/SIGs/Games/Packaging

| Data files (maps, pixmaps, sounds) go in  %{_datadir}/%{name} ,
| not %{_datadir}/games/%{name} . Binaries go in  %{_bindir} and
| not /usr/games. According to the FHS, the use of /usr/share/games
| and /usr/games is optional, and we recommend not using either for
| consistency, so that games are packaged like all other applications. 


 %{_datadir}/mime/packages/pentobi-mime.xml

https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo

 %{_datadir}/icons/hicolor/16x16/apps/pentobi.png

https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

 %{_datadir}/thumbnailers/pentobi.thumbnailer

$ rpm -qf /usr/share/thumbnailers
file /usr/share/thumbnailers is not owned by any package

https://fedoraproject.org/wiki/Packaging:UnownedDirectories

$ repoquery --whatprovides /usr/share/thumbnailers
thunar-vfs-0:1.2.0-7.fc18.x86_64
thunar-vfs-0:1.2.0-7.fc18.i686
ffmpegthumbnailer-0:2.0.8-2.fc18.x86_64
whaawmp-0:0.2.14-4.fc18.noarch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=OU4letEJDNa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885038

--- Comment #5 from Antonio Trande trp...@katamail.com ---
(In reply to comment #4)
  Note: Cannot find license.html in rpm(s)
 
 That could be a bug in fedora-review, because the file _is_ included, and
 the package also includes a COPYING as %doc.
 
 fedora-review is not 100% safe. It certainly doesn't know all of the
 packaging guidelines to tell whether a package meets them or not. I wouldn't
 trust it too much, but suggest using it only to see where it complains and
 then double-check those items.
 
 
  [!]: Macros in Summary, %description expandable at SRPM build time.
  
  You can use: %{name} is a computer program to play the board game Blokus
 
 If fedora-review flagged that as '[!]', that's strange. The guidelines say:
 https://fedoraproject.org/wiki/Packaging:
 Guidelines#Source_RPM_Buildtime_Macros
 
 But this package doesn't use any macros in %summary or %description, so I
 don't understand what should be wrong here.
 
 Btw, on the web page the game is named Pentobi with an upper-case first
 character. The package is named pentobi, because more often than not we
 write everything in lower-case. If %name were used here, the %description
 would start the sentence with a lower-case character, which would look
 unusual.
 
 The Naming Guidelines _try_ to explain when it may make sense to use a
 specific case in the package name,
 
   https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Case_Sensitivity
 
 but I think there are only very few examples where developers have tried to
 influence the naming of RPM packages actually.
 
 Conclusively, Name: pentobi is fine, and not using %{name} in the summary
 or description is fine, too.
 
 
  [x]: Package uses nothing in %doc for runtime.
 
 This isn't trivial to check. And it's hard to tell how many
 packagers/reviewers examine it at all. For this package, it would be
 sufficient to check whether it wants to display the manual (not in a docdir,
 however) or the three %doc files via its Help menu. = It doesn't seem to
 do that.
 
 
  BuildRequires and Requires entries should be listed one-by-one.
 
 Packager is free to disagree, however. ;-)
 
 
  [-]: %check is present and all tests pass.
 
 Remains to be examined. Are the unit tests suitable for %check section?
 
 
 [...]
 
 
 A few findings:
 
  Requires:   boost,qt
 
 https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires
 
 
  %{_prefix}/games/pentobi
  %dir %{_datadir}/games/%{name}
 
 http://fedoraproject.org/wiki/SIGs/Games
 http://fedoraproject.org/wiki/SIGs/Games/Packaging
 
 | Data files (maps, pixmaps, sounds) go in  %{_datadir}/%{name} ,
 | not %{_datadir}/games/%{name} . Binaries go in  %{_bindir} and
 | not /usr/games. According to the FHS, the use of /usr/share/games
 | and /usr/games is optional, and we recommend not using either for
 | consistency, so that games are packaged like all other applications. 
 
 

Hi Michael. Thank you for your helping me.

Really I noted these points but I'm confuse, because by compiling this software
manually, its binaries are located precisely in those paths. 

  %{_datadir}/mime/packages/pentobi-mime.xml
 
 https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo
 
  %{_datadir}/icons/hicolor/16x16/apps/pentobi.png
 
 https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
 
  %{_datadir}/thumbnailers/pentobi.thumbnailer
 
 $ rpm -qf /usr/share/thumbnailers
 file /usr/share/thumbnailers is not owned by any package
 
 https://fedoraproject.org/wiki/Packaging:UnownedDirectories
 
 $ repoquery --whatprovides /usr/share/thumbnailers
 thunar-vfs-0:1.2.0-7.fc18.x86_64
 thunar-vfs-0:1.2.0-7.fc18.i686
 ffmpegthumbnailer-0:2.0.8-2.fc18.x86_64
 whaawmp-0:0.2.14-4.fc18.noarch

mmh... I have not seen a lot things.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=XTPet3dj3Pa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885038

Antonio Trande trp...@katamail.com changed:

   What|Removed |Added

 CC||trp...@katamail.com

--- Comment #3 from Antonio Trande trp...@katamail.com ---
Hi Christophe.

I'm not an official packager. Following is an 'unofficial package review' that
is not valid and could contain some (my) errors.

 Package Review
==

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed


Issues:
===
[!]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
 Note: Cannot find license.html in rpm(s)
See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

See below.

= MUST items =

C/C++:
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[-]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm  4.4
[!]: Macros in Summary, %description expandable at SRPM build time.

You can use: %{name} is a computer program to play the board game Blokus

[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install if there is
 such a file.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
 Note: Cannot find license.html in rpm(s)
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 Unknown or generated. 1 files have unknown license. Detailed output of
 licensecheck in /home/sagitter/885038-pentobi/licensecheck.txt

The license should be GPLv3+ (GPLv3 or later)
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#.22or_later_version.22_licenses

[!]: Package consistently uses macro is (instead of hard-coded directory
 names).

You can use %{name} in place of 'pentobi' in spec file. For example:

%{_datadir}/icons/hicolor/16x16/apps/%{name}.png instead of 
%{_datadir}/icons/hicolor/16x16/apps/pentobi.png

and so on.

[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
 Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[-]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file is legible and written in American English.

BuildRequires and Requires entries should be listed one-by-one.

BuildRequires:boost-devel
BuildRequires:  qt-devel
BuildRequires:  cmake
BuildRequires:  desktop-file-utils


[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[-]: Package 

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885038

--- Comment #1 from Christophe Burgun jo...@fedoraproject.org ---
Updating spec file with new pentobi version

Spec URL: http://jouty.fedorapeople.org/pentobi.spec
SRPM URL: http://jouty.fedorapeople.org/pentobi-5.0-1.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=fTuCvfzXb4a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885038

--- Comment #2 from Christophe Burgun jo...@fedoraproject.org ---
Add requires and some other changes (changelog)

Spec URL: http://jouty.fedorapeople.org/pentobi.spec
SRPM URL: http://jouty.fedorapeople.org/pentobi-5.0-2.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=7Vd3S4O8s4a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885038

Christophe Burgun jo...@fedoraproject.org changed:

   What|Removed |Added

 CC||pin...@pingoured.fr
 Blocks||177841 (FE-NEEDSPONSOR)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=8Ys93jpJ2ja=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review