[Bug 895077] Review Request: python-docopt - Pythonic argument parser, that will make you smile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=895077

Athos Ribeiro  changed:

   What|Removed |Added

 CC||david.hanneq...@gmail.com



--- Comment #13 from Athos Ribeiro  ---
*** Bug 1384589 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 895077] Review Request: python-docopt - Pythonic argument parser, that will make you smile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=895077

Martin Sivák msi...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #11 from Martin Sivák msi...@redhat.com ---
Package Change Request
==
Package Name: python-docopt
New Branches: el6
Owners: msivak miminar
InitialCC: 

There is a request for docopt on CentOS 6 -
https://bugzilla.redhat.com/show_bug.cgi?id=1194598

I think it is not a bad idea.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 895077] Review Request: python-docopt - Pythonic argument parser, that will make you smile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=895077

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 895077] Review Request: python-docopt - Pythonic argument parser, that will make you smile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=895077



--- Comment #12 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 895077] Review Request: python-docopt - Pythonic argument parser, that will make you smile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=895077

Michal Minar mimi...@redhat.com changed:

   What|Removed |Added

 CC||mimi...@redhat.com



--- Comment #8 from Michal Minar mimi...@redhat.com ---
Package Change Request
==
Package Name: python-docopt
New Branches: el7
Owners: msivak miminar
InitialCC: 

python-docopt is being currently used in openlmi side project, which will later
probably go to rhel7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=i3AKHl18m7a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 895077] Review Request: python-docopt - Pythonic argument parser, that will make you smile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=895077

Michal Minar mimi...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-cvs+ |fedora-cvs?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=cStw5l4LQFa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 895077] Review Request: python-docopt - Pythonic argument parser, that will make you smile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=895077

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 CC||cicku...@gmail.com



--- Comment #9 from Christopher Meng cicku...@gmail.com ---
el7?

No such branch currently?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Wc3LI0SpE6a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 895077] Review Request: python-docopt - Pythonic argument parser, that will make you smile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=895077



--- Comment #10 from Jon Ciesla limburg...@gmail.com ---
No such branch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=9Jxkm4YLGxa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 895077] Review Request: python-docopt - Pythonic argument parser, that will make you smile

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=895077

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=axMv9jWs5Na=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 895077] Review Request: python-docopt - Pythonic argument parser, that will make you smile

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=895077

Bohuslav Slavek Kabrda bkab...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2013-03-13 02:58:18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=goVQuNOaqwa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 895077] Review Request: python-docopt - Pythonic argument parser, that will make you smile

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=895077

Martin Sivák msi...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #6 from Martin Sivák msi...@redhat.com ---
New Package SCM Request
===
Package Name: python-docopt
Short Description: Pythonic argument parser that uses the help message to
generate the parsing rules.
Owners: msivak
Branches: f17 f18
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=8mXAiuPPIha=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 895077] Review Request: python-docopt - Pythonic argument parser, that will make you smile

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=895077

--- Comment #7 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=NoFnhqEMv5a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 895077] Review Request: python-docopt - Pythonic argument parser, that will make you smile

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=895077

Martin Sivák msi...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=XJjjHlVnhVa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 895077] Review Request: python-docopt - Pythonic argument parser, that will make you smile

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=895077

Bohuslav Slavek Kabrda bkab...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||bkab...@redhat.com
   Assignee|nob...@fedoraproject.org|bkab...@redhat.com

--- Comment #1 from Bohuslav Slavek Kabrda bkab...@redhat.com ---
I'll take this for a review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=0oQvMqO82ya=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 895077] Review Request: python-docopt - Pythonic argument parser, that will make you smile

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=895077

--- Comment #2 from Bohuslav Slavek Kabrda bkab...@redhat.com ---
- python-setuptools-devel is no longer used, you should use just
python-setuptools.
- If you want the packages to go just to Fedora, you can remove the macro
definitions from the beginning, they are already defined in macrofiles.
- The line with rm -rf ${buildroot}%{python_sitelib}/setuptools/tests seems
to be useless (at least in mock build, so it should be removed).
Otherwise the package seems to be ok, so once you fix these minorities, I'll
approve.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=7uLAysBDaYa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 895077] Review Request: python-docopt - Pythonic argument parser, that will make you smile

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=895077

--- Comment #3 from Martin Sivák msi...@redhat.com ---
I updated the spec file according to the comment and reuploaded the files to
the same urls.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=A3OyVc7Gw6a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 895077] Review Request: python-docopt - Pythonic argument parser, that will make you smile

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=895077

Fabian Affolter m...@fabian-affolter.ch changed:

   What|Removed |Added

 CC||m...@fabian-affolter.ch

--- Comment #4 from Fabian Affolter m...@fabian-affolter.ch ---
Just some quick comments:

- %dos are missing (e.g. LICENSE-MIT, README.md)
- The %description and the %summary needs some tweaking. At the moment both are
not very useful.
- There is no *.egg-info file in the upstream tarball. I would suggest to leave
it in place. You never know what will happen in the future.
- There is an folder with examples. Perhaps it's worth to pack those files.

The 'review' flag should be set by the reviewer and not the reporter.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=nuhReVk496a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 895077] Review Request: python-docopt - Pythonic argument parser, that will make you smile

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=895077

Bohuslav Slavek Kabrda bkab...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #5 from Bohuslav Slavek Kabrda bkab...@redhat.com ---
(In reply to comment #4)
 Just some quick comments:
 
 - %dos are missing (e.g. LICENSE-MIT, README.md)

They aren't in the upstream tarball, in which case the guidelines don't mandate
them to be present. [1] says  If (and only if) the source package includes the
text of the license(s) in its own file, then that file, containing the text of
the license(s) for the package must be included in %doc.

 - The %description and the %summary needs some tweaking. At the moment both
 are not very useful.

I disagree, from my point of view it says enough. Anyway, this is not a blocker
for me, so I'll leave it up to Martin's best judgement whether he'll change
this or not before importing to dist-git.

 - There is no *.egg-info file in the upstream tarball. I would suggest to
 leave it in place. You never know what will happen in the future.

There is a docopt.egg-info directory and I agree that it should be removed and
regenerated during build. I consider this to be a good practice, that makes
sure everything that can be regenerated is regenerated.

 - There is an folder with examples. Perhaps it's worth to pack those files.

If it was in the upstream tarball, I'd concur. This way, I'd maybe just
encourage upstream to include it (and also include the license text), but this
is not mandatory.

 
 The 'review' flag should be set by the reviewer and not the reporter.

True :) And thanks for your comments!


Martin, please next time when doing changes during review, bump the release and
add a proper changelog entry.


Since I see no blockers, this package is APPROVED. Martin, please consider
improving the summary and description before importing to dist-git and
encouraging upstream to include license text and examples in the next tarball.

[1]
https://fedoraproject.org/wiki/Packaging:ReviewGuidelines?rd=Packaging/ReviewGuidelines#Things_To_Check_On_Review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=sOVNvioQEea=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review