[Bug 918801] Review Request: schroedinger-cat-backgrounds - Schrödinger's Cat desktop backgrounds
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=918801 Martin Sourada martin.sour...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2013-03-13 06:01:27 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4xG8HP89NHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 918801] Review Request: schroedinger-cat-backgrounds - Schrödinger's Cat desktop backgrounds
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=918801 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iuczNVC6u9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 918801] Review Request: schroedinger-cat-backgrounds - Schrödinger's Cat desktop backgrounds
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=918801 Luya Tshimbalanga l...@fedoraproject.org changed: What|Removed |Added CC||l...@fedoraproject.org Assignee|nob...@fedoraproject.org|l...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=btUJsO1OGMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 918801] Review Request: schroedinger-cat-backgrounds - Schrödinger's Cat desktop backgrounds
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=918801 Luya Tshimbalanga l...@fedoraproject.org changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=htNaxZ90KDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 918801] Review Request: schroedinger-cat-backgrounds - Schrödinger's Cat desktop backgrounds
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=918801
--- Comment #1 from Luya Tshimbalanga l...@fedoraproject.org ---
Here is the generated package review:
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
schroedinger-cat-backgrounds-base , schroedinger-cat-backgrounds-animated
, schroedinger-cat-backgrounds-kde , schroedinger-cat-backgrounds-gnome ,
schroedinger-cat-backgrounds-mate , schroedinger-cat-backgrounds-xfce
[x] Package complies to the Packaging Guidelines
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 30720 bytes in 2 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.
= EXTRA items =
Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
[x]: Rpmlint is run on all installed
[Bug 918801] Review Request: schroedinger-cat-backgrounds - Schrödinger's Cat desktop backgrounds
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=918801 --- Comment #2 from Martin Sourada martin.sour...@gmail.com --- (In reply to comment #1) Could you fix the URL and spelling error (en)US) as displayed by rpmlint? Schrödinger's - Schrodinger's, Schlesinger's, Schwinger's AFAIK, false positive. Fedora 19 official release name is Schrödinger's Cat, which is also the correct name (the physicist was called Schrödinger, Schrodinger and Schroedinger are simplifications to avoid having to type ö with the first one just dropping the accent, the second one being, IMHO, generally accepted transliteration). http://fedoraproject.org/wiki/History_of_Fedora_release_names#Fedora_19_.28Schr.C3.B6dinger.27s_Cat.29 schroedinger-cat-backgrounds.noarch: W: invalid-url URL: https://fedoraproject.org/wiki/F19_Artwork HTTP Error 404: Not Found This was fixed between the time you run the test suite and posted the result. https://fedoraproject.org/wiki/F19_Artwork Thanks for taking up the review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6JOxLbhUGza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 918801] Review Request: schroedinger-cat-backgrounds - Schrödinger's Cat desktop backgrounds
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=918801 Luya Tshimbalanga l...@fedoraproject.org changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CRpbI3twtAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 918801] Review Request: schroedinger-cat-backgrounds - Schrödinger's Cat desktop backgrounds
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=918801 Luya Tshimbalanga l...@fedoraproject.org changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #3 from Luya Tshimbalanga l...@fedoraproject.org --- No problem. No documentation part from rpmlint can be ignored because the packages are backgrounds set. Consider this review successfully passed. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wazwdCuBfVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 918801] Review Request: schroedinger-cat-backgrounds - Schrödinger's Cat desktop backgrounds
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=918801 Martin Sourada martin.sour...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Martin Sourada martin.sour...@gmail.com --- New Package SCM Request === Package Name: schroedinger-cat-backgrounds Short Description: Schrödinger's Cat desktop backgrounds Owners: mso Branches: InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8pEqBYPsvza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
