[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #34 from Fedora Update System upda...@fedoraproject.org --- metis-5.1.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/metis-5.1.0-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SXpa5KAZd3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #35 from Fedora Update System upda...@fedoraproject.org --- metis-5.1.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/metis-5.1.0-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L1AeK3ehf2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #36 from Fedora Update System upda...@fedoraproject.org --- metis-5.1.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/metis-5.1.0-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RmHUXSmcyxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Resolution|NEXTRELEASE |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=08Zk54GpfXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #32 from Fedora Update System upda...@fedoraproject.org --- metis-5.0.3-10.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rYo6Vo2VhVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #33 from Fedora Update System upda...@fedoraproject.org --- metis-5.0.3-10.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8DJVZlaeFSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #29 from Fedora Update System upda...@fedoraproject.org --- metis-5.0.3-10.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/metis-5.0.3-10.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JrGl9B1DZ4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #31 from Fedora Update System upda...@fedoraproject.org --- metis-5.0.3-10.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/metis-5.0.3-10.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=r8v6TNkqxLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #30 from Fedora Update System upda...@fedoraproject.org --- metis-5.0.3-10.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/metis-5.0.3-10.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DWWfifUrQPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 Antonio Trande anto.tra...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2013-03-24 18:40:29 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XDI0wbKniSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #26 from Fedora Update System upda...@fedoraproject.org --- metis-5.0.3-9.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/metis-5.0.3-9.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OxxTNajzlja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #27 from Fedora Update System upda...@fedoraproject.org --- metis-5.0.3-9.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/metis-5.0.3-9.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fytzmmJoyqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #28 from Fedora Update System upda...@fedoraproject.org --- metis-5.0.3-9.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/metis-5.0.3-9.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1usrrOyhRaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #25 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TVpxb8zBpea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #14 from Antonio Trande anto.tra...@gmail.com --- (In reply to comment #13) Appears good looking in the spec, but when trying fedora-review, it fails in %check because the binaries are not in $PATH: + cd /builddir/build/BUILD ~/build/BUILD/metis-5.0.3/graphs ~/build/BUILD/metis-5.0.3 + cd metis-5.0.3 + pushd graphs + ndmetis mdual.graph /var/tmp/rpm-tmp.lerKCw: line 30: ndmetis: command not found Not for me.(In reply to comment #13) Appears good looking in the spec, but when trying fedora-review, it fails in %check because the binaries are not in $PATH: + cd /builddir/build/BUILD ~/build/BUILD/metis-5.0.3/graphs ~/build/BUILD/metis-5.0.3 + cd metis-5.0.3 + pushd graphs + ndmetis mdual.graph /var/tmp/rpm-tmp.lerKCw: line 30: ndmetis: command not found Not for me. I show you the build.log from my fedora-review output. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cmhC6YLTK2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #15 from Antonio Trande anto.tra...@gmail.com --- Created attachment 713341 -- https://bugzilla.redhat.com/attachment.cgi?id=713341action=edit build.log from fedora-reviw results directory -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=92QZPLltiGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #16 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Probably you have it installed in the mock chroot. Try mock --clean and run fedora-review again. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UNkaSPs33Ja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #17 from Antonio Trande anto.tra...@gmail.com --- Spec URL: http://sagitter.fedorapeople.org/metis/metis.spec SRPM URL: http://sagitter.fedorapeople.org/metis/metis-5.0.3-6.fc18.src.rpm It should be functioning. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=loqazwU5X0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=920518
--- Comment #18 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com
---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Permissions on files are set properly.
Note: See rpmlint output
See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
- Spec file lacks Packager, Vendor, PreReq tags.
Note: Found : Packager: pcpa paulo.cesar.pereira.de.andr...@gmail.com
See: (this test has no URL)
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
BSD, BSD (2 clause), LGPL (v2.1 or later) (with incorrect FSF
address), Unknown or generated. 4 files have unknown license. Detailed
output of licensecheck in /home/pcpa/920518-metis/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 419840 bytes in 4 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=920518
Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com changed:
What|Removed |Added
Flags||fedora-review?
--- Comment #19 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com
---
The permissions warning appears bogus, and should
be caused by not installing files owned by root:
$ rpm2cpio metis-5.0.3-6.fc19.x86_64.rpm |cpio -id
2077 blocks
$ ll usr/bin/ndmetis
-rwxr-xr-x 1 pcpa pcpa 40648 Mar 20 16:25 usr/bin/ndmetis
The missing manual page warning is due to explicitly
compressing them. Should not do it, just copy the
manual pages to the proper directory and let rpmbuild
compress them. Also, change this:
mkdir %{buildroot}%{_datadir}
mkdir %{buildroot}%{_mandir} ; mkdir %{buildroot}%{_mandir}/man1
into
mkdir -p %{buildroot}%{_mandir}/man1
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=uyMv65tMfYa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #20 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- It is up to you if wish to make a new package for review with the man page correction, otherwise I see no other problems, just make sure to add the correction to the final package. I consider the package APPROVED. BTW, I see you did not yet populate the MUMPS git tree: http://pkgs.fedoraproject.org/cgit/MUMPS.git/ Do you need some help with it? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=auRev1vcDba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #21 from Antonio Trande anto.tra...@gmail.com --- (In reply to comment #20) It is up to you if wish to make a new package for review with the man page correction, otherwise I see no other problems, just make sure to add the correction to the final package. I still have some doubts about license (see comment#0). I consider the package APPROVED. Okay. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wvcPV4n8nIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #22 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- You should write it as License: ASL 2.0 and BSD and LGPLv2+ I did look at gkregex GKlib headers and sources earlier in the review, and they are not built; it uses system regex (regcomp/regexec), that in Linux just happens to be updated versions of those GKlib files. It does not use random.c by default either. But, it compiles all the files, just that does not generate any code, unless some preprocessor symbol is defined, for example USE_GKREGEX to use LGPL regex. But it actually builds a few, like getopt.c, it just renames the symbols adding a gk_ prefix. It also uses glibc qsort macros to implement several specialized quick sort routines. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EAldqwNMYpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #23 from Antonio Trande anto.tra...@gmail.com --- (In reply to comment #22) You should write it as License: ASL 2.0 and BSD and LGPLv2+ Fixed. Thank you. Spec URL: http://sagitter.fedorapeople.org/metis/metis.spec SRPM URL: http://sagitter.fedorapeople.org/metis/metis-5.0.3-7.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=d4SAOoGCPva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 Antonio Trande anto.tra...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #24 from Antonio Trande anto.tra...@gmail.com --- New Package SCM Request === Package Name: metis Short Description: Serial Graph Partitioning and Fill-reducing Matrix Ordering Owners: sagitter Branches: f17 f18 f19 el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=itemEEVWXba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #12 from Antonio Trande anto.tra...@gmail.com --- Added %check section and removed GKlib installation. Spec URL: http://sagitter.fedorapeople.org/metis/metis.spec SRPM URL: http://sagitter.fedorapeople.org/metis/metis-5.0.3-5.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6V1MODxrwJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|paulo.cesar.pereira.de.andr ||a...@gmail.com --- Comment #13 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Appears good looking in the spec, but when trying fedora-review, it fails in %check because the binaries are not in $PATH: + cd /builddir/build/BUILD ~/build/BUILD/metis-5.0.3/graphs ~/build/BUILD/metis-5.0.3 + cd metis-5.0.3 + pushd graphs + ndmetis mdual.graph /var/tmp/rpm-tmp.lerKCw: line 30: ndmetis: command not found -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0xgHp9XkaTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #9 from Antonio Trande anto.tra...@gmail.com --- (In reply to comment #8) If you run make in the GKlib directory it creates test binaries: $ pwd /home/pcpa/rpmbuild/BUILD/metis-5.0.3/GKlib $ ls test/*.c test/fis.c test/gkgraph.c test/gksort.c test/rw.c test/strings.c $ ls build/test CMakeFiles cmake_install.cmake fis gkgraph gksort Makefile rw strings $ ldd build/test/fis linux-vdso.so.1 = (0x7fff907fe000) libGKlib.so.5.0.3 = /home/pcpa/rpmbuild/BUILD/metis-5.0.3/GKlib/build/libGKlib.so.5.0.3 (0x7f85e6521000) libm.so.6 = /lib64/libm.so.6 (0x0035e340) libc.so.6 = /lib64/libc.so.6 (0x0035e300) /lib64/ld-linux-x86-64.so.2 (0x0035e2c0) These binaries seem be used exclusively by upstream (as developer confirmed to me); also they could lead to false positives in future. Maybe we can ignore them. :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QEjpWv5wK9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #10 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- (In reply to comment #9) $ ldd build/test/fis linux-vdso.so.1 = (0x7fff907fe000) libGKlib.so.5.0.3 = /home/pcpa/rpmbuild/BUILD/metis-5.0.3/GKlib/build/libGKlib.so.5.0.3 (0x7f85e6521000) libm.so.6 = /lib64/libm.so.6 (0x0035e340) libc.so.6 = /lib64/libc.so.6 (0x0035e300) /lib64/ld-linux-x86-64.so.2 (0x0035e2c0) These binaries seem be used exclusively by upstream (as developer confirmed to me); also they could lead to false positives in future. This comes back to my comment in #4: ---%--- First, I have a feeling GKlib is not supposed to be installed, well, the .c files are compiled and added to libmetis.so, so anything linking to libmetis and libGKlib will fail due to duplicated symbols. And upstream may not want the header files installed to not have a compromise with an API/ABI. ---%--- Maybe we can ignore them. :) Can you confirm the GKlib headers are not supposed to be installed? Note that this still does not mean running the test binaries in %check is not required :-) They are supposed to work in the build environment, and would make it easier to validate that the package works as intended. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mtTZ43MLj5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #11 from Antonio Trande anto.tra...@gmail.com --- (In reply to comment #10) Can you confirm the GKlib headers are not supposed to be installed? Note that this still does not mean running the test binaries in %check is not required :-) Confirmed. You are right. So, if I understood fine, all gk*.h files can be not included on the package. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HOdVl4uBtHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=920518
--- Comment #7 from Antonio Trande anto.tra...@gmail.com ---
Spec URL: http://sagitter.fedorapeople.org/metis/metis.spec
SRPM URL: http://sagitter.fedorapeople.org/metis/metis-5.0.3-4.fc18.src.rpm
--
5. You should not need to install the graphs subdir to
%{_datadir}/%{name}/graphs, but instead, use them, as
they are actually example input files, in a %check
section. Also, should add GKlib/test binaries to a
%check run.
Onestly I don't see any GKlib/test binaries. :)
12. Binaries are being installed with 775 permission. Check
it, should be 755.
They seem me all with 755:
$ ll /usr/bin | grep metis
-rwxr-xr-x. 1 root root 43024 Mar 17 19:55 gpmetis
-rwxr-xr-x. 1 root root 31040 Mar 17 19:55 m2gmetis
-rwxr-xr-x. 1 root root 43152 Mar 17 19:55 mpmetis
-rwxr-xr-x. 1 root root 40624 Mar 17 19:55 ndmetis
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=ymAvwxwoeoa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=920518
--- Comment #8 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com ---
(In reply to comment #7)
Spec URL: http://sagitter.fedorapeople.org/metis/metis.spec
SRPM URL: http://sagitter.fedorapeople.org/metis/metis-5.0.3-4.fc18.src.rpm
--
5. You should not need to install the graphs subdir to
%{_datadir}/%{name}/graphs, but instead, use them, as
they are actually example input files, in a %check
section. Also, should add GKlib/test binaries to a
%check run.
Onestly I don't see any GKlib/test binaries. :)
If you run make in the GKlib directory it creates test binaries:
$ pwd
/home/pcpa/rpmbuild/BUILD/metis-5.0.3/GKlib
$ ls test/*.c
test/fis.c test/gkgraph.c test/gksort.c test/rw.c test/strings.c
$ ls build/test
CMakeFiles cmake_install.cmake fis gkgraph gksort Makefile rw strings
$ ldd build/test/fis
linux-vdso.so.1 = (0x7fff907fe000)
libGKlib.so.5.0.3 =
/home/pcpa/rpmbuild/BUILD/metis-5.0.3/GKlib/build/libGKlib.so.5.0.3
(0x7f85e6521000)
libm.so.6 = /lib64/libm.so.6 (0x0035e340)
libc.so.6 = /lib64/libc.so.6 (0x0035e300)
/lib64/ld-linux-x86-64.so.2 (0x0035e2c0)
12. Binaries are being installed with 775 permission. Check
it, should be 755.
They seem me all with 755:
$ ll /usr/bin | grep metis
-rwxr-xr-x. 1 root root 43024 Mar 17 19:55 gpmetis
-rwxr-xr-x. 1 root root 31040 Mar 17 19:55 m2gmetis
-rwxr-xr-x. 1 root root 43152 Mar 17 19:55 mpmetis
-rwxr-xr-x. 1 root root 40624 Mar 17 19:55 ndmetis
Try running fedora-review, tail of review.txt:
Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -r -v -n metis
and review.txt says:
Rpmlint (installed packages)
# rpmlint metis metis-devel
metis.x86_64: W: spelling-error %description -l en_US multi - mulch, mufti
metis.x86_64: E: non-standard-executable-perm /usr/bin/cmpfillin 0775L
metis.x86_64: E: non-standard-executable-perm /usr/bin/mpmetis 0775L
metis.x86_64: E: non-standard-executable-perm /usr/lib64/metis/libmetis.so
0775L
metis.x86_64: E: non-standard-executable-perm /usr/bin/m2gmetis 0775L
metis.x86_64: E: non-standard-executable-perm /usr/bin/ndmetis 0775L
metis.x86_64: E: non-standard-executable-perm /usr/bin/graphchk 0775L
metis.x86_64: E: non-standard-executable-perm /usr/bin/gpmetis 0775L
metis.x86_64: W: no-manual-page-for-binary cmpfillin
metis.x86_64: W: no-manual-page-for-binary gpmetis
metis.x86_64: W: no-manual-page-for-binary graphchk
metis.x86_64: W: no-manual-page-for-binary mpmetis
metis.x86_64: W: no-manual-page-for-binary ndmetis
metis.x86_64: W: no-manual-page-for-binary m2gmetis
2 packages and 0 specfiles checked; 7 errors, 7 warnings.
# echo 'rpmlint-done:'
If I recall correctly, fedora-review (or mock?) on purpose
use a non standard umask to trigger cases of builds relying
on a default umask.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=7DF3458Srpa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 Michael Schwendt mschwe...@gmail.com changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xosVwO8EVQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #5 from Antonio Trande trp...@katamail.com --- (In reply to comment #4) 7. My suggestion to invoke cmake directly was due to no other way to set some options, but you should follow the pattern in the toplevel Makefile, that has: ---%--- CONFIG_FLAGS = -DCMAKE_VERBOSE_MAKEFILE=1 ifeq ($(gklib_path), not-set) gklib_path = GKlib endif CONFIG_FLAGS += -DGKLIB_PATH=$(abspath $(gklib_path)) ifneq ($(gdb), not-set) CONFIG_FLAGS += -DGDB=$(gdb) endif ifneq ($(assert), not-set) CONFIG_FLAGS += -DASSERT=$(assert) endif ifneq ($(assert2), not-set) CONFIG_FLAGS += -DASSERT2=$(assert2) endif ifneq ($(debug), not-set) CONFIG_FLAGS += -DDEBUG=$(debug) endif ifneq ($(gprof), not-set) CONFIG_FLAGS += -DGPROF=$(gprof) endif ifneq ($(openmp), not-set) CONFIG_FLAGS += -DOPENMP=$(openmp) endif ifneq ($(prefix), not-set) CONFIG_FLAGS += -DCMAKE_INSTALL_PREFIX=$(prefix) endif ifneq ($(shared), not-set) CONFIG_FLAGS += -DSHARED=1 endif ifneq ($(cc), not-set) CONFIG_FLAGS += -DCMAKE_C_COMPILER=$(cc) endif ---%--- Actually, it may be better to add a libsuffix extra option to the Makefile instead of invoking cmake. I don't understand what you mean here. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LBTE71uxhQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #6 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- (In reply to comment #5) (In reply to comment #4) 7. My suggestion to invoke cmake directly was due to no other way to set some options, but you should follow the pattern in the toplevel Makefile, that has: ---%--- CONFIG_FLAGS = -DCMAKE_VERBOSE_MAKEFILE=1 ifeq ($(gklib_path), not-set) gklib_path = GKlib endif [...] ---%--- Actually, it may be better to add a libsuffix extra option to the Makefile instead of invoking cmake. I don't understand what you mean here. It was a suggestion to add one (or more) extra option(s) appended to CONFIG_FLAGS, because the toplevel Makefile calls cmake aready, in this chunk: mkdir -p $(BUILDDIR) cd $(BUILDDIR) cmake $(CURDIR) $(CONFIG_FLAGS) Untested patch to add to the toplevel Makefile would be: libsuffix = not-set [...] ifneq ($(cc), not-set) CONFIG_FLAGS += -DCMAKE_C_COMPILER=$(cc) endif ifneq ($(libsuffix), not-set) CONFIG_FLAGS += -DLIB_SUFFIX=$(libsuffix) endif and then invoke the toplevel Makefile with the extra option: make ... libsuffix=64 if on a 64 bit arch. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CW99q6EQaZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=920518
--- Comment #2 from Antonio Trande trp...@katamail.com ---
(In reply to comment #1)
Some comments after an initial look in the package:
--
1. You should avoid as much as possible a manual install because that
easily does not do what upstream intend or end up installing
files that should not be installed. After running make
install setting DESTDIR I see:
$ find .
.
./usr
./usr/include
./usr/include/metis.h
./usr/lib
./usr/lib/libmetis.so
./usr/bin
./usr/bin/gpmetis
./usr/bin/cmpfillin
./usr/bin/m2gmetis
./usr/bin/mpmetis
./usr/bin/ndmetis
./usr/bin/graphchk
That means at first that -DLIB_SUFFIX=64 is not being passed to
cmake, so, either should patch the Makefile that calls cmake, or,
since the cmake wrapper in the toplevel Makefile is not that
complex, call cmake explicitly, example:
mkdir build
pushd build
%cmake $CMAKE_OPTIONS ..
%make %{?_smp_mflags}
popd
Also, after running make install it is not required to mess
with rpath:
$ chrpath -l usr/bin/cmpfillin
usr/bin/cmpfillin: no rpath or runpath tag found.
Some cmake option seem not be accepted by using both %cmake macro and cmake
command.
With %cmake:
CMake Warning:
Manually-specified variables were not used by the project:
CMAKE_C_FLAGS_RELEASE
INCLUDE_INSTALL_DIR
LIB_INSTALL_DIR
LIB_SUFFIX
SHARE_INSTALL_PREFIX
SYSCONF_INSTALL_DIR
With cmake command:
CMake Warning:
Manually-specified variables were not used by the project:
CMAKE_C_FLAGS_RELEASE
LIB_SUFFIX
so libmetis.so/libGKlib.a are always located in /usr/lib.
I don't know what I must patch to fix this issue.
Following there is a temporary version of src rpm.
Spec URL: http://sagitter.fedorapeople.org/metis/metis.spec
SRPM URL: http://sagitter.fedorapeople.org/metis/metis-5.0.3-2.fc18.src.rpm
--
2. Several features appear to not be set/used. I believe another
strong reason to call cmake explicitly:
---%---
$ cmake -LA
-- The C compiler identification is GNU 4.8.0
-- The CXX compiler identification is GNU 4.8.0
-- Check for working C compiler: /usr/lib64/ccache/cc
-- Check for working C compiler: /usr/lib64/ccache/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/lib64/ccache/c++
-- Check for working CXX compiler: /usr/lib64/ccache/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Looking for execinfo.h
-- Looking for execinfo.h - found
-- Looking for getline
-- Looking for getline - found
CMake Error at CMakeLists.txt:9 (ADD_EXECUTABLE):
Cannot find source file:
GKlib/conf/check_thread_storage.c
Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp
.hxx .in .txx
CMake Error: Internal CMake error, TryCompile generation of cmake failed
-- checking for thread-local storage - not found
-- Configuring incomplete, errors occurred!
-- Cache values
ASSERT:BOOL=OFF
ASSERT2:BOOL=OFF
CMAKE_AR:FILEPATH=/usr/bin/ar
CMAKE_BUILD_TYPE:STRING=
CMAKE_COLOR_MAKEFILE:BOOL=ON
CMAKE_CXX_COMPILER:FILEPATH=/usr/lib64/ccache/c++
CMAKE_CXX_FLAGS:STRING=
CMAKE_CXX_FLAGS_DEBUG:STRING=-g
CMAKE_CXX_FLAGS_MINSIZEREL:STRING=-Os -DNDEBUG
CMAKE_CXX_FLAGS_RELEASE:STRING=-O3 -DNDEBUG
CMAKE_CXX_FLAGS_RELWITHDEBINFO:STRING=-O2 -g -DNDEBUG
CMAKE_C_COMPILER:FILEPATH=/usr/lib64/ccache/cc
CMAKE_C_FLAGS:STRING=
CMAKE_C_FLAGS_DEBUG:STRING=-g
CMAKE_C_FLAGS_MINSIZEREL:STRING=-Os -DNDEBUG
CMAKE_C_FLAGS_RELEASE:STRING=-O3 -DNDEBUG
CMAKE_C_FLAGS_RELWITHDEBINFO:STRING=-O2 -g -DNDEBUG
CMAKE_EXE_LINKER_FLAGS:STRING=
CMAKE_EXE_LINKER_FLAGS_DEBUG:STRING=
CMAKE_EXE_LINKER_FLAGS_MINSIZEREL:STRING=
CMAKE_EXE_LINKER_FLAGS_RELEASE:STRING=
CMAKE_EXE_LINKER_FLAGS_RELWITHDEBINFO:STRING=
CMAKE_EXPORT_COMPILE_COMMANDS:BOOL=OFF
CMAKE_INSTALL_PREFIX:PATH=/usr/local
CMAKE_LINKER:FILEPATH=/usr/bin/ld
CMAKE_MAKE_PROGRAM:FILEPATH=/usr/bin/gmake
CMAKE_MODULE_LINKER_FLAGS:STRING=
CMAKE_MODULE_LINKER_FLAGS_DEBUG:STRING=
CMAKE_MODULE_LINKER_FLAGS_MINSIZEREL:STRING=
CMAKE_MODULE_LINKER_FLAGS_RELEASE:STRING=
CMAKE_MODULE_LINKER_FLAGS_RELWITHDEBINFO:STRING=
CMAKE_NM:FILEPATH=/usr/bin/nm
CMAKE_OBJCOPY:FILEPATH=/usr/bin/objcopy
CMAKE_OBJDUMP:FILEPATH=/usr/bin/objdump
CMAKE_RANLIB:FILEPATH=/usr/bin/ranlib
CMAKE_SHARED_LINKER_FLAGS:STRING=
CMAKE_SHARED_LINKER_FLAGS_DEBUG:STRING=
CMAKE_SHARED_LINKER_FLAGS_MINSIZEREL:STRING=
CMAKE_SHARED_LINKER_FLAGS_RELEASE:STRING=
CMAKE_SHARED_LINKER_FLAGS_RELWITHDEBINFO:STRING=
CMAKE_SKIP_INSTALL_RPATH:BOOL=NO
CMAKE_SKIP_RPATH:BOOL=NO
CMAKE_STRIP:FILEPATH=/usr/bin/strip
CMAKE_USE_RELATIVE_PATHS:BOOL=OFF
CMAKE_VERBOSE_MAKEFILE:BOOL=FALSE
DEBUG:BOOL=OFF
GDB:BOOL=OFF
GKLIB_PATH:PATH=GKlib
GKRAND:BOOL=OFF
GKREGEX:BOOL=OFF
GPROF:BOOL=OFF
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 --- Comment #3 from Antonio Trande trp...@katamail.com --- Spec URL: http://sagitter.fedorapeople.org/metis/metis.spec SRPM URL: http://sagitter.fedorapeople.org/metis/metis-5.0.3-3.fc18.src.rpm Now the patches should be better. Static sub-package is removed. I'm working to include %check section properly. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=riEoijDieTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=920518
--- Comment #4 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com ---
Another pass on looking at the package, for a pre
review request :-)
First, I have a feeling GKlib is not supposed to be installed,
well, the .c files are compiled and added to libmetis.so, so
anything linking to libmetis and libGKlib will fail due to
duplicated symbols. And upstream may not want the header files
installed to not have a compromise with an API/ABI.
1. Use %{name}-*.patch, example pseudo patch:
-Patch0: metis-libmetis.patch
+Patch0: %{name}-libmetis.patch
Latest rawhide fedora-review does not issue an error,
but previous versions would, so should be a good
practice to do it.
2. I think using version as soname may not be
a good idea, example pseudo patch:
-set_target_properties(metis PROPERTIES SOVERSION 5.0.3)
+set_target_properties(metis PROPERTIES SOVERSION 0)
3. I think you edited metis-width-datatype.patch :-)
This looks odd:
---%---
@@ -40,7 +40,7 @@
32 : single precission floating point (float)
64 : double precission floating point (double)
--*/
-#define REALTYPEWIDTH 32
+#define REALTYPEWIDTH 32
---%---
I had suggested defining it to 64 to use a double
precision value, but that depends on if the precision
is really required, that is, usually 32 bit float is
only meant for speed with very low compromise with
precision.
4. This is working by accident because the variables
are being ignored and using CFLAGS and CXXFLAGS, but
you should quote %{optflags} in the spec if using it:
-DCMAKE_CXX_FLAGS=%{optflags} -DCMAKE_C_FLAGS_RELEASE=%{optflags} \
5. There is a missing Requires in the -devel package,
should have:
Requires:%{name}%{?_isa} = %{version}-%{release}
6. Should not use x86_64 to detect 64 bit, instead use,
something like the pseudo patch:
-%ifarch x86_64
+if [ %{__isa_bits} = 64 ]; then
+%patch2 -p1
+fi
-%endif
7. My suggestion to invoke cmake directly was due
to no other way to set some options, but you should
follow the pattern in the toplevel Makefile, that has:
---%---
CONFIG_FLAGS = -DCMAKE_VERBOSE_MAKEFILE=1
ifeq ($(gklib_path), not-set)
gklib_path = GKlib
endif
CONFIG_FLAGS += -DGKLIB_PATH=$(abspath $(gklib_path))
ifneq ($(gdb), not-set)
CONFIG_FLAGS += -DGDB=$(gdb)
endif
ifneq ($(assert), not-set)
CONFIG_FLAGS += -DASSERT=$(assert)
endif
ifneq ($(assert2), not-set)
CONFIG_FLAGS += -DASSERT2=$(assert2)
endif
ifneq ($(debug), not-set)
CONFIG_FLAGS += -DDEBUG=$(debug)
endif
ifneq ($(gprof), not-set)
CONFIG_FLAGS += -DGPROF=$(gprof)
endif
ifneq ($(openmp), not-set)
CONFIG_FLAGS += -DOPENMP=$(openmp)
endif
ifneq ($(prefix), not-set)
CONFIG_FLAGS += -DCMAKE_INSTALL_PREFIX=$(prefix)
endif
ifneq ($(shared), not-set)
CONFIG_FLAGS += -DSHARED=1
endif
ifneq ($(cc), not-set)
CONFIG_FLAGS += -DCMAKE_C_COMPILER=$(cc)
endif
---%---
Actually, it may be better to add a libsuffix extra
option to the Makefile instead of invoking cmake.
8. There is a missing/wrong check for openmp. It does
not find an FindOpenMP cmake config file. Probably
it is searching for this:
http://www.openmesh.org/svnrepo/OpenMesh/trunk/cmake/FindOpenMP.cmake
So, you may want to experiment with defining OPENMP and/or __OPENMP__
and having -fopenmp in CFLAGS and CXXFLAGS.
9. PCRE is also being disabled by default. Should at
least investigate it.
10. Instead of moving files after install of GKlib you may
want to experiment with patching GKlib/CMakeLists.txt, untested:
-install(FILES ${GKlib_includes} DESTINATION include)
-install(FILES ${GKlib_includes} DESTINATION include/metis)
11. I suggest adding -pthread to CFLAGS and CXXFLAGS, but
when adding a %check section any issues should be made
visible. This is because of the weird message when running
the test for __thread, but GKlib sources declare __thread
variables.
12. Binaries are being installed with 775 permission. Check
it, should be 755.
13. Consider running help2man or manually generating manpages
for the installed binaries.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=odqnOKHGj0a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=920518
Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com changed:
What|Removed |Added
CC||paulo.cesar.pereira.de.andr
||a...@gmail.com
--- Comment #1 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com ---
Some comments after an initial look in the package:
--
1. You should avoid as much as possible a manual install because that
easily does not do what upstream intend or end up installing
files that should not be installed. After running make
install setting DESTDIR I see:
$ find .
.
./usr
./usr/include
./usr/include/metis.h
./usr/lib
./usr/lib/libmetis.so
./usr/bin
./usr/bin/gpmetis
./usr/bin/cmpfillin
./usr/bin/m2gmetis
./usr/bin/mpmetis
./usr/bin/ndmetis
./usr/bin/graphchk
That means at first that -DLIB_SUFFIX=64 is not being passed to
cmake, so, either should patch the Makefile that calls cmake, or,
since the cmake wrapper in the toplevel Makefile is not that
complex, call cmake explicitly, example:
mkdir build
pushd build
%cmake $CMAKE_OPTIONS ..
%make %{?_smp_mflags}
popd
Also, after running make install it is not required to mess
with rpath:
$ chrpath -l usr/bin/cmpfillin
usr/bin/cmpfillin: no rpath or runpath tag found.
--
2. Several features appear to not be set/used. I believe another
strong reason to call cmake explicitly:
---%---
$ cmake -LA
-- The C compiler identification is GNU 4.8.0
-- The CXX compiler identification is GNU 4.8.0
-- Check for working C compiler: /usr/lib64/ccache/cc
-- Check for working C compiler: /usr/lib64/ccache/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/lib64/ccache/c++
-- Check for working CXX compiler: /usr/lib64/ccache/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Looking for execinfo.h
-- Looking for execinfo.h - found
-- Looking for getline
-- Looking for getline - found
CMake Error at CMakeLists.txt:9 (ADD_EXECUTABLE):
Cannot find source file:
GKlib/conf/check_thread_storage.c
Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp
.hxx .in .txx
CMake Error: Internal CMake error, TryCompile generation of cmake failed
-- checking for thread-local storage - not found
-- Configuring incomplete, errors occurred!
-- Cache values
ASSERT:BOOL=OFF
ASSERT2:BOOL=OFF
CMAKE_AR:FILEPATH=/usr/bin/ar
CMAKE_BUILD_TYPE:STRING=
CMAKE_COLOR_MAKEFILE:BOOL=ON
CMAKE_CXX_COMPILER:FILEPATH=/usr/lib64/ccache/c++
CMAKE_CXX_FLAGS:STRING=
CMAKE_CXX_FLAGS_DEBUG:STRING=-g
CMAKE_CXX_FLAGS_MINSIZEREL:STRING=-Os -DNDEBUG
CMAKE_CXX_FLAGS_RELEASE:STRING=-O3 -DNDEBUG
CMAKE_CXX_FLAGS_RELWITHDEBINFO:STRING=-O2 -g -DNDEBUG
CMAKE_C_COMPILER:FILEPATH=/usr/lib64/ccache/cc
CMAKE_C_FLAGS:STRING=
CMAKE_C_FLAGS_DEBUG:STRING=-g
CMAKE_C_FLAGS_MINSIZEREL:STRING=-Os -DNDEBUG
CMAKE_C_FLAGS_RELEASE:STRING=-O3 -DNDEBUG
CMAKE_C_FLAGS_RELWITHDEBINFO:STRING=-O2 -g -DNDEBUG
CMAKE_EXE_LINKER_FLAGS:STRING=
CMAKE_EXE_LINKER_FLAGS_DEBUG:STRING=
CMAKE_EXE_LINKER_FLAGS_MINSIZEREL:STRING=
CMAKE_EXE_LINKER_FLAGS_RELEASE:STRING=
CMAKE_EXE_LINKER_FLAGS_RELWITHDEBINFO:STRING=
CMAKE_EXPORT_COMPILE_COMMANDS:BOOL=OFF
CMAKE_INSTALL_PREFIX:PATH=/usr/local
CMAKE_LINKER:FILEPATH=/usr/bin/ld
CMAKE_MAKE_PROGRAM:FILEPATH=/usr/bin/gmake
CMAKE_MODULE_LINKER_FLAGS:STRING=
CMAKE_MODULE_LINKER_FLAGS_DEBUG:STRING=
CMAKE_MODULE_LINKER_FLAGS_MINSIZEREL:STRING=
CMAKE_MODULE_LINKER_FLAGS_RELEASE:STRING=
CMAKE_MODULE_LINKER_FLAGS_RELWITHDEBINFO:STRING=
CMAKE_NM:FILEPATH=/usr/bin/nm
CMAKE_OBJCOPY:FILEPATH=/usr/bin/objcopy
CMAKE_OBJDUMP:FILEPATH=/usr/bin/objdump
CMAKE_RANLIB:FILEPATH=/usr/bin/ranlib
CMAKE_SHARED_LINKER_FLAGS:STRING=
CMAKE_SHARED_LINKER_FLAGS_DEBUG:STRING=
CMAKE_SHARED_LINKER_FLAGS_MINSIZEREL:STRING=
CMAKE_SHARED_LINKER_FLAGS_RELEASE:STRING=
CMAKE_SHARED_LINKER_FLAGS_RELWITHDEBINFO:STRING=
CMAKE_SKIP_INSTALL_RPATH:BOOL=NO
CMAKE_SKIP_RPATH:BOOL=NO
CMAKE_STRIP:FILEPATH=/usr/bin/strip
CMAKE_USE_RELATIVE_PATHS:BOOL=OFF
CMAKE_VERBOSE_MAKEFILE:BOOL=FALSE
DEBUG:BOOL=OFF
GDB:BOOL=OFF
GKLIB_PATH:PATH=GKlib
GKRAND:BOOL=OFF
GKREGEX:BOOL=OFF
GPROF:BOOL=OFF
OPENMP:BOOL=OFF
PCRE:BOOL=OFF
SHARED:BOOL=FALSE
---%---
Yet another issue is:
---%---
$ cd GKlib
$ make install DESTDIR=/tmp/gklib
Scanning dependencies of target GKlib
[ 3%] Building C object CMakeFiles/GKlib.dir/random.c.o
[ 6%] Building C object CMakeFiles/GKlib.dir/fs.c.o
[ 9%] Building C object CMakeFiles/GKlib.dir/b64.c.o
[ 12%] Building C object CMakeFiles/GKlib.dir/seq.c.o
[ 16%] Building C object CMakeFiles/GKlib.dir/mcore.c.o
[ 19%] Building C object CMakeFiles/GKlib.dir/graph.c.o
[ 22%] Building C object
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 Antonio Trande trp...@katamail.com changed: What|Removed |Added Blocks||908088 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SfGWNXTJnqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920518] Review Request: metis - Serial Graph Partitioning and Fill-reducing Matrix Ordering
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920518 Antonio Trande trp...@katamail.com changed: What|Removed |Added CC||trp...@katamail.com Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dcxL60Sqw7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
