[Bug 927374] Review Request: rubygem-rugged - Ruby binding to the libgit2 linkable library
https://bugzilla.redhat.com/show_bug.cgi?id=927374 Vít Ondruch vondr...@redhat.com changed: What|Removed |Added CC||ktdre...@ktdreyer.com --- Comment #26 from Vít Ondruch vondr...@redhat.com --- *** Bug 1047762 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927374] Review Request: rubygem-rugged - Ruby binding to the libgit2 linkable library
https://bugzilla.redhat.com/show_bug.cgi?id=927374
Troy Dawson tdaw...@redhat.com changed:
What|Removed |Added
CC|package-review@lists.fedora |
|project.org |
--- Comment #17 from Troy Dawson tdaw...@redhat.com ---
Spec URL: http://tdawson.fedorapeople.org/review/rubygem-rugged.spec
SRPM URL:
http://tdawson.fedorapeople.org/review/rubygem-rugged-0.19.0-3.fc20.src.rpm
- Added version to ruby(abi)
- Added %{?rubygems_default_filter} before description
- Added BR: git
-- didn't use /usr/bin/git because that would break on older Fedora versions
- Removed line where I was removing hidden files
- Added full test directory from github (Source1)
-- In comments say how I get and package Source1
-- Let developers know of gemspec bug, they have already thanked me and said
they will fix it.
- Remove BR: rubygem(test-unit)
- Fix up tests so they all pass
-- Added LANG variable
-- run git config --global user.name John Doe
Thanks for the help with the tests. I would have never found those missing
directories, and switching to minitest fixed the exit code problem.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=ecUMWRjY2ca=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927374] Review Request: rubygem-rugged - Ruby binding to the libgit2 linkable library
https://bugzilla.redhat.com/show_bug.cgi?id=927374
--- Comment #15 from Vít Ondruch vondr...@redhat.com ---
* Hidden files
- It looks that rugged is not shipping the hidden files you are removing
anymore. I suggest to drop that line.
* Use rubygem(minitest) only
- There is anywhere any notion, that the test suite is designed for
rubygem(test-unit). Please drop the BR and go forward just with
rubygem(minitest) and testrb
* Omitted dot files
- It seems that upstream .gemspec has a bug in line [1]. There are not
included dot files in resulting .gem, therefore there are missing folders
such as [2] and hence several test cases fail.
- Even though the upstream sources differ already, the bug in .gemspec is
still there. Would you mind to report this issue upstream?
- Please add the dot directories as additional source to fix the test suite.
* Missing global git config
- There is one more failing test:
ConfigTest#test_read_global_config_file [/builddir/build/BUILD/
rugged-0.19.0/usr/share/gems/gems/rugged-0.19.0/test/config_test.rb:19]:
Failed assertion, no message given.
- This can be fixed by setting global git configuration, such as:
$ git config --global user.name John Doe
- Not sure if that should not be done by test suite itself.
* Add BR: /usr/bin/git
- This fixes plenty of test cases, it seems (but please, double check when
you have the missing dot files available).
* Filter the .so file provides
- Please add %{?rubygems_default_filter} macro prior description. Although
this macro is not yet documented in Ruby packaging guidelines, it removes
the automatically generated rugged.so provide, which is useless for Ruby
package.
[1] https://github.com/libgit2/rugged/blob/development/rugged.gemspec#L16
[2] https://github.com/libgit2/rugged/tree/v0.19.0/test/fixtures/diff/.gitted
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=wWaBoAwuHxa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927374] Review Request: rubygem-rugged - Ruby binding to the libgit2 linkable library
https://bugzilla.redhat.com/show_bug.cgi?id=927374 --- Comment #16 from Vít Ondruch vondr...@redhat.com --- Forgot to mention that ruby(abi) should be always versioned. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OUQnZHNJSTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927374] Review Request: rubygem-rugged - Ruby binding to the libgit2 linkable library
https://bugzilla.redhat.com/show_bug.cgi?id=927374 --- Comment #14 from Troy Dawson tdaw...@redhat.com --- Spec URL: http://tdawson.fedorapeople.org/review/rubygem-rugged.spec SRPM URL: http://tdawson.fedorapeople.org/review/rubygem-rugged-0.19.0-2.fc20.src.rpm - Remove vendor directory during %prep - Patch gemspec to reflect missing vendor directory - added export LIBGIT2_PATH=/usr/ before building -- You were right Vit, after removing the vendor directory it was obvious that it was being used, and the fix was easy to test. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nheQV7l6fFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927374] Review Request: rubygem-rugged - Ruby binding to the libgit2 linkable library
https://bugzilla.redhat.com/show_bug.cgi?id=927374 --- Comment #13 from Vít Ondruch vondr...@redhat.com --- (In reply to Troy Dawson from comment #8) -- Since we are building with the libgit2-devel rpm installed we just need to remove the vendor directory at the end. See comment #2. Troy, this is not a good idea. I suspect that rugged is build and staticaly linked against vendored libgit2. These are parts of build logs that suggest that: checking for gmake... yes -- /usr/bin/gmake -f Makefile.embed checking for main() in -lgit2_embed... yes checking for git2.h... yes creating Makefile make DESTDIR= gcc -I. -I/builddir/build/BUILD/rugged-0.19.0/usr/share/gems/gems/rugged-0.19.0/ext/rugged/../../vendor/libgit2/include -I/usr/include -I/usr/include/ruby/backward -I/usr/include -I. -DHAVE_GIT2_H -fPIC -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -g -Wall -m64 -o rugged.o -c rugged.c ... gcc -shared -o rugged.so rugged.o rugged_blob.o rugged_branch.o rugged_commit.o rugged_config.o rugged_diff.o rugged_diff_delta.o rugged_diff_hunk.o rugged_diff_line.o rugged_diff_patch.o rugged_index.o rugged_note.o rugged_object.o rugged_reference.o rugged_remote.o rugged_repo.o rugged_revwalk.o rugged_settings.o rugged_signature.o rugged_tag.o rugged_tree.o -L. -L/usr/lib64 -L. -Wl,-z,relro -fstack-protector -rdynamic -Wl,-export-dynamic -L/builddir/build/BUILD/rugged-0.19.0/usr/share/gems/gems/rugged-0.19.0/ext/rugged -m64 -lruby -lgit2_embed -lpthread -lrt -ldl -lcrypt -lm -lc ... Requires(rpmlib): rpmlib(CompressedFileNames) = 3.0.4-1 rpmlib(FileDigests) = 4.6.0-1 rpmlib(PayloadFilesHavePrefix) = 4.0-1 Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libc.so.6(GLIBC_2.8)(64bit) libcrypt.so.1()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libpthread.so.0(GLIBC_2.2.5)(64bit) librt.so.1()(64bit) libruby.so.2.0()(64bit) rtld(GNU_HASH) You should probably specify LIBGIT2_PATH [1] to make it build against system libgit2. And I still believe it is good idea to remove the vendor dir in %prep section, which would make the build fail, instead of silently used the vendored libgit2. [1] https://github.com/libgit2/rugged/blob/development/ext/rugged/extconf.rb#L28 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=emwN8UM6Fta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927374] Review Request: rubygem-rugged - Ruby binding to the libgit2 linkable library
https://bugzilla.redhat.com/show_bug.cgi?id=927374 --- Comment #10 from Vít Ondruch vondr...@redhat.com --- Troy, it seems that you have forgot to update the .spec file. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PLLemEG15Ua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927374] Review Request: rubygem-rugged - Ruby binding to the libgit2 linkable library
https://bugzilla.redhat.com/show_bug.cgi?id=927374 --- Comment #11 from Vít Ondruch vondr...@redhat.com --- Eh, not just the .spec file, you have not uploaded the SRPM as well, it seems. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iEjnBYg0ofa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927374] Review Request: rubygem-rugged - Ruby binding to the libgit2 linkable library
https://bugzilla.redhat.com/show_bug.cgi?id=927374 --- Comment #12 from Troy Dawson tdaw...@redhat.com --- Sorry about that. I uploaded to the wrong directory. Both the spec and src.rpm are there now. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0lzzbs8hEma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927374] Review Request: rubygem-rugged - Ruby binding to the libgit2 linkable library
https://bugzilla.redhat.com/show_bug.cgi?id=927374 --- Comment #8 from Troy Dawson tdaw...@redhat.com --- Spec URL: http://tdawson.fedorapeople.org/review/rubygem-rugged.spec SRPM URL: http://tdawson.fedorapeople.org/review/rubygem-rugged-0.19.0-1.fc20.src.rpm - I have updated to 0.19.0 -- Since we are building with the libgit2-devel rpm installed we just need to remove the vendor directory at the end. See comment #2. -- We are removing the vendor directory from it's new place. - tests -- There is several tests that don't work, even on gem installed rugged. I remove those tests. -- Even though all the tests pass, we are still getting an exit code of 1, which makes the %check section fail. I'm at a total loss for this and can't figure out the reason. Because of this, I've commented out the %check section. If anyone has an answer, or a work around, I'll gladly uncomment it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ixgxl1R9Wua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927374] Review Request: rubygem-rugged - Ruby binding to the libgit2 linkable library
https://bugzilla.redhat.com/show_bug.cgi?id=927374 --- Comment #9 from Axilleas Pipinellis axill...@archlinux.gr --- Hi, thanks for the update, I will look into the failing tests. It seems that you forgot to update the spec file though ;) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cfk4bdLotsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927374] Review Request: rubygem-rugged - Ruby binding to the libgit2 linkable library
https://bugzilla.redhat.com/show_bug.cgi?id=927374 --- Comment #7 from Axilleas Pipinellis axill...@archlinux.gr --- Hey Troy, sorry for the delay, now that I got sponsored I can make an official review. First of all, I just noticed that you are packaging rugged 0.16.0 which dates back to November 28, 2011! Is there a particular reason not to ship 0.19.0 (July 10, 2013)? I bumped the version to 0.19.0 in your spec, but the tests fail and it appears that the libgit2 library is now bundled in the vendor folder. Can you address these problems first? Thank you :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0CDMGnUiTRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927374] Review Request: rubygem-rugged - Ruby binding to the libgit2 linkable library
https://bugzilla.redhat.com/show_bug.cgi?id=927374 Axilleas Pipinellis axill...@archlinux.gr changed: What|Removed |Added Assignee|nob...@fedoraproject.org|axill...@archlinux.gr -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=urOJjjf6Gca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927374] Review Request: rubygem-rugged - Ruby binding to the libgit2 linkable library
https://bugzilla.redhat.com/show_bug.cgi?id=927374 Axilleas Pipinellis axill...@archlinux.gr changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Rnd7OFOaVRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927374] Review Request: rubygem-rugged - Ruby binding to the libgit2 linkable library
https://bugzilla.redhat.com/show_bug.cgi?id=927374
--- Comment #6 from Troy Dawson tdaw...@redhat.com ---
Spec URL: http://tdawson.fedorapeople.org/review/rubygem-rugged.spec
SRPM URL:
http://tdawson.fedorapeople.org/review/rubygem-rugged-0.16.0-3.fc20.src.rpm
Sorry for the delay, I was out of town at a wedding.
- Cleaned up the %build section to use the current ruby guidelines
- Cleaned up the ext sections to just use %{gem_extdir_mri}
-- Note: when I was originally making this rpm the ruby guidelines were going
through changes, so I had to do things a bit odd. Now that the guidelines are
done, everything is much cleaner and simpler.
- move lib/rugged/rugged.so instead of ext/rugged/rugged.so
-- This did clear up the permissions problem.
-- I also cleaned up all the extra lines that were fixing the permissions
problem, and the extra file problem.
- move rugged.so into the correct directory %{gem_extdir_mri}/lib/%{gem_name}/
-- Thank you for that catch. Everything is working now.
- cleaned up the %check section
-- Now that rugged.so is in the right place we are able to use testrb2 (instead
of testrb) and all the tests run correctly, without any extra work.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=wccv3Z3svya=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927374] Review Request: rubygem-rugged - Ruby binding to the libgit2 linkable library
https://bugzilla.redhat.com/show_bug.cgi?id=927374 --- Comment #5 from Axilleas Pipinellis axill...@archlinux.gr --- (In reply to Vít Ondruch from comment #4) (In reply to Axilleas Pipinellis from comment #3) Copying rugged.so from /usr/lib64 back to /usr/share, fixed it. I also confirmed that it plays fine even with the .so in /usr/lib64 removed. In conclusion, it only needs the one in /usr/share. Sorry, that is wrong conclusion for several reasons: Yes, you are right. I didn't mean that the right place is in /usr/share, I was rather trying to point that there was something wrong going on. Bad choice of words I guess. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RAfBhKXHI0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927374] Review Request: rubygem-rugged - Ruby binding to the libgit2 linkable library
https://bugzilla.redhat.com/show_bug.cgi?id=927374
Vít Ondruch vondr...@redhat.com changed:
What|Removed |Added
CC||vondr...@redhat.com
--- Comment #4 from Vít Ondruch vondr...@redhat.com ---
A few comments from my side.
* %{gem_extdir_mri} is available in older Fedoras
- You dont have to branch the %install and %files sections, since
%{gem_extdir_mri} macro is supported by older Fedoras.
* Ship lib/rugged/rugged.so instead of ext/rugged/rugged.so
- If you read the guidelines properly, it exactly specifies, that you should
move lib/rugged/rugged.so into %{gem_extdir_mri}.
- This should fix also the wrong file permissions IMO, so you could remove
the chmod.
- This would render the:
rm -rf %{buildroot}%{gem_instdir}/lib/rugged/rugged.so
unnecessary as well.
(In reply to Axilleas Pipinellis from comment #3)
Copying rugged.so from /usr/lib64 back to /usr/share, fixed it. I also
confirmed that it plays fine even with the .so in /usr/lib64 removed. In
conclusion, it only needs the one in /usr/share.
Sorry, that is wrong conclusion for several reasons:
* .so file is platform dependent and cannot end up in /usr/share what so ever
* moving of .so file into /usr/share works, since the path is already available
in Ruby's search path. That does not make it correct.
* The problem is hidden in:
mkdir -p %{buildroot}%{gem_extdir_mri}/lib/%{name}/
mv %{buildroot}%{gem_instdir}/ext/rugged/rugged.so \
%{buildroot}%{gem_extdir_mri}/lib/%{name}/
where %{name} should be replaced with %{gem_name}. I did not tested this
change, but this is creates
/usr/lib/gems/ruby/rugged-0.16.0/lib/rubygem-rugged/, which is apparently
wrong.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=XQDH0zmWkCa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927374] Review Request: rubygem-rugged - Ruby binding to the libgit2 linkable library
https://bugzilla.redhat.com/show_bug.cgi?id=927374
--- Comment #1 from Axilleas Pipinellis axill...@archlinux.gr ---
Hi, this is my first informal review as I am yet to be sponsored as a packager
:)
Followed by the discussion in Ruby-SIG[0], I am posting both those questions
answered and some other details that need fixing.
* explicit-lib-dependency libgit2
- libgit2 is bundled in the gem, it should be removed.
* non-standard-executable-perm
/usr/lib64/gems/ruby/rugged-0.16.0/lib/rubygem-rugged/rugged.so 0775L
- Permissions should be 755.
* Duplicate sonames (arch-dependent-file-in-usr-share)
- /usr/share/gems/gems/rugged-0.16.0/lib/rugged/rugged.so should not be
there.
* Mixed use of macros
- Use either %{buildroot} or $RPM_BUILD_ROOT, not both.
* Test suite
- Since this package provides a test suite it would be nice to run it.
Here is a patch that builds fine (download here [1]):
diff -rupN a/rubygem-rugged.spec b/rubygem-rugged.spec
--- a/rubygem-rugged.spec 2013-03-25 20:42:26.0 +0200
+++ b/rubygem-rugged.spec 2013-06-24 22:27:23.84000 +0300
@@ -17,9 +17,10 @@ BuildRequires: ruby(release)
Requires: ruby(abi)
BuildRequires: ruby(abi)
%endif
-BuildRequires: zlib-devel
-BuildRequires: ruby-devel
-BuildRequires: rubygems-devel
+BuildRequires: zlib-devel
+BuildRequires: ruby-devel
+BuildRequires: rubygem(minitest)
+BuildRequires: rubygems-devel
Provides: rubygem(%{gem_name}) = %{version}
%description
@@ -73,6 +74,17 @@ mv %{buildroot}%{gem_instdir}/ext/rugged
rm -rf
$RPM_BUILD_ROOT%{gem_instdir}/{.require_paths,.gitignore,.travis.yml,.yardoc}
rm -rf $RPM_BUILD_ROOT%{gem_instdir}/ext/
+%check
+
+pushd .%{gem_instdir}
+
+## Fix failing test: https://github.com/libgit2/rugged/pull/65
+sed -i '78s/.*/now = Time.at Time.now.to_i/' test/index_test.rb
+
+find test -type f -name *_test.rb | xargs testrb -Ilib
+
+popd
+
%files
%doc %{gem_instdir}/LICENSE
%doc %{gem_instdir}/README.md
---
[0] https://lists.fedoraproject.org/pipermail/ruby-sig/2013-July/001373.html
[1] http://axilleas.fedorapeople.org/tmp/rubygem-rugged.spec.patch
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=sM2n15yYhBa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927374] Review Request: rubygem-rugged - Ruby binding to the libgit2 linkable library
https://bugzilla.redhat.com/show_bug.cgi?id=927374
--- Comment #2 from Troy Dawson tdaw...@redhat.com ---
Spec URL: http://tdawson.fedorapeople.org/review/rubygem-rugged.spec
SRPM URL:
http://tdawson.fedorapeople.org/review/rubygem-rugged-0.16.0-1.fc20.src.rpm
- libgit2 is bundled in the gem, it should be removed.
-- according to ext/rugged/extconf.rb if we have git2 and git2.h installed, it
will not use the bundled library.
-- Added BuildRequires: libgit2-devel which pulls in git2 and git2.h, so that
the bundled library isn't used during build.
-- We delete the bundled library so it isn't shipped.
- Permissions should be 755 for rugged.so
-- Fixed
- Duplicate rugged.so
-- Fixed (remove /usr/share/gems/gems/rugged-0.16.0/lib/rugged/rugged.so)
- Mixed use of macros
-- Fixed (now consistently use %{buildroot}
- Run tests
-- Thank you for the testing syntax, I have put that in and it works.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=JIyd1ktaPHa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927374] Review Request: rubygem-rugged - Ruby binding to the libgit2 linkable library
https://bugzilla.redhat.com/show_bug.cgi?id=927374 --- Comment #3 from Axilleas Pipinellis axill...@archlinux.gr --- The spec looks good and rpmlint didn't find any errors or warnings. It also builds fine in mock for versions 18-20 that I tested it. BUT, there is another issue. The library cannot load. In particular: -- irb(main):001:0 require 'rugged' LoadError: cannot load such file -- rugged/rugged from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:45:in `require' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:45:in `require' from /usr/share/gems/gems/rugged-0.16.0/lib/rugged.rb:1:in `top (required)' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:110:in `require' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:110:in `rescue in require' from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:35:in `require' from (irb):1 from /usr/bin/irb:12:in `main' -- Copying rugged.so from /usr/lib64 back to /usr/share, fixed it. I also confirmed that it plays fine even with the .so in /usr/lib64 removed. In conclusion, it only needs the one in /usr/share. PS. You linked the wrong SRPM version previously ;) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0nY1fODIJka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
