[Bug 947155] Review Request: mingw-gstreamer1 - MinGW build of GStreamer1
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947155 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- mingw-gstreamer1-1.0.6-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HGTUFsVqcna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947155] Review Request: mingw-gstreamer1 - MinGW build of GStreamer1
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947155 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added CC|fedora-mingw@lists.fedorapr | |oject.org | Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-04-20 16:19:53 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mDWeNAdjoRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947155] Review Request: mingw-gstreamer1 - MinGW build of GStreamer1
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947155 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bqQcQD8NZ9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947155] Review Request: mingw-gstreamer1 - MinGW build of GStreamer1
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947155 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- mingw-gstreamer1-1.0.6-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=peWFQafRJza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947155] Review Request: mingw-gstreamer1 - MinGW build of GStreamer1
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947155 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7muFknP3FXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947155] Review Request: mingw-gstreamer1 - MinGW build of GStreamer1
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947155 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- mingw-gstreamer1-1.0.6-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mingw-gstreamer1-1.0.6-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=B0tu1vkKwJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947155] Review Request: mingw-gstreamer1 - MinGW build of GStreamer1
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947155 Paweł Forysiuk tuxa...@o2.pl changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Paweł Forysiuk tuxa...@o2.pl --- New Package SCM Request === Package Name: mingw-gstreamer1 Short Description: MinGW compilation of GStreamer1 Owners: pfor Branches: f18 f19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TSn2w1GNNUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947155] Review Request: mingw-gstreamer1 - MinGW build of GStreamer1
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947155 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=c8pCYPbGAQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947155] Review Request: mingw-gstreamer1 - MinGW build of GStreamer1
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947155 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TxOYY6pjtqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947155] Review Request: mingw-gstreamer1 - MinGW build of GStreamer1
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947155 Kalev Lember kalevlem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||fedora-mingw@lists.fedorapr ||oject.org, ||kalevlem...@gmail.com Assignee|nob...@fedoraproject.org|kalevlem...@gmail.com --- Comment #1 from Kalev Lember kalevlem...@gmail.com --- Taking for review. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5195682 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=K4TRUEJRZsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947155] Review Request: mingw-gstreamer1 - MinGW build of GStreamer1
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947155 --- Comment #2 from Kalev Lember kalevlem...@gmail.com --- The spec file renames the gst-plugin-scanner.exe that's in libexec/ to gst-plugin-scanner-1.0.exe; why? I'm no gstreamer expert, but it seems to be an internal helper executable invoked by libgstreamer-1.0-0.dll. How does the library know what the new name is? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AHAr7U9aGEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947155] Review Request: mingw-gstreamer1 - MinGW build of GStreamer1
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947155 --- Comment #3 from Paweł Forysiuk tuxa...@o2.pl --- This was clearly a mistake, thanks for pointing it out. Updated files below. Spec URL: https://dl.dropbox.com/u/2448780/mingw-gstreamer1-1.0.6.spec SRPM URL: https://dl.dropbox.com/u/2448780/mingw-gstreamer1-1.0.6-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WXUq9CFcmVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947155] Review Request: mingw-gstreamer1 - MinGW build of GStreamer1
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=947155
Kalev Lember kalevlem...@gmail.com changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #4 from Kalev Lember kalevlem...@gmail.com ---
Fedora review of mingw-gstreamer1-1.0.6-1.fc18.src.rpm 2013-04-01
+ OK
! needs attention
rpmlint output:
$ rpmlint mingw-gstreamer1-1.0.6-1.fc19.src.rpm \
mingw32-gstreamer1-1.0.6-1.fc19.noarch.rpm \
mingw64-gstreamer1-1.0.6-1.fc19.noarch.rpm \
mingw32-gstreamer1-debuginfo-1.0.6-1.fc19.noarch.rpm \
mingw64-gstreamer1-debuginfo-1.0.6-1.fc19.noarch.rpm
mingw-gstreamer1.src: W: spelling-error %description -l en_US GStreamer - G
Streamer, Streamer, Steamer
mingw-gstreamer1.src: E: changelog-time-in-future 2013-04-02
mingw-gstreamer1.src: E: specfile-error warning: bogus date in %changelog: Mon
Apr 02 2013 Paweł Forysiuk tuxa...@o2.pl - 1.0.6-1
mingw32-gstreamer1.noarch: W: spelling-error %description -l en_US GStreamer -
G Streamer, Streamer, Steamer
mingw32-gstreamer1.noarch: E: changelog-time-in-future 2013-04-02
mingw32-gstreamer1.noarch: E: incorrect-fsf-address
/usr/share/doc/mingw32-gstreamer1-1.0.6/COPYING
mingw64-gstreamer1.noarch: W: spelling-error %description -l en_US GStreamer -
G Streamer, Streamer, Steamer
mingw64-gstreamer1.noarch: E: changelog-time-in-future 2013-04-02
mingw64-gstreamer1.noarch: E: incorrect-fsf-address
/usr/share/doc/mingw64-gstreamer1-1.0.6/COPYING
mingw32-gstreamer1-debuginfo.noarch: E: changelog-time-in-future 2013-04-02
mingw32-gstreamer1-debuginfo.noarch: E: debuginfo-without-sources
mingw64-gstreamer1-debuginfo.noarch: E: changelog-time-in-future 2013-04-02
mingw64-gstreamer1-debuginfo.noarch: E: debuginfo-without-sources
5 packages and 0 specfiles checked; 10 errors, 3 warnings.
+ The package is named according to Fedora MinGW packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The stated license is the same as the one for the corresponding
native Fedora package
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
d0797e51a420fca0beb973b9dcda586f gstreamer-1.0.6.tar.xz
d0797e51a420fca0beb973b9dcda586f Download/gstreamer-1.0.6.tar.xz
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
+ locale handling
n/a ldconfig in %post and %postun
+ Package doesn't bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
Not applicable to MinGW packages.
n/a Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
+ Packages must not contain libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8
Just a small issue that rpmlint caught above: it should be 'Mon Apr 01', not
'Mon Apr 02' in the changelog.
Otherwise looks good, but please fix this before importing.
APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=BrRmRBNm8La=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
