[Bug 948000] Review Request: gr-osmosdr - Common software API for various radio hardware
https://bugzilla.redhat.com/show_bug.cgi?id=948000 Jaroslav Škarvada jskar...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #10 from Jaroslav Škarvada jskar...@redhat.com --- Package Change Request == Package Name: gr-osmosdr New Branches: epel7 Owners: jskarvad InitialCC: cottsay -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948000] Review Request: gr-osmosdr - Common software API for various radio hardware
https://bugzilla.redhat.com/show_bug.cgi?id=948000 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948000] Review Request: gr-osmosdr - Common software API for various radio hardware
https://bugzilla.redhat.com/show_bug.cgi?id=948000 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948000] Review Request: gr-osmosdr - Common software API for various radio hardware
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948000 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- gr-osmosdr-0.0.1-2.20130403gite85c68d9.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kl1SuP4FZda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948000] Review Request: gr-osmosdr - Common software API for various radio hardware
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948000 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Resolution|NEXTRELEASE |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zcoScZaXNBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948000] Review Request: gr-osmosdr - Common software API for various radio hardware
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948000 Jaroslav Škarvada jskar...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Jaroslav Škarvada jskar...@redhat.com --- New Package SCM Request === Package Name: gr-osmosdr Short Description: Common software API for various radio hardware Owners: jskarvad Branches: f18 f19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DMX0uclVWpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948000] Review Request: gr-osmosdr - Common software API for various radio hardware
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948000 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VAslYfokEYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948000] Review Request: gr-osmosdr - Common software API for various radio hardware
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948000 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XGIgAAGPCza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948000] Review Request: gr-osmosdr - Common software API for various radio hardware
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948000 Jaroslav Škarvada jskar...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |NEXTRELEASE Last Closed||2013-04-10 09:45:33 --- Comment #6 from Jaroslav Škarvada jskar...@redhat.com --- (In reply to comment #5) Git done (by process-git-requests). Thanks. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bSj6f6hQ9va=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948000] Review Request: gr-osmosdr - Common software API for various radio hardware
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948000 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- gr-osmosdr-0.0.1-2.20130403gite85c68d9.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/gr-osmosdr-0.0.1-2.20130403gite85c68d9.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mwMca67kDia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948000] Review Request: gr-osmosdr - Common software API for various radio hardware
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948000 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- gr-osmosdr-0.0.1-2.20130403gite85c68d9.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/gr-osmosdr-0.0.1-2.20130403gite85c68d9.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KaQByezmXia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948000] Review Request: gr-osmosdr - Common software API for various radio hardware
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=948000
--- Comment #2 from Jaroslav Škarvada jskar...@redhat.com ---
Thanks for the review.
- Package contains BR: python2-devel or python3-devel
See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires
Used python2-devel.
- Package own directory that belong to gnuradio (
/usr/share/gnuradio/grc/blocks )
Fixed.
- %{_isa} is missing in Requires from -devel
Fixed.
- why are some includes removed ( ie, the one about swig ) ?
Fixed.
- I would add the 2 examples application in %doc ( in apps/ ), what do you
think about it ?
Added to examples subdir.
- there is also some doxygen documentation, shouldn't it be shipped ?
Built.
I also changed the group to Applications/Engineering.
I sent all patches to upstream (osmocom-...@lists.osmocom.org), but the list
seems moderated and my posts still didn't appear in the list archive.
Spec URL: http://fedorapeople.org/~jskarvad/gr-osmosdr/gr-osmosdr.spec
SRPM URL:
http://fedorapeople.org/~jskarvad/gr-osmosdr/gr-osmosdr-0.0.1-2.20130403gite85c68d9.fc18.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=xv2lXDLlKka=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948000] Review Request: gr-osmosdr - Common software API for various radio hardware
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948000 Michael Scherer m...@zarb.org changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #3 from Michael Scherer m...@zarb.org --- ok, seems good. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oamYzT72ska=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948000] Review Request: gr-osmosdr - Common software API for various radio hardware
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948000 Bug 948000 depends on bug 949336, which changed state. Bug 949336 Summary: Review Request: rtl-sdr - SDR utilities for Realtek RTL2832 based DVB-T dongles https://bugzilla.redhat.com/show_bug.cgi?id=949336 What|Removed |Added Status|NEW |CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Tpc8tOMux1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948000] Review Request: gr-osmosdr - Common software API for various radio hardware
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=948000
Michael Scherer m...@zarb.org changed:
What|Removed |Added
CC||m...@zarb.org
Assignee|nob...@fedoraproject.org|m...@zarb.org
Flags||fedora-review?
--- Comment #1 from Michael Scherer m...@zarb.org ---
Package Review
==
Key:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package contains BR: python2-devel or python3-devel
See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires
- Package own directory that belong to gnuradio (
/usr/share/gnuradio/grc/blocks )
- %{_isa} is missing in Requires from -devel
- why are some includes removed ( ie, the one about swig ) ?
- I would add the 2 examples application in %doc ( in apps/ ), what do you
think about it ?
- there is also some doxygen documentation, shouldn't it be shipped ?
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v2 or later), GPL (v3 or later), Unknown or generated. 1 files
have unknown license. Detailed output of licensecheck in
/home/misc/checkout/git/FedoraReview/948000-gr-osmosdr/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/gnuradio/grc/blocks(gnuradio)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gr-osmosdr-
devel
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match
[Bug 948000] Review Request: gr-osmosdr - Common software API for various radio hardware
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948000 Jaroslav Škarvada jskar...@redhat.com changed: What|Removed |Added Depends On||949336 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EVa1obW8COa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
