[Bug 1378160] Review Request: jitterentropy-rngd - RNGD based on CPU Jitter RNG

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378160

Fedora Update System  changed:

   What|Removed |Added

 Status|VERIFIED|ON_QA



--- Comment #3 from Fedora Update System  ---
jitterentropy-rngd-1.0.3-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d380b9537d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378014] Review Request: perl-IO-FDPass - Pass a file descriptor over a socket

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378014



--- Comment #8 from Fedora Update System  ---
perl-IO-FDPass-1.1-3.fc24 has been pushed to the Fedora 24 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-521b8ec92d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376869] Review Request: gap-pkg-lpres - Nilpotent quotients of L-presented groups

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376869

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA



--- Comment #4 from Fedora Update System  ---
gap-pkg-lpres-0.3.1-1.fc24 has been pushed to the Fedora 24 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-97850b68cb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378999] New: Review Request: perl-Test-Mock-Guard - Simple mock test library using RAII

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378999

Bug ID: 1378999
   Summary: Review Request: perl-Test-Mock-Guard - Simple mock
test library using RAII
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: n...@fedoraproject.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://nb.fedorapeople.org/perl-Test-Mock-Guard.spec
SRPM URL: https://nb.fedorapeople.org/perl-Test-Mock-Guard-0.10-1.fc24.src.rpm
Description: Simple mock test library using RAII
Fedora Account System Username: nb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378999] Review Request: perl-Test-Mock-Guard - Simple mock test library using RAII

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378999

Nick Bebout  changed:

   What|Removed |Added

 Blocks||1377444




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1377444
[Bug 1377444] Review Request: perl-JSON-WebToken - JSON Web Token (JWT)
implementation
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290337] Review Request: ed25519-java - Implementation of EdDSA ( Ed25519) in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290337



--- Comment #2 from Christoph Junghans  ---
3 questions:
- Does it make sense to install the javadoc without the actual package -
Missing "Require:"?
- pom.xml isn't packaged, why?
- There seem to be tests in test/net/i2p/crypto/eddsa, but no %check

Detailed Package Review
===

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[X]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[X]: License field in the package spec file matches the actual license.
[X]: License file installed when any subpackage combination is installed.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
 names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[-]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[X]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
 Note: Maven packages do not need to (Build)Require jpackage-utils. It
 is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
 subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[?]: If package contains pom.xml files install it (including metadata) even
 when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
 utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[-]: Final provides and requires are sane (see attachments).
[?]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ed25519
 -java-javadoc
[X]: Package functions as 

[Bug 1378014] Review Request: perl-IO-FDPass - Pass a file descriptor over a socket

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378014



--- Comment #9 from Fedora Update System  ---
perl-IO-FDPass-1.1-3.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-e0de107952

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377444] Review Request: perl-JSON-WebToken - JSON Web Token (JWT) implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377444

Nick Bebout  changed:

   What|Removed |Added

 Depends On||1378999
 Whiteboard|NotReady|




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1378999
[Bug 1378999] Review Request: perl-Test-Mock-Guard - Simple mock test
library using RAII
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=977116

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA



--- Comment #57 from Fedora Update System  ---
pgmodeler-0.8.2-4.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-16511f4864

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373666] Review Request: hddfancontrol - Control system fan speed by monitoring hard drive temperature

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373666

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |ON_QA



--- Comment #3 from Fedora Update System  ---
hddfancontrol-1.2.4-1.fc24 has been pushed to the Fedora 24 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-88f8b0e433

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378014] Review Request: perl-IO-FDPass - Pass a file descriptor over a socket

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378014



--- Comment #7 from Fedora Update System  ---
perl-IO-FDPass-1.1-3.fc23 has been pushed to the Fedora 23 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-76dc50a7d2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373666] Review Request: hddfancontrol - Control system fan speed by monitoring hard drive temperature

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373666



--- Comment #4 from Fedora Update System  ---
hddfancontrol-1.2.4-1.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-e0fadab9df

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378160] Review Request: jitterentropy-rngd - RNGD based on CPU Jitter RNG

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378160



--- Comment #4 from Fedora Update System  ---
jitterentropy-rngd-1.0.3-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6dbaf19524

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369534] Review Request: libsass - C/ C++ port of the Sass CSS precompiler

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369534

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA



--- Comment #7 from Fedora Update System  ---
libsass-3.3.6-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-57a1f8f677

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376869] Review Request: gap-pkg-lpres - Nilpotent quotients of L-presented groups

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376869



--- Comment #5 from Fedora Update System  ---
gap-pkg-lpres-0.3.1-1.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-36fa8c86eb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1362490] Review Request: libphutil - A collection of PHP utility classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362490



--- Comment #25 from Tim Flink  ---
(In reply to Jared Smith from comment #24)
> You're going to need to adjust the license tag on this package. 
> Licensecheck found several licenses other than Apache in parts of the code
> base:
> 
> GPL (v3 or later)
> -
> libphutil-8f8e02d47569dce5f035383d8bcbf7a08481e839/support/xhpast/parser.
> yacc.cpp
> libphutil-8f8e02d47569dce5f035383d8bcbf7a08481e839/support/xhpast/parser.
> yacc.hpp

Bah, I thought those were covered under the special GPL exception for bison
output but I missed the part about "as long as it isn't used as part of a
parser generator'.

> MIT/X11 (BSD like)
> --
> libphutil-8f8e02d47569dce5f035383d8bcbf7a08481e839/externals/jsonlint/LICENSE

Why couldn't this be distributed as APL2? Ignoring the GPL3 issue with the
bison output, I mean.

> You should also set the Version: tag to 0 and the Release: tag to
> 0.1.20160806.git%{git_short_version_hash}%{dist} 
> 
> If you were to do a second build with that same git hash, it would then be
> 0.2.20160806.git%{git_short_version_hash}%{dist}, and so on.
> 
> This way, if/when a version 1.0 comes out, it will be greater than version
> 0.x.2016whatever.

That makes sense but I'm going to see if I can get more out of Jeroen WRT the
potential requires/provides  issue he mentioned. I'm not sure if that's been
tested at all or if there was a plan to work around the concerns.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373486] Review Request: python34 - Version 3.4 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373486



--- Comment #10 from Miro Hrončok  ---
s/Peter/Petr/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290337] Review Request: ed25519-java - Implementation of EdDSA ( Ed25519) in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290337



--- Comment #3 from gil cattaneo  ---
(In reply to Christoph Junghans from comment #2)
> 3 questions:
> - Does it make sense to install the javadoc without the actual package -
> Missing "Require:"?
No
> [?]: Fully versioned dependency in subpackages if applicable.
>  Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ed25519
>  -java-javadoc

Requires are handled by our: java(packages-)tools
and this is a noarch package. for refrerences see:
https://fedora-java.github.io/howto/latest/#maven

> [?]: If package contains pom.xml files install it (including metadata) even
>  when building with ant

> - pom.xml isn't packaged, why?

is not true see "Provides" mvn(net.i2p.crypto:eddsa:pom:)

> [?]: %check is present and all tests pass.

> - There seem to be tests in test/net/i2p/crypto/eddsa, but no %check

This is a maven build style and "%check" is useless only in this case (and with
gradle)


> Requires
> 
> ed25519-java (rpmlib, GLIBC filtered):
> java-headless
> javapackages-tools
> 
> ed25519-java-javadoc (rpmlib, GLIBC filtered):
> javapackages-tools
> 
> 
> 
> Provides
> 
> ed25519-java:
> ed25519-java
> mvn(net.i2p.crypto:eddsa)
> mvn(net.i2p.crypto:eddsa:pom:)
> osgi(net.i2p.crypto.eddsa)
>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290339] Review Request: curve25519-java - Implementation of Curve25519 in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290339

Luya Tshimbalanga  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Luya Tshimbalanga  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "*No copyright* Apache (v2.0)". 
[x]: License file installed when any subpackage combination is installed.
[-]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
 Note: Maven packages do not need to (Build)Require jpackage-utils. It
 is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
 subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
 when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
 utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and 

[Bug 1378341] Review Request: fedpkg-copr - copr dist-git client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378341



--- Comment #2 from Neal Gompa  ---
The general form of the spec looks fine, but you're missing buildrequires.

Running fedora-review caused it to bomb out because "a2x" was not found. Please
review your build-time requirements and fix your spec.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373486] Review Request: python34 - Version 3.4 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373486

Miro Hrončok  changed:

   What|Removed |Added

 CC||pvikt...@redhat.com
  Flags||needinfo?(pviktori@redhat.c
   ||om)



--- Comment #9 from Miro Hrončok  ---
So, we already have python34 in the git, because of EPEL. I'v just requested
ACLs on the package for Fedora branches and I'm asking the maintainer (who
happens to be Peter Viktorin), if he agrees to use this package in Fedora, as
approved by this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378014] Review Request: perl-IO-FDPass - Pass a file descriptor over a socket

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378014

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA



--- Comment #6 from Fedora Update System  ---
perl-IO-FDPass-1.1-3.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-0ce15e8fa9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971



--- Comment #12 from Luya Tshimbalanga  ---
SCM request
F25: https://admin.fedoraproject.org/pkgdb/package/requests/7934
Master: https://admin.fedoraproject.org/pkgdb/package/requests/7935

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290339] Review Request: curve25519-java - Implementation of Curve25519 in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290339

Luya Tshimbalanga  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290339] Review Request: curve25519-java - Implementation of Curve25519 in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290339



--- Comment #4 from gil cattaneo  ---
Thanks for the review!

create new SCM requests:
https://admin.fedoraproject.org/pkgdb/package/requests/7936

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290339] Review Request: curve25519-java - Implementation of Curve25519 in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290339

gil cattaneo  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1348162] Review Request: rubygem-net-dns - Pure Ruby DNS library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348162



--- Comment #11 from Fedora Update System  ---
rubygem-net-dns-0.8.0-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-bc46bcc322

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1332052] Review Request: python-filelock - A platform independent file lock

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332052



--- Comment #6 from Fedora Update System  ---
python-filelock-2.0.6-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-343b685e87

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1348202] Review Request: rubygem-pcaprub - libpcap bindings for ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348202



--- Comment #12 from Fedora Update System  ---
rubygem-pcaprub-0.12.4-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b59a456f28

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1364805] Review Request: hamster-cinnamon-applet - Cinnamon applet for hamster time tracker.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364805

Lukáš Nykrýn  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|xsk...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1364805] Review Request: hamster-cinnamon-applet - Cinnamon applet for hamster time tracker.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364805



--- Comment #2 from Daniel Maixner  ---
I'm going to look at it next week

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1332052] Review Request: python-filelock - A platform independent file lock

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332052



--- Comment #5 from Fedora Update System  ---
python-filelock-2.0.6-1.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-389bd2e5a0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1348202] Review Request: rubygem-pcaprub - libpcap bindings for ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348202



--- Comment #11 from Fedora Update System  ---
rubygem-pcaprub-0.12.4-1.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-c385335ed5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1348162] Review Request: rubygem-net-dns - Pure Ruby DNS library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348162



--- Comment #10 from Fedora Update System  ---
rubygem-net-dns-0.8.0-1.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-da2233a0aa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376899] Review Request: pcaudiolib - Portable C Audio Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376899

Petr Menšík  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review-



--- Comment #6 from Petr Menšík  ---
[x]: Fully versioned dependency in subpackages if applicable.
Thank you, I think it is ready.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376899] Review Request: pcaudiolib - Portable C Audio Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376899

Petr Menšík  changed:

   What|Removed |Added

  Flags|fedora-review-  |fedora-review+



--- Comment #7 from Petr Menšík  ---
Sorry!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374024] Review Request: python-plotcat - Python library for plotting live serial input using matplotlib

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374024



--- Comment #9 from girish joshi  ---
I've updated the spec file and srpm

Specfile Url:
https://raw.githubusercontent.com/girish946/plot-cat/master/python-plotcat.spec

Srpm Url:
https://github.com/girish946/plot-cat/raw/master/dist/python-plotcat-1.0.0.1-2.fc24.src.rpm

the rpmlint issues are fixed.

koji builds: 
   rawhide : http://koji.fedoraproject.org/koji/taskinfo?taskID=15760013
   epel: http://koji.fedoraproject.org/koji/taskinfo?taskID=15759967

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378021] Review Request: jetty-alpn - Jetty implementation of ALPN API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378021



--- Comment #6 from Michael Simacek  ---
(In reply to gil cattaneo from comment #5)
> Issues:
> [!]: Package contains no bundled libraries without FPC exception.
>  See maven-shade-plugin and maven-bundle-plugin tasks

Removed maven-shade-plugin.
maven-bundle-plugin is for generating OSGi bundles, those are not bundling,
they are just named like that.

> 
> [!]: If the source package does not include license text(s) as a separate
>  file from upstream, the packager SHOULD query upstream to include it.
> 
> [!]: Package does not include license text files separate from upstream.
> 
> jetty-alpn.noarch: E: incorrect-fsf-address
> /usr/share/licenses/jetty-alpn/gplv2+ce.html
> jetty-alpn-javadoc.noarch: E: incorrect-fsf-address
> /usr/share/licenses/jetty-alpn-javadoc/gplv2+ce.html

Actually, the package is under GPL, which doesn't require license file to be
distributed alongside the source. So I just removed it.

Spec URL: https://msimacek.fedorapeople.org/jetty-alpn.spec
SRPM URL:
https://msimacek.fedorapeople.org/jetty-alpn-8.1.9-2.v20160720.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378028] Review Request: perl-MCE-Shared - MCE extension for sharing data, supporting threads and processes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378028



--- Comment #1 from Paul Howarth  ---
Updated to 1.805:

Spec URL:
http://subversion.city-fan.org/repos/cfo-repo/perl-MCE-Shared/branches/fedora/perl-MCE-Shared.spec

SRPM URL:
http://www.city-fan.org/~paul/extras/perl-MCE-Shared/perl-MCE-Shared-1.805-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378740] Review Request: python-pytest-faulthandler - py.test plugin that activates the fault handler module for tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378740



--- Comment #1 from Igor Gnatenko  ---
> %{python3_sitelib}/__pycache__/
I suppose you wanted %{python3_sitelib}/__pycache__/pytest_faulthandler.*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378021] Review Request: jetty-alpn - Jetty implementation of ALPN API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378021



--- Comment #7 from gil cattaneo  ---
Pòease, remove "cp -p %{SOURCE1} ."

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1353224] Review Request: python-tackerclient - Client for OpenStack tacker project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1353224

Alfredo Moralejo  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-09-23 07:14:19



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378860] Review Request: jetty-setuid - SetUID support for jetty

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378860

Mikolaj Izdebski  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mizde...@redhat.com
   Assignee|nob...@fedoraproject.org|mizde...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378740] New: Review Request: python-pytest-faulthandler - py.test plugin that activates the fault handler module for tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378740

Bug ID: 1378740
   Summary: Review Request: python-pytest-faulthandler - py.test
plugin that activates the fault handler module for
tests
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: dkre...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://dkrejci.fedorapeople.org/python-pytest-faulthandler/python-pytest-faulthandler.spec
SRPM URL:
https://dkrejci.fedorapeople.org/python-pytest-faulthandler/python-pytest-faulthandler-1.3.0-1.fc24.src.rpm
Description: Plugin for pytest that automatically enables the faulthandler
module during tests. Inspired by the nose faulthandler plugin.
Fedora Account System Username: dkrejci

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15761398

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1353224] Review Request: python-tackerclient - Client for OpenStack tacker project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1353224

Alfredo Moralejo  changed:

   What|Removed |Added

   Fixed In Version||python-tackerclient-0.7.0-1
   ||.fc26



--- Comment #8 from Alfredo Moralejo  ---
Built in http://koji.fedoraproject.org/koji/buildinfo?buildID=802727 for fedora
rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1338339] Review Request: openrave - Open Robotics Automation Virtual Environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1338339

Till Hofmann  changed:

   What|Removed |Added

  Flags|needinfo?(till.hofmann@post |
   |eo.de)  |



--- Comment #24 from Till Hofmann  ---
I added a link to a copy of a full build log:
https://thofmann.fedorapeople.org/openrave/build.log

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378860] New: Review Request: jetty-setuid - SetUID support for jetty

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378860

Bug ID: 1378860
   Summary: Review Request: jetty-setuid - SetUID support for
jetty
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: msima...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Blocks: 652183 (FE-JAVASIG)



Spec URL:
http://msimacek.fedorapeople.org/review/jetty-setuid/jetty-setuid.spec
SRPM URL:
http://msimacek.fedorapeople.org/review/jetty-setuid/jetty-setuid-1.0.3-1.fc24.src.rpm
Description: Jetty’s SetUID module allows you to run Jetty as a normal user
even when you
need to run Jetty on port 80 or 443.
Fedora Account System Username: msimacek


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=977116



--- Comment #56 from Sandro Mani  ---
If you do MinGW reviews, could you have a look at
https://bugzilla.redhat.com/show_bug.cgi?id=1378807?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378807] New: Review Request: mingw-podofo - MinGW Windows podofo library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378807

Bug ID: 1378807
   Summary: Review Request: mingw-podofo - MinGW Windows podofo
library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: manisan...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://smani.fedorapeople.org/review/mingw-podofo.spec
SRPM URL:
https://smani.fedorapeople.org/review/mingw-podofo-0.9.4-1.fc26.src.rpm
Description: MinGW Windows podofo library
Fedora Account System Username: smani

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378021] Review Request: jetty-alpn - Jetty implementation of ALPN API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378021



--- Comment #8 from Michael Simacek  ---
(In reply to gil cattaneo from comment #7)
> Pòease, remove "cp -p %{SOURCE1} ."

Done.

Spec URL: https://msimacek.fedorapeople.org/jetty-alpn.spec
SRPM URL:
https://msimacek.fedorapeople.org/jetty-alpn-8.1.9-3.v20160720.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378021] Review Request: jetty-alpn - Jetty implementation of ALPN API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378021



--- Comment #10 from gil cattaneo  ---
is not enough "%pom_remove_plugin :maven-shade-plugin". Please, use
"%pom_remove_plugin -r :maven-shade-plugin". "org.eclipse.jetty.alpn:alpn-api"
is till shaded: "[INFO] --- maven-shade-plugin:2.4.3:shade (default) @
alpn-boot ---
[INFO] Including org.eclipse.jetty.alpn:alpn-api:jar:1.1.3.v20160715 in the
shaded jar.
[INFO] Replacing original artifact with shaded artifact.
[INFO] Replacing
/builddir/build/BUILD/jetty-alpn-alpn-project-8.1.9.v20160720/alpn-boot/target/alpn-boot-8.1.9.v20160720.jar
with
/builddir/build/BUILD/jetty-alpn-alpn-project-8.1.9.v20160720/alpn-boot/target/alpn-boot-8.1.9.v20160720-shaded.jar
[INFO] Dependency-reduced POM written at:
/builddir/build/BUILD/jetty-alpn-alpn-project-8.1.9.v20160720/alpn-boot/dependency-reduced-pom.xml"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #7 from gil cattaneo  ---
Issues:

[?]: Package contains the mandatory BuildRequires and Requires:.
 Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`";
 echo $version)) missing?
for gasnet_trace.pl

unused-direct-shlib-dependency and undefined-non-weak-symbol should be fixes
replacing "-shared" with "-Wl,--as-needed"

NON blocking issues:
[!]: Latest version is packaged.
 Is available: gasnet-1.27.5, gasnet-1.28.0-rc1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378021] Review Request: jetty-alpn - Jetty implementation of ALPN API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378021



--- Comment #9 from gil cattaneo  ---
(In reply to Michael Simacek from comment #6)
> (In reply to gil cattaneo from comment #5)
> > Issues:
> > [!]: Package contains no bundled libraries without FPC exception.
> >  See maven-shade-plugin and maven-bundle-plugin tasks
> 
> Removed maven-shade-plugin.
> maven-bundle-plugin is for generating OSGi bundles, those are not bundling,
> they are just named like that.
yes but the export/import configuration are wrong:
"org.eclipse.jetty.alpn;sun.security.ssl;version="${parsedVersion.majorVersion}.${parsedVersion.minorVersion}.${parsedVersion.incrementalVersion}""

should be:
"sun.security.ssl;version="${parsedVersion.majorVersion}.${parsedVersion.minorVersion}.${parsedVersion.incrementalVersion}"
!sun.*,org.eclipse.jetty.alpn"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445

Fl@sh  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|alex.mail.1...@gmail.com



--- Comment #2 from Fl@sh  ---

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
 Note: Using prebuilt packages// << scratch build is present
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL", "LGPL (v2 or later)", "GPL (v2 or later)", "Unknown or
 generated". 46 files have unknown license. Detailed output of
 licensecheck in /home/Flash/Downloads/review-
 kf5-kirigami/licensecheck.txt // << used common LGPLv2 license
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
 Note: Using prebuilt rpms.// << scratch build is present
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 901120 bytes in 66 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.

= SHOULD items =

Generic:
[x]: Reviewer should test that the package builds in mock.
 // << scratch build is present
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and 

[Bug 1378740] Review Request: python-pytest-faulthandler - py.test plugin that activates the fault handler module for tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378740



--- Comment #2 from Dominika Krejčí  ---
Fixed:

Spec URL:
https://dkrejci.fedorapeople.org/python-pytest-faulthandler/python-pytest-faulthandler.spec
SRPM URL:
https://dkrejci.fedorapeople.org/python-pytest-faulthandler/python-pytest-faulthandler-1.3.0-1.fc24.src.rpm

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15761562

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1332052] Review Request: python-filelock - A platform independent file lock

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332052



--- Comment #7 from Fedora Update System  ---
python-filelock-2.0.6-1.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-cb33a5937b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378021] Review Request: jetty-alpn - Jetty implementation of ALPN API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378021



--- Comment #11 from Michael Simacek  ---
Done

Spec URL: https://msimacek.fedorapeople.org/jetty-alpn.spec
SRPM URL:
https://msimacek.fedorapeople.org/jetty-alpn-8.1.9-3.v20160720.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445



--- Comment #3 from Rex Dieter  ---
Spec URL: https://rdieter.fedorapeople.org/rpms/kf5/kf5-kirigami.spec
SRPM URL:
https://rdieter.fedorapeople.org/rpms/kf5/kf5-kirigami-1.0.2-2.fc24.src.rpm

%changelog
* Fri Sep 23 2016 Rex Dieter  - 1.0.2-2
- refresh spec/srpm for review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-kirigami

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378077] Review Request: jetty-test-helper - Jetty toolchain test helper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378077



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/jetty-test-helper

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378021] Review Request: jetty-alpn - Jetty implementation of ALPN API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378021

gil cattaneo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #12 from gil cattaneo  ---
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378860] Review Request: jetty-setuid - SetUID support for jetty

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378860

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it



--- Comment #1 from gil cattaneo  ---
hi
sorry for the noise, some hints:
License field is wrong:
EPL-1.0
---
jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/jetty-setuid-java/src/main/java/org/eclipse/jetty/setuid/Group.java
jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/jetty-setuid-java/src/main/java/org/eclipse/jetty/setuid/Passwd.java
jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/jetty-setuid-java/src/main/java/org/eclipse/jetty/setuid/RLimit.java
jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/jetty-setuid-java/src/main/java/org/eclipse/jetty/setuid/SetUID.java
jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/jetty-setuid-java/src/main/java/org/eclipse/jetty/setuid/SetUIDListener.java
jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/jetty-setuid-java/src/main/java/org/eclipse/jetty/setuid/SetUIDServer.java
jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/jetty-setuid-native/src/main/resources/org_eclipse_jetty_setuid_SetUID.c
rpmlint output:
Checking: jetty-setuid-1.0.3-1.fc26.i686.rpm
  jetty-setuid-javadoc-1.0.3-1.fc26.i686.rpm
  jetty-setuid-1.0.3-1.fc26.src.rpm
jetty-setuid.i686: W: unstripped-binary-or-object
/usr/lib/java/jetty-setuid/libsetuid-linux.so
jetty-setuid.i686: E: missing-call-to-setgroups-before-setuid
/usr/lib/java/jetty-setuid/libsetuid-linux.so
jetty-setuid.src: W: file-size-mismatch LICENSE-eplv10-aslv20.html = 280721,
https://raw.githubusercontent.com/eclipse/jetty.project/jetty-9.3.x/LICENSE-eplv10-aslv20.html
= 30012
3 packages and 0 specfiles checked; 1 errors, 2 warnings.

libsetuid-linux have these entries:

-shared -lc
-ldl
maybe you shoukd change with:
-Wl --as-needed -lc
-ldl
for avoid "unused-direct-shlib-dependency and undefined-non-weak-symbol"

jetty-setuid-native artifact contains only the generated C files used for build
the jni library only, maybe you could remove

   maven-dependency-plugin

  
unpack
generate-resources

  unpack


  

  org.eclipse.jetty.toolchain.setuid
  jetty-setuid-native
  ${project.version}
  true
  ${native-source-dir}/

  

  

  
  
org.codehaus.mojo
native-maven-plugin
 ...
  
  

  org.eclipse.jetty.toolchain
  jetty-test-helper
  ${jetty-test-helper-version}
  test


  org.eclipse.jetty.toolchain.setuid
  jetty-setuid-java
  ${project.version}
-
-
-  org.eclipse.jetty.toolchain.setuid
-  jetty-setuid-native
-  ${project.version}


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445

Rex Dieter  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-09-23 10:04:56



--- Comment #6 from Rex Dieter  ---
imported, thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376899] Review Request: pcaudiolib - Portable C Audio Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376899



--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/pcaudiolib

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445

Fl@sh  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Fl@sh  ---
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378860] Review Request: jetty-setuid - SetUID support for jetty

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378860

Michael Simacek  changed:

   What|Removed |Added

 Depends On||1378077




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1378077
[Bug 1378077] Review Request: jetty-test-helper - Jetty toolchain test
helper
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378077] Review Request: jetty-test-helper - Jetty toolchain test helper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378077

Michael Simacek  changed:

   What|Removed |Added

 Blocks||1378860




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1378860
[Bug 1378860] Review Request: jetty-setuid - SetUID support for jetty
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378860] Review Request: jetty-setuid - SetUID support for jetty

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378860



--- Comment #2 from gil cattaneo  ---
(In reply to gil cattaneo from comment #1)
> hi
> sorry for the noise, some hints:
> License field is wrong:
> EPL-1.0
Sorry, my mistake, license field is correct

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378860] Review Request: jetty-setuid - SetUID support for jetty

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378860



--- Comment #3 from gil cattaneo  ---
(In reply to gil cattaneo from comment #1)
> rpmlint output:
> Checking: jetty-setuid-1.0.3-1.fc26.i686.rpm
>   jetty-setuid-javadoc-1.0.3-1.fc26.i686.rpm
>   jetty-setuid-1.0.3-1.fc26.src.rpm
> jetty-setuid.i686: W: unstripped-binary-or-object
> /usr/lib/java/jetty-setuid/libsetuid-linux.so
> jetty-setuid.i686: E: missing-call-to-setgroups-before-setuid
> /usr/lib/java/jetty-setuid/libsetuid-linux.so
> jetty-setuid.src: W: file-size-mismatch LICENSE-eplv10-aslv20.html = 280721,
> https://raw.githubusercontent.com/eclipse/jetty.project/jetty-9.3.x/LICENSE-
> eplv10-aslv20.html = 30012
> 3 packages and 0 specfiles checked; 1 errors, 2 warnings.
> 
> libsetuid-linux have these entries:
> 
> -shared -lc
> -ldl
> maybe you shoukd change with:
> -Wl --as-needed -lc
> -ldl
> for avoid "unused-direct-shlib-dependency and undefined-non-weak-symbol"
Do not work

[INFO] --- native-maven-plugin:1.0-alpha-8:link (default-link) @
libsetuid-linux ---
[INFO] /bin/sh -c cd
'/home/gil/rpmbuild/BUILD/jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/libsetuid-linux'
&& 'gcc' '-Wl' '--as-needed' '-lc' '-ldl' '-o'
'/home/gil/rpmbuild/BUILD/jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/libsetuid-linux/target/libsetuid-linux.so'
'target/objs/org_eclipse_jetty_setuid_SetUID.o' '-o'
'/home/gil/rpmbuild/BUILD/jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/libsetuid-linux/target/libsetuid-linux.so'
gcc: error: unrecognized command line option '-Wl'; did you mean '-W'?
gcc: error: unrecognized command line option '--as-needed'

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373486] Review Request: python34 - Version 3.4 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373486

Charalampos Stratakis  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378021] Review Request: jetty-alpn - Jetty implementation of ALPN API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378021



--- Comment #13 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/jetty-alpn

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1368623] Review Request: python-hamcrest - Hamcrest matchers for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368623



--- Comment #8 from Fedora Update System  ---
python-hamcrest-1.8.5-2.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373487] Review Request: python33 - Version 3.3 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373487

Charalampos Stratakis  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376207] Review Request: python-fedmsg-atomic-composer - Composes atomic trees when Fedora repositories are updated

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376207

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-09-23 12:19:34



--- Comment #14 from Fedora Update System  ---
python-fedmsg-atomic-composer-2016.2-2.fc24 has been pushed to the Fedora 24
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290337] Review Request: ed25519-java - Implementation of EdDSA ( Ed25519) in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290337

Christoph Junghans  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373486] Review Request: python34 - Version 3.4 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373486

Charalampos Stratakis  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Charalampos Stratakis  ---
Package is updated to 3.4.5, the latest version of Python 3.4 upstream.

Rewheel mode is disabled.

Debug build is disabled.

Package is flat, meaning that there are no subpackages, all the files and
directories are at the main package.

Most binaries, as well as libraries and man pages are removed or renamed so
they do not conflict with the system python3 package. The binary for this
package is renamed to python34.

python(abi) is not required/provided.

setuptools and pip come bundled with this package, so to comply with the
packaging guidelines virtual provides are added.

%{pylibdir} gets expanded to %{_libdir}/python3.4 so it will not conflict with
%{_libdir}/python3.5 at F24+ (or %{_libdir}/python3.6 in the future at F26+).

Tested on F24, F25 and rawhide VM's. No regressions noted.

'python3' command fires up the python 3.5.1 (F24) or 3.5.2 (F25+)  shell and
'python34' the 3.4.5 shell.

There were no upgrade paths issues and the package name does not conflict with
anything so far for branches that it is intended to be built against

Package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971



--- Comment #3 from Luya Tshimbalanga  ---
(In reply to stan from comment #2)
> I don't know if it helps, but I saw your message asking for review and
> decided to try these packages.  I am not a reviewer, but I am running f25. 
> I was able to build the rpms locally from the src.rpm above, and install
> them successfully.  For what it is worth.

Good to hear.
If you are interested, please read the document about the reviewer guideline:
https://fedoraproject.org/wiki/Package_Review_Process#Reviewer

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it
   Assignee|nob...@fedoraproject.org|punto...@libero.it
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971



--- Comment #4 from gil cattaneo  ---
have time for this https://bugzilla.redhat.com/show_bug.cgi?id=1290339 ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1370473] Review Request: python-fauxquests - Mock HTTP requests sent with the requests package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370473



--- Comment #11 from Fedora Update System  ---
python-fauxquests-1.1-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1370469] Review Request: python-dict-sorted - Dictionaries sorted by key or by comparison function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370469



--- Comment #11 from Fedora Update System  ---
python-dict-sorted-1.0.0-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #5 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 4 files have unknown license. Detailed
 output of licensecheck in
 /home/gil/1378971-f25-backgrounds/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[?]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/xfce4/backdrops
[?]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gnome-background-
 properties, /usr/share/mate-background-properties,
 /usr/share/xfce4/backdrops
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in f25
 -backgrounds-base , f25-backgrounds-kde , f25-backgrounds-gnome , f25
 -backgrounds-mate , f25-backgrounds-xfce
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into 

[Bug 1378971] New: Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971

Bug ID: 1378971
   Summary: Review Request: f25-backgrounds - Fedora 25 default
desktop background
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: l...@fedoraproject.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://luya.fedorapeople.org/packages/SPECS/f25-backgrounds.spec
SRPM URL:
https://luya.fedorapeople.org/packages/SRPMS/f25-backgrounds-25.0.0-1.fc24.src.rpm
Description: This package contains desktop backgrounds for the Fedora 25
default
theme.  Pulls in themes for GNOME, KDE, Mate and Xfce desktops.
Fedora Account System Username: luya

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1287802] Review Request: make_ext4fs - Create reproducible ext4 images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287802

Greg Swift  changed:

   What|Removed |Added

 CC||gregsw...@gmail.com



--- Comment #4 from Greg Swift  ---
fwiw: doesnt build in mock on f22 because it is missing a buildrequires for
zlib-devel

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971



--- Comment #1 from Luya Tshimbalanga  ---
Scratch build result:
http://koji.fedoraproject.org/koji/taskinfo?taskID=15770685

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1362487] Review Request: arcanist - A command line interface to Phabricator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362487



--- Comment #12 from Tim Flink  ---
Spec URL:
https://tflink.fedorapeople.org/packages/phabricator-review/arcanist/arcanist.spec
SRPM URL:
https://tflink.fedorapeople.org/packages/phabricator-review/arcanist/arcanist-20160806.gitc9337c2-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971

stan  changed:

   What|Removed |Added

 CC||gr...@q.com



--- Comment #2 from stan  ---
I don't know if it helps, but I saw your message asking for review and decided
to try these packages.  I am not a reviewer, but I am running f25.  I was able
to build the rpms locally from the src.rpm above, and install them
successfully.  For what it is worth.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1366047] Review Request: tss2 - IBM's TSS 2.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366047



--- Comment #27 from l...@us.ibm.com ---
Spec URL: https://fedorapeople.org/~honclo/tss2.spec
SRPM URL: https://fedorapeople.org/~honclo/tss2-713-4.el6.src.rpm

Description:

TSS2 is a user space Trusted Computing Group's Software Stack (TSS) for
TPM 2.0.  It implements the functionality equivalent to the TCG TSS
working group's ESAPI, SAPI, and TCTI layers (and perhaps more) but with
a hopefully far simpler interface.

It comes with about 80 "TPM tools" that can be used for rapid prototyping,
education and debugging. 

Fedora Account System Username: l...@us.ibm.com
Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15770811

This is my first package and I need a sponsor.  Thanks for all the comments
and review!


Here is the Rpmlint outputs:

# uname -a
Linux fed24vm 4.5.5-300.fc24.x86_64 #1 SMP Thu May 19 13:05:32 UTC 2016 x86_64
x86_64 x86_64 GNU/Linux

# rpmlint --version
rpmlint version 1.9 Copyright (C) 1999-2007 Frederic Lepied, Mandriva

# rpmlint tss2.spec ../RPMS/ ../SRPMS/
sh: /usr/bin/python: No such file or directory
tss2-devel.x86_64: W: only-non-binary-in-usr-lib
4 packages and 1 specfiles checked; 0 errors, 1 warnings.



%changelog
* Mon Sep 19 2016 Hon Ching(Vicky) Lo  - 713-4
- Used ExclusiveArch instead of BuildArch tag
- Removed attr from symlink in devel subpackage 
- Added manpages and modified the Source0
- Added CCFLAGS and LNFLAGS to enforce hardening and optimization


Vicky

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1366047] Review Request: tss2 - IBM's TSS 2.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366047



--- Comment #28 from l...@us.ibm.com ---
(In reply to Tomas Mraz from comment #26)
> (In reply to lo1 from comment #24)
> > The developer has been using nonstandard variables such as LNFLAGS (as
> > opposed to LDFLAGS) and CCFLAGS (for CFLAGS) etc.  There were other compile
> > flags such as CCLFLAGS for compiling library and CCAFLAGS for compiling
> > application.
> > 
> > Would that be OK to keep the naming of those nonstandard variables, while
> > I'm making sure that the build includes hardending and optimalization with
> > the RPM_OPT_FLAGS?
> 
Done.

I see that 2016-09-27 is the date for 100% Code Complete Deadline.  We don't
expect there is any more code change, once the package is accepted.  If it gets
accepted, are there any other steps that has to happen other than checking in
the code before 9/27 on my part?  I did see that the bug status has to be
ON_QA, but I wonder how long it'll take from package acceptance till the bug is
moved to ON_QA.  Please advise.


Thanks,
Vicky

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1362487] Review Request: arcanist - A command line interface to Phabricator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362487



--- Comment #13 from Tim Flink  ---
Note that the content is still the same, I just rebuilt the SRPM from sources
because the link in c#6 goes to a .noarch instead of a .src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374957] Review Request: python-colorspacious - Perform colorspace conversions accurately and easily

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374957

Tim Flink  changed:

   What|Removed |Added

 CC||tfl...@redhat.com
   Assignee|nob...@fedoraproject.org|tfl...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971



--- Comment #6 from gil cattaneo  ---
Issues:
- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.

NON blocking issues:
f25-backgrounds.noarch: W: incoherent-version-in-changelog 24.0.0-1
['25.0.0-1.fc26', '25.0.0-1']

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1362487] Review Request: arcanist - A command line interface to Phabricator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362487



--- Comment #14 from Jared Smith  ---
The version and release tags are still wrong.  As I mentioned in comment number
1 and in person at Flock, you should set the Version: tag to 0 and the Release:
tag to 0.1.20160806.git%{git_short_version_hash}%{dist} 

If you were to do a second build with that same git hash, it would then be
0.2.20160806.git%{git_short_version_hash}%{dist}, and so on.

This way, if/when a version 1.0 comes out, it will be greater than version
0.x.whatever.

See the Pre-release section of
https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidelines#NonNumericRelease
for more information on versioning of pre-releases, especially the example of
kismet in the pre-release section of that page

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290339] Review Request: curve25519-java - Implementation of Curve25519 in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290339

Luya Tshimbalanga  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||l...@fedoraproject.org
   Assignee|nob...@fedoraproject.org|l...@fedoraproject.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971



--- Comment #7 from gil cattaneo  ---
desktop-file-validate
~/1378971-f25-backgrounds/rpms-unpacked/f25-backgrounds-kde-25.0.0-1.fc26.noarch.rpm/usr/share/wallpapers/F25/metadata.desktop
/home/gil/1378971-f25-backgrounds/rpms-unpacked/f25-backgrounds-kde-25.0.0-1.fc26.noarch.rpm/usr/share/wallpapers/F25/metadata.desktop:

error: required key "Type" in group "Desktop Entry" is not present

Is usual for this kind of desktop file?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971



--- Comment #8 from Luya Tshimbalanga  ---
(In reply to gil cattaneo from comment #4)
> have time for this https://bugzilla.redhat.com/show_bug.cgi?id=1290339 ?

Taken.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1362490] Review Request: libphutil - A collection of PHP utility classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362490



--- Comment #24 from Jared Smith  ---
You're going to need to adjust the license tag on this package.  Licensecheck
found several licenses other than Apache in parts of the code base:

GPL (v3 or later)
-
libphutil-8f8e02d47569dce5f035383d8bcbf7a08481e839/support/xhpast/parser.yacc.cpp
libphutil-8f8e02d47569dce5f035383d8bcbf7a08481e839/support/xhpast/parser.yacc.hpp

MIT/X11 (BSD like)
--
libphutil-8f8e02d47569dce5f035383d8bcbf7a08481e839/externals/jsonlint/LICENSE

You should also set the Version: tag to 0 and the Release: tag to
0.1.20160806.git%{git_short_version_hash}%{dist} 

If you were to do a second build with that same git hash, it would then be
0.2.20160806.git%{git_short_version_hash}%{dist}, and so on.

This way, if/when a version 1.0 comes out, it will be greater than version
0.x.2016whatever.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1362487] Review Request: arcanist - A command line interface to Phabricator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362487



--- Comment #15 from Tim Flink  ---
Spec URL:
https://tflink.fedorapeople.org/packages/phabricator-review/arcanist/arcanist.spec
SRPM URL:
https://tflink.fedorapeople.org/packages/phabricator-review/arcanist/arcanist-0.0-2.20160806.gitc9337c2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971



--- Comment #9 from Luya Tshimbalanga  ---
(In reply to gil cattaneo from comment #7)
> desktop-file-validate
> ~/1378971-f25-backgrounds/rpms-unpacked/f25-backgrounds-kde-25.0.0-1.fc26.
> noarch.rpm/usr/share/wallpapers/F25/metadata.desktop
> /home/gil/1378971-f25-backgrounds/rpms-unpacked/f25-backgrounds-kde-25.0.0-1.
> fc26.noarch.rpm/usr/share/wallpapers/F25/metadata.desktop:
> 
> error: required key "Type" in group "Desktop Entry" is not present
> 
> Is usual for this kind of desktop file?

It is specific to KDE.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971

gil cattaneo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #10 from gil cattaneo  ---
(In reply to Luya Tshimbalanga from comment #9)
> (In reply to gil cattaneo from comment #7)
> > desktop-file-validate
> > ~/1378971-f25-backgrounds/rpms-unpacked/f25-backgrounds-kde-25.0.0-1.fc26.
> > noarch.rpm/usr/share/wallpapers/F25/metadata.desktop
> > /home/gil/1378971-f25-backgrounds/rpms-unpacked/f25-backgrounds-kde-25.0.0-1.
> > fc26.noarch.rpm/usr/share/wallpapers/F25/metadata.desktop:
> > 
> > error: required key "Type" in group "Desktop Entry" is not present
> > 
> > Is usual for this kind of desktop file?
> 
> It is specific to KDE.

Ok, fix changelog entry/ies before import
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org