[Bug 1538309] Review Request: python-google-auth - library for server-to-server authentication mechanisms to access Google APIs.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538309

Alfredo Moralejo  changed:

   What|Removed |Added

 Blocks||1486366 (RDO-QUEENS)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1486366
[Bug 1486366] Tracker: Blockers and Review requests for new RDO Queens
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538309] New: Review Request: python-google-auth - library for server-to-server authentication mechanisms to access Google APIs.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538309

Bug ID: 1538309
   Summary: Review Request: python-google-auth - library for
server-to-server authentication mechanisms to access
Google APIs.
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: amora...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://amoralej.fedorapeople.org/python-google-auth/python-google-auth.spec
SRPM URL:
https://amoralej.fedorapeople.org/python-google-auth/python-google-auth-1.3.0-1.fc26.src.rpm
Description:

This library simplifies using Google's various server-to-server authentication
mechanisms to access Google APIs.

It's a requirement for python-kubernetes >= 3.0.0
(https://github.com/kubernetes-client/python/blob/master/requirements.txt)

Scratch build in https://koji.fedoraproject.org/koji/taskinfo?taskID=24419665

Fedora Account System Username: amoralej

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538067] Review Request: nodejs-decimal-js - A Javascript library for arbitrary-precision arithmetic

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538067

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
 - Use the macro %{?nodejs_find_provides_and_requires} in the header for EPEL
compatibility. See
https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers#Automatic_Requires_and_Provides

 - You should download and run the tests in %check. See how it's done on
another SPEC: https://src.fedoraproject.org/rpms/nodejs-cheerio/tree/master →
i.e. using the dl-tests.sh script.

Basically it looks like this:

%{?nodejs_find_provides_and_requires}

# See https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers
%global npm_name decimal.js

%global enable_tests 1

Name:nodejs-decimal-js
Version:9.0.1
Release:1%{?dist}
Summary:A library for arbitrary-precision arithmetic

License:MIT
URL:https://github.com/MikeMcl/decimal.js/
Source0:http://registry.npmjs.org/%{npm_name}/-/%{npm_name}-%{version}.tgz
# The test files are not included in the npm tarball.
# Source{1-9} are generated by running Source10, which pulls from the upstream
# version control repository.
Source1:tests-%{version}.tar.bz2
Source10:dl-tests.sh
BuildArch:noarch
ExclusiveArch:%{nodejs_arches} noarch
BuildRequires:nodejs-packaging dos2unix

%description
A JavaScript library for arbitrary-precision decimal and non-decimal
arithmetic.

%prep
%setup -q -n package
# setup the tests
%setup -q -T -D -a 1 -n package
dos2unix README.md CHANGELOG.md

%build
# Nothing to do

%install
mkdir -p %{buildroot}%{nodejs_sitelib}/%{npm_name}
cp -pr package.json decimal.d.ts decimal.js decimal.min.js decimal.mjs \
   %{buildroot}%{nodejs_sitelib}/%{npm_name}
%nodejs_symlink_deps

%check
%{__nodejs} -e 'require("./")'
%if 0%{?enable_tests}
%__nodejs test/test.js
%else
%{_bindir}/echo -e "\e[101m -=#=- Tests disabled -=#=- \e[0m"
%endif


%files
%doc README.md CHANGELOG.md doc/API.html
%license LICENCE.md
%{nodejs_sitelib}/%{npm_name}

%changelog
* Thu Jan 18 2018 Timothée Floure  - 9.0.1-1
- Update to 9.0.1
- Remove the deprecated 'Group' tag
- Add the 'check' section to comply with packaging guidelines
- Fix end of line encoding for README.md and CHANGELOG.md

* Mon Jun 26 2017 Timothée Floure  - 7.2.3-1
- Let there be package





All ok otherwise:
 - Package builds in mock 
 - No RPMLint error
 - License ok
 - Latest version packaged

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538309] Review Request: python-google-auth - library for server-to-server authentication mechanisms to access Google APIs.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538309

Haïkel Guémar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||karlthe...@gmail.com
   Assignee|nob...@fedoraproject.org|karlthe...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538076] Review Request: insect - A scientific calculator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538076

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
 - Replace /usr/bin/env node with /usr/bin/node:

insect.noarch: E: wrong-script-interpreter
/usr/lib/node_modules/insect/index.js /usr/bin/env node

sed -i '1s/env //' index.js



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 363 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/insect/review-insect/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
 architectures.

[Bug 1538099] Review Request: rust-float-cmp - Floating point approximate comparison traits

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538099

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in mock
 - No rpmlint errors

Package approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433798] Review Request: nodejs-xdg-basedir - Get XDG Base Directory paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433798

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
 - Please bump to version 3

 - Remove: %{!?_licensedir:%global license %doc}

 - Add your own changelog entry

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #11 from Antonio Trande  ---
(In reply to Alexander Ploumistos from comment #10)
> Caught it:
> 
> diff 0.5.1-4/molsketch.spec 0.5.1-4b/molsketch.spec 
> 90c90
> < %{_libdir}/lib*.so.*
> ---
> > %{_libdir}/lib*.so*
> 
> If I revert that line to how it was before, it works. How should I proceed?

Can you post the output of

$ ldd -r /usr/bin/molsketch-qt5

?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433798] Review Request: nodejs-xdg-basedir - Get XDG Base Directory paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433798



--- Comment #2 from Robert-André Mauchin  ---
 - And add a basic %check, see
https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers#Build_testing_in_.25check

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536159] Review Request: openvswitch-ovn-kubernetes - Wedge between kubernetes and OVN

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536159

Phil Cameron  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-24 13:25:42



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538309] Review Request: python-google-auth - library for server-to-server authentication mechanisms to access Google APIs.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538309

Haïkel Guémar  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Haïkel Guémar  ---
Just a remark: BR: git can be moved to the top (avoid the duplication)

Approved.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
 (v2.0)". 52 files have unknown license. Detailed output of
 licensecheck in /home/hguemar/dist-git/rdo/openstack-glance/1538309
 -python-google-auth/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python2.7/site-
 packages/google, /usr/lib/python3.6/site-packages/google
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
 -google-auth , python3-google-auth
[x]: Package functions as described.
[x]: 

[Bug 1538341] New: Review Request: python-testinfra - unit testing for server state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538341

Bug ID: 1538341
   Summary: Review Request: python-testinfra - unit testing for
server state
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ble...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://wakko666.fedorapeople.org/python-testinfra/python-testinfra.spec
SRPM URL:
https://wakko666.fedorapeople.org/python-testinfra/python2-testinfra-1.10.1-1.fc28.src.rpm
Description: With Testinfra you can write unit tests in Python to test actual
state of your servers configured by management tools like Salt, Ansible,
Puppet, Chef and so on. Testinfra aims to be a Serverspec equivalent in python
and is written as a plugin to the powerful Pytest test engine

Fedora Account System Username: wakko666

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538355] Review Request: jackson-dataformats-binary - Jackson standard binary dataformat backends

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538355



--- Comment #1 from Mat Booth  ---
Koji rawhide scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24421790

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538110] Review Request: rust-phf_generator - PHF generation logic

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538110



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-phf_generator

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538188] Review Request: rust-cssparser - Rust implementation of CSS Syntax Level 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538188

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in mock
 - No rpmlint errors


You must include the LICENSE file with %license and README.md with %doc. I
trust you'll do this before import. Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538107] Review Request: rust-phf_shared - Support code shared by PHF libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538107



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-phf_shared

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538102] Review Request: rust-dtoa-short - Serialize float number and truncate to certain precision

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538102



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-dtoa-short

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538142] Review Request: rust-cssparser-macros - Procedural macros for cssparser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538142

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in mock
 - No rpmlint errors

Package approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #13 from Alexander Ploumistos  ---
Btw, that's from the last build with all the libraries -versioned &
unversioned- packaged.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538107] Review Request: rust-phf_shared - Support code shared by PHF libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538107

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in mock
 - No rpmlint errors

Package approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538135] Review Request: rust-phf_codegen - Codegen library for PHF types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538135

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in mock
 - No rpmlint errors

Package approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538097] Review Request: rust-downcast-rs - Trait object downcasting support using safe code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538097



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-downcast-rs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538173] Review Request: rust-difference - Rust text diffing and assertion library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538173

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in mock
 - No rpmlint errors

Package approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538097] Review Request: rust-downcast-rs - Trait object downcasting support using safe code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538097

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-24 17:58:21



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538173] Review Request: rust-difference - Rust text diffing and assertion library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538173



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-difference

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #10 from Alexander Ploumistos  ---
Caught it:

diff 0.5.1-4/molsketch.spec 0.5.1-4b/molsketch.spec 
90c90
< %{_libdir}/lib*.so.*
---
> %{_libdir}/lib*.so*

If I revert that line to how it was before, it works. How should I proceed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538097] Review Request: rust-downcast-rs - Trait object downcasting support using safe code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538097

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in mock
 - No rpmlint errors

Package approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538102] Review Request: rust-dtoa-short - Serialize float number and truncate to certain precision

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538102

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in mock
 - No rpmlint errors

Package approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538356] New: Review Request: jackson-dataformats-text - Jackson standard text-format dataformat backends

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538356

Bug ID: 1538356
   Summary: Review Request: jackson-dataformats-text - Jackson
standard text-format dataformat backends
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mat.bo...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://fedorapeople.org/~mbooth/reviews/jackson-dataformats-text.spec
SRPM URL:
https://fedorapeople.org/~mbooth/reviews/jackson-dataformats-text-2.9.4-1.fc28.src.rpm

Description:
Parent pom for Jackson text-format dataformats.

Fedora Account System Username: mbooth

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538355] New: Review Request: jackson-dataformats-binary - Jackson standard binary dataformat backends

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538355

Bug ID: 1538355
   Summary: Review Request: jackson-dataformats-binary - Jackson
standard binary dataformat backends
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mat.bo...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://fedorapeople.org/~mbooth/reviews/jackson-dataformats-binary.spec
SRPM URL:
https://fedorapeople.org/~mbooth/reviews/jackson-dataformats-binary-2.9.4-1.fc28.src.rpm

Description:
Parent pom for Jackson binary dataformats.

Fedora Account System Username: mbooth

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538110] Review Request: rust-phf_generator - PHF generation logic

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538110

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in mock
 - No rpmlint errors

Package approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538099] Review Request: rust-float-cmp - Floating point approximate comparison traits

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538099



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-float-cmp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538135] Review Request: rust-phf_codegen - Codegen library for PHF types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538135



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-phf_codegen

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538142] Review Request: rust-cssparser-macros - Procedural macros for cssparser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538142



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-cssparser-macros

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538356] Review Request: jackson-dataformats-text - Jackson standard text-format dataformat backends

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538356



--- Comment #1 from Mat Booth  ---
Koji rawhide scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24421788

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538178] Review Request: rust-phf - Runtime support for perfect hash function data structures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538178

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in mock
 - No rpmlint errors

Package approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538178] Review Request: rust-phf - Runtime support for perfect hash function data structures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538178



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-phf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #12 from Alexander Ploumistos  ---
(In reply to Antonio Trande from comment #11)
> Can you post the output of
> 
> $ ldd -r /usr/bin/molsketch-qt5
> 
> ?

linux-vdso.so.1 (0x7ffc76bb)
libmolsketch-qt5.so.0 => /lib64/libmolsketch-qt5.so.0 (0x7fd8e155c000)
libQt5PrintSupport.so.5 => /lib64/libQt5PrintSupport.so.5
(0x7fd8e12ee000)
libQt5Svg.so.5 => /lib64/libQt5Svg.so.5 (0x7fd8e1098000)
libQt5Widgets.so.5 => /lib64/libQt5Widgets.so.5 (0x7fd8e084c000)
libQt5Gui.so.5 => /lib64/libQt5Gui.so.5 (0x7fd8e018e000)
libQt5Network.so.5 => /lib64/libQt5Network.so.5 (0x7fd8dfe06000)
libQt5Core.so.5 => /lib64/libQt5Core.so.5 (0x7fd8df764000)
libGL.so.1 => /lib64/libGL.so.1 (0x7fd8df4d8000)
libpthread.so.0 => /lib64/libpthread.so.0 (0x7fd8df2b9000)
libstdc++.so.6 => /lib64/libstdc++.so.6 (0x7fd8def33000)
libm.so.6 => /lib64/libm.so.6 (0x7fd8debde000)
libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x7fd8de9c7000)
libc.so.6 => /lib64/libc.so.6 (0x7fd8de5e4000)
libz.so.1 => /lib64/libz.so.1 (0x7fd8de3cd000)
libpng16.so.16 => /lib64/libpng16.so.16 (0x7fd8de19a000)
libharfbuzz.so.0 => /lib64/libharfbuzz.so.0 (0x7fd8ddf02000)
libssl.so.1.1 => /lib64/libssl.so.1.1 (0x7fd8ddc96000)
libcrypto.so.1.1 => /lib64/libcrypto.so.1.1 (0x7fd8dd80e000)
libsystemd.so.0 => /lib64/libsystemd.so.0 (0x7fd8dd584000)
libicui18n.so.57 => /lib64/libicui18n.so.57 (0x7fd8dd111000)
libicuuc.so.57 => /lib64/libicuuc.so.57 (0x7fd8dcd6c000)
libicudata.so.57 => /lib64/libicudata.so.57 (0x7fd8db2ef000)
libpcre2-16.so.0 => /lib64/libpcre2-16.so.0 (0x7fd8db077000)
libdl.so.2 => /lib64/libdl.so.2 (0x7fd8dae73000)
libgthread-2.0.so.0 => /lib64/libgthread-2.0.so.0 (0x7fd8dac71000)
libglib-2.0.so.0 => /lib64/libglib-2.0.so.0 (0x7fd8da95d000)
/lib64/ld-linux-x86-64.so.2 (0x7fd8e1cf9000)
libGLX.so.0 => /lib64/libGLX.so.0 (0x7fd8da72b000)
libX11.so.6 => /lib64/libX11.so.6 (0x7fd8da3ed000)
libXext.so.6 => /lib64/libXext.so.6 (0x7fd8da1db000)
libGLdispatch.so.0 => /lib64/libGLdispatch.so.0 (0x7fd8d9f25000)
libfreetype.so.6 => /lib64/libfreetype.so.6 (0x7fd8d9c7)
libgraphite2.so.3 => /lib64/libgraphite2.so.3 (0x7fd8d9a44000)
libgcrypt.so.20 => /lib64/libgcrypt.so.20 (0x7fd8d972a000)
librt.so.1 => /lib64/librt.so.1 (0x7fd8d9522000)
liblzma.so.5 => /lib64/liblzma.so.5 (0x7fd8d92fc000)
liblz4.so.1 => /lib64/liblz4.so.1 (0x7fd8d90e7000)
libselinux.so.1 => /lib64/libselinux.so.1 (0x7fd8d8ebe000)
libpcre.so.1 => /lib64/libpcre.so.1 (0x7fd8d8c4b000)
libxcb.so.1 => /lib64/libxcb.so.1 (0x7fd8d8a23000)
libbz2.so.1 => /lib64/libbz2.so.1 (0x7fd8d8812000)
libgpg-error.so.0 => /lib64/libgpg-error.so.0 (0x7fd8d85fd000)
libpcre2-8.so.0 => /lib64/libpcre2-8.so.0 (0x7fd8d8379000)
libXau.so.6 => /lib64/libXau.so.6 (0x7fd8d8175000)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538135] Review Request: rust-phf_codegen - Codegen library for PHF types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538135
Bug 1538135 depends on bug 1538110, which changed state.

Bug 1538110 Summary: Review Request: rust-phf_generator - PHF generation logic
https://bugzilla.redhat.com/show_bug.cgi?id=1538110

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538188] Review Request: rust-cssparser - Rust implementation of CSS Syntax Level 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538188
Bug 1538188 depends on bug 1538142, which changed state.

Bug 1538142 Summary: Review Request: rust-cssparser-macros - Procedural macros 
for cssparser
https://bugzilla.redhat.com/show_bug.cgi?id=1538142

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538173] Review Request: rust-difference - Rust text diffing and assertion library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538173

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-25 02:01:54



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534799] Review Request: python-hdfs - HdfsCLI: API and command line interface for HDFS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534799

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
python-hdfs-2.1.0-2.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-c93c8b9950

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538178] Review Request: rust-phf - Runtime support for perfect hash function data structures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538178

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-25 02:01:49



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538142] Review Request: rust-cssparser-macros - Procedural macros for cssparser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538142

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-25 02:01:44



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520922] Review Request: extractpdfmark - Extract page mode and named destinations as PDFmark from PDF

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520922



--- Comment #7 from Igor Gnatenko  ---
> [!]: %build honors applicable compiler flags or justifies otherwise.
I don't see why, according to build.log it is fine.

> [!]: Package contains no bundled libraries without FPC exception.
There are no bundled libs as I can see.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538188] Review Request: rust-cssparser - Rust implementation of CSS Syntax Level 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538188
Bug 1538188 depends on bug 1538173, which changed state.

Bug 1538173 Summary: Review Request: rust-difference - Rust text diffing and 
assertion library
https://bugzilla.redhat.com/show_bug.cgi?id=1538173

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538188] Review Request: rust-cssparser - Rust implementation of CSS Syntax Level 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538188
Bug 1538188 depends on bug 1538178, which changed state.

Bug 1538178 Summary: Review Request: rust-phf - Runtime support for perfect 
hash function data structures
https://bugzilla.redhat.com/show_bug.cgi?id=1538178

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538135] Review Request: rust-phf_codegen - Codegen library for PHF types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538135

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-25 01:27:34



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538142] Review Request: rust-cssparser-macros - Procedural macros for cssparser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538142
Bug 1538142 depends on bug 1538135, which changed state.

Bug 1538135 Summary: Review Request: rust-phf_codegen - Codegen library for PHF 
types
https://bugzilla.redhat.com/show_bug.cgi?id=1538135

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538110] Review Request: rust-phf_generator - PHF generation logic

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538110

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-25 01:27:29



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538178] Review Request: rust-phf - Runtime support for perfect hash function data structures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538178
Bug 1538178 depends on bug 1538107, which changed state.

Bug 1538107 Summary: Review Request: rust-phf_shared - Support code shared by 
PHF libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1538107

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538110] Review Request: rust-phf_generator - PHF generation logic

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538110
Bug 1538110 depends on bug 1538107, which changed state.

Bug 1538107 Summary: Review Request: rust-phf_shared - Support code shared by 
PHF libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1538107

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538135] Review Request: rust-phf_codegen - Codegen library for PHF types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538135
Bug 1538135 depends on bug 1538107, which changed state.

Bug 1538107 Summary: Review Request: rust-phf_shared - Support code shared by 
PHF libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1538107

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538107] Review Request: rust-phf_shared - Support code shared by PHF libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538107

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-25 01:27:23



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538102] Review Request: rust-dtoa-short - Serialize float number and truncate to certain precision

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538102

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-25 01:27:17



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538099] Review Request: rust-float-cmp - Floating point approximate comparison traits

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538099

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-25 01:27:12



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538188] Review Request: rust-cssparser - Rust implementation of CSS Syntax Level 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538188
Bug 1538188 depends on bug 1538102, which changed state.

Bug 1538102 Summary: Review Request: rust-dtoa-short - Serialize float number 
and truncate to certain precision
https://bugzilla.redhat.com/show_bug.cgi?id=1538102

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538102] Review Request: rust-dtoa-short - Serialize float number and truncate to certain precision

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538102
Bug 1538102 depends on bug 1538099, which changed state.

Bug 1538099 Summary: Review Request: rust-float-cmp - Floating point 
approximate comparison traits
https://bugzilla.redhat.com/show_bug.cgi?id=1538099

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538110] Review Request: rust-phf_generator - PHF generation logic

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538110

Igor Gnatenko  changed:

   What|Removed |Added

 Depends On||1538107 (rust-phf_shared)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1538107
[Bug 1538107] Review Request: rust-phf_shared - Support code shared by PHF
libraries
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538135] Review Request: rust-phf_codegen - Codegen library for PHF types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538135

Igor Gnatenko  changed:

   What|Removed |Added

 Depends On||1538107 (rust-phf_shared),
   ||1538110
   ||(rust-phf_generator)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1538107
[Bug 1538107] Review Request: rust-phf_shared - Support code shared by PHF
libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1538110
[Bug 1538110] Review Request: rust-phf_generator - PHF generation logic
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538107] Review Request: rust-phf_shared - Support code shared by PHF libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538107

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1538110
   ||(rust-phf_generator)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1538110
[Bug 1538110] Review Request: rust-phf_generator - PHF generation logic
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538110] Review Request: rust-phf_generator - PHF generation logic

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538110

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1538135 (rust-phf_codegen)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1538135
[Bug 1538135] Review Request: rust-phf_codegen - Codegen library for PHF
types
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538107] Review Request: rust-phf_shared - Support code shared by PHF libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538107

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1538135 (rust-phf_codegen)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1538135
[Bug 1538135] Review Request: rust-phf_codegen - Codegen library for PHF
types
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537677] Review Request: nomad-firewall - UFW control module for KDE Plasma 5 and Nomad Desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537677



--- Comment #4 from Robert-André Mauchin  ---
>I don't like virtual BRs all that much, but I can make this change if you 
>think it is an improvement (but I should probably use the full list of used 
>modules then: e.g., the CMakeLists.txt uses more than just Qt5Core from 
>qt5-qtbase).

Please do.

> I think we should include as many digits as allowed of the commit hash to 
> avoid running into hash collisions.

That's unlikely but do as you wish, it's just the usual practice, not a
requirement per se.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538135] New: Review Request: rust-phf_codegen - Codegen library for PHF types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538135

Bug ID: 1538135
   Summary: Review Request: rust-phf_codegen - Codegen library for
PHF types
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-phf_codegen.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-phf_codegen-0.7.21-1.fc28.src.rpm
Description:
Codegen library for PHF types.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537403] Review Request: rust-intervaltree - Simple and generic implementation of an immutable interval tree

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537403



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-intervaltree

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538135] Review Request: rust-phf_codegen - Codegen library for PHF types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538135

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1538142
   ||(rust-cssparser-macros)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1538142
[Bug 1538142] Review Request: rust-cssparser-macros - Procedural macros for
cssparser
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538142] New: Review Request: rust-cssparser-macros - Procedural macros for cssparser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538142

Bug ID: 1538142
   Summary: Review Request: rust-cssparser-macros - Procedural
macros for cssparser
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-cssparser-macros.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-cssparser-macros-0.3.0-1.fc28.src.rpm
Description:
Procedural macros for cssparser.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538173] New: Review Request: rust-difference - Rust text diffing and assertion library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538173

Bug ID: 1538173
   Summary: Review Request: rust-difference - Rust text diffing
and assertion library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-difference.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-difference-2.0.0-1.fc28.src.rpm
Description:
Rust text diffing and assertion library.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537572] Review Request: corosync-qdevice - The Corosync Cluster Engine Qdevice

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537572

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
Package is approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
 generated", "MIT/X11 (BSD like)", "*No copyright* BSD (unspecified)",
 "BSD (3 clause)". 33 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/corosync-qdevice/review-
 corosync-qdevice/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /etc/corosync
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 corosync-qnetd
[?]: Package functions as described.
[x]: Latest version 

[Bug 1536565] Review Request: ntp-refclock - Drivers for hardware reference clocks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536565



--- Comment #3 from Miroslav Lichvar  ---
It was suggested on the list to use Provides: bundled(ntp) instead of adding
the ntp version to the release string.

Spec URL: https://mlichvar.fedorapeople.org/tmp/ntp-refclock.spec
SRPM URL: https://mlichvar.fedorapeople.org/tmp/ntp-refclock-0.1-2.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536565] Review Request: ntp-refclock - Drivers for hardware reference clocks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536565

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #4 from Robert-André Mauchin  ---
All good, package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538069] Review Request: nodejs-historic-readline - A JavaScript library extending the node readline module to save history to file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538069

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
 - Use the macro %{?nodejs_find_provides_and_requires} in the header for EPEL
compatibility. See
https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers#Automatic_Requires_and_Provides

 - Use %nodejs_symlink_deps at the end of %install. See
https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers#Symlinking_Dependencies.

 - Please consider asking upstream for a LICENSE file.


All ok otherwise:
 - Package builds in mock 
 - No RPMLint error
 - License ok
 - Latest version packaged

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536565] Review Request: ntp-refclock - Drivers for hardware reference clocks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536565



--- Comment #5 from Miroslav Lichvar  ---
Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536565] Review Request: ntp-refclock - Drivers for hardware reference clocks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536565



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ntp-refclock

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536780] Review Request: swift-lang - Apple' s Swift Programming Language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536780



--- Comment #9 from Ron Olson  ---
(In reply to Ron Olson from comment #8)
> I've been playing around with a downloaded copy of Swift in conjunction with
> an installed copy of lldb and I believe that the swift binary is explicitly
> looking for lldb in the same directory to run the REPL; I've asked on the
> Swift forums to confirm my findings. 
> 
> It seems that the copy of lldb is inclusive of existing functionality (i.e.
> I tested that it also debugs C/C++ executables as well), but that doesn't
> really matter insofar as it's not the same copy that ships with the existing
> lldb rpm. I believe the lldb that is included with Swift is essentially a
> fork with additional functionality to support Swift. 
> 
> I'd like to float the possibility of allowing the installation to be put in
> /opt/fedora per
> https://fedoraproject.org/wiki/Packaging:Guidelines#Limited_usage_of_.2Fopt.
> 2C_.2Fetc.2Fopt.2C_and_.2Fvar.2Fopt. I'm looking to get more
> information/confirmation from the Swift group before making the formal
> proposal.

I was looking at the wrong repo for llvm/lldb...they seem to have references to
Swift so I'm currently building the latest version of llvm/lldb and see what's
available; it may be possible to just tie Swift with a later version of LLDB so
that the two can coexist.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538259] New: Review Request: ocaml-lambda-term - Terminal manipulation library for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538259

Bug ID: 1538259
   Summary: Review Request: ocaml-lambda-term - Terminal
manipulation library for OCaml
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: rosser@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://tc01.fedorapeople.org/ocaml/utop/ocaml-lambda-term.spec
SRPM URL:
https://tc01.fedorapeople.org/ocaml/utop/ocaml-lambda-term-1.12.0-1.fc27.src.rpm

Description: Lambda-term is a cross-platform library for manipulating the
terminal. It
provides an abstraction for keys, mouse events, colors, as well as a set of
widgets to write curses-like applications.

The main objective of lambda-term is to provide a higher level functional
interface to terminal manipulation than, for example, ncurses, by providing
a native OCaml interface instead of bindings to a C library.

Fedora Account System Username: tc01

Now that opam (and therefore, opam-installer) is in Fedora, I can go ahead and
submit this. rpmlint found one obvious problem:

> ocaml-lambda-term.x86_64: E: missing-call-to-chdir-with-chroot 
> /usr/bin/lambda-term-actions

I am not entirely sure what to do about this, given that this is an OCaml
package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487067



--- Comment #27 from Benjamin Kircher  ---
If I can be of any help here, ping me (bkircher) on #fedora-devel or shoot me a
mail.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1500958] Review Request: python-kiwi-gtk - Framework for Python GUI applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1500958



--- Comment #6 from Haïkel Guémar  ---
Spec URL: https://hguemar.fedorapeople.org/reviews/python-kiwi-gtk.spec
SRPM URL:
https://hguemar.fedorapeople.org/reviews/python-kiwi-gtk-1.11.1-1.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520582] Review Request: perl-Mojolicious-Plugin-I18N - Internationalization Plugin for Mojolicious

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520582

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-01-24 04:57:50



--- Comment #15 from Fedora Update System  ---
perl-Mojolicious-Plugin-I18N-1.6-1.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536990] Review Request: openssl-ibmpkcs11 - IBM OpenSSL PKCS#11 engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536990



--- Comment #6 from Dan Horák  ---
Updated spec URL: http://fedora.danny.cz/openssl-ibmpkcs11.spec
Updated SRPM URL: http://fedora.danny.cz/openssl-ibmpkcs11-1.0.1-2.fc27.src.rpm

Changes:
- apply upstreamed fix for autotools
- don't hard-code %%enginesdir
- use simpler Source URL

The opencryptoki library is dlopen()-ed, so the rpmlint complaint bellow is not
valid. But I changed that to "R: opencryptoki-libs%{?_isa}" to be multilib
safe.
openssl-ibmpkcs11.x86_64: E: explicit-lib-dependency opencryptoki-libs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537805] Review Request: python-josepy - JOSE protocol implementation in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537805

James Hogarth  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|james.hoga...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537805] Review Request: python-josepy - JOSE protocol implementation in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537805

James Hogarth  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537805] Review Request: python-josepy - JOSE protocol implementation in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537805

James Hogarth  changed:

   What|Removed |Added

 Blocks||1535995
 Depends On|1535995 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1535995
[Bug 1535995] certbot-0.21.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537805] Review Request: python-josepy - JOSE protocol implementation in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537805

James Hogarth  changed:

   What|Removed |Added

 Depends On||1535995




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1535995
[Bug 1535995] certbot-0.21.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501522] Review Request: fdk-aac - Third-Party Modified Version of the Fraunhofer FDK AAC Codec Library for Android

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501522



--- Comment #66 from Kevin Kofler  ---
My point is that we should wait for what they actually say instead of assuming
things.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538107] New: Review Request: rust-phf_shared - Support code shared by PHF libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538107

Bug ID: 1538107
   Summary: Review Request: rust-phf_shared - Support code shared
by PHF libraries
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-phf_shared.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-phf_shared-0.7.21-1.fc28.src.rpm
Description:
Support code shared by PHF libraries.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538067] New: Review Request: nodejs-decimal-js - A Javascript library for arbitrary-precision arithmetic

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538067

Bug ID: 1538067
   Summary: Review Request: nodejs-decimal-js - A Javascript
library for arbitrary-precision arithmetic
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: timothee.flo...@fnux.ch
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://fedorapeople.org/~fnux/pkg-reviews/nodejs-decimal-js.spec
SRPM URL:
https://fedorapeople.org/~fnux/pkg-reviews/nodejs-decimal-js-9.0.1-1.fc26.src.rpm
Description: A JavaScript library for arbitrary-precision decimal and
non-decimal arithmetic.
Fedora Account System Username: fnux

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538069] New: Review Request: nodejs-historic-readline - A JavaScript library extending the node readline module to save history to file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538069

Bug ID: 1538069
   Summary: Review Request: nodejs-historic-readline - A
JavaScript library extending the node readline module
to save history to file
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: timothee.flo...@fnux.ch
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://fedorapeople.org/~fnux/pkg-reviews/nodejs-historic-readline.spec
SRPM URL:
https://fedorapeople.org/~fnux/pkg-reviews/nodejs-historic-readline-1.0.8-2.fc26.src.rpm
Description: A JavaScript library extending the node readline module to save
history to file.
Fedora Account System Username: fnux

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1500958] Review Request: python-kiwi-gtk - Framework for Python GUI applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1500958

Neal Gompa  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #7 from Neal Gompa  ---
Looks good to me.

Please make sure to change flumotion as noted in Comment 1 after completing the
rename.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538097] New: Review Request: rust-downcast-rs - Trait object downcasting support using safe code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538097

Bug ID: 1538097
   Summary: Review Request: rust-downcast-rs - Trait object
downcasting support using safe code
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-downcast-rs.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-downcast-rs-1.0.0-1.fc28.src.rpm
Description:
Trait object downcasting support using safe code.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538099] Review Request: rust-float-cmp - Floating point approximate comparison traits

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538099

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1538102 (rust-dtoa-short)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1538102
[Bug 1538102] Review Request: rust-dtoa-short - Serialize float number and
truncate to certain precision
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538102] Review Request: rust-dtoa-short - Serialize float number and truncate to certain precision

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538102

Igor Gnatenko  changed:

   What|Removed |Added

 Depends On||1538099 (rust-float-cmp)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1538099
[Bug 1538099] Review Request: rust-float-cmp - Floating point approximate
comparison traits
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537572] Review Request: corosync-qdevice - The Corosync Cluster Engine Qdevice

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537572



--- Comment #2 from Jan Friesse  ---
@Robert-André Mauchin:

Thank you a lot for the review.

I've fixed all issues with exception of 

BuildRequires: systemd-devel

because package is using libsystemd for sd_notify.

Fixed Spec URL:
https://honzaf.fedorapeople.org/corosync-qdevice/corosync-qdevice.spec
Fixed SRPM URL:
https://honzaf.fedorapeople.org/corosync-qdevice/corosync-qdevice-2.90.0-2.fc28.src.rpm
Fixed koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24414371

Thanks again for the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538076] New: Review Request: insect - A scientific calculator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538076

Bug ID: 1538076
   Summary: Review Request: insect - A scientific calculator
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: timothee.flo...@fnux.ch
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://fedorapeople.org/~fnux/pkg-reviews/insect.spec
SRPM URL:
https://fedorapeople.org/~fnux/pkg-reviews/insect-5.0.0-2.fc26.src.rpm
Description: High precision scientific calculator with support for physical
units
Fedora Account System Username: fnux

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538069] Review Request: nodejs-historic-readline - A JavaScript library extending the node readline module to save history to file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538069

Timothée Floure  changed:

   What|Removed |Added

 Blocks||1538076




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1538076
[Bug 1538076] Review Request: insect - A scientific calculator
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538067] Review Request: nodejs-decimal-js - A Javascript library for arbitrary-precision arithmetic

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538067

Timothée Floure  changed:

   What|Removed |Added

 Blocks||1538076




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1538076
[Bug 1538076] Review Request: insect - A scientific calculator
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538076] Review Request: insect - A scientific calculator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538076

Timothée Floure  changed:

   What|Removed |Added

 Depends On||1433798, 1538069, 1538067




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1433798
[Bug 1433798] Review Request: nodejs-xdg-basedir - Get XDG Base Directory
paths
https://bugzilla.redhat.com/show_bug.cgi?id=1538067
[Bug 1538067] Review Request: nodejs-decimal-js - A Javascript library for
arbitrary-precision arithmetic
https://bugzilla.redhat.com/show_bug.cgi?id=1538069
[Bug 1538069] Review Request: nodejs-historic-readline - A JavaScript
library extending the node readline module to save history to file
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433798] Review Request: nodejs-xdg-basedir - Get XDG Base Directory paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433798

Timothée Floure  changed:

   What|Removed |Added

 Blocks||1538076




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1538076
[Bug 1538076] Review Request: insect - A scientific calculator
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1500958] Review Request: python-kiwi-gtk - Framework for Python GUI applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1500958



--- Comment #8 from Neal Gompa  ---
This will require special attention by releng, because the git repository needs
to be renamed instead of you getting a new repository, otherwise I can't use
python-kiwi still.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org