[Bug 1570798] Review Request: nodejs-chai-cheerio - Cheerio assertions for the Chai assertion library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1570798

Jared Smith  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #2 from Jared Smith  ---
Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/6286.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1570763] Review Request: nodejs-mutate-fs - Mutate the filesystem behavior for tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1570763

Jared Smith  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #2 from Jared Smith  ---
Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/6287.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1570438] Review Request: nodejs-minipass - Minimal implementation of a PassThrough stream

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1570438

Jared Smith  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #2 from Jared Smith  ---
Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/6285.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1570827] Review Request: nodejs-glob-to-regexp - Convert globs to regular expressions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1570827

Jared Smith  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #2 from Jared Smith  ---
Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/6288.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1570928] Review Request: nodejs-wolfy87-eventemitter - Event based JavaScript for the browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1570928

Jared Smith  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #2 from Jared Smith  ---
Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/6290.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1570933] Review Request: nodejs-async-arrays - Async control for arrays

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1570933

Jared Smith  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #2 from Jared Smith  ---
Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/6292.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1570904] Review Request: nodejs-sift - Function for mongodb query style array filtering

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1570904

Jared Smith  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #2 from Jared Smith  ---
Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/6291.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1570929] Review Request: nodejs-extended-emitter - An emitter with expanded utility, UMD with dependencies for node and the browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1570929

Jared Smith  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #2 from Jared Smith  ---
Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/6293.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1570985] Review Request: nodejs-tv4 - A public domain JSON Schema validator for JavaScript

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1570985

Jared Smith  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #2 from Jared Smith  ---
Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/6296.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1571757] Review Request: squeezelite - Headless music player for streaming from Logitech Media Server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1571757

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #3 from Robert-André Mauchin  ---
 - You include DSD support, which is licensed under BSD, add it to the License
field and add a comment exblining the license breakdown.

 - Install the DSD license file too, you have to rename it first

mv dsd2pcm/LICENSE.txt dsd2pcm/LICENSE-dsd.txt

%license dsd2pcm/LICENSE-dsd.txt


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL", "GPL (v3 or later)", "Unknown or generated", "BSD (2
 clause) GPL (v3 or later)", "NTP", "ISC", "GPL (v2 or later) (with
 incorrect FSF address)", "BSD (2 clause)". 43 files have unknown
 license. Detailed output of licensecheck in
 /home/bob/packaging/review/squeezelite/review-
 squeezelite/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.

[Bug 1572229] New: Review Request: nodejs-debug-log - Node.js 0.12 util.debuglog() ponyfill

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572229

Bug ID: 1572229
   Summary: Review Request: nodejs-debug-log - Node.js 0.12
util.debuglog() ponyfill
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: jsmith.fed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Blocks: 956806 (nodejs-reviews), 1269538 (IoT)



Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-debug-log/nodejs-debug-log.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-debug-log/nodejs-debug-log-1.0.1-1.fc29.src.rpm
Description: Node.js 0.12 util.debuglog() ponyfill
Fedora Account System Username: jsmith


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1269538
[Bug 1269538] Tracker for IoT on Fedora
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1572035] Review Request: cohomCalg - Sheaf cohomologies for line bundles on toric varieties

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572035

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
 - How do you get/generate Source1? Add a comment explaining it.

 - Split the doc in a separate noarch subpackage.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 1064960 bytes in 2 files.
  See:
  http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "*No copyright* GPL (v3 or later)", "*No copyright* GPL (v3)",
 "Unknown or generated", "GPL (v3 or later)". 48 files have unknown
 license. Detailed output of licensecheck in
 /home/bob/packaging/review/cohomCalg/review-cohomCalg/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is 

[Bug 1571757] Review Request: squeezelite - Headless music player for streaming from Logitech Media Server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1571757



--- Comment #5 from Robert-André Mauchin  ---
(In reply to Peter Oliver from comment #4)
> Apologies, my understanding was that when you mixed GNU GPL with BSD then
> the result was GNU GPL.  I will update the License tag.
> 
> The existing LICENSE.txt includes the contents of dsd2pcm/LICENSE.txt.  Is
> it necessary to distribute both files?

No, you're right, one will be ok.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1570928] Review Request: nodejs-wolfy87-eventemitter - Event based JavaScript for the browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1570928



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nodejs-wolfy87-eventemitter

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1570763] Review Request: nodejs-mutate-fs - Mutate the filesystem behavior for tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1570763

Jared Smith  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-04-26 08:43:09



--- Comment #4 from Jared Smith  ---
Packaged in Rawhide, closing this issue

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1570798] Review Request: nodejs-chai-cheerio - Cheerio assertions for the Chai assertion library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1570798

Jared Smith  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-04-26 08:43:02



--- Comment #4 from Jared Smith  ---
Packaged in Rawhide, closing this issue

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1570438] Review Request: nodejs-minipass - Minimal implementation of a PassThrough stream

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1570438

Jared Smith  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-04-26 08:42:18



--- Comment #4 from Jared Smith  ---
Packaged in Rawhide, closing this issue

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1572070] Review Request: pass-otp - A pass extension for managing one-time-password (OTP) tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572070

Juan Orti  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-04-26 10:36:56



--- Comment #4 from Juan Orti  ---
Thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1571757] Review Request: squeezelite - Headless music player for streaming from Logitech Media Server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1571757



--- Comment #6 from Peter Oliver  ---
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/mavit/squeezelite/fedora-rawhide-x86_64/00745884-squeezelite/squeezelite-1.8.7.1083-5.20180425git8386ece.fc29.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1570438] Review Request: nodejs-minipass - Minimal implementation of a PassThrough stream

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1570438



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nodejs-minipass

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1570978] Review Request: nodejs-proclaim - A simple assertion library for server and client side JavaScript

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1570978



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nodejs-proclaim

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1570985] Review Request: nodejs-tv4 - A public domain JSON Schema validator for JavaScript

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1570985



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nodejs-tv4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1572007] Review Request: R-colorspace - Color Space Manipulation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572007

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
Package approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package have the default element marked as %%doc :doc, DESCRIPTION, NEWS,
  CITATION
- Package requires R-core.


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[ x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Unknown or generated". 96 files have unknown
 license. Detailed output of licensecheck in

/home/bob/packaging/review/R-colorspace/review-R-colorspace/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

R:
[x]: Package contains the mandatory BuildRequires.
[x]: The package has the standard %install section.

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.

[Bug 1571757] Review Request: squeezelite - Headless music player for streaming from Logitech Media Server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1571757



--- Comment #4 from Peter Oliver  ---
Apologies, my understanding was that when you mixed GNU GPL with BSD then the
result was GNU GPL.  I will update the License tag.

The existing LICENSE.txt includes the contents of dsd2pcm/LICENSE.txt.  Is it
necessary to distribute both files?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1570887] Review Request: nodejs-call-me-maybe - Let your JS API users either give you a callback or receive a promise

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1570887



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nodejs-call-me-maybe

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1572083] Review Request: rust-take_mut - Take a T from a T temporarily

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572083



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-take_mut

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1572070] Review Request: pass-otp - A pass extension for managing one-time-password (OTP) tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572070



--- Comment #7 from Fedora Update System  ---
pass-otp-1.1.0-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-32c6db863f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1570763] Review Request: nodejs-mutate-fs - Mutate the filesystem behavior for tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1570763



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nodejs-mutate-fs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1388908] Review Request: python-flask-bootstrap - Python flask bootstrap

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1388908



--- Comment #10 from David Hannequin  ---
Hi,

I fix license and summary issue. Could you approve ?

https://src.fedoraproject.org/rpms/python-flask-bootstrap

Best regard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1517451] Review Request: gnome-internet-radio-locator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1517451



--- Comment #7 from o...@gnome.org ---
Spec URL:
https://people.gnome.org/~ole/testing/SPECS/gnome-internet-radio-locator.spec
SRPM URL:
https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1.1-1.fc28.src.rpm
Description: Locate Internet Radio Stations
Fedora Account System Username: oka

I have built RPM packages for fc27 and fc28.

https://people.gnome.org/~ole/testing/RPMS/x86_64/gnome-internet-radio-locator-1.1.1-1.fc27.x86_64.rpm
https://people.gnome.org/~ole/testing/RPMS/x86_64/gnome-internet-radio-locator-1.1.1-1.fc28.x86_64.rpm

https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1.1-1.fc27.src.rpm
https://people.gnome.org/~ole/testing/SRPMS/gnome-internet-radio-locator-1.1.1-1.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1572183] Review Request: perl-Menlo-Legacy - Legacy internal and client support for Menlo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572183

Jitka Plesnikova  changed:

   What|Removed |Added

 Blocks||1572199




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1572199
[Bug 1572199] perl-App-cpm-0.971 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1570827] Review Request: nodejs-glob-to-regexp - Convert globs to regular expressions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1570827



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nodejs-glob-to-regexp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1570963] Review Request: nodejs-util-inspect - A cross-browser node.js util.inspect module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1570963



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nodejs-util-inspect

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1570929] Review Request: nodejs-extended-emitter - An emitter with expanded utility, UMD with dependencies for node and the browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1570929



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nodejs-extended-emitter

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1572083] Review Request: rust-take_mut - Take a T from a T temporarily

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572083

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in Mock
 - Conforms to the Packaging Guidelines

 - Fix the line encodings for the README file:

rust-take_mut-devel.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/rust-take_mut-devel/README.md

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1572070] Review Request: pass-otp - A pass extension for managing one-time-password (OTP) tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572070



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/pass-otp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1572070] Review Request: pass-otp - A pass extension for managing one-time-password (OTP) tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572070



--- Comment #5 from Fedora Update System  ---
pass-otp-1.1.0-2.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-1d308fc5f6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1572070] Review Request: pass-otp - A pass extension for managing one-time-password (OTP) tokens

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572070



--- Comment #6 from Fedora Update System  ---
pass-otp-1.1.0-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-5e09195603

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1572370] New: Review Request: nodejs-babel-plugin-syntax-async-generators - Allow parsing of async generator functions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572370

Bug ID: 1572370
   Summary: Review Request:
nodejs-babel-plugin-syntax-async-generators - Allow
parsing of async generator functions
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: jsmith.fed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Blocks: 956806 (nodejs-reviews), 1269538 (IoT)



Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-babel-plugin-syntax-async-generators/nodejs-babel-plugin-syntax-async-generators.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-babel-plugin-syntax-async-generators/nodejs-babel-plugin-syntax-async-generators-6.13.0-1.fc29.src.rpm
Description: Allow parsing of async generator functions
Fedora Account System Username: jsmith


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1269538
[Bug 1269538] Tracker for IoT on Fedora
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org