[Bug 1218779] Review Request: vagrant-triggers - Vagrant plugin to allow using arbitrary commands on host before /after Vagrant commands

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1218779

Vít Ondruch  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX
Last Closed||2018-05-11 04:05:35



--- Comment #14 from Vít Ondruch  ---
(In reply to Aron Griffis from comment #13)
> Functionality of vagrant-triggers has been merged into vagrant proper now
> 
> https://github.com/hashicorp/vagrant/pull/9713

Thx for the info. Because this has not moved forward a lot in past two years, I
believe it is save to close this as WONTFIX and focus on update of Vagrant (bug
1574756) instead.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1577011] Review Request: wiringpi - PIN based GPIO access library for BCM283x SoC devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1577011



--- Comment #3 from Peter Oliver  ---
Thanks for submitting this.  Here’s my review:

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Dist tag is present.  Use %{?dist} instead of %{dist}.  See
https://fedoraproject.org/wiki/Packaging:DistTag
- Development (unversioned) .so files in -devel subpackage, if present.
  Note: Unversioned so-files directly in %_libdir.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
  Files /usr/lib/libwiringPi.so and /usr/lib/libwiringPiDev.so are present in
both the libs and devel subpackages, but should only be in the devel
subpackage.
- ldconfig called in %post and %postun if required.
  Note: /sbin/ldconfig not called in wiringpi-libs
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries
  On Fedora 27 and earlier, a post-install scriptlet is required in the libs
subpackage.  
- Package uses hardened build flags if required to.
  Note: suid files: gpio and not %global _hardened_build
  See:
http://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Compiler_flags
- The licence can be left out of the main and devel subpackages, since both
depend on libs, which also contains the licence.
- The devel subpackage should mention %{?_isa} when it requires the libs
subpackage.  Perhaps the main package should require the libs subpackage in the
same way.
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Requiring_Base_Package
- Can this be built on all ARM flavours?  ExclusiveArch could be set to %{arm}
if so.
- rpmlint suggests that “WiringPi is” is left off the start of the Summary.
- Commit 8d188fa of WiringPi is tagged as version 2.46, which means the
“release version” guidelines rather than the “snapshot” guidelines of
https://fedoraproject.org/wiki/Packaging:Versioning should be followed (i.e.,
“.git%{commit_short}” can removed).
- It might be nice to install the examples as documentation in the devel
package.
- Could some of the Makefile changes be submitted upstream?

= MUST items =

C/C++:
[-]: Provides: bundled(gnulib) in place as required.
 Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
 Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: There is no build directory. Running licensecheck on vanilla
 upstream sources. No licenses found. Please check the source files for
 licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
 Note: Using prebuilt rpms.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[!]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package 

[Bug 1576413] Review Request: boom-boot - boot manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1576413



--- Comment #3 from Marian Csontos  ---
I have made the package slightly more non-compliant, adding these:

python3-boom.noarch: W: non-etc-or-var-file-marked-as-conffile
/boot/boom/boom.conf
python3-boom.noarch: W: non-etc-or-var-file-marked-as-conffile
/boot/boom/profiles/21e37c8002f33c177524192b15d91dc9612343a3-ubuntu16.04.profile
python3-boom.noarch: W: non-etc-or-var-file-marked-as-conffile
/boot/boom/profiles/3fc389bba581e5b20c6a46c7fc31b04be465e973-rhel7.2.profile
python3-boom.noarch: W: non-etc-or-var-file-marked-as-conffile
/boot/boom/profiles/9736c347ccb724368be04e51bb25687a361e535c-fedora25.profile
python3-boom.noarch: W: non-etc-or-var-file-marked-as-conffile
/boot/boom/profiles/98c3edb94b7b3c8c95cb7d93f75693d2b25f764d-rhel6.profile
python3-boom.noarch: W: non-etc-or-var-file-marked-as-conffile
/boot/boom/profiles/9cb53ddda889d6285fd9ab985a4c47025884999f-fedora24.profile
python3-boom.noarch: W: non-etc-or-var-file-marked-as-conffile
/boot/boom/profiles/c0b921ea84dbc5259477cbff7a15b000dd222671-rhel7.profile
python3-boom.noarch: W: non-etc-or-var-file-marked-as-conffile
/boot/boom/profiles/d4439b7d2f928c39f1160c0b0291407e5990b9e0-fedora26.profile
python3-boom.noarch: W: non-etc-or-var-file-marked-as-conffile
/boot/boom/profiles/efd6d41ee868310fec02d25925688e4840a7869a-rhel4.profile

Files in /boot must be treated as config files. These are supposed to be edited
by user, and must be in /boot to ensure they are shared among all snapshots
and/or operating systems.

The precedent for this is grub2, which has the same reasons for placing files
in /boot and using %config for those.

I have also added Conflict, and dependencies (Requires: and Suggests:)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1577011] Review Request: wiringpi - PIN based GPIO access library for BCM283x SoC devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1577011

Peter Oliver  changed:

   What|Removed |Added

 CC||ma...@mavit.org.uk



--- Comment #2 from Peter Oliver  ---
You need to link directly to the spec, not to a web page containing the text of
the spec, so that it can be read directly by the fedora-review tool.

Spec URL: https://raw.githubusercontent.com/agrez/wiringpi/master/wiringpi.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1576056] Review Request: python-pyte - Simple VTXXX-compatible linux terminal emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1576056

Guido Aulisi  changed:

   What|Removed |Added

 CC||guido.aul...@gmail.com



--- Comment #1 from Guido Aulisi  ---
This is an informal preliminary review.

You should use raw content for spec files, so fedora-review can use them.
Spec URL should be:
https://gitlab.com/mati865/pyte-fedora/raw/master/python-pyte.spec

I think license should be  LGPLv3+

Description lines are too long, please wrap them.

Different spec files in url and in SRPM

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1577011] Review Request: wiringpi - PIN based GPIO access library for BCM283x SoC devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1577011

Peter Oliver  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|ma...@mavit.org.uk
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1576519] Review Request: golang-github-ema-qdisc - qdisc allows to get queuing discipline information via netlink

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1576519



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-ema-qdisc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1575142] Review Request: python-ansible-runner - Tool to interface with ansible

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1575142



--- Comment #12 from Fedora Update System  ---
python-ansible-runner-1.0.1-1.el7 has been submitted as an update to Fedora
EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-5187aa95dd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1575142] Review Request: python-ansible-runner - Tool to interface with ansible

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1575142

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1576056] Review Request: python-pyte - Simple VTXXX-compatible linux terminal emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1576056



--- Comment #2 from Mateusz Mikuła  ---
Thank you for help.

> I think license should be  LGPLv3+
I couldn't find like `or later` in the repository and it's listed as `LGPLv3`
on PyPI.

Addressed other things, cannot edit description so posting it here:


Spec URL: https://gitlab.com/mati865/pyte-fedora/raw/master/python-pyte.spec
SRPM URL:
https://gitlab.com/mati865/pyte-fedora/raw/master/python-pyte-0.8.0-1.fc28.src.rpm
Description:
It's an in memory VTXXX-compatible terminal emulator.
XXX stands for a series of video terminals,\
developed by DEC between 1970 and 1995.

Fedora Account System Username: mati865

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534052] Review Request: golang-github-mdlayher-netlink - Package netlink provides low-level access to Linux netlink sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534052



--- Comment #12 from Paul Gier  ---
Pagure repo has been created:
https://pagure.io/releng/fedora-scm-requests/issue/6509
Build is complete: https://koji.fedoraproject.org/koji/taskinfo?taskID=26895873

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1576413] Review Request: boom-boot - boot manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1576413



--- Comment #4 from Marian Csontos  ---
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=26891979
SRPM: https://mcsontos.fedorapeople.org/boom-boot/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534052] Review Request: golang-github-mdlayher-netlink - Package netlink provides low-level access to Linux netlink sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534052



--- Comment #10 from Paul Gier  ---
I made the requested changed, reported the failing tests upstream, and was able
to fix one of the tests so it no longer needs to be patched out.  Also
re-enabled the build (but skipped tests) on s390x.
https://koji.fedoraproject.org/koji/taskinfo?taskID=26883450

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1577217] New: Review Request: python-gitlab - Interact with GitLab API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1577217

Bug ID: 1577217
   Summary: Review Request: python-gitlab -  Interact with GitLab
API
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: steve.tray...@cern.ch
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://cern.ch/straylen/rpms/python-gitlab/python-gitlab.spec
SRPM URL:
http://cern.ch/straylen/rpms/python-gitlab/python-gitlab-1.3.0-1.fc28.src.rpm
Description:  Interact with GitLab API
Fedora Account System Username: stevetraylen

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534052] Review Request: golang-github-mdlayher-netlink - Package netlink provides low-level access to Linux netlink sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534052



--- Comment #11 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-mdlayher-netlink

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1577198] Review Request: python-httmock - mocking library for requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1577198

Steve Traylen  changed:

   What|Removed |Added

 Blocks||1577217




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1577217
[Bug 1577217] Review Request: python-gitlab -  Interact with GitLab API
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1577217] Review Request: python-gitlab - Interact with GitLab API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1577217

Steve Traylen  changed:

   What|Removed |Added

 Depends On||1577198




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1577198
[Bug 1577198] Review Request: python-httmock - mocking library for requests
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1577198] New: Review Request: python-httmock - mocking library for requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1577198

Bug ID: 1577198
   Summary: Review Request: python-httmock - mocking library for
requests
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: steve.tray...@cern.ch
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://cern.ch/straylen/rpms/python-httmock/python-httmock.spec
SRPM URL:
http://cern.ch/straylen/rpms/python-httmock/python-httmock-1.2.6-1.fc28.src.rpm
Description: A mocking library for requests
Fedora Account System Username: stevetraylen

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1572287] Review Request: nodejs-istanbul-lib-hook - Hooks for require , vm and script used in istanbul

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572287

Jared Smith  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-05-11 09:38:20



--- Comment #7 from Jared Smith  ---
Packaged in Rawhide, closing this issue

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1576282] Review Request: rust-pangocairo - Rust bindings for the PangoCairo library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1576282
Bug 1576282 depends on bug 1576264, which changed state.

Bug 1576264 Summary: Review Request: rust-pangocairo-sys - FFI bindings to 
PangoCairo
https://bugzilla.redhat.com/show_bug.cgi?id=1576264

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1576264] Review Request: rust-pangocairo-sys - FFI bindings to PangoCairo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1576264

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-05-11 04:03:22



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1576282] Review Request: rust-pangocairo - Rust bindings for the PangoCairo library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1576282

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-05-11 04:03:26



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1564716] Review Request: dionaea - Low interaction honeypot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1564716



--- Comment #27 from Fedora Update System  ---
dionaea-0.7.0-1.fc28 has been pushed to the Fedora 28 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-75b6619cd4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1576879] Review Request: ignition - First boot installer and configuration tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1576879



--- Comment #6 from Dusty Mabe  ---
I think I agree with derek here. seems like ignition isn't that useful without
the dracut modules so why not include them?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1576519] Review Request: golang-github-ema-qdisc - qdisc allows to get queuing discipline information via netlink

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1576519



--- Comment #3 from Paul Gier  ---
Spec file updated based on recommendations.
New rawhide build is complete:
https://koji.fedoraproject.org/koji/taskinfo?taskID=26898729

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1575601] Review Request: beakerlib-libraries - Beakerlib Libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1575601



--- Comment #4 from Artur Iwicki  ---
I'm not sure why you have three %defines at the top for the name, version and
release. If you put them in the tags (like "Version: 0.1"), you can use the
macros (e.g. "%{version}") later on without any issues.

>Release: 39.g764645d
This should end with the dist tag (e.g. "f27") - use "%{?dist}".

>%setup -n beakerlib-libraries
It's recommended to use a "quiet setup" - use the -q option.

>%install
>rm -rf %{buildroot}
Do not remove the buildroot at start of %install. [1]

>%clean
>rm -rf $RPM_BUILD_ROOT
Drop the %clean section completely. [1]

>rm -rf %{buildroot}
>rm -rf $RPM_BUILD_ROOT
Do not mix usages of %{buildroot} and $RPM_BUILD_ROOT. Pick one and stick to
it. [2]

>cp -rf * %{buildroot}%{libraries_path}
Use the -p option to preserve timestamps. [3]

There are some scripts (.sh) installed which do not have the executable bit
set: [4]
/usr/share/beakerlib-libraries/authconfig/Library/basic/lib.sh
/usr/share/beakerlib-libraries/bind/Library/bind-setup/lib.sh
/usr/share/beakerlib-libraries/distribution/Library/Cleanup/lib.sh
/usr/share/beakerlib-libraries/distribution/Library/Log/lib.sh
/usr/share/beakerlib-libraries/distribution/Library/RpmSnapshot/lib.sh
/usr/share/beakerlib-libraries/distribution/Library/dpcommon/lib.sh
/usr/share/beakerlib-libraries/distribution/Library/dump/lib.sh
/usr/share/beakerlib-libraries/distribution/Library/epel/lib.sh
/usr/share/beakerlib-libraries/distribution/Library/opts/lib.sh
/usr/share/beakerlib-libraries/distribution/Library/sundry/lib.sh
/usr/share/beakerlib-libraries/kernel/Library/base/lib-compat.sh
/usr/share/beakerlib-libraries/kernel/Library/base/lib.sh
/usr/share/beakerlib-libraries/nginx/Library/nginx/lib.sh
/usr/share/beakerlib-libraries/openssl/Library/certgen/lib.sh
/usr/share/beakerlib-libraries/openssl/Library/certgen/runtest.sh
/usr/share/beakerlib-libraries/perl/Library/subpackage/lib.sh
/usr/share/beakerlib-libraries/php/Library/utils/lib.sh
/usr/share/beakerlib-libraries/samba/Library/samba-bits/lib.sh
/usr/share/beakerlib-libraries/sos/Library/utils/lib.sh
/usr/share/beakerlib-libraries/squid/Library/squid/lib.sh
/usr/share/beakerlib-libraries/tuned/Library/basic/lib.sh
/usr/share/beakerlib-libraries/yum/Library/common-functions/lib.sh

There's also a single .c file with the executable bit set: [4]
/usr/share/beakerlib-libraries/kernel/Library/base/src/expendfdrun/expendfdrun.c

You should also add %changelog entries when making changes.

[1] https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
[2]
https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS
[3] https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps
[4] https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1576879] Review Request: ignition - First boot installer and configuration tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1576879



--- Comment #7 from Steve Milner  ---
In this case so that we can make the stream pull from dist-git to rebuild. If
we need to make more modifications to the spec then I'll suggest we move
towards direct building for the time being in the stream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1564716] Review Request: dionaea - Low interaction honeypot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1564716

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #26 from Fedora Update System  ---
dionaea-0.7.0-1.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-106e8d6871

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1576413] Review Request: boom-boot - boot manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1576413



--- Comment #5 from Neal Gompa  ---
Marian,

Is there a solid reason for these things being in /boot as content managed by
the package? Can they not be installed in more normal locations?

My understanding is that boom doesn't do any _real_ boot management functions,
and instead just generates configuration for loaders like GRUB2, rEFInd, or
sd-boot to use instead.

Thus, I don't see why I should allow non-compliant stuff like this like we do
for GRUB 2.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1573639] Review Request: R-httr - Tools for Working with URLs and HTTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1573639

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-05-11 16:27:53



--- Comment #8 from Fedora Update System  ---
R-httr-1.3.1-1.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1564716] Review Request: dionaea - Low interaction honeypot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1564716



--- Comment #28 from Fedora Update System  ---
dionaea-0.7.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-22358c60e4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1576879] Review Request: ignition - First boot installer and configuration tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1576879

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com



--- Comment #8 from Neal Gompa  ---
I have a couple of questions here:

1. Why are we disabling debuginfo? That has been working with Go for several
releases now.

2. My understanding is that ignition uses dracut modules and has dracut module
configuration too. I don't see it in the ignition source tree, though. Where is
it, and what will provide it? I would expect a dracut module subpackage, like
how other packages do it (e.g. kiwi).

I also think the changes that Colin requested in comment 1 need to be done as
well.

You also have an empty message entry in your %changelog. Please fix. :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1572929] Review Request: R-promises - Abstractions for Promise-Based Asynchronous Programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1572929

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-05-11 17:13:19



--- Comment #6 from Fedora Update System  ---
R-promises-1.0.1-1.fc28 has been pushed to the Fedora 28 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1573639] Review Request: R-httr - Tools for Working with URLs and HTTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1573639



--- Comment #9 from Fedora Update System  ---
R-httr-1.3.1-1.fc28 has been pushed to the Fedora 28 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1576413] Review Request: boom-boot - boot manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1576413



--- Comment #7 from Alasdair Kergon  ---
From the docs https://github.com/bmr-cymru/boom :

> Boom configuration data is stored in the /boot file system to permit
> the tool to be run from any booted instance of any installed operating system.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1576413] Review Request: boom-boot - boot manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1576413



--- Comment #6 from Alasdair Kergon  ---
Have you tried out using the package to swap between different environments or
snapshots? 

Whichever environment you choose to boot into - with different instances of
root volumes and data etc. - you need to be able to see the current version of
all the boom data.  So there isn't really anywhere else to put /boot/boom
unless you're going to start imposing filesystem layouts on people which would
defeat part of the reason for using boom.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1577404] Review Request: kaldi - A toolkit for speech recognition

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1577404

Alejandro Acosta  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1577404] New: Review Request: kaldi - A toolkit for speech recognition

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1577404

Bug ID: 1577404
   Summary: Review Request: kaldi - A toolkit for speech
recognition
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: alxacos...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://aacosta.fedorapeople.org/rpmdevel/kaldi-5.3.spec
SRPM URL: https://aacosta.fedorapeople.org/rpmdevel/kaldi-5.3-1.fc28.src.rpm
Description: Kaldi is a toolkit for speech recognition, intended for use by
speech recognition researchers and professionals.
Fedora Account System Username: aacosta

The koji build is located at
https://koji.fedoraproject.org/koji/taskinfo?taskID=26902190

This is my first package and I'm looking for a sponsor so I can join the
packagers group. I've been in Fedora since 2008, contributing as an Ambassador
and now I'm looking forward to expanding my contribution in this great project.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org