Re: [pacman-dev] Versioned packages

2016-09-20 Thread Eli Schwartz 
On 09/19/2016 11:49 AM, Gordian Edenhofer wrote:
> What about adding a new option to pacman's '-D, --database' operator
> which would enable users to rename packages and add a corresponding
> provide field. This would empower everyone to decide on their own which
> packages they want in different versions and which they don't want.
> Pacman would handle file conflicts as usual without introducing a new
> kind of packages. Plus it would avoid discussions about which package
> should be a dummy package and which shouldn't be.

Was that meant to be some sort of a joke? Because even Debian is not
that insane, AFAIK.

-- 
Eli Schwartz

Re: [pacman-dev] [PATCH v8 01/12] bacman: allow for multiple packages as arguments

2016-09-20 Thread Allan McRae 
On 09/09/16 16:21, Allan McRae wrote:
> Correct - most changes will be pulled from this patchset.  Just not the
> parallelization patches.  I will pull the other patches to my patchqueue
> branch soon.

You can now see what I intend to commit on my "bacman" branch:

https://git.archlinux.org/users/allan/pacman.git/log/?h=bacman

Allan

Re: [pacman-dev] [PATCH v8 11/12] bacman: add manual page

2016-09-20 Thread Allan McRae 
On 05/09/16 02:14, Gordian Edenhofer wrote:
> Signed-off-by: Gordian Edenhofer 

I made some minor wording changes and adjusted the examples section
formatting.

A

Re: [pacman-dev] [PATCH v8 10/12] bacman: add option to specify the number of jobs

2016-09-20 Thread Allan McRae 
On 05/09/16 02:14, Gordian Edenhofer wrote:
> Signed-off-by: Gordian Edenhofer 

As discussed, this will not be included.

A

Re: [pacman-dev] [PATCH v8 04/12] bacman: proper option handling

2016-09-20 Thread Allan McRae 
On 20/09/16 23:32, Allan McRae wrote:
> On 05/09/16 02:13, Gordian Edenhofer wrote:
>> Switch to parseopts instead of merely checking the first argument.
>>
>> Signed-off-by: Gordian Edenhofer 
> 
> OK.  I made minor modifications due to not include patch #3.
> 

Well...  I also had to fix:

- -m|--nocolor stopped working due to moving where colors were set up
- OPT_SHORT had an extra ":"

Re: [pacman-dev] [PATCH v8 07/12] bacman: quote pkg_pkger variable

2016-09-20 Thread Allan McRae 
On 05/09/16 02:14, Gordian Edenhofer wrote:
> Signed-off-by: Gordian Edenhofer 
> ---

OK.

Re: [pacman-dev] [PATCH v8 08/12] bacman: add option to print fewer status updates

2016-09-20 Thread Allan McRae 
On 05/09/16 02:14, Gordian Edenhofer wrote:
> Signed-off-by: Gordian Edenhofer 
> ---
>  contrib/bacman.sh.in | 8 ++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 

OK.

Re: [pacman-dev] [PATCH v8 06/12] bacman: code structuring

2016-09-20 Thread Allan McRae 
On 05/09/16 02:14, Gordian Edenhofer wrote:
> Adding and clarifying comments.
> Adding and removing some new lines.
> 
> Signed-off-by: Gordian Edenhofer 

OK.

Re: [pacman-dev] [PATCH v8 05/12] bacman: rewrite usage function

2016-09-20 Thread Allan McRae 
On 05/09/16 02:14, Gordian Edenhofer wrote:
> Signed-off-by: Gordian Edenhofer 
> ---
>  contrib/bacman.sh.in | 16 
>  1 file changed, 12 insertions(+), 4 deletions(-)
> 
> diff --git a/contrib/bacman.sh.in b/contrib/bacman.sh.in
> index e56f31b..5045d6e 100644
> --- a/contrib/bacman.sh.in
> +++ b/contrib/bacman.sh.in
> @@ -48,13 +48,21 @@ trap clean_up SIGHUP SIGINT SIGTERM
>  # User Friendliness
>  #
>  usage() {
> - echo "${myname} (pacman) v${myver}"
> + printf "%s (pacman) %s\n" "$myname" "$myver"
>   echo
> - echo "Recreate a package using pacman's database and system files"
> + printf -- "$(gettext "Recreate packages using pacman's database and 
> system files")\n"
>   echo
> - echo "Usage: ${myname} [--nocolor] [--pacnew] "
> + printf -- "$(gettext "Usage: %s [options] ")\n" "$0"
> + echo
> + printf -- "$(gettext "Options:")\n"
> + printf -- "$(gettext "  -h, --help   Show this help message and 
> exit")\n"
> + printf -- "$(gettext "  -m, --nocolorDisable colorized output 
> messages")\n"
> + printf -- "$(gettext "  --pacnew Package .pacnew files")\n"
> + echo
> + printf -- "$(gettext "Examples:  %s linux-headers")\n" "$myname"

Moved "Examples:" to its own line for formatting for later examples to
be consistent.

Removed gettext calls to non-translatable examples

> + printf -- "$(gettext "  %s --nocolor --pacnew gzip munge binutils")\n" 
> "$myname"
> + printf -- "$(gettext "  %s \$(pacman -Qsq)")\n" "$myname"

Minor modification...  Changed -Qsq to -Qq


>   echo
> - echo "Example: ${myname} linux-headers"
>  }
>  
>  version() {
>

Re: [pacman-dev] [PATCH v8 04/12] bacman: proper option handling

2016-09-20 Thread Allan McRae 
On 05/09/16 02:13, Gordian Edenhofer wrote:
> Switch to parseopts instead of merely checking the first argument.
> 
> Signed-off-by: Gordian Edenhofer 

OK.  I made minor modifications due to not include patch #3.

A

Re: [pacman-dev] [PATCH v8 02/12] bacman: handle SIGHUP, SIGINT, SIGTERM signals

2016-09-20 Thread Allan McRae 
On 05/09/16 02:13, Gordian Edenhofer wrote:
> Trap SIGHUP, SIGINT, SIGTERM and remove working directories accordingly.
> 
> Signed-off-by: Gordian Edenhofer 

OK

Re: [pacman-dev] [PATCH v8 01/12] bacman: allow for multiple packages as arguments

2016-09-20 Thread Allan McRae 
On 05/09/16 02:13, Gordian Edenhofer wrote:
> To enable the creation of multiple packages with one command move the
> assembly process into its own function.
> 
> Signed-off-by: Gordian Edenhofer 

OK

Re: [pacman-dev] [PATCH v8 03/12] bacman: parallel packaging

2016-09-20 Thread Allan McRae 
On 05/09/16 02:13, Gordian Edenhofer wrote:
> Signed-off-by: Gordian Edenhofer 

As discussed, this will not be pulled.

Re: [pacman-dev] [PATCH] Fix gcc strict-overflow error

2016-09-20 Thread Andrew Gregory 
On 09/20/16 at 10:50pm, Allan McRae wrote:
> On 18/09/16 01:13, Rikard Falkeborn wrote:
> > Recent gcc (tested with 6.2.1) produces the following error when
> > compiling with both --enable-warningflags and --enable-debug.
> > In particular, it seems it is the combination of GCC_STACK_PROTECT_LIB
> > and -Wstrict-overflow=5 produces the error.
> > 
> > be_local.c:609:4: error: assuming signed overflow does not occur
> >  when simplifying conditional
> >  [-Werror=strict-overflow]
> > if(count > 0) {
> > 
> > Fix this by changing the type of count from int to size_t, which is
> > fine since count is never negative.
> 
> Thanks.
> 
> I was a bit wary given we are still returning casting to an int in the
> return, but this brings the local db handling of counts in line with the
> sync_db function so doe snot make anything worse...
> 
> Allan

We don't actually use the returned count, so we could go ahead and
change the return for each function to a simple boolean.

apg

Re: [pacman-dev] [PATCH] Fix gcc strict-overflow error

2016-09-20 Thread Allan McRae 
On 18/09/16 01:13, Rikard Falkeborn wrote:
> Recent gcc (tested with 6.2.1) produces the following error when
> compiling with both --enable-warningflags and --enable-debug.
> In particular, it seems it is the combination of GCC_STACK_PROTECT_LIB
> and -Wstrict-overflow=5 produces the error.
> 
> be_local.c:609:4: error: assuming signed overflow does not occur
>  when simplifying conditional
>  [-Werror=strict-overflow]
> if(count > 0) {
> 
> Fix this by changing the type of count from int to size_t, which is
> fine since count is never negative.

Thanks.

I was a bit wary given we are still returning casting to an int in the
return, but this brings the local db handling of counts in line with the
sync_db function so doe snot make anything worse...

Allan