Re: [Paraview] paraview 3.10 + OpenFOAM
Hello David, Somewhat related to the above topic, this issue would also be important for the 3.10.1 update. http://paraview.org/Bug/view.php?id=11893 /mark ___ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview
Re: [Paraview] paraview 3.10 + OpenFOAM
This has been applied to release and master. Perfect! Thanks David and Takuya. Sorry I still didn't have time to compile and test it myself. /mark DISCLAIMER: This electronic transmission (and any attachments thereto) is intended solely for the use of the addressee(s). It may contain confidential or legally privileged information. If you are not the intended recipient of this message, you must delete it immediately and notify the sender. Any unauthorized use or disclosure of this message is strictly prohibited. Faurecia does not guarantee the integrity of this transmission and shall therefore never be liable if the message is altered or falsified nor for any virus, interception or damage to your system. ___ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview
Re: [Paraview] paraview 3.10 + OpenFOAM
Mark, looking forward to hearing your test results, that's where you can definitely contribute ;-) Takuya Takuya OSHIMA, Ph.D. Faculty of Engineering, Niigata University 8050 Ikarashi-Ninocho, Nishi-ku, Niigata, 950-2181, JAPAN This has been applied to release and master. Perfect! Thanks David and Takuya. Sorry I still didn't have time to compile and test it myself. /mark ___ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview
Re: [Paraview] paraview 3.10 + OpenFOAM
Hey Takuya and Mark, Do either of you have a dataset that could be included in ParaViewData to make a simple regression test that exercises this functionality? Thanks! On Thu, Mar 17, 2011 at 7:18 AM, Takuya OSHIMA osh...@eng.niigata-u.ac.jpwrote: Mark, looking forward to hearing your test results, that's where you can definitely contribute ;-) Takuya Takuya OSHIMA, Ph.D. Faculty of Engineering, Niigata University 8050 Ikarashi-Ninocho, Nishi-ku, Niigata, 950-2181, JAPAN This has been applied to release and master. Perfect! Thanks David and Takuya. Sorry I still didn't have time to compile and test it myself. /mark ___ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview
Re: [Paraview] paraview 3.10 + OpenFOAM
I have a dataset contributed by Mark but am not sure about its license. Mark, do you have any? Takuya Takuya OSHIMA, Ph.D. Faculty of Engineering, Niigata University 8050 Ikarashi-Ninocho, Nishi-ku, Niigata, 950-2181, JAPAN From: David Partyka david.part...@kitware.com Subject: Re: [Paraview] paraview 3.10 + OpenFOAM Date: Thu, 17 Mar 2011 07:47:06 -0400 Hey Takuya and Mark, Do either of you have a dataset that could be included in ParaViewData to make a simple regression test that exercises this functionality? Thanks! On Thu, Mar 17, 2011 at 7:18 AM, Takuya OSHIMA osh...@eng.niigata-u.ac.jpwrote: Mark, looking forward to hearing your test results, that's where you can definitely contribute ;-) Takuya Takuya OSHIMA, Ph.D. Faculty of Engineering, Niigata University 8050 Ikarashi-Ninocho, Nishi-ku, Niigata, 950-2181, JAPAN This has been applied to release and master. Perfect! Thanks David and Takuya. Sorry I still didn't have time to compile and test it myself. /mark ___ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview
Re: [Paraview] paraview 3.10 + OpenFOAM
Is there currently any particular OpenFOAM dataset being used for testing? If so, I could convert it into the compact-face format. Otherwise the dataset from Takuya (cavity tutorial I think) should be okay - there are no license issues. I have a dataset contributed by Mark but am not sure about its license. Mark, do you have any? DISCLAIMER: This electronic transmission (and any attachments thereto) is intended solely for the use of the addressee(s). It may contain confidential or legally privileged information. If you are not the intended recipient of this message, you must delete it immediately and notify the sender. Any unauthorized use or disclosure of this message is strictly prohibited. Faurecia does not guarantee the integrity of this transmission and shall therefore never be liable if the message is altered or falsified nor for any virus, interception or damage to your system. ___ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview
Re: [Paraview] paraview 3.10 + OpenFOAM
Yes the cavity tutorial. AFAIK there's no OpenFOAM dataset being used for testing ( http://paraview.org/Bug/view.php?id=10247 ), so I attached Mark's cavity dataset (with addition of a .foam stub). Dave, open cavity.foam in the archive and Apply. Takuya Takuya OSHIMA, Ph.D. Faculty of Engineering, Niigata University 8050 Ikarashi-Ninocho, Nishi-ku, Niigata, 950-2181, JAPAN From: OLESEN Mark mark.ole...@faurecia.com Subject: RE: [Paraview] paraview 3.10 + OpenFOAM Date: Thu, 17 Mar 2011 13:06:10 +0100 Is there currently any particular OpenFOAM dataset being used for testing? If so, I could convert it into the compact-face format. Otherwise the dataset from Takuya (cavity tutorial I think) should be okay - there are no license issues. I have a dataset contributed by Mark but am not sure about its license. Mark, do you have any? cavity.tar.bz2 Description: Binary data ___ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview
Re: [Paraview] paraview 3.10 + OpenFOAM
Excellent. Thank you! I'll make this into a regression test for ParaView. On Thu, Mar 17, 2011 at 8:34 AM, Takuya OSHIMA osh...@eng.niigata-u.ac.jpwrote: Yes the cavity tutorial. AFAIK there's no OpenFOAM dataset being used for testing ( http://paraview.org/Bug/view.php?id=10247 ), so I attached Mark's cavity dataset (with addition of a .foam stub). Dave, open cavity.foam in the archive and Apply. Takuya Takuya OSHIMA, Ph.D. Faculty of Engineering, Niigata University 8050 Ikarashi-Ninocho, Nishi-ku, Niigata, 950-2181, JAPAN From: OLESEN Mark mark.ole...@faurecia.com Subject: RE: [Paraview] paraview 3.10 + OpenFOAM Date: Thu, 17 Mar 2011 13:06:10 +0100 Is there currently any particular OpenFOAM dataset being used for testing? If so, I could convert it into the compact-face format. Otherwise the dataset from Takuya (cavity tutorial I think) should be okay - there are no license issues. I have a dataset contributed by Mark but am not sure about its license. Mark, do you have any? ___ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview
Re: [Paraview] paraview 3.10 + OpenFOAM
I filed a bug for this:
http://www.paraview.org/Bug/view.php?id=11974
The patch is also attached to this mail.
As Mark says it would be very important, so we really hope to see this
included in the upcoming 3.10.1 release.
Thanks!
Takuya
Takuya OSHIMA, Ph.D.
Faculty of Engineering, Niigata University
8050 Ikarashi-Ninocho, Nishi-ku, Niigata, 950-2181, JAPAN
From: David Partyka david.part...@kitware.com
Subject: Re: [Paraview] paraview 3.10 + OpenFOAM
Date: Fri, 11 Mar 2011 05:32:05 -0500
It was released two days ago ;-). Your patch most certainly could be
included for the next release. If you want, submit a bug on
paraview.org/Bugwith your patch, and possibly a dataset and
instructions to recreate the
original issue.
Thanks!
On Fri, Mar 11, 2011 at 3:21 AM, OLESEN Mark mark.ole...@faurecia.comwrote:
When is 3.10 slated for release?
I have a patch from Takuya OSHIMA for handling a compact face format in
OpenFOAM. It would be very important to get this in before the next release.
What tests are needed and what is the time-frame to squeezing in this type
of change before the 3.10 release?
/mark
DISCLAIMER:
This electronic transmission (and any attachments thereto) is intended
solely for the use of the addressee(s). It may contain confidential or
legally privileged information. If you are not the intended recipient of
this message, you must delete it immediately and notify the sender. Any
unauthorized use or disclosure of this message is strictly prohibited.
Faurecia does not guarantee the integrity of this transmission and shall
therefore never be liable if the message is altered or falsified nor for any
virus, interception or damage to your system.
___
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the ParaView Wiki at:
http://paraview.org/Wiki/ParaView
Follow this link to subscribe/unsubscribe:
http://www.paraview.org/mailman/listinfo/paraview
diff --git a/IO/vtkOpenFOAMReader.cxx b/IO/vtkOpenFOAMReader.cxx
index e9870cb..7445c6f 100644
--- a/IO/vtkOpenFOAMReader.cxx
+++ b/IO/vtkOpenFOAMReader.cxx
@@ -348,8 +348,6 @@ struct vtkFoamIntVectorVector
private:
vtkIntArray *Indices, *Body;
- vtkFoamIntVectorVector();
-
public:
~vtkFoamIntVectorVector()
{
@@ -363,6 +361,10 @@ public:
this-Indices-Register(0); // vtkDataArrays do not have ShallowCopy
this-Body-Register(0);
}
+ vtkFoamIntVectorVector() :
+Indices(vtkIntArray::New()), Body(vtkIntArray::New())
+ {
+ }
vtkFoamIntVectorVector(const int nElements, const int bodyLength) :
Indices(vtkIntArray::New()), Body(vtkIntArray::New())
{
@@ -2406,6 +2408,51 @@ public:
}
}
+ // reads compact list of labels.
+ void ReadCompactIOLabelList(vtkFoamIOobject io)
+ {
+if (io.GetFormat() != vtkFoamIOobject::BINARY)
+ {
+ this-ReadLabelListList(io);
+ return;
+ }
+
+this-Superclass::LabelListListPtr = new vtkFoamIntVectorVector;
+this-Superclass::Type = LABELLISTLIST;
+for(int arrayI = 0; arrayI 2; arrayI++)
+ {
+ vtkFoamToken currToken;
+ if (!io.Read(currToken))
+{
+throw vtkFoamError() Unexpected EOF;
+}
+ if (currToken.GetType() == vtkFoamToken::LABEL)
+{
+const int sizeI = currToken.Toint();
+if (sizeI 0)
+ {
+ throw vtkFoamError() List size must not be negative: size =
+ sizeI;
+ }
+if (sizeI 0) // avoid invalid reference
+ {
+ vtkIntArray *array = (arrayI == 0
+ ? this-Superclass::LabelListListPtr-GetIndices()
+ : this-Superclass::LabelListListPtr-GetBody());
+ array-SetNumberOfValues(sizeI);
+ io.ReadExpecting('(');
+ io.Read(reinterpret_castunsigned char*(array-GetPointer(0)),
+ sizeI * sizeof(int));
+ io.ReadExpecting(')');
+ }
+}
+ else
+{
+throw vtkFoamError() Expected integer, found currToken;
+}
+ }
+ }
+
bool ReadField(vtkFoamIOobject io)
{
try
@@ -4580,7 +4627,14 @@ vtkFoamIntVectorVector * vtkOpenFOAMReaderPrivate::ReadFacesFile(
vtkFoamEntryValue dict(NULL);
try
{
-dict.ReadLabelListList(io);
+if (io.GetClassName() == faceCompactList)
+ {
+ dict.ReadCompactIOLabelList(io);
+ }
+else
+ {
+ dict.ReadLabelListList(io);
+ }
}
catch(vtkFoamError e)
{
___
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the ParaView Wiki at:
http://paraview.org/Wiki/ParaView
Follow this link to subscribe/unsubscribe:
http://www.paraview.org/mailman/listinfo/paraview
Re: [Paraview] paraview 3.10 + OpenFOAM
This has been applied to release and master. http://vtk.org/gitweb?p=VTK.git;a=commit;h=9fda3e707034e45adc261f66089de5d7711d870e On Wed, Mar 16, 2011 at 8:33 AM, Takuya OSHIMA osh...@eng.niigata-u.ac.jpwrote: I filed a bug for this: http://www.paraview.org/Bug/view.php?id=11974 The patch is also attached to this mail. As Mark says it would be very important, so we really hope to see this included in the upcoming 3.10.1 release. Thanks! Takuya Takuya OSHIMA, Ph.D. Faculty of Engineering, Niigata University 8050 Ikarashi-Ninocho, Nishi-ku, Niigata, 950-2181, JAPAN From: David Partyka david.part...@kitware.com Subject: Re: [Paraview] paraview 3.10 + OpenFOAM Date: Fri, 11 Mar 2011 05:32:05 -0500 It was released two days ago ;-). Your patch most certainly could be included for the next release. If you want, submit a bug on paraview.org/Bugwith your patch, and possibly a dataset and instructions to recreate the original issue. Thanks! On Fri, Mar 11, 2011 at 3:21 AM, OLESEN Mark mark.ole...@faurecia.com wrote: When is 3.10 slated for release? I have a patch from Takuya OSHIMA for handling a compact face format in OpenFOAM. It would be very important to get this in before the next release. What tests are needed and what is the time-frame to squeezing in this type of change before the 3.10 release? /mark DISCLAIMER: This electronic transmission (and any attachments thereto) is intended solely for the use of the addressee(s). It may contain confidential or legally privileged information. If you are not the intended recipient of this message, you must delete it immediately and notify the sender. Any unauthorized use or disclosure of this message is strictly prohibited. Faurecia does not guarantee the integrity of this transmission and shall therefore never be liable if the message is altered or falsified nor for any virus, interception or damage to your system. ___ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview ___ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview
Re: [Paraview] paraview 3.10 + OpenFOAM
Thanks, David! Takuya Takuya OSHIMA, Ph.D. Faculty of Engineering, Niigata University 8050 Ikarashi-Ninocho, Nishi-ku, Niigata, 950-2181, JAPAN From: David Partyka david.part...@kitware.com Subject: Re: [Paraview] paraview 3.10 + OpenFOAM Date: Wed, 16 Mar 2011 11:52:52 -0400 This has been applied to release and master. http://vtk.org/gitweb?p=VTK.git;a=commit;h=9fda3e707034e45adc261f66089de5d7711d870e On Wed, Mar 16, 2011 at 8:33 AM, Takuya OSHIMA osh...@eng.niigata-u.ac.jpwrote: I filed a bug for this: http://www.paraview.org/Bug/view.php?id=11974 The patch is also attached to this mail. As Mark says it would be very important, so we really hope to see this included in the upcoming 3.10.1 release. Thanks! Takuya Takuya OSHIMA, Ph.D. Faculty of Engineering, Niigata University 8050 Ikarashi-Ninocho, Nishi-ku, Niigata, 950-2181, JAPAN From: David Partyka david.part...@kitware.com Subject: Re: [Paraview] paraview 3.10 + OpenFOAM Date: Fri, 11 Mar 2011 05:32:05 -0500 It was released two days ago ;-). Your patch most certainly could be included for the next release. If you want, submit a bug on paraview.org/Bugwith your patch, and possibly a dataset and instructions to recreate the original issue. Thanks! On Fri, Mar 11, 2011 at 3:21 AM, OLESEN Mark mark.ole...@faurecia.com wrote: When is 3.10 slated for release? I have a patch from Takuya OSHIMA for handling a compact face format in OpenFOAM. It would be very important to get this in before the next release. What tests are needed and what is the time-frame to squeezing in this type of change before the 3.10 release? /mark DISCLAIMER: This electronic transmission (and any attachments thereto) is intended solely for the use of the addressee(s). It may contain confidential or legally privileged information. If you are not the intended recipient of this message, you must delete it immediately and notify the sender. Any unauthorized use or disclosure of this message is strictly prohibited. Faurecia does not guarantee the integrity of this transmission and shall therefore never be liable if the message is altered or falsified nor for any virus, interception or damage to your system. ___ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview ___ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview
Re: [Paraview] paraview 3.10 + OpenFOAM
Hi Bastian, I am just wondering what this patch is good for? It handles the case where 'faces' are written in a form similar to that used by CompactListList, which can be more efficient in some cases. /mark DISCLAIMER: This electronic transmission (and any attachments thereto) is intended solely for the use of the addressee(s). It may contain confidential or legally privileged information. If you are not the intended recipient of this message, you must delete it immediately and notify the sender. Any unauthorized use or disclosure of this message is strictly prohibited. Faurecia does not guarantee the integrity of this transmission and shall therefore never be liable if the message is altered or falsified nor for any virus, interception or damage to your system. ___ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview
Re: [Paraview] paraview 3.10 + OpenFOAM
Mark, I am just wondering what this patch is good for? Thanks. Regards Bastian Am 11.03.2011 11:32, schrieb David Partyka: It was released two days ago ;-). Your patch most certainly could be included for the next release. If you want, submit a bug on paraview.org/Bug http://paraview.org/Bug with your patch, and possibly a dataset and instructions to recreate the original issue. Thanks! On Fri, Mar 11, 2011 at 3:21 AM, OLESEN Mark mark.ole...@faurecia.com mailto:mark.ole...@faurecia.com wrote: When is 3.10 slated for release? I have a patch from Takuya OSHIMA for handling a compact face format in OpenFOAM. It would be very important to get this in before the next release. What tests are needed and what is the time-frame to squeezing in this type of change before the 3.10 release? /mark DISCLAIMER: This electronic transmission (and any attachments thereto) is intended solely for the use of the addressee(s). It may contain confidential or legally privileged information. If you are not the intended recipient of this message, you must delete it immediately and notify the sender. Any unauthorized use or disclosure of this message is strictly prohibited. Faurecia does not guarantee the integrity of this transmission and shall therefore never be liable if the message is altered or falsified nor for any virus, interception or damage to your system. ___ Powered by www.kitware.com http://www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview ___ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview ___ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview
[Paraview] paraview 3.10 + OpenFOAM
When is 3.10 slated for release? I have a patch from Takuya OSHIMA for handling a compact face format in OpenFOAM. It would be very important to get this in before the next release. What tests are needed and what is the time-frame to squeezing in this type of change before the 3.10 release? /mark DISCLAIMER: This electronic transmission (and any attachments thereto) is intended solely for the use of the addressee(s). It may contain confidential or legally privileged information. If you are not the intended recipient of this message, you must delete it immediately and notify the sender. Any unauthorized use or disclosure of this message is strictly prohibited. Faurecia does not guarantee the integrity of this transmission and shall therefore never be liable if the message is altered or falsified nor for any virus, interception or damage to your system. ___ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the ParaView Wiki at: http://paraview.org/Wiki/ParaView Follow this link to subscribe/unsubscribe: http://www.paraview.org/mailman/listinfo/paraview
