Re: [PATCH] Handle EmptyPage exceptions
Hi Daniel, > If a user asks for a page beyond the range of pages, an EmptyPage > exception is thrown. Catch this and clamp the page number > appropriately. This does fix the issue I'm seeing, thanks! Tested-by: Jeremy Kerr Cheers, Jeremy ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
[PATCH] Handle EmptyPage exceptions
If a user asks for a page beyond the range of pages, an EmptyPage exception is thrown. Catch this and clamp the page number appropriately. Reported-by: Jeremy Kerr Signed-off-by: Daniel Axtens --- patchwork/paginator.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/patchwork/paginator.py b/patchwork/paginator.py index 609e908c2cbf..e4cf556ebd96 100644 --- a/patchwork/paginator.py +++ b/patchwork/paginator.py @@ -55,6 +55,12 @@ class Paginator(paginator.Paginator): except ValueError: page_no = 1 self.current_page = self.page(page_no) +except paginator.EmptyPage: +if page_no < 1: +page_no = 1 +else: +page_no = self.num_pages +self.current_page = self.page(page_no) self.leading_set = self.trailing_set = [] -- 2.11.0 ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Patchwork v2.0.0 Available
From: Jeremy Kerr Date: Mon, 28 Aug 2017 08:51:56 +0800 > Hi David, > >> Please look into this soon, thank you. > > OK, sorted. Permissions problem with the patchwork_event table. Let me > know if anything else is breaking. Seems to work now, thanks for looking into it. ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Patchwork v2.0.0 Available
David Miller writes: > From: David Miller > Date: Sun, 27 Aug 2017 09:48:58 -0700 (PDT) > >> From: Jeremy Kerr >> Date: Sun, 27 Aug 2017 19:37:11 +0800 >> >>> Hi all, >>> Just an update: the database migration for v2.0.0 is taking a *long* time, so we'll be out for more than that one hour. I'll get things back up and running as soon as possible, but we're dependent on this migration completing first. >>> >>> OK, we're back up now. Please let me know if anything looks amiss. >> >> Go to: >> >> http://patchwork.ozlabs.org/project/netdev/list/?series=25 >> >> Click the box to the left of "Patch" field so all patches get selected. >> >> Select state of "Under Review" and delegate "davem", click update. >> >> Get a page with just "Server Error (500)" >> >> Happens every time I try it. > > I cannot change the state of any patch, which means I can't get any > work done at all today. I am able to modify patch states under the linuxppc-dev project. So maybe it's something netdev specific (somehow) ? cheers ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Patchwork v2.0.0 Available
Hi David, Please look into this soon, thank you. OK, sorted. Permissions problem with the patchwork_event table. Let me know if anything else is breaking. Daniel: I also seem to be getting zero (email) notification of server-side errors, I assume from the new LOGGING configuration in base.py :( Cheers, Jeremy ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Patchwork v2.0.0 Available
On 28/08/17 10:02, David Miller wrote: I cannot change the state of any patch, which means I can't get any work done at all today. I've tried to log out and log back in again, same problem. Now that jk has fixed user login, I can change the state of my patches fine. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Patchwork v2.0.0 Available
From: David Miller Date: Sun, 27 Aug 2017 09:48:58 -0700 (PDT) > From: Jeremy Kerr > Date: Sun, 27 Aug 2017 19:37:11 +0800 > >> Hi all, >> >>> Just an update: the database migration for v2.0.0 is taking a *long* >>> time, so we'll be out for more than that one hour. I'll get things >>> back up and running as soon as possible, but we're dependent on this >>> migration completing first. >> >> OK, we're back up now. Please let me know if anything looks amiss. > > Go to: > > http://patchwork.ozlabs.org/project/netdev/list/?series=25 > > Click the box to the left of "Patch" field so all patches get selected. > > Select state of "Under Review" and delegate "davem", click update. > > Get a page with just "Server Error (500)" > > Happens every time I try it. I cannot change the state of any patch, which means I can't get any work done at all today. I've tried to log out and log back in again, same problem. Please look into this soon, thank you. ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
ozlabs instance borked [was: Patchwork v2.0.0 Available]
Jeremy, All, On Sun, 2017-08-27 09:48:58 -0700 (PDT), David Miller spake thusly: > Go to: > http://patchwork.ozlabs.org/project/netdev/list/?series=25 > > Click the box to the left of "Patch" field so all patches get selected. > Select state of "Under Review" and delegate "davem", click update. > Get a page with just "Server Error (500)" > Happens every time I try it. Ditto here, I get http/500 while trying to change the state of any patch for the Buildroot project, when it was working with the version previously deployed at ozlabs: https://patchwork.ozlabs.org/project/buildroot/list/ Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `.---: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL| v conspiracy. | '--^---^--^' ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Patchwork v2.0.0 Available
From: Jeremy Kerr Date: Sun, 27 Aug 2017 19:37:11 +0800 > Hi all, > >> Just an update: the database migration for v2.0.0 is taking a *long* >> time, so we'll be out for more than that one hour. I'll get things >> back up and running as soon as possible, but we're dependent on this >> migration completing first. > > OK, we're back up now. Please let me know if anything looks amiss. Go to: http://patchwork.ozlabs.org/project/netdev/list/?series=25 Click the box to the left of "Patch" field so all patches get selected. Select state of "Under Review" and delegate "davem", click update. Get a page with just "Server Error (500)" Happens every time I try it. ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Patchwork v2.0.0 Available
Hi Andrew, I'm seeing a 500 immediately upon login at https://patchwork.ozlabs.org/user/... OK, sorted. Looks like the permissions scripts are quite out-of-date with the changes to the db. Cheers, Jeremy ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Patchwork v2.0.0 Available
On 27/08/17 21:37, Jeremy Kerr wrote: OK, we're back up now. Please let me know if anything looks amiss. I'm seeing a 500 immediately upon login at https://patchwork.ozlabs.org/user/... -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Patchwork v2.0.0 Available
Hi all, Just an update: the database migration for v2.0.0 is taking a *long* time, so we'll be out for more than that one hour. I'll get things back up and running as soon as possible, but we're dependent on this migration completing first. OK, we're back up now. Please let me know if anything looks amiss. Cheers, Jeremy ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Welcoming a new maintainer: Daniel Axtens
> I'm happy to announce that Daniel Axtens has agreed to come aboard as a > maintainer of Patchwork. Thanks Stephen! > Daniel has been contributing to Patchwork fairly consistently for about a year > now, and it's been a pleasure working with him during that time. He was a > massive help in getting 2.0 out of the door, and I look forward to continuing > to work with him on future improvements over the coming months and years. Looking forward to it! Regards, Daniel > > Thanks, Daniel! > > Stephen ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Patchwork v2.0.0 Available
Hi all, The total timeframe somewhat depends on how smoothly the upgrade goes, but one hour would be a conservative estimate. Just an update: the database migration for v2.0.0 is taking a *long* time, so we'll be out for more than that one hour. I'll get things back up and running as soon as possible, but we're dependent on this migration completing first. Cheers, Jeremy ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
