Re: [U-Boot] patchwork does not pick my patch

2013-11-21 Thread Masahiro Yamada
Hello Jeremy


> >> But my patch would not appear on patchwork.
> >> (Maybe because there is no diff line.)
> > 
> > I think so too. There is some handling for renames without patch in
> > patchwork, but I think there is no handling for just file permission
> > changes. That should be fixed in patchwork then.
> 
> Yep, that's correct - there's no support for these permission changes at
> present. I'll add that!

Thanks!


BTW, I notice another issue of patchwork.

Patchwork sometimes picks up emails which should not be.

For example,
I post an email (not a patch format, but includes some diff lines)
to the ML:
http://u-boot.10912.n7.nabble.com/RFC-ARM-optimized-memcpy-memset-on-SPL-build-td159583.html

And it was shown up on patchwork against my will.
http://patchwork.ozlabs.org/patch/260004/

I appreciate if you would fix this also.


Best Regards
Masahiro Yamada

___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork


Re: [U-Boot] patchwork does not pick my patch

2013-11-21 Thread Jeremy Kerr
Hi all,

> On 11/21/2013 12:14 PM, Masahiro Yamada wrote:
>> Hi.
>>
>> I posted a patch to change a file permission.
>> This:
>> http://lists.denx.de/pipermail/u-boot/2013-November/167573.html
>>
>> and again:
>> http://lists.denx.de/pipermail/u-boot/2013-November/167608.html
>>
>>
>> But my patch would not appear on patchwork.
>> (Maybe because there is no diff line.)
> 
> I think so too. There is some handling for renames without patch in
> patchwork, but I think there is no handling for just file permission
> changes. That should be fixed in patchwork then.

Yep, that's correct - there's no support for these permission changes at
present. I'll add that!

Cheers,


Jeremy
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork


Re: [U-Boot] patchwork does not pick my patch

2013-11-21 Thread Andreas Bießmann
Dear Masahiro Yamada,

+patchwork list

On 11/21/2013 12:14 PM, Masahiro Yamada wrote:
> Hi.
> 
> I posted a patch to change a file permission.
> This:
> http://lists.denx.de/pipermail/u-boot/2013-November/167573.html
> 
> and again:
> http://lists.denx.de/pipermail/u-boot/2013-November/167608.html
> 
> 
> But my patch would not appear on patchwork.
> (Maybe because there is no diff line.)

I think so too. There is some handling for renames without patch in
patchwork, but I think there is no handling for just file permission
changes. That should be fixed in patchwork then.

> What should I do?

File bug report at patchwork ML?

> Is it better to squash it to another patch?

Well to show it up in patchwork that could work. Since this change is
quite trivial I think it will also work if you just peak the relevant
custodian to pick this from the list.

Best regards

Andreas Bießmann
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork