Re: Changing person/author names
> Yeah, there was a question on this here on the ML just last week [1]. > The solution proposed - create a patchwork account - does seem like > overkill. Yes and no. It could be worse, but asking a random patch developer to register at a (for the developer) random site because it makes my workflow easier is surely sub-optimal. > like to get that in first. OK to hold on this change for a week or two > while we get cover letter support in? Oh, I am waiting for this for years now (I reported it multiple times) so I can easily wait two more weeks :) Thanks for tackling it! signature.asc Description: PGP signature ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Changing person/author names
On 22 Mar 08:37, Wolfram Sang wrote: > > > > Patches applied using pwclient will always use the first name that has > > > been seen for a particular email address. While this is usually fine, It > > > actually causes issues for people changing name without changing email > > > addresses or people changing the capitalization of their name (less > > > important though). > > > > ... and for folks that change names (I've had a few requests for that). > > What most happened to me: Somebody initially writes mail without a real > name set up: "" This gets later changed to " " but > patchwork still uses the first one forcing me to fix this manually in my > branch. > > > Yes, I think this is worthwhile. > > Thus, definately +1 on this one. Yeah, there was a question on this here on the ML just last week [1]. The solution proposed - create a patchwork account - does seem like overkill. This should be a simple change in 'parsemail'. However, I've done some rework of this file as part of the Cover Letter feature [2] and would like to get that in first. OK to hold on this change for a week or two while we get cover letter support in? Cheers, Stephen PS: This is in the issue tracker now to make sure it's done [3] [1] https://lists.ozlabs.org/pipermail/patchwork/2016-March/002415.html [2] https://lists.ozlabs.org/pipermail/patchwork/2016-March/002435.html [3] https://github.com/getpatchwork/patchwork/issues/24 ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Changing person/author names
> > Patches applied using pwclient will always use the first name that has > > been seen for a particular email address. While this is usually fine, It > > actually causes issues for people changing name without changing email > > addresses or people changing the capitalization of their name (less > > important though). > > ... and for folks that change names (I've had a few requests for that). What most happened to me: Somebody initially writes mail without a real name set up: "" This gets later changed to " " but patchwork still uses the first one forcing me to fix this manually in my branch. > Yes, I think this is worthwhile. Thus, definately +1 on this one. signature.asc Description: PGP signature ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Changing person/author names
Hi Alexandre, > I have a feature request. I had a quick look at the code and I have to > admit that I'm not quite sure how to achieve it :) > > Patches applied using pwclient will always use the first name that has > been seen for a particular email address. While this is usually fine, It > actually causes issues for people changing name without changing email > addresses or people changing the capitalization of their name (less > important though). ... and for folks that change names (I've had a few requests for that). Yes, I think this is worthwhile. > So I would prefer .save() to be called even if the email already exists > in the database. - provided that the Person does not have a patchwork account where the name has previously been manually set; we'd probably need a boolean on the profile model for that. Regards, Jeremy ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
