Re: [PD-dev] figuring out how to get everything merged

[IOhannes m zmoelnig]

On 2/6/23 00:38, IOhannes m zmölnig wrote:

On 2/5/23 22:56, Christof Ressi wrote:
it's compiling just fine here using mingw so it's probably something 
stupid.

Are you building with ASIO support?


yes, that's crucial.
make sure you have ASIO extracted as asio/ASIO/


i've submitted a fix to the 'develop' branch.

it seems dan's import of portaudio was partially broken (keeping some 
outdated files).


hopefully my fix doesn't further complicate merging...

gfmdras
IOhannes



OpenPGP_signature
Description: OpenPGP digital signature
___
Pd-dev mailing list
Pd-dev@lists.iem.at
https://lists.puredata.info/listinfo/pd-dev

Re: [PD-dev] figuring out how to get everything merged

[Dan Wilcox]

> on close inspection, it turns out that the portaudio/ directories in the 
> '0.53-2' branch and the 'master' branch are indeed different.
> i don't know why and how they have been imported (presumably with the 
> 'portaudio/update.sh' script, but the 
> portaudio/portaudio/src/common/pa_gitrevision.h now shows 'unknown' 
> which is not very helpful)

It looks like the script was not used nor was my update/portaudio branch merged 
which has the define set. The script indeed sets the PA_GIT_REVISION using the 
update_gitrevision.sh script in the PA repo. I had fixed several small issues 
with the script itself, mainly due to a file no longer being present in the new 
portaudio version which may have been why it wasn't used in the end.

In any case, I made a small commit directly to the 0.53-2 branch which 
addresses this and should be pulled into master:

dd20389559b3b293a1dd4fdc427f1881e3818bd3


Dan Wilcox
@danomatika 
danomatika.com 
robotcowboy.com 



___
Pd-dev mailing list
Pd-dev@lists.iem.at
https://lists.puredata.info/listinfo/pd-dev

Re: [PD-dev] figuring out how to get everything merged

[IOhannes m zmölnig]

On 2/5/23 22:56, Christof Ressi wrote:
it's compiling just fine here using mingw so it's probably something 
stupid.

Are you building with ASIO support?


yes, that's crucial.
make sure you have ASIO extracted as asio/ASIO/

fdd
IOhannes


OpenPGP_signature
Description: OpenPGP digital signature
___
Pd-dev mailing list
Pd-dev@lists.iem.at
https://lists.puredata.info/listinfo/pd-dev

Re: [PD-dev] figuring out how to get everything merged

[Christof Ressi]

Also, I can confirm that the 0.52-2 branch (with ASIO/portaudio support) 
compiles just fine.


On 05.02.2023 22:56, Christof Ressi wrote:
it's compiling just fine here using mingw so it's probably something 
stupid.

Are you building with ASIO support?

./configure --enable-portaudio --enable-asio -> FAIL

./configure --enable-portaudio --disable-asio -> FAIL

./configure --disable-portaudio -> SUCCESS

Christof

On 05.02.2023 22:37, Miller Puckette via Pd-dev wrote:

Yep, I originally made a "0.53" branch but then messed it up so badly
I had to start over - and thought it better to change the name to
avoid confusion.

I'll check on the windows build at some point; it's compiling just fine
here using mingw so it's probably something stupid.  But will go mostly
AWOL til Thursday.

cheers
M
On Sun, Feb 05, 2023 at 10:15:08PM +0100, IOhannes m zmölnig wrote:

On 2/4/23 19:58, Miller Puckette via Pd-dev wrote:
I made a git branch off 0.53-1 and back-applied the portaudio 
update to it.
just a quick note: the current `master` seems to not build on 
Windows/MinGW

any longer. seems to be related to ASIO.

see https://git.iem.at/pd/pure-data/-/jobs/46362

the '0.53-2' branch¹ however seems to build fine.
which is a bit weird...

on close inspection, it turns out that the portaudio/ directories in 
the

'0.53-2' branch and the 'master' branch are indeed different.
i don't know why and how they have been imported (presumably with the
'portaudio/update.sh' script, but the
portaudio/portaudio/src/common/pa_gitrevision.h now shows 'unknown' 
which is

not very helpful)



gfmdasd
IOhannes


¹ shouldn't that branch be called '0.53' instead, as it is 
(hopefully) will

contain the entire 0.53-x history?





___
Pd-dev mailing list
Pd-dev@lists.iem.at
https://lists.puredata.info/listinfo/pd-dev




___
Pd-dev mailing list
Pd-dev@lists.iem.at
https://lists.puredata.info/listinfo/pd-dev




___
Pd-dev mailing list
Pd-dev@lists.iem.at
https://lists.puredata.info/listinfo/pd-dev




___
Pd-dev mailing list
Pd-dev@lists.iem.at
https://lists.puredata.info/listinfo/pd-dev

Re: [PD-dev] figuring out how to get everything merged

[Christof Ressi]

it's compiling just fine here using mingw so it's probably something stupid.

Are you building with ASIO support?

./configure --enable-portaudio --enable-asio -> FAIL

./configure --enable-portaudio --disable-asio -> FAIL

./configure --disable-portaudio -> SUCCESS

Christof

On 05.02.2023 22:37, Miller Puckette via Pd-dev wrote:

Yep, I originally made a "0.53" branch but then messed it up so badly
I had to start over - and thought it better to change the name to
avoid confusion.

I'll check on the windows build at some point; it's compiling just fine
here using mingw so it's probably something stupid.  But will go mostly
AWOL til Thursday.

cheers
M
On Sun, Feb 05, 2023 at 10:15:08PM +0100, IOhannes m zmölnig wrote:

On 2/4/23 19:58, Miller Puckette via Pd-dev wrote:

I made a git branch off 0.53-1 and back-applied the portaudio update to it.

just a quick note: the current `master` seems to not build on Windows/MinGW
any longer. seems to be related to ASIO.

see https://git.iem.at/pd/pure-data/-/jobs/46362

the '0.53-2' branch¹ however seems to build fine.
which is a bit weird...

on close inspection, it turns out that the portaudio/ directories in the
'0.53-2' branch and the 'master' branch are indeed different.
i don't know why and how they have been imported (presumably with the
'portaudio/update.sh' script, but the
portaudio/portaudio/src/common/pa_gitrevision.h now shows 'unknown' which is
not very helpful)



gfmdasd
IOhannes


¹ shouldn't that branch be called '0.53' instead, as it is (hopefully) will
contain the entire 0.53-x history?





___
Pd-dev mailing list
Pd-dev@lists.iem.at
https://lists.puredata.info/listinfo/pd-dev




___
Pd-dev mailing list
Pd-dev@lists.iem.at
https://lists.puredata.info/listinfo/pd-dev




___
Pd-dev mailing list
Pd-dev@lists.iem.at
https://lists.puredata.info/listinfo/pd-dev

Re: [PD-dev] figuring out how to get everything merged

[Miller Puckette via Pd-dev]

Yep, I originally made a "0.53" branch but then messed it up so badly
I had to start over - and thought it better to change the name to
avoid confusion.

I'll check on the windows build at some point; it's compiling just fine
here using mingw so it's probably something stupid.  But will go mostly
AWOL til Thursday.

cheers
M
On Sun, Feb 05, 2023 at 10:15:08PM +0100, IOhannes m zmölnig wrote:
> On 2/4/23 19:58, Miller Puckette via Pd-dev wrote:
> > I made a git branch off 0.53-1 and back-applied the portaudio update to it.
> 
> just a quick note: the current `master` seems to not build on Windows/MinGW
> any longer. seems to be related to ASIO.
> 
> see https://git.iem.at/pd/pure-data/-/jobs/46362
> 
> the '0.53-2' branch¹ however seems to build fine.
> which is a bit weird...
> 
> on close inspection, it turns out that the portaudio/ directories in the
> '0.53-2' branch and the 'master' branch are indeed different.
> i don't know why and how they have been imported (presumably with the
> 'portaudio/update.sh' script, but the
> portaudio/portaudio/src/common/pa_gitrevision.h now shows 'unknown' which is
> not very helpful)
> 
> 
> 
> gfmdasd
> IOhannes
> 
> 
> ¹ shouldn't that branch be called '0.53' instead, as it is (hopefully) will
> contain the entire 0.53-x history?




> ___
> Pd-dev mailing list
> Pd-dev@lists.iem.at
> https://lists.puredata.info/listinfo/pd-dev




___
Pd-dev mailing list
Pd-dev@lists.iem.at
https://lists.puredata.info/listinfo/pd-dev

Re: [PD-dev] figuring out how to get everything merged

[IOhannes m zmölnig]

On 2/4/23 19:58, Miller Puckette via Pd-dev wrote:

I made a git branch off 0.53-1 and back-applied the portaudio update to it.


just a quick note: the current `master` seems to not build on 
Windows/MinGW any longer. seems to be related to ASIO.


see https://git.iem.at/pd/pure-data/-/jobs/46362

the '0.53-2' branch¹ however seems to build fine.
which is a bit weird...

on close inspection, it turns out that the portaudio/ directories in the 
'0.53-2' branch and the 'master' branch are indeed different.
i don't know why and how they have been imported (presumably with the 
'portaudio/update.sh' script, but the 
portaudio/portaudio/src/common/pa_gitrevision.h now shows 'unknown' 
which is not very helpful)




gfmdasd
IOhannes


¹ shouldn't that branch be called '0.53' instead, as it is (hopefully) 
will contain the entire 0.53-x history?


OpenPGP_signature
Description: OpenPGP digital signature
___
Pd-dev mailing list
Pd-dev@lists.iem.at
https://lists.puredata.info/listinfo/pd-dev

Re: [PD-dev] figuring out how to get everything merged

[Christof Ressi]

Meanwhile there's Christof's semaphor feature which promises to lower latency
(I tried doing this earlier in s_audio_pa.c but found it actually increased
latency; not sure what's going on here).


I guess you are talking about the THREADSIGNAL part (which has never 
been enabled, except for a very brief moment).


There are two major differences to my new implementation:

a) I use a semaphore instead of a condition variable to avoid 
unnecessary mutex locking.


b) The old THREADSIGNAL implementation would sleep on the condition 
variable as soon as the FIFO is empty/full. This would waste precious 
time that could be spent otherwise, in particular with larger hardware 
buffer sizes.
In my implementation, on the other hand, I check the ringbuffer in a 
loop and only sleep on the semaphore when Pd is really idle, i.e. 
sched_idletask() has returned 0. See also 
https://github.com/pure-data/pure-data/pull/1756/commits/de8c62e0ce726634cba7570016a1b256eb724540.


Christof




___
Pd-dev mailing list
Pd-dev@lists.iem.at
https://lists.puredata.info/listinfo/pd-dev

Re: [PD-dev] figuring out how to get everything merged

[Alexandre Torres Porres]

ok, that makes sense, hahaha, cool, thanks

Em sáb., 4 de fev. de 2023 às 15:58, Miller Puckette 
escreveu:

> I made a git branch off 0.53-1 and back-applied the portaudio update to it.
> None of the multichannel stuff (or anything else since that release) is
> part
> of it.
>
> cheers
> M
>
> On Sat, Feb 04, 2023 at 03:46:48PM -0300, Alexandre Torres Porres wrote:
> > I just don't understand how you're gonna hide features and stuff already
> > done to release a bugfix (0.53-2) without multichannel objects and
> support
> > for it in [send~]/[throw~] for instance.
> >
> > Em sáb., 4 de fev. de 2023 às 14:58, Miller Puckette via Pd-dev <
> > pd-dev@lists.iem.at> escreveu:
> >
> > > I've back-merged the portaudio update to version 0.53 (tried a week
> ago but
> > > messed it up, hopefully have it correct now).  If I understand
> correctly
> > > this will fix the hang-on-macos-13 trouble but won't prevent people
> from
> > > checking callback which also can hang Pd on a Mac.
> > >
> > > Meanwhile there's Christof's semaphor feature which promises to lower
> > > latency
> > > (I tried doing this earlier in s_audio_pa.c but found it actually
> increased
> > > latency; not sure what's going on here).  The PR is here:
> > >
> https://urldefense.com/v3/__https://github.com/pure-data/pure-data/pull/1756__;!!Mih3wA!CehDeFwkYhOonPn5ByNcA2wkP6V66zu88smmg76ipfpKMcwfhw6wi38MhQO-xiPZALK9_I1zUg$
> > >
> > > I'm now thinking I should get multichannel inlet~/outlet~ finished
> first,
> > > then study and hopefully incorporate the semaphore PR after that's all
> > > working.
> > > Then that can be 0.54 (so that 0.53 can be limited to bug-fixing).
> > >
> > > I wanna get the 0.53 bugfix out as soon as it's pretty sure that it
> > > actually
> > > fixes things...
> > >
> > > cheers
> > > Miller
> > >
> > >
> > >
> > > ___
> > > Pd-dev mailing list
> > > Pd-dev@lists.iem.at
> > >
> https://urldefense.com/v3/__https://lists.puredata.info/listinfo/pd-dev__;!!Mih3wA!CehDeFwkYhOonPn5ByNcA2wkP6V66zu88smmg76ipfpKMcwfhw6wi38MhQO-xiPZALKOmQLolQ$
> > >
>
___
Pd-dev mailing list
Pd-dev@lists.iem.at
https://lists.puredata.info/listinfo/pd-dev

Re: [PD-dev] figuring out how to get everything merged

[Miller Puckette via Pd-dev]

I made a git branch off 0.53-1 and back-applied the portaudio update to it.
None of the multichannel stuff (or anything else since that release) is part
of it.

cheers
M

On Sat, Feb 04, 2023 at 03:46:48PM -0300, Alexandre Torres Porres wrote:
> I just don't understand how you're gonna hide features and stuff already
> done to release a bugfix (0.53-2) without multichannel objects and support
> for it in [send~]/[throw~] for instance.
> 
> Em sáb., 4 de fev. de 2023 às 14:58, Miller Puckette via Pd-dev <
> pd-dev@lists.iem.at> escreveu:
> 
> > I've back-merged the portaudio update to version 0.53 (tried a week ago but
> > messed it up, hopefully have it correct now).  If I understand correctly
> > this will fix the hang-on-macos-13 trouble but won't prevent people from
> > checking callback which also can hang Pd on a Mac.
> >
> > Meanwhile there's Christof's semaphor feature which promises to lower
> > latency
> > (I tried doing this earlier in s_audio_pa.c but found it actually increased
> > latency; not sure what's going on here).  The PR is here:
> > https://urldefense.com/v3/__https://github.com/pure-data/pure-data/pull/1756__;!!Mih3wA!CehDeFwkYhOonPn5ByNcA2wkP6V66zu88smmg76ipfpKMcwfhw6wi38MhQO-xiPZALK9_I1zUg$
> >  
> >
> > I'm now thinking I should get multichannel inlet~/outlet~ finished first,
> > then study and hopefully incorporate the semaphore PR after that's all
> > working.
> > Then that can be 0.54 (so that 0.53 can be limited to bug-fixing).
> >
> > I wanna get the 0.53 bugfix out as soon as it's pretty sure that it
> > actually
> > fixes things...
> >
> > cheers
> > Miller
> >
> >
> >
> > ___
> > Pd-dev mailing list
> > Pd-dev@lists.iem.at
> > https://urldefense.com/v3/__https://lists.puredata.info/listinfo/pd-dev__;!!Mih3wA!CehDeFwkYhOonPn5ByNcA2wkP6V66zu88smmg76ipfpKMcwfhw6wi38MhQO-xiPZALKOmQLolQ$
> >  
> >



___
Pd-dev mailing list
Pd-dev@lists.iem.at
https://lists.puredata.info/listinfo/pd-dev

Re: [PD-dev] figuring out how to get everything merged

[Alexandre Torres Porres]

I just don't understand how you're gonna hide features and stuff already
done to release a bugfix (0.53-2) without multichannel objects and support
for it in [send~]/[throw~] for instance.

Em sáb., 4 de fev. de 2023 às 14:58, Miller Puckette via Pd-dev <
pd-dev@lists.iem.at> escreveu:

> I've back-merged the portaudio update to version 0.53 (tried a week ago but
> messed it up, hopefully have it correct now).  If I understand correctly
> this will fix the hang-on-macos-13 trouble but won't prevent people from
> checking callback which also can hang Pd on a Mac.
>
> Meanwhile there's Christof's semaphor feature which promises to lower
> latency
> (I tried doing this earlier in s_audio_pa.c but found it actually increased
> latency; not sure what's going on here).  The PR is here:
> https://github.com/pure-data/pure-data/pull/1756
>
> I'm now thinking I should get multichannel inlet~/outlet~ finished first,
> then study and hopefully incorporate the semaphore PR after that's all
> working.
> Then that can be 0.54 (so that 0.53 can be limited to bug-fixing).
>
> I wanna get the 0.53 bugfix out as soon as it's pretty sure that it
> actually
> fixes things...
>
> cheers
> Miller
>
>
>
> ___
> Pd-dev mailing list
> Pd-dev@lists.iem.at
> https://lists.puredata.info/listinfo/pd-dev
>
___
Pd-dev mailing list
Pd-dev@lists.iem.at
https://lists.puredata.info/listinfo/pd-dev

[PD-dev] figuring out how to get everything merged

[Miller Puckette via Pd-dev]

I've back-merged the portaudio update to version 0.53 (tried a week ago but
messed it up, hopefully have it correct now).  If I understand correctly
this will fix the hang-on-macos-13 trouble but won't prevent people from
checking callback which also can hang Pd on a Mac.

Meanwhile there's Christof's semaphor feature which promises to lower latency
(I tried doing this earlier in s_audio_pa.c but found it actually increased
latency; not sure what's going on here).  The PR is here:
https://github.com/pure-data/pure-data/pull/1756

I'm now thinking I should get multichannel inlet~/outlet~ finished first,
then study and hopefully incorporate the semaphore PR after that's all working.
Then that can be 0.54 (so that 0.53 can be limited to bug-fixing).

I wanna get the 0.53 bugfix out as soon as it's pretty sure that it actually
fixes things...

cheers
Miller



___
Pd-dev mailing list
Pd-dev@lists.iem.at
https://lists.puredata.info/listinfo/pd-dev