Re: [PD] PDP test release
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 2013-07-21 23:02, Tom Schouten wrote:
- the v4l2 code bails out because of undefined
V4L2_CID_HCENTER/V4L2_CID_VCENTER
attached are two patches that seem to fix these two problems.
thanks for the patches!
it seems they have not made it into DARCS yet :-(
btw, i also found a small note [1] on removing the unused
V4L2_CID_VCENTER/V4L2_CID_HCENTER controls from videodev2.h in 2012.
anyhow.
attached is yet another patch, that adds --with-pd= flags to
configure.ac, so you can specify the header-search path rather than
having to guess (thw wrong one).
fgamsdr
IOhannes
[1] http://permalink.gmane.org/gmane.linux.kernel.commits.head/315755
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Icedove - http://www.enigmail.net/
iEYEARECAAYFAlHtEv4ACgkQkX2Xpv6ydvTXUACeKny6JZqbIn7QIcgTg9GRZy+R
q18AoLd6T0/uPz5ePKCj1GEnwZWfgAYB
=rVx4
-END PGP SIGNATURE-
From 02fa9186a5e84fb7c1cf2a4ebdc29fcafb27e9b2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?IOhannes=20m=20zm=C3=B6lnig?= zmoel...@iem.at
Date: Mon, 22 Jul 2013 13:03:25 +0200
Subject: [PATCH 1/2] adding --with-pd flag
to allow specifiying where the Pd-headers *really* are
(without having to guess)
---
configure.ac | 61 +---
1 file changed, 42 insertions(+), 19 deletions(-)
diff --git a/configure.ac b/configure.ac
index 8434aff..02492ec 100644
--- a/configure.ac
+++ b/configure.ac
@@ -48,6 +48,11 @@ AC_ARG_ENABLE(png,
AC_ARG_ENABLE(debug,
[ --enable-debug enable debugging support (no)], , enable_debug=no)
+AC_ARG_WITH([pd],
+ [ --with-pd=/path/to/pd where to look for pd-headers and and -libs])
+
+
+
# long double? -Wno-long-double
PDP_CFLAGS=-DPD -Wall -W -Wstrict-prototypes -Wno-unused -Wno-parentheses -Wno-switch -fPIC
@@ -84,28 +89,46 @@ dnl try to locate the pd header in case the setup is nonstandard
dnl check in $prefix/pd/src then ../pd/src
dnl if this fails we trust it is in the standard include path
PWD=`pwd`
-if test -f $prefix/pd/src/m_pd.h;
-then
- PD_CPPFLAGS=-I$prefix/pd/src
-elif test -f $prefix/src/pd/src/m_pd.h;
-then
- PD_CPPFLAGS=-I$prefix/src/pd/src
-elif test -f $PWD/../pd/src/m_pd.h;
-then
- PD_CPPFLAGS=-I$PWD/../pd/src
-elif test -f $PWD/../src/m_pd.h;
-then
- PD_CPPFLAGS=-I$PWD/../src
-elif test -f /usr/local/include/pd/m_pd.h;
-then
- PD_CPPFLAGS=-I/usr/local/include/pd
-elif test -f /usr/include/pd/m_pd.h;
-then
- PD_CPPFLAGS=-I/usr/include/pd
+if test x$with_pd != x; then
+ if test -d ${with_pd}; then
+ PDPATH=${with_pd}
+ fi
+ if test -d ${PDPATH}/src; then
+ AC_MSG_RESULT([adding ${PDPATH}/src to INCLUDES])
+ PD_CPPFLAGS=-I${PDPATH}/src
+
+ AC_MSG_RESULT([adding ${PDPATH}/src to LDFLAGS])
+ LDFLAGS=-L${PDPATH}/src ${LDFLAGS}
+ else
+ if test -d ${PDPATH}; then
+ AC_MSG_RESULT([adding ${PDPATH} to INCLUDES])
+ PD_CPPFLAGS=-I${PDPATH}
+ fi
+ fi
+else
+dnl try some defaults
+ if test -f $prefix/pd/src/m_pd.h;
+ then
+ PD_CPPFLAGS=-I$prefix/pd/src
+ elif test -f $prefix/src/pd/src/m_pd.h;
+ then
+ PD_CPPFLAGS=-I$prefix/src/pd/src
+ elif test -f $PWD/../pd/src/m_pd.h;
+ then
+ PD_CPPFLAGS=-I$PWD/../pd/src
+ elif test -f $PWD/../src/m_pd.h;
+ then
+ PD_CPPFLAGS=-I$PWD/../src
+ elif test -f /usr/local/include/pd/m_pd.h;
+ then
+ PD_CPPFLAGS=-I/usr/local/include/pd
+ elif test -f /usr/include/pd/m_pd.h;
+ then
+ PD_CPPFLAGS=-I/usr/include/pd
+ fi
fi
-
CPPFLAGS=$CPPFLAGS $PD_CPPFLAGS
AC_CHECK_HEADER(m_pd.h,,
echo WARNING: m_pd.h not found. Is PD installed?
--
1.8.3.2
___
Pd-list@iem.at mailing list
UNSUBSCRIBE and account-management -
http://lists.puredata.info/listinfo/pd-list
Re: [PD] PDP test release
On 07/22/2013 07:09 AM, IOhannes m zmoelnig wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2013-07-21 23:02, Tom Schouten wrote: - the v4l2 code bails out because of undefined V4L2_CID_HCENTER/V4L2_CID_VCENTER attached are two patches that seem to fix these two problems. thanks for the patches! it seems they have not made it into DARCS yet :-( btw, i also found a small note [1] on removing the unused V4L2_CID_VCENTER/V4L2_CID_HCENTER controls from videodev2.h in 2012. anyhow. attached is yet another patch, that adds --with-pd= flags to configure.ac, so you can specify the header-search path rather than having to guess (thw wrong one). fgamsdr IOhannes thanks will add it as soon as time allows ___ Pd-list@iem.at mailing list UNSUBSCRIBE and account-management - http://lists.puredata.info/listinfo/pd-list
Re: [PD] PDP test release
hi IOhannes On 07/19/2013 04:00 PM, IOhannes zmölnig wrote: hi tom, On 05/14/2013 09:35 PM, Tom Schouten wrote: Hello, There's a PDP release in the pipeline: 0.14.0: Port ia32 MMX assembly code to GCC extensions (MMX support on amd64) Add V4L2 support to pdp_v4l (merge with pdp_v4l2) Distill zl (Zwizwa Lib) from PDP and libprim/PF code. great news. while i haven't done any functional tests yet, i tried to build the latest snapshot (20130516_010555) and ran into two problems: - it will fail to compile if gsl-dev is not installed (regardless of the enable-gsl flag) - the v4l2 code bails out because of undefined V4L2_CID_HCENTER/V4L2_CID_VCENTER attached are two patches that seem to fix these two problems. thanks for the patches! btw, is your darcs repository public? this would allow meto simply pull the latest version instead of having to search my inbox (and http://zwizwa.be/pd/pdp/test/) - which is rather errorprone. yes. i just synced the public repo with my working copy: http://zwizwa.be/darcs/pdp/ hopefully there'll be a 0.14 release soon i had been thinking to release current state as 0.14 since there were no more bug reports, but i'll include these fixes first. cheers tom ___ Pd-list@iem.at mailing list UNSUBSCRIBE and account-management - http://lists.puredata.info/listinfo/pd-list
Re: [PD] PDP test release
hi tom, On 05/14/2013 09:35 PM, Tom Schouten wrote: Hello, There's a PDP release in the pipeline: 0.14.0: Port ia32 MMX assembly code to GCC extensions (MMX support on amd64) Add V4L2 support to pdp_v4l (merge with pdp_v4l2) Distill zl (Zwizwa Lib) from PDP and libprim/PF code. great news. while i haven't done any functional tests yet, i tried to build the latest snapshot (20130516_010555) and ran into two problems: - it will fail to compile if gsl-dev is not installed (regardless of the enable-gsl flag) - the v4l2 code bails out because of undefined V4L2_CID_HCENTER/V4L2_CID_VCENTER attached are two patches that seem to fix these two problems. btw, is your darcs repository public? this would allow meto simply pull the latest version instead of having to search my inbox (and http://zwizwa.be/pd/pdp/test/) - which is rather errorprone. hopefully there'll be a 0.14 release soon gmsdr IOhannes From 6b4942518cf7827870bcd119621a0105bdf5a829 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?IOhannes=20m=20zm=C3=B6lnig?= zmoel...@iem.at Date: Fri, 19 Jul 2013 21:39:17 +0200 Subject: [PATCH 1/2] removed HCENTER/VCENTER controls there are no V4L2_CID_*CENTER controls defined on my system (linux-3.10) --- system/zl/v4l.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/system/zl/v4l.h b/system/zl/v4l.h index 10f8786..370ea8e 100644 --- a/system/zl/v4l.h +++ b/system/zl/v4l.h @@ -186,8 +186,6 @@ const char *zl_v4l_control_name(int id); ZL_V4L_CTRL(GAIN) \ ZL_V4L_CTRL(HFLIP) \ ZL_V4L_CTRL(VFLIP) \ -ZL_V4L_CTRL(HCENTER) \ -ZL_V4L_CTRL(VCENTER) \ ZL_V4L_CTRL(POWER_LINE_FREQUENCY) \ ZL_V4L_CTRL(HUE_AUTO) \ ZL_V4L_CTRL(WHITE_BALANCE_TEMPERATURE) \ -- 1.8.3.2 From 2f33e2b9a30d5933984174e50e89f39b072f391a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?IOhannes=20m=20zm=C3=B6lnig?= zmoel...@iem.at Date: Fri, 19 Jul 2013 21:51:32 +0200 Subject: [PATCH 2/2] pdp_matrix.h only makes sense if GSL is used --- include/pdp_matrix.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/pdp_matrix.h b/include/pdp_matrix.h index bda051b..4a677a2 100644 --- a/include/pdp_matrix.h +++ b/include/pdp_matrix.h @@ -20,6 +20,8 @@ #ifndef PDP_MATRIX_H #define PDP_MATRIX_H +#include pdp_config.h +#ifdef HAVE_PDP_GSL #include stdio.h #include gsl/gsl_block.h @@ -89,6 +91,7 @@ int pdp_packet_matrix_blas_mv(CBLAS_TRANSPOSE_t TransA, int pdp_packet_matrix_LU(int p_matrix); int pdp_packet_matrix_LU_to_inverse(int p_matrix); int pdp_packet_matrix_LU_solve(int p_matrix, int p_vector); +#endif #endif -- 1.8.3.2 signature.asc Description: OpenPGP digital signature ___ Pd-list@iem.at mailing list UNSUBSCRIBE and account-management - http://lists.puredata.info/listinfo/pd-list
Re: [PD] PDP test release
./configure found m_pd.h now (I think) checking m_pd.h usability... yes checking m_pd.h presence... yes but have this error message #check if pd is installed. if this fails make install will stop here. test -d /usr/local/lib/pd install -d /usr/local/lib/pd/extra install -m 755 pdp.pd_linux /usr/local/lib/pd/extra install: cannot stat `pdp.pd_linux': No such file or directory make: *** [install] Error 1 thanks again! Alan On Wed, May 15, 2013 at 10:30 PM, Tom Schouten t...@zwizwa.be wrote: On 05/15/2013 05:18 PM, Alan Brooker wrote: Hi Tom Sorry to be a pain- but got his error @ sudo make install not a pain at all. thanks for the report. #check if pd is installed. if this fails make install will stop here. test -d /usr/lib/pd-extended/bin/lib/**pd make: *** [install] Error 1 I have Pd installed at usr/local/lib/pd (and also pd-extended usr/lib/pd-extended) already? as a quick fix, you could copy the m_pd.h to somewhere in your standard include path, i.e. to /usr/local/include these are the directories where configure looks for m_pd.h apart from the standard include path: $prefix/pd/src $prefix/src/pd/src ../src/ /usr/local/include/pd/ Where $prefix is what you give configure as: configure --prefix=... I wonder if there is a canonical way to do m_pd.h discovery these days. ___ Pd-list@iem.at mailing list UNSUBSCRIBE and account-management - http://lists.puredata.info/listinfo/pd-list
Re: [PD] PDP test release
I have no problems with configure but make says nothing to be done. Make clean has no effect Sent from my iPhone On May 15, 2013, at 6:33 PM, Alan Brooker alan.brooker2...@gmail.commailto:alan.brooker2...@gmail.com wrote: ./configure found m_pd.h now (I think) checking m_pd.h usability... yes checking m_pd.h presence... yes but have this error message #check if pd is installed. if this fails make install will stop here. test -d /usr/local/lib/pd install -d /usr/local/lib/pd/extra install -m 755 pdp.pd_linux /usr/local/lib/pd/extra install: cannot stat `pdp.pd_linux': No such file or directory make: *** [install] Error 1 thanks again! Alan On Wed, May 15, 2013 at 10:30 PM, Tom Schouten t...@zwizwa.bemailto:t...@zwizwa.be wrote: On 05/15/2013 05:18 PM, Alan Brooker wrote: Hi Tom Sorry to be a pain- but got his error @ sudo make install not a pain at all. thanks for the report. #check if pd is installed. if this fails make install will stop here. test -d /usr/lib/pd-extended/bin/lib/pd make: *** [install] Error 1 I have Pd installed at usr/local/lib/pd (and also pd-extended usr/lib/pd-extended) already? as a quick fix, you could copy the m_pd.h to somewhere in your standard include path, i.e. to /usr/local/include these are the directories where configure looks for m_pd.h apart from the standard include path: $prefix/pd/src $prefix/src/pd/src ../src/ /usr/local/include/pd/ Where $prefix is what you give configure as: configure --prefix=... I wonder if there is a canonical way to do m_pd.h discovery these days. ___ Pd-list@iem.atmailto:Pd-list@iem.at mailing list UNSUBSCRIBE and account-management - http://lists.puredata.info/listinfo/pd-list ___ Pd-list@iem.at mailing list UNSUBSCRIBE and account-management - http://lists.puredata.info/listinfo/pd-list
