[PECL-DEV] Re: Ported some PHP5 PECL extensions to PHP7
No - my first commit to RAR repository was to support PHP7, there were no commits prior to this(it was named "started support for PHP7"). My only goal was to support PHP7 nothing more, nothing less. On 02/28/2016 06:32 PM, Jan Ehrhardt wrote: Tautvydas in php.pecl.dev (Sun, 28 Feb 2016 15:23:24 +0200): Yes I have backup of bitbucket repo(I can push to separate branch or send as zip to you), but I did not quite understand why you need it for PHP5 - there were only PHP7 rewrite, nothing more. As far as I could remember, you started with some general commits before you began working on PHP7. And you ended AFAIR with some memory leak fixing, but they might be PHP7-specific. Or my memory fails me and those commits were in some other extensions by you. Jan -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PECL-DEV] Re: Ported some PHP5 PECL extensions to PHP7
Tautvydas in php.pecl.dev (Sun, 28 Feb 2016 15:23:24 +0200): >Yes I have backup of bitbucket repo(I can push to separate branch or >send as zip to you), but I did not quite understand why you need it for >PHP5 - there were only PHP7 rewrite, nothing more. As far as I could remember, you started with some general commits before you began working on PHP7. And you ended AFAIR with some memory leak fixing, but they might be PHP7-specific. Or my memory fails me and those commits were in some other extensions by you. Jan -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PECL-DEV] Re: Ported some PHP5 PECL extensions to PHP7
Tautvydas in php.pecl.dev (Sun, 28 Feb 2016 16:13:00 +0200): >Just so you know I have fixed the ZTS, now testing and if everything is >ok will push to repo. > >> I have accepted PR`s. Thanks. I have recompiled all my 7.0.4RC1 builds with RAR and your other ports (except quickhash): https://www.apachelounge.com/viewtopic.php?t=6617 Jan -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PECL-DEV] Re: Ported some PHP5 PECL extensions to PHP7
Just so you know I have fixed the ZTS, now testing and if everything is ok will push to repo. I have accepted PR`s. And - yes I have backup of bitbucket repo - I can try to push them to https://github.com/esminis/php_pecl_rar as a separate branch or send you a zip. But I did not quite understand why you need it - there was only PHP7 rewrite, there was nothing for PHP5. On 02/28/2016 01:02 PM, Jan Ehrhardt wrote: Tautvydas in php.pecl.dev (Sun, 28 Feb 2016 09:57:41 +0200): I have created repository in github: https://github.com/esminis/php_pecl_rar If you can - create pull request (if you can`t then I can of course copy paste but there will be no references to you). 2 PR's created (with due reference to @weltling). And about TS build - you will probably need some #ifdef because seems that if ZTS is defined it is different, see #define RAR_G(v) in php_rar.h I will look into this sometime later(not exactly sure when) if you won`t. The same code is used in the PHP5 version, without #ifdef's. Something must have changed in the ZTS version of RAR_G(v) or VC14 is more strict than VC11 was. I do not know how to fix it. After windows version is fixed I will try to do pull request to main repository maybe maintainer will accept it. OK. https://bitbucket.org/esminis/php_pecl_rar It is a pity you deleted that repo, because the history of the non-PHP7 commits is now lost. I wanted to improve the PHP5 branch with your findings, but cannot do that anymore. Do you still have the commit history as it was on bitbucket? Jan -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PECL-DEV] Re: Ported some PHP5 PECL extensions to PHP7
Hi, Thanks for fix. I have created repository in github: https://github.com/esminis/php_pecl_rar If you can - create pull request (if you can`t then I can of course copy paste but there will be no references to you). And about TS build - you will probably need some #ifdef because seems that if ZTS is defined it is different, see #define RAR_G(v) in php_rar.h I will look into this sometime later(not exactly sure when) if you won`t. After windows version is fixed I will try to do pull request to main repository maybe maintainer will accept it. On 02/28/2016 04:36 AM, Jan Ehrhardt wrote: Jan Ehrhardt in php.pecl.dev (Sat, 27 Feb 2016 13:48:13 +0100): Tautvydas in php.pecl.dev (Sat, 27 Feb 2016 09:13:51 +0200): Here are source repositories: https://bitbucket.org/esminis/php_pecl_rar Wonderful job! Could somebody with karma give Tautvydas access to the PECL sources, please? And rar has some problems with VC14. TS x64: rar_stream.c(923): error C2198: 'function through pointer': too few arguments for call rar_stream.c(962): error C2198: 'function through pointer': too few arguments for call rar_stream.c(964): error C2198: 'function through pointer': too few arguments for call NTS x64: dll.obj : error LNK2001: unresolved external symbol "void __cdecl cleandata(void *,unsigned __int64)" (?cleandata@@YAXPEAX_K@Z) crypt.obj : error LNK2019: unresolved external symbol "public: __cdecl SecPassword::SecPassword(void)" (??0SecPassword@@QEAA@XZ) referenced in function "public: __cdecl CryptKeyCache Item::CryptKeyCacheItem(void)" (??0CryptKeyCacheItem@@QEAA@XZ) I fixed the NTS builds. Config.w32 did not include secpassword.cpp: https://github.com/Jan-E/php_pecl_rar7/commit/b9c6922c4677ffc5759669d530664c302b967686 @Tautvydas please adjust your config.w32 as well. I did not fix the TS builds yet. There are arguments missing in the .get() and .put() functions in https://github.com/Jan-E/php_pecl_rar7/blob/master/rar_stream.c#L923 https://github.com/Jan-E/php_pecl_rar7/blob/master/rar_stream.c#L961 https://github.com/Jan-E/php_pecl_rar7/blob/master/rar_stream.c#L964 Does anyone know how to fix the TS builds (Windows, VC14)? Jan -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PECL-DEV] Re: Ported some PHP5 PECL extensions to PHP7
Jan Ehrhardt in php.pecl.dev (Sat, 27 Feb 2016 13:48:13 +0100): >Tautvydas in php.pecl.dev (Sat, 27 Feb 2016 09:13:51 +0200): >>Here are source repositories: >> >>https://bitbucket.org/esminis/php_pecl_rar > >Wonderful job! Could somebody with karma give Tautvydas access to the PECL >sources, please? >And rar has some problems with VC14. > >TS x64: > >rar_stream.c(923): error C2198: 'function through pointer': too few >arguments for call >rar_stream.c(962): error C2198: 'function through pointer': too few >arguments for call >rar_stream.c(964): error C2198: 'function through pointer': too few >arguments for call > >NTS x64: > >dll.obj : error LNK2001: unresolved external symbol "void __cdecl >cleandata(void *,unsigned __int64)" (?cleandata@@YAXPEAX_K@Z) >crypt.obj : error LNK2019: unresolved external symbol "public: __cdecl >SecPassword::SecPassword(void)" (??0SecPassword@@QEAA@XZ) referenced in >function "public: __cdecl CryptKeyCache Item::CryptKeyCacheItem(void)" >(??0CryptKeyCacheItem@@QEAA@XZ) I fixed the NTS builds. Config.w32 did not include secpassword.cpp: https://github.com/Jan-E/php_pecl_rar7/commit/b9c6922c4677ffc5759669d530664c302b967686 @Tautvydas please adjust your config.w32 as well. I did not fix the TS builds yet. There are arguments missing in the .get() and .put() functions in https://github.com/Jan-E/php_pecl_rar7/blob/master/rar_stream.c#L923 https://github.com/Jan-E/php_pecl_rar7/blob/master/rar_stream.c#L961 https://github.com/Jan-E/php_pecl_rar7/blob/master/rar_stream.c#L964 Does anyone know how to fix the TS builds (Windows, VC14)? Jan -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PECL-DEV] Re: Ported some PHP5 PECL extensions to PHP7
On Sat, 27 Feb 2016, Jan Ehrhardt wrote: > Tautvydas in php.pecl.dev (Sat, 27 Feb 2016 09:13:51 +0200): > >Here are source repositories: > > > >https://bitbucket.org/esminis/php_pecl_judy > >https://bitbucket.org/esminis/php_pecl_spl_types > >https://bitbucket.org/esminis/php_pecl_id3 > >https://bitbucket.org/esminis/php_pecl_rar > >https://bitbucket.org/esminis/php_pecl_quickhash > >https://bitbucket.org/esminis/php_pecl_bbcode > >https://bitbucket.org/esminis/php_pecl_rpmreader > > Wonderful job! Could somebody with karma give Tautvydas access to the PECL > sources, please? > > See > https://phpdev.toolsforresearch.com/php-7.0.4RC1-Win32-VC14-x64.htm > https://phpdev.toolsforresearch.com/php-7.0.4RC1-Win32-VC14-x64.zip > for the Windows builds with judy, spl_types, id3, bbcode and rpmreader. > I am compiling the other versions right now. > > Quickhash lacks a config.w32, so that could not be compiled under VC14. Quickhash specifically does not work on Windows. It's Linux only. cheers, Derick -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PECL-DEV] Re: Ported some PHP5 PECL extensions to PHP7
Tautvydas in php.pecl.dev (Sat, 27 Feb 2016 09:13:51 +0200): >Here are source repositories: > >https://bitbucket.org/esminis/php_pecl_judy >https://bitbucket.org/esminis/php_pecl_spl_types >https://bitbucket.org/esminis/php_pecl_id3 >https://bitbucket.org/esminis/php_pecl_rar >https://bitbucket.org/esminis/php_pecl_quickhash >https://bitbucket.org/esminis/php_pecl_bbcode >https://bitbucket.org/esminis/php_pecl_rpmreader Wonderful job! Could somebody with karma give Tautvydas access to the PECL sources, please? See https://phpdev.toolsforresearch.com/php-7.0.4RC1-Win32-VC14-x64.htm https://phpdev.toolsforresearch.com/php-7.0.4RC1-Win32-VC14-x64.zip for the Windows builds with judy, spl_types, id3, bbcode and rpmreader. I am compiling the other versions right now. Quickhash lacks a config.w32, so that could not be compiled under VC14. And rar has some problems with VC14. TS x64: rar_stream.c(923): error C2198: 'function through pointer': too few arguments for call rar_stream.c(962): error C2198: 'function through pointer': too few arguments for call rar_stream.c(964): error C2198: 'function through pointer': too few arguments for call NTS x64: dll.obj : error LNK2001: unresolved external symbol "void __cdecl cleandata(void *,unsigned __int64)" (?cleandata@@YAXPEAX_K@Z) crypt.obj : error LNK2019: unresolved external symbol "public: __cdecl SecPassword::SecPassword(void)" (??0SecPassword@@QEAA@XZ) referenced in function "public: __cdecl CryptKeyCache Item::CryptKeyCacheItem(void)" (??0CryptKeyCacheItem@@QEAA@XZ) Jan -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
