Hi: http://news.php.net/php.pecl.dev/15288 this is my account application address, is still waiting for the review, it has been half a month, I am still waiting, ask the community to handle it, thank you! Viest 在2018年04月26日 18:32，Anatol Belski 写道： Hi Viest, On Thu, 2018-04-26 at 01:21 +0800, dev wrote: > Hi: > > Thank you very much for the case provided by "Anatol Belski<a...@php.ne > t>", which was very helpful to me! > > I modified the project (https://github.com/viest/php-ext-excel-export > ) and used valgrind to test the memory process. If there are other > problems with the project, I will make quick changes! > > Thanks to the help of "Anatol Belski<a...@php.net>", I believe PHP's > ecology will be getting better and better. > thanks for checking the comments. Your fixes look good so far. I've found a place which can potentially cause a memory leak. See https://gi thub.com/viest/php-ext-excel-export/blob/master/kernel/excel.c#L160 . For example if the filename method would be called multiple times successive. Other than that, IMO the quality should be now acceptable. It's now to see for perhaps more comments. Processing the account request might take some time, but someone from the admin team would sure come to it. Regards Anatol
