[Bug 1128373] Review Request: perl-Audio-Cuefile-Parser - Perl cuefile parser module
https://bugzilla.redhat.com/show_bug.cgi?id=1128373 Petr Šabata psab...@redhat.com changed: What|Removed |Added Flags||needinfo?(i...@cicku.me) --- Comment #5 from Petr Šabata psab...@redhat.com --- This looks like a dead review but I'm not allowed to reset the review flag. Christopher, consider closing this. -- You are receiving this mail because: You are on the CC list for the bug. -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
[Bug 1128373] Review Request: perl-Audio-Cuefile-Parser - Perl cuefile parser module
https://bugzilla.redhat.com/show_bug.cgi?id=1128373 Petr Šabata psab...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Blocks||201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Flags|fedora-review? | |needinfo?(i...@cicku.me) | Last Closed||2015-08-18 08:51:53 --- Comment #6 from Petr Šabata psab...@redhat.com --- Actually never mind. UI issues. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
[Bug 1128373] Review Request: perl-Audio-Cuefile-Parser - Perl cuefile parser module
https://bugzilla.redhat.com/show_bug.cgi?id=1128373 Petr Šabata psab...@redhat.com changed: What|Removed |Added CC||psab...@redhat.com --- Comment #4 from Petr Šabata psab...@redhat.com --- Anything new here? -- You are receiving this mail because: You are on the CC list for the bug. -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
[Bug 1128373] Review Request: perl-Audio-Cuefile-Parser - Perl cuefile parser module
https://bugzilla.redhat.com/show_bug.cgi?id=1128373 --- Comment #2 from Hans de Goede hdego...@redhat.com --- Hi Christopher, Many thanks for the review. I'm going in vacation in 2 days, and I still need to wrap up various other things, so I'm not sure if I will get around to doing a new version before then. As for swapping, I'm all in favor of that. bug 1128335 looks like an easy review, so I'll go and review it right away. I've plenty more perl modules coming up. I'm trying to at least get all the modules squeezeboxserver needs which have a binary component packaged up. As these cannot be used as bundled by upstream on ARM. So when I'm back I'll happily swap some more reviews for the rest. Note these are my first perl packages, as such it may be best if I review non perl packages for you, and I may need some guidance left and right. perl beginner question, how did you come to the missing BuildRequires ? Thanks, Hans -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZloKcJMvvGa=cc_unsubscribe -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
[Bug 1128373] Review Request: perl-Audio-Cuefile-Parser - Perl cuefile parser module
https://bugzilla.redhat.com/show_bug.cgi?id=1128373 Petr Šabata psab...@redhat.com changed: What|Removed |Added CC||psab...@redhat.com --- Comment #3 from Petr Šabata psab...@redhat.com --- (In reply to Hans de Goede from comment #2) perl beginner question, how did you come to the missing BuildRequires ? You need to go through the perl code and see what modules get actually loaded. Look for the `use', `require' and `no' statements, although there are other ways, too... `use' and `no' are evaluated, unlike `require', at compile time and modules loaded this way will always be needed (if your module gets actually tested). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=W10SQV2hyya=cc_unsubscribe -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
[Bug 1128373] Review Request: perl-Audio-Cuefile-Parser - Perl cuefile parser module
https://bugzilla.redhat.com/show_bug.cgi?id=1128373
--- Comment #1 from Christopher Meng i...@cicku.me ---
1. Missing BRs of module itself:
perl(Carp)
perl(Class::Struct)
perl(IO::File)
perl(strict)
perl(warnings)
2. Missing BR of tests:
perl(File::Basename)
3. Drop this in the SPEC:
find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2/dev/null \;
4. Hint for f21+ do not generate packlist: perl Makefile.PL NO_PACKLIST=1
Finally, swap with bug 1128335 if you have time.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=G1RutYVBkia=cc_unsubscribe
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/perl-devel
[Bug 1128373] Review Request: perl-Audio-Cuefile-Parser - Perl cuefile parser module
https://bugzilla.redhat.com/show_bug.cgi?id=1128373 Hans de Goede hdego...@redhat.com changed: What|Removed |Added CC||perl-devel@lists.fedoraproj ||ect.org -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xpR0q4BhZ9a=cc_unsubscribe -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
[Bug 1128373] Review Request: perl-Audio-Cuefile-Parser - Perl cuefile parser module
https://bugzilla.redhat.com/show_bug.cgi?id=1128373 Christopher Meng i...@cicku.me changed: What|Removed |Added Status|NEW |ASSIGNED CC||i...@cicku.me Assignee|nob...@fedoraproject.org|i...@cicku.me -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vz6kwAuo21a=cc_unsubscribe -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
