[Bug 1307459] Review Request: perl-Test-Fake-HTTPD - Fake HTTP server module for testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307459



--- Comment #11 from Fedora Update System  ---
perl-Test-Fake-HTTPD-0.07-2.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1307459] Review Request: perl-Test-Fake-HTTPD - Fake HTTP server module for testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307459



--- Comment #10 from Fedora Update System  ---
perl-Test-Fake-HTTPD-0.07-2.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1307459] Review Request: perl-Test-Fake-HTTPD - Fake HTTP server module for testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307459

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-03-20 21:52:04



-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1307459] Review Request: perl-Test-Fake-HTTPD - Fake HTTP server module for testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307459



--- Comment #9 from Fedora Update System  ---
perl-Test-Fake-HTTPD-0.07-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-035c3b864e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1307459] Review Request: perl-Test-Fake-HTTPD - Fake HTTP server module for testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307459

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
perl-Test-Fake-HTTPD-0.07-2.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-bad94cd096

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1307459] Review Request: perl-Test-Fake-HTTPD - Fake HTTP server module for testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307459



--- Comment #6 from Fedora Update System  ---
perl-Test-Fake-HTTPD-0.07-2.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-bad94cd096

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1307459] Review Request: perl-Test-Fake-HTTPD - Fake HTTP server module for testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307459



--- Comment #7 from Fedora Update System  ---
perl-Test-Fake-HTTPD-0.07-2.el7 has been submitted as an update to Fedora EPEL
7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-035c3b864e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1307459] Review Request: perl-Test-Fake-HTTPD - Fake HTTP server module for testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307459



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/perl-Test-Fake-HTTPD

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1307459] Review Request: perl-Test-Fake-HTTPD - Fake HTTP server module for testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307459



--- Comment #4 from Denis Fateyev  ---
(In reply to Petr Pisar from comment #2)
> FIX: Build-require `perl(Config)' (inc/Module/Install/Can.pm:5).
> FIX: Build-requie `perl(Fcntl)' (inc/Module/Install/Makefile.pm:7).

Oh, forgot about these two. Will add them.

> FIX: Do install the HTTPD.pm.sslparam file. This can be achieved by removing
> `-b .sslparam' arguments from %patch0 command.

I did it just to have the original version in buildroot for testing.
Seems not harmful, but sure I'll remove this backup anyway.

Thanks for reviewing the package.

Updated version:
Spec URL: http://www.fateyev.com/RPMS/Fedora22/perl-Test-Fake-HTTPD.spec
SRPM URL:
http://www.fateyev.com/RPMS/Fedora22/perl-Test-Fake-HTTPD-0.07-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1307459] Review Request: perl-Test-Fake-HTTPD - Fake HTTP server module for testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307459



--- Comment #3 from Upstream Release Monitoring 
 ---
dfateyev's scratch build of perl-Test-Fake-HTTPD-0.07-2.fc23.denf.src.rpm for
rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12994040

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1307459] Review Request: perl-Test-Fake-HTTPD - Fake HTTP server module for testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307459

Petr Pisar  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Petr Pisar  ---
URL and Source0 are usable Ok.
Source archive is original (SHA-256:
708e6e5f168b562c3d060369583fc146eec1bbcf526d48f4e5ef8ee8f9f41209). Ok.
License verified from README.pod, META.yml, lib/Test/Fake/HTTPD.pm.
No XS code used, noarch BuildArch is Ok.

TODO: Add a dot at the end of description's last sentence.

TODO: Prune the ./inc directory and build-require inc::Module::Install modules.
Or fulfill these:

FIX: Build-require `perl(Config)' (inc/Module/Install/Can.pm:5).
FIX: Build-requie `perl(Fcntl)' (inc/Module/Install/Makefile.pm:7).

All tests pass. Ok.

$ rpmlint perl-Test-Fake-HTTPD.spec
../SRPMS/perl-Test-Fake-HTTPD-0.07-1.fc24.src.rpm
../RPMS/noarch/perl-Test-Fake-HTTPD-0.07-1.fc24.noarch.rpm 
(none): E: no installed packages by name perl-Test-Fake-HTTPD.spec
perl-Test-Fake-HTTPD.src: W: spelling-error %description -l en_US masaki ->
Saki
perl-Test-Fake-HTTPD.src: W: spelling-error %description -l en_US cpan -> can,
pan, span
perl-Test-Fake-HTTPD.noarch: W: spelling-error %description -l en_US masaki ->
Saki
perl-Test-Fake-HTTPD.noarch: W: spelling-error %description -l en_US cpan ->
can, pan, span
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Test-Fake-HTTPD-0.07-1.fc24.noarch.rpm 
drwxr-xr-x2 root   
root0 Feb 15 15:17 /usr/share/doc/perl-Test-Fake-HTTPD
-rw-r--r--1 rootroot  474 Jan 25  2015
/usr/share/doc/perl-Test-Fake-HTTPD/Changes
-rw-r--r--1 rootroot 6758 Jan 25  2015
/usr/share/doc/perl-Test-Fake-HTTPD/README.pod
-rw-r--r--1 rootroot 2325 Feb 15 15:17
/usr/share/man/man3/Test::Fake::HTTPD.3pm.gz
-rw-r--r--1 rootroot 2327 Feb 15 15:17
/usr/share/man/man3/Test::Fake::README.3pm.gz
drwxr-xr-x2 rootroot0 Feb 15 15:17
/usr/share/perl5/vendor_perl/Test
drwxr-xr-x2 rootroot0 Feb 15 15:17
/usr/share/perl5/vendor_perl/Test/Fake
-rw-r--r--1 rootroot 7024 Feb 15 15:17
/usr/share/perl5/vendor_perl/Test/Fake/HTTPD.pm
-rw-r--r--1 rootroot 6758 Jan 25  2015
/usr/share/perl5/vendor_perl/Test/Fake/HTTPD.pm.sslparam
-rw-r--r--1 rootroot 6758 Jan 25  2015
/usr/share/perl5/vendor_perl/Test/Fake/README.pod

FIX: Do install the HTTPD.pm.sslparam file. This can be achieved by removing
`-b .sslparam' arguments from %patch0 command.

$ rpm -q --requires -p
../RPMS/noarch/perl-Test-Fake-HTTPD-0.07-1.fc24.noarch.rpm | sort -f | uniq -c
  1 perl(:MODULE_COMPAT_5.22.1)
  1 perl(:VERSION) >= 5.8.0
  1 perl(Carp)
  1 perl(Exporter)
  1 perl(HTTP::Daemon)
  1 perl(HTTP::Daemon::SSL)
  1 perl(HTTP::Message::PSGI)
  1 perl(Scalar::Util)
  1 perl(strict)
  1 perl(Test::TCP)
  1 perl(Time::HiRes)
  1 perl(URI)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
TODO: Constrain `perl(Scalar::Util)' with `>= 1.14'.

$ rpm -q --provides -p
../RPMS/noarch/perl-Test-Fake-HTTPD-0.07-1.fc24.noarch.rpm | sort -f | uniq -c
  1 perl(Test::Fake::HTTPD) = 0.07
  1 perl-Test-Fake-HTTPD = 0.07-1.fc24
Binary provides are Ok.

$ resolvedeps rawhide
../RPMS/noarch/perl-Test-Fake-HTTPD-0.07-1.fc24.noarch.rpm
Binary dependencies resolvable. Ok.

Package builds in F24
(http://koji.fedoraproject.org/koji/taskinfo?taskID=12993425). Ok.

Otherwise the package is in line Fedora and Perl packaging guide lines.

Please correct all `FIX' items and consider fixing `TODO' items before building
the package.

Resolution: Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1307459] Review Request: perl-Test-Fake-HTTPD - Fake HTTP server module for testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307459



--- Comment #1 from Upstream Release Monitoring 
 ---
ppisar's scratch build of perl-Test-Fake-HTTPD-0.07-1.fc24.src.rpm for f24
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12993425

-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1307459] Review Request: perl-Test-Fake-HTTPD - Fake HTTP server module for testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307459

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com
   Assignee|nob...@fedoraproject.org|ppi...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org

[Bug 1307459] Review Request: perl-Test-Fake-HTTPD - Fake HTTP server module for testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307459

Denis Fateyev  changed:

   What|Removed |Added

 CC||perl-devel@lists.fedoraproj
   ||ect.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org