[Bug 2072972] Review Request: perl-IP-Geolocation-MMDB - Read MaxMind DB files
https://bugzilla.redhat.com/show_bug.cgi?id=2072972 Andreas Vögele changed: What|Removed |Added Resolution|--- |RAWHIDE Fixed In Version||perl-IP-Geolocation-MMDB-1. ||010-1.fc39 Status|ASSIGNED|CLOSED Last Closed||2023-07-05 13:33:42 -- You are receiving this mail because: You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2072972 ___ perl-devel mailing list -- perl-devel@lists.fedoraproject.org To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2072972] Review Request: perl-IP-Geolocation-MMDB - Read MaxMind DB files
https://bugzilla.redhat.com/show_bug.cgi?id=2072972 --- Comment #7 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-IP-Geolocation-MMDB -- You are receiving this mail because: You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2072972 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202072972%23c7 ___ perl-devel mailing list -- perl-devel@lists.fedoraproject.org To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2072972] Review Request: perl-IP-Geolocation-MMDB - Read MaxMind DB files
https://bugzilla.redhat.com/show_bug.cgi?id=2072972 Michal Josef Spacek changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Michal Josef Spacek --- Source file is ok Summary is ok License is ok Description is ok URL and Source are ok All tests passed BuildRequires are ok $ rpm -qp --requires perl-IP-Geolocation-MMDB-1.010-1.fc39.x86_64.rpm | sort | uniq -c | grep -v rpmlib 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libc.so.6()(64bit) 1 libmaxminddb.so.0()(64bit) 1 libperl.so.5.36()(64bit) 1 perl(IP::Geolocation::MMDB::Metadata) 1 perl-libs 1 perl(Math::BigInt) >= 1.999806 1 perl(:MODULE_COMPAT_5.36.1) 1 perl(utf8) 1 perl(:VERSION) >= 5.16.0 1 perl(warnings) 1 perl(XSLoader) 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -qp --provides perl-IP-Geolocation-MMDB-1.010-1.fc39.x86_64.rpm | sort | uniq -c 1 perl(IP::Geolocation::MMDB::Metadata) = 1.010 1 perl-IP-Geolocation-MMDB(x86-64) = 1.010-1.fc39 1 perl(IP::Geolocation::MMDB) = 1.010 1 perl-IP-Geolocation-MMDB = 1.010-1.fc39 Binary provides are Ok. $ rpmlint perl-IP-Geolocation-MMDB-* 4 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s Rpmlint is ok The package is in line with Fedora and Perl packaging guide lines. Resolution: approved -- You are receiving this mail because: You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2072972 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202072972%23c6 ___ perl-devel mailing list -- perl-devel@lists.fedoraproject.org To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2072972] Review Request: perl-IP-Geolocation-MMDB - Read MaxMind DB files
https://bugzilla.redhat.com/show_bug.cgi?id=2072972
--- Comment #4 from Michal Josef Spacek ---
Hi Andreas,
There is one missing thing with not explicitly named files in spec file.
Need to name files in %{perl_vendorlib}/ and %{_mandir}/man3/
See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2072972
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%202072972%23c4
___
perl-devel mailing list -- perl-devel@lists.fedoraproject.org
To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[Bug 2072972] Review Request: perl-IP-Geolocation-MMDB - Read MaxMind DB files
https://bugzilla.redhat.com/show_bug.cgi?id=2072972 Petr Pisar changed: What|Removed |Added CC||ppi...@redhat.com Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2072972 ___ perl-devel mailing list -- perl-devel@lists.fedoraproject.org To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2072972] Review Request: perl-IP-Geolocation-MMDB - Read MaxMind DB files
https://bugzilla.redhat.com/show_bug.cgi?id=2072972 Bug 2072972 depends on bug 2072968, which changed state. Bug 2072968 Summary: Review Request: perl-Alien-libmaxminddb - Find libmaxminddb https://bugzilla.redhat.com/show_bug.cgi?id=2072968 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2072972 ___ perl-devel mailing list -- perl-devel@lists.fedoraproject.org To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2072972] Review Request: perl-IP-Geolocation-MMDB - Read MaxMind DB files
https://bugzilla.redhat.com/show_bug.cgi?id=2072972 --- Comment #3 from Andreas Vögele --- Hello Michal, thanks a lot for the review. I've removed the MODULE_COMPAT requirement. I had already updated the version and the license in Copr. Today's build with review output in the "fedora-review" subfolder is here: https://download.copr.fedorainfracloud.org/results/voegelas/fedora/fedora-rawhide-x86_64/05934643-perl-IP-Geolocation-MMDB/ Kind regards, Andreas Spec URL: https://download.copr.fedorainfracloud.org/results/voegelas/fedora/fedora-rawhide-x86_64/05934643-perl-IP-Geolocation-MMDB/perl-IP-Geolocation-MMDB.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/voegelas/fedora/fedora-rawhide-x86_64/05934643-perl-IP-Geolocation-MMDB/perl-IP-Geolocation-MMDB-1.010-1.fc39.src.rpm Description: A Perl module that reads MaxMind DB files and maps IP addresses to location information such as country and city names Fedora Account System Username: voegelas -- You are receiving this mail because: You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2072972 ___ perl-devel mailing list -- perl-devel@lists.fedoraproject.org To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2072972] Review Request: perl-IP-Geolocation-MMDB - Read MaxMind DB files
https://bugzilla.redhat.com/show_bug.cgi?id=2072972 --- Comment #2 from Michal Josef Spacek --- @andr...@andreasvoegele.com Hi Andreas, could we update to last version of module from CPAN? I was looking at https://bugzilla.redhat.com/show_bug.cgi?id=2072968 and the issues in this are similar. 1) License 2) MODULE_COMPAT -- You are receiving this mail because: You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2072972 ___ perl-devel mailing list -- perl-devel@lists.fedoraproject.org To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2072972] Review Request: perl-IP-Geolocation-MMDB - Read MaxMind DB files
https://bugzilla.redhat.com/show_bug.cgi?id=2072972 --- Comment #1 from Michal Josef Spacek --- Sorry, I forgot about this review. -- You are receiving this mail because: You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2072972 ___ perl-devel mailing list -- perl-devel@lists.fedoraproject.org To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2072972] Review Request: perl-IP-Geolocation-MMDB - Read MaxMind DB files
https://bugzilla.redhat.com/show_bug.cgi?id=2072972 Petr Pisar changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2072972 ___ perl-devel mailing list -- perl-devel@lists.fedoraproject.org To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2072972] Review Request: perl-IP-Geolocation-MMDB - Read MaxMind DB files
https://bugzilla.redhat.com/show_bug.cgi?id=2072972 Michal Josef Spacek changed: What|Removed |Added Doc Type|--- |If docs needed, set a value CC||mspa...@redhat.com Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mspa...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2072972 ___ perl-devel mailing list -- perl-devel@lists.fedoraproject.org To unsubscribe send an email to perl-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/perl-devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
