[Bug 992734] perl-Test-Class: FTBFS in rawhide
https://bugzilla.redhat.com/show_bug.cgi?id=992734 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|st...@silug.org |ppi...@redhat.com --- Comment #8 from Petr Pisar ppi...@redhat.com --- Fixed perl-Test-Simple is being built now. I will push and build fixed perl-Test-Class in turn. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KbyLZiZzoKa=cc_unsubscribe -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
[Bug 992734] perl-Test-Class: FTBFS in rawhide
https://bugzilla.redhat.com/show_bug.cgi?id=992734 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-Test-Class-0.39-3.fc20 Resolution|--- |RAWHIDE Last Closed||2013-08-09 04:40:28 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZKbElUOE2Ga=cc_unsubscribe -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
[Bug 992734] perl-Test-Class: FTBFS in rawhide
https://bugzilla.redhat.com/show_bug.cgi?id=992734 Ralf Corsepius rc040...@freenet.de changed: What|Removed |Added Blocks||992709 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PeeL5r7hGua=cc_unsubscribe -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
[Bug 992734] perl-Test-Class: FTBFS in rawhide
https://bugzilla.redhat.com/show_bug.cgi?id=992734 Ralf Corsepius rc040...@freenet.de changed: What|Removed |Added Blocks||992578 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=APJGtJR9Ksa=cc_unsubscribe -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
[Bug 992734] perl-Test-Class: FTBFS in rawhide
https://bugzilla.redhat.com/show_bug.cgi?id=992734 --- Comment #3 from Petr Pisar ppi...@redhat.com --- Test-Simple 0.98_05 fixes another bugs that appeared in the early rebuild stage, thus I upgraded to the this development version intentionally. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rItlYcFV0Wa=cc_unsubscribe -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
[Bug 992734] perl-Test-Class: FTBFS in rawhide
https://bugzilla.redhat.com/show_bug.cgi?id=992734 --- Comment #4 from Petr Pisar ppi...@redhat.com --- This looks like a different wording introduced in 0.98_04. I have already adapted other packages due this change. I will try it here too. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=t5g24Y5OIFa=cc_unsubscribe -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
[Bug 992734] perl-Test-Class: FTBFS in rawhide
https://bugzilla.redhat.com/show_bug.cgi?id=992734 --- Comment #5 from Petr Pisar ppi...@redhat.com --- Created attachment 783932 -- https://bugzilla.redhat.com/attachment.cgi?id=783932action=edit Fix up to 0.98_04 This patch fixes Test-Class test failures due to changes in Test-Simple up to 0.98_04. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yQzVyGvS92a=cc_unsubscribe -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
[Bug 992734] perl-Test-Class: FTBFS in rawhide
https://bugzilla.redhat.com/show_bug.cgi?id=992734
--- Comment #6 from Petr Pisar ppi...@redhat.com ---
There are mysterious failure with Test-Simple 0.98_05. They are caused with
this Test-Simple commit:
commit 1d69410753cf233807ef9526b75d74afbddf92d8
Author: nnutter i...@nnutter.com
Date: Thu Apr 4 22:27:28 2013 -0500
fix bug when test_fail is called via a do statement
test_fail used $0 as the filename instead of the filename reported by
caller. Under normal execution these would be the same but if the test
is executed by a do block then these would no longer be the same.
diff --git a/lib/Test/Builder/Tester.pm b/lib/Test/Builder/Tester.pm
index f84e630..d9ac9e7 100644
--- a/lib/Test/Builder/Tester.pm
+++ b/lib/Test/Builder/Tester.pm
@@ -222,7 +222,7 @@ sub test_fail {
$line = $line + ( shift() || 0 );# prevent warnings
# expect that on stderr
-$err-expect(# Failed test ($0 at line $line));
+$err-expect(# Failed test ($filename at line $line));
}
=item test_diag
They happen when Test-Class test calls test_err(qr//):
[test@fedora-20 test-class]$ perl -I/tmp/Test-Simple-0.98_05/lib/ -T -Ilib
t/runtests_return.t
1..2
ok 1 - early return handled (skip)
not ok 2 - early return handled (fail)
# Failed test 'early return handled (fail)'
# at t/runtests_return.t line 42.
# STDERR is:
# # Failed test '(Bar::darwin_only returned before plan complete)'
# # at lib/Test/Class.pm line 392.
# # (in Bar-darwin_only)
# # Failed test '(Bar::darwin_only returned before plan complete)'
# # at lib/Test/Class.pm line 392.
# # (in Bar-darwin_only)
#
# not:
# (?^s:.*in Bar-darwin_only.*)
#
# as expected
But I don't understand why that fails because it nowhere checks the file name.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=j6PdgJcwqla=cc_unsubscribe
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/perl-devel
[Bug 992734] perl-Test-Class: FTBFS in rawhide
https://bugzilla.redhat.com/show_bug.cgi?id=992734
--- Comment #7 from Petr Pisar ppi...@redhat.com ---
Hm, no. It's caused by this Test-Simple commit:
commit 497965306444982d4948e24811e44e72619885f8
Author: Michael G. Schwern schw...@pobox.com
Date: Mon Apr 15 17:13:43 2013 +0100
Fix Test::Builder::Tester so it works with subtests.
They already work in TB1.5 and this wasn't hard to fix.
For #350
diff --git a/lib/Test/Builder/Tester.pm b/lib/Test/Builder/Tester.pm
index 573c818..2c49cf4 100644
--- a/lib/Test/Builder/Tester.pm
+++ b/lib/Test/Builder/Tester.pm
@@ -98,15 +98,13 @@ my $err = tie *$error_handle,
Test::Builder::Tester::Tie,
# for remembering that we're testing and where we're testing at
my $testing = 0;
my $testing_num;
+my $original_is_passing;
# remembering where the file handles were originally connected
my $original_output_handle;
my $original_failure_handle;
my $original_todo_handle;
-my $original_test_number;
-my $original_harness_state;
-
my $original_harness_env;
# function that starts testing and redirects the filehandles for now
@@ -134,6 +132,8 @@ sub _start_testing {
$testing = 1;
$testing_num = $t-current_test;
$t-current_test(0);
+$original_is_passing = $t-is_passing;
+$t-is_passing(1);
# look, we shouldn't do the ending stuff
$t-no_ending(1);
@@ -329,6 +329,7 @@ sub test_test {
# restore the test no, etc, back to the original point
$t-current_test($testing_num);
$testing = 0;
+$t-is_passing($original_is_passing);
# re-enable the original setting of the harness
$ENV{HARNESS_ACTIVE} = $original_harness_env;
@@ -469,11 +470,19 @@ sub expect {
my @checks = @_;
foreach my $check (@checks) {
+$check = $self-_account_for_subtest($check);
$check = $self-_translate_Failed_check($check);
push @{ $self-{wanted} }, ref $check ? $check : $check\n;
}
}
+sub _account_for_subtest {
+my( $self, $check ) = @_;
+
+# Since we ship with Test::Builder, calling a private method is
safe...ish.
+return $t-_indent . $check;
+}
+
sub _translate_Failed_check {
my( $self, $check ) = @_;
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=9idkdQmyuUa=cc_unsubscribe
--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
perl-devel mailing list
perl-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/perl-devel
[Bug 992734] perl-Test-Class: FTBFS in rawhide
https://bugzilla.redhat.com/show_bug.cgi?id=992734 Petr Pisar ppi...@redhat.com changed: What|Removed |Added URL||https://github.com/schwern/ ||test-more/issues/387 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OXHPh9SeFga=cc_unsubscribe -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
[Bug 992734] perl-Test-Class: FTBFS in rawhide
https://bugzilla.redhat.com/show_bug.cgi?id=992734 Petr Pisar ppi...@redhat.com changed: What|Removed |Added CC||ppi...@redhat.com External Bug ID||CPAN 85004 --- Comment #1 from Petr Pisar ppi...@redhat.com --- Tests are not compatible with Test-Simple 0.98_05. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NWKM11quYia=cc_unsubscribe -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
[Bug 992734] perl-Test-Class: FTBFS in rawhide
https://bugzilla.redhat.com/show_bug.cgi?id=992734 Ralf Corsepius rc040...@freenet.de changed: What|Removed |Added Blocks||992485 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hetWTBNcgfa=cc_unsubscribe -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
[Bug 992734] perl-Test-Class: FTBFS in rawhide
https://bugzilla.redhat.com/show_bug.cgi?id=992734 Ralf Corsepius rc040...@freenet.de changed: What|Removed |Added CC||rc040...@freenet.de --- Comment #2 from Ralf Corsepius rc040...@freenet.de --- (In reply to Petr Pisar from comment #1) Tests are not compatible with Test-Simple 0.98_05. According to CPAN Test-Simple 0.98_05 is a developer release. Looking at the timestamps, I would not want to exclude it's a stalled development release. Q: Any particular reason for using this version instead of the official stable version (0.98)? IMO, it's worth considering downgrading to 0.98, but I am sure about it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=U0v6KMtxhYa=cc_unsubscribe -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/perl-devel
