Re: Change 22021: Upgrade to Test::Harness 2.40.
Andy Lester wrote: wrt RGS feedback,
I don't get the rationale for this change; diag() is supposed to be
used for error/diagnostic messages, right ? not for comments, more
mundane in nature. (This perturbs the nice line-up of my test logs.
Go ahead and patch it. I'll add an "unless $ENV{PERL_CORE}" in the next
release.
Darn dual-life modules...
xoa
Well, it seems Ive been abusing diag() for some time now :-O
Is there a 'right' way to do this ? perhaps just using ok() ?
or maybe a new function, ex: note() is better:
note..ok# YOUR INFORMATIONAL
MESSAGE HERE
Since Ive been using diag() to denote groups of tests,
which separates chunks of foo . ok,
But this appears to be precisely what RGS doesnt like.
Hence ive UPCASEd the note to give it some of the visual distinction
that I got from diag(), hopefully w/o the annoyance.
Is this worthwhile ? If so, Ill work up a patch
Re: Change 22021: Upgrade to Test::Harness 2.40.
Jim Cromie wrote: > > Well, it seems Ive been abusing diag() for some time now :-O > > Is there a 'right' way to do this ? perhaps just using ok() ? ok() goes to stdout by default, diag() to stderr > or maybe a new function, ex: note() is better: > > note..ok# YOUR INFORMATIONAL > MESSAGE HERE if that goes to stdout, that won't appear in the default harness output > Since Ive been using diag() to denote groups of tests, > which separates chunks of foo . ok, > But this appears to be precisely what RGS doesnt like. Or use separate .t files ? > Hence ive UPCASEd the note to give it some of the visual distinction > that I got from diag(), hopefully w/o the annoyance. > > Is this worthwhile ? If so, Ill work up a patch
Re: Change 22021: Upgrade to Test::Harness 2.40.
Rafael Garcia-Suarez wrote: Jim Cromie wrote: Well, it seems Ive been abusing diag() for some time now :-O Is there a 'right' way to do this ? perhaps just using ok() ? ok() goes to stdout by default, diag() to stderr which is, I presume, why perl -Ilib t/foo.t produces more output than make test. I see that as a feature.I guess note() should go to stderr - for my preferences at least. I guess I should just do it here, and see how it turns out ;-) or maybe a new function, ex: note() is better: note..ok# YOUR INFORMATIONAL MESSAGE HERE if that goes to stdout, that won't appear in the default harness output Im not sure whether you regard this as a problem or a feature. Since Ive been using diag() to denote groups of tests, which separates chunks of foo . ok, But this appears to be precisely what RGS doesnt like. Or use separate .t files ? for some cases, thats overkill. For example, Ive got several sets of 2-nested for loops doing a single tests combinatorially with 2 options. The loops are so similar, it seems silly to put them in separate files. the diag()s just helped me find the broken tests. Hence ive UPCASEd the note to give it some of the visual distinction that I got from diag(), hopefully w/o the annoyance. Is this worthwhile ? If so, Ill work up a patch even with it in - theres a long delay before it becomes ubiquitious, so it cant be used with out dependency consequences.
Re: Change 22021: Upgrade to Test::Harness 2.40.
Jim Cromie wrote: > >ok() goes to stdout by default, diag() to stderr > > > > which is, I presume, why perl -Ilib t/foo.t produces more output than > make test. > I see that as a feature.I guess note() should go to stderr - for my > preferences at least. Then just do *note = \&diag :) > >>or maybe a new function, ex: note() is better: > >> > >>note..ok# YOUR INFORMATIONAL > >>MESSAGE HERE > >> > >> > > > >if that goes to stdout, that won't appear in the default harness output > > > > > > Im not sure whether you regard this as a problem or a feature. as a feature. As I was saying, I like neat lined up OKs :) lots of :) > >Or use separate .t files ? > > for some cases, thats overkill. I knew you were going to say this.
Re: Change 22021: Upgrade to Test::Harness 2.40.
* Jim Cromie [2003/12/31 09:15]: > the diag()s just helped me find the broken tests. Isn't that what test names are for? (darren) -- In order to make an apple pie from scratch, you must first create the universe. -- Carl Sagan pgp0.pgp Description: PGP signature
