Re: MARC::Record tests and MicroLIF.pm

2005-01-10 Thread Ed Summers
On Thu, Jan 06, 2005 at 10:03:13PM -0600, Bryan Baldus wrote:
 Is there any problem with committing the revised version of 
 MARC::File::USMARC, and adding+committing the three files above to 
 cvs in the t/ directory?

Nice work :) as long as the tests pass I think comitting sounds like a
good idea.

//Ed


Re: Module to read Isis data

2005-01-10 Thread Bryan Baldus
At 10:39 AM -0600 1/4/05, Andy Lester wrote:
On Tue, Jan 04, 2005 at 05:17:56PM +0100, Dobrica Pavlinusic 
([EMAIL PROTECTED]) wrote:
 It's perl-only module (as opposed to OpenIsis which is depreciating it's
 XS binding) and has support just for reading. It's developed for WebPAC
 (library data search engine) so I never needed ability to search Isis
 files directly.

It t/002_whatever throws many errors on Mac OS X.  Line-endings?
This was true under MacPerl (MacOS 9.2.2), as well. I tried the new 
Biblio::Isis 0.11. Tests results are at the bottom of this message.

You might want to consider using File::Spec for specifying paths to 
files, especially for tests. Otherwise MacPerl (and other?) users 
will have to modify the test from, for example (from test 001_load.t):

isisdb = './data/winisis/BIBL',
to:
isisdb = ':data:winisis:BIBL',
Perhaps:
use File::Spec;
#...
my $path= File::Spec-catfile('data', 'winisis', 'BIBL');
$isis = Biblio::Isis-new (
isisdb = $path,
include_deleted = 1,
debug = $debug,
);
might work? It seems to be fine for MacPerl, but I don't know about 
other platforms. I ran into odd problems when I tried this using the 
earlier IsisDB module (when I moved the tests to different 
directories/hard drive partitions, results differed, weird things 
happened). These may have been due to other problems, which appear to 
have been fixed (test 2 no longer runs in a continuous loop).

I also had to comment out use blib, which doesn't exist, since 
MacPerl has problems with Makefile.PL files (and Build.PL 
files)--installation and testing generally needs to be done manually, 
in my limited experience. I have gotten a blib to appear when running 
the Makefile for other modules, but Biblio::Isis's gives (as do 
MARC::Record and MARC::Lint):
# Can't locate object method makemakerdflt via package 1.
File '[path_to_lib]:ExtUtils:MM_MacOS.pm'; Line 201
This seems to be a MacPerl problem, though I don't understand what is 
wrong, or why some modules don't report this error.

Test 2 report:
##
1..110
ok 1 - use Biblio::Isis;
$VAR1 = bless( {
 'xrf_file' = ':data:winisis:BIBL.XRF',
 'hash_filter' = undef,
 'fdt_file' = ':data:winisis:BIBL.FDT',
 'fileMST' = \*{'Biblio::Isis::$__ANONIO__'},
 'isisdb' = ':data:winisis:BIBL',
 'cnt_file' = ':data:winisis:BIBL.CNT',
 'fileXRF' = \*{'Biblio::Isis::$__ANONIO__'},
 'include_deleted' = 1,
 'mst_file' = ':data:winisis:BIBL.mst',
 'debug' = undef,
 'NXTMFN' = 6
   }, 'Biblio::Isis' );
ok 2 - The object isa Biblio::Isis
ok 3 - count is 5
ok 4 - read_cnt
ok 5 - returns 2 elements
ok 6 - cnt 1 ORDN same
ok 7 - cnt 1 ABNORMAL same
ok 8 - cnt 1 N same
ok 9 - cnt 1 LIV same
ok 10 - cnt 1 K same
ok 11 - cnt 1 ORDF same
ok 12 - cnt 1 FMAXPOS same
ok 13 - cnt 1 NMAXPOS same
ok 14 - cnt 1 POSRX same
ok 15 - cnt 2 ORDN same
ok 16 - cnt 2 ABNORMAL same
ok 17 - cnt 2 N same
ok 18 - cnt 2 LIV same
ok 19 - cnt 2 K same
ok 20 - cnt 2 ORDF same
ok 21 - cnt 2 FMAXPOS same
ok 22 - cnt 2 NMAXPOS same
ok 23 - cnt 2 POSRX same
ok 24 - fetch 1
ok 25 - MFN 1 702:0 ^aHolder^bElizabeth
ok 26 - MFN 1 990:0 2140
ok 27 - MFN 1 990:1 88
ok 28 - MFN 1 990:2 HAY
ok 29 - MFN 1 675:0 ^a159.9
ok 30 - MFN 1 210:0 ^aNew York^cNew York University press^dcop. 1988
ok 31 - MFN 1 801:0 ^aFFZG
ok 32 - fetch 2
ok 33 - MFN 2 215:0 ^aIX, 275 str.^d23 cm
ok 34 - MFN 2 200:0 ^aPsychoanalysis and psychology^eminding the 
gap^fStephen Frosh
ok 35 - MFN 2 990:0 2140
ok 36 - MFN 2 990:1 89
ok 37 - MFN 2 990:2 FRO
ok 38 - MFN 2 210:0 ^aNew York^cUniversity press^d1989
ok 39 - MFN 2 700:0 ^aFrosh^bStephen
ok 40 - fetch 3
ok 41 - MFN 3 200:0 ^aPsychoanalitic politics^eJacques Lacan and 
Freud's French Revolution^fSherry Turkle
ok 42 - MFN 3 990:0 2140
ok 43 - MFN 3 990:1 92
ok 44 - MFN 3 990:2 LAC
ok 45 - MFN 3 210:0 ^aLondon^cFree Associoation Books^d1992
ok 46 - MFN 3 700:0 ^aTurkle^bShirlie
ok 47 - MFN 3 686:0 ^a2140
ok 48 - MFN 3 686:1 ^a2140
ok 49 - fetch 4
ok 50 - MFN 4 200:0 ^aKey studies in psychology^fRichard D. Gross
ok 51 - MFN 4 210:0 ^aLondon^cHodder  Stoughton^d1994
ok 52 - MFN 4 10:0 ^a0-340-59691-0
ok 53 - MFN 4 700:0 ^aGross^bRichard
ok 54 - fetch 5
ok 55 - MFN 5 200:0 ^aPsychology^fCamille B. Wortman, Elizabeth F. 
Loftus, Mary E. Marshal
ok 56 - MFN 5 225:0 ^aMcGraw-Hill series in Psychology
not ok 57 - md5 1
# Failed test (RAM Disk:002_isis.t at line 119)
#  got: 'fbaa4b35c85b289e9fec15ba0f99b14a'
# expected: 'a369eff702307ba12eb81656ee0587fe'
not ok 58 - md5 2
# Failed test (RAM Disk:002_isis.t at line 119)
#  got: '14f828e2049a5d8523b6301c7009a3fe'
# expected: '4fb38537a94f3f5954e40d9536b942b0'
not ok 59 - md5 3
# Failed test (RAM Disk:002_isis.t at line 119)
#  got: '67d92a83434115acd98c4cb28b2784ec'
# expected: