Re: Lots of warnings building [EMAIL PROTECTED]

2005-09-25 Thread Yitzchak Scott-Thoennes
On Sat, Sep 17, 2005 at 04:10:41PM +0100, Nicholas Clark wrote:
 On Sat, Sep 17, 2005 at 10:02:19AM -0500, Andy Lester wrote:
  
  They're mostly the same errors as blead had around patch 24079
  (etc) when Andy started adding const to blead.
  
  I'm hoping that as I work through them most of the warnings will go  
  away
  because I bring in the patches that fix the warnings.
  
  
  
  Is there anything I can do to help this effort?
 
 Not yet - I've not got all your changes merged in. I know that you fixed
 warnings in later changes.
 
 Once they're all merged in, then it would be useful to work out what remains
 to be done to get maint warning free once more.

Nicholas, will you let us know when you want warning reports?
I'm still seeing lots @25596 (all tests still pass).


Re: Lots of warnings building [EMAIL PROTECTED]

2005-09-19 Thread Andy Dougherty
On Sat, 17 Sep 2005, Nicholas Clark wrote:

 I don't think that glibc has clean enough headers to allow perl to compile
 with -ansi -pedantic on Linux - I was doing it on FreeBSD, which does.
 
 So now I want
 
   valgrind
   dtrace
   gdb that works with threads
   *and*
   clean system headers
 
 all on the same platform. Is this too much to ask?
 
 (What are the system headers like on Solaris x86? Is anyone porting valgrind
 to it? This seems like the path of least resistance)

I don't know about the x86 version, but at least in Solaris 8/SPARC, the 
system headers won't work with -ansi -pedantic.  I'd be surprised if 
things were any different on Solaris 10/x86.

-- 
Andy Dougherty  [EMAIL PROTECTED]


Lots of warnings building [EMAIL PROTECTED]

2005-09-17 Thread Paul Marquess

This is with gcc 3.4.3

$ make test 
`sh  cflags optimize='-g' miniperlmain.o`  miniperlmain.c
  CCCMD =  gcc-3.4.3 -DPERL_CORE -c -DDEBUGGING -fno-strict-aliasing
-pipe -Wdeclaration-after-statement -I/usr/local/include -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64 -I/usr/include/gdbm -g  -Wall
`sh  cflags optimize='-g' perl.o`  perl.c
  CCCMD =  gcc-3.4.3 -DPERL_CORE -c -DDEBUGGING -fno-strict-aliasing
-pipe -Wdeclaration-after-statement -I/usr/local/include -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64 -I/usr/include/gdbm -g  -Wall
perl.c: In function `perl_construct':
perl.c:335: warning: assignment from incompatible pointer type
perl.c: In function `S_parse_body':
perl.c:1707: warning: passing arg 1 of `S_open_script' discards qualifiers
from pointer target type
`sh  cflags optimize='-g' gv.o`  gv.c
  CCCMD =  gcc-3.4.3 -DPERL_CORE -c -DDEBUGGING -fno-strict-aliasing
-pipe -Wdeclaration-after-statement -I/usr/local/include -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64 -I/usr/include/gdbm -g  -Wall
gv.c: In function `Perl_gv_fetchpv':
gv.c:735: warning: passing arg 1 of `Perl_is_utf8_idcont' discards
qualifiers from pointer target type
gv.c:735: warning: passing arg 1 of `Perl_is_utf8_digit' discards qualifiers
from pointer target type
`sh  cflags optimize='-g' toke.o`  toke.c
  CCCMD =  gcc-3.4.3 -DPERL_CORE -c -DDEBUGGING -fno-strict-aliasing
-pipe -Wdeclaration-after-statement -I/usr/local/include -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64 -I/usr/include/gdbm -g  -Wall
toke.c: In function `S_no_op':
toke.c:386: warning: passing arg 1 of `Perl_is_utf8_idcont' discards
qualifiersfrom pointer target type
toke.c:386: warning: passing arg 1 of `Perl_is_utf8_digit' discards
qualifiers from pointer target type
toke.c:388: warning: passing arg 1 of `Perl_is_utf8_alnum' discards
qualifiers from pointer target type
toke.c: In function `S_check_uni':
toke.c:807: warning: passing arg 1 of `Perl_is_utf8_alnum' discards
qualifiers from pointer target type
toke.c: In function `S_force_word':
toke.c:900: warning: passing arg 1 of `Perl_is_utf8_idcont' discards
qualifiers from pointer target type
toke.c:900: warning: passing arg 1 of `Perl_is_utf8_digit' discards
qualifiers from pointer target type
...



Re: Lots of warnings building [EMAIL PROTECTED]

2005-09-17 Thread Nicholas Clark
On Sat, Sep 17, 2005 at 02:28:30PM +0100, Paul Marquess wrote:
 
 This is with gcc 3.4.3

They're mostly the same errors as blead had around patch 24079
(etc) when Andy started adding const to blead.

I'm hoping that as I work through them most of the warnings will go away
because I bring in the patches that fix the warnings.

Then I'll only be left with the warnings that are due to me keeping all
the non-static functions identical to 5.8.7 (ie no const there)

I might have broken VMS or Windows, but as testdrive is down I can't check
on VMS. Sorry.

Nicholas Clark


Re: Lots of warnings building [EMAIL PROTECTED]

2005-09-17 Thread Andy Lester


They're mostly the same errors as blead had around patch 24079
(etc) when Andy started adding const to blead.

I'm hoping that as I work through them most of the warnings will go  
away

because I bring in the patches that fix the warnings.




Is there anything I can do to help this effort?

xoxo,
Andy

--
Andy Lester = [EMAIL PROTECTED] = www.petdance.com = AIM:petdance




Re: Lots of warnings building [EMAIL PROTECTED]

2005-09-17 Thread Nicholas Clark
On Sat, Sep 17, 2005 at 10:02:19AM -0500, Andy Lester wrote:
 
 They're mostly the same errors as blead had around patch 24079
 (etc) when Andy started adding const to blead.
 
 I'm hoping that as I work through them most of the warnings will go  
 away
 because I bring in the patches that fix the warnings.
 
 
 
 Is there anything I can do to help this effort?

Not yet - I've not got all your changes merged in. I know that you fixed
warnings in later changes.

Once they're all merged in, then it would be useful to work out what remains
to be done to get maint warning free once more.


One thing I did notice on blead was that if I Configure with

  -Accflags='-ansi -pedantic -DPERL_GCC_PEDANTIC'

then I'm getting warnings about function pointer to data pointer conversions
in (at least) toke.c and sv.c, and a lot from intrpvar.h, perlvars.h and
thrdvar.h

  ISO C forbids conversion of function pointer to object pointer type

Oh, and this:

op.c: In function `Perl_newXS':
op.c:4628: warning: assignment discards qualifiers from pointer target type


I don't think that glibc has clean enough headers to allow perl to compile
with -ansi -pedantic on Linux - I was doing it on FreeBSD, which does.

So now I want

  valgrind
  dtrace
  gdb that works with threads
  *and*
  clean system headers

all on the same platform. Is this too much to ask?

(What are the system headers like on Solaris x86? Is anyone porting valgrind
to it? This seems like the path of least resistance)

Nicholas Clark