[perl #46823] [TODO] [Pir] Rewrite Resizeable*Array tests properly when exceptions are implemented

2008-09-02 Thread Christoph Otto via RT
On Wed Aug 27 22:49:37 2008, cotto wrote:
 
 Most of these test wouldn't throw an exception anyway, since assigning
 to a positive out-of-bounds element simply resizes the array.  (This
 excludes nonsensically large positive indicies, which should probably
 tested for.)  I added exception handling for oob indicies to the one
 fixed array test in r30610, which still passes.  I deleted the other
 references to this ticket.
 It's possible that out-of-bounds refers to negative indicies.  I added
 some tests with exception handlers for those cases in r30611.
 
 If there are no objections, I'll mark this resolved after the weekend.
 
 Christoph
 

Done.



[perl #46823] [TODO] [Pir] Rewrite Resizeable*Array tests properly when exceptions are implemented

2008-08-28 Thread Christoph Otto via RT
On Thu Oct 25 00:49:38 2007, pcoch wrote:
 
 To be totally honest I wish I knew.  I'm just going through converting
 the todo items in code into RT tickets and sometimes the todo comments
 aren't necessarily all that clear as to what needs to be done.  I'm
 also (unfortunately) not familiar enough with pir to see in the code
 of the tests what needs fixing otherwise I might have been able to
 expand a little in the ticket.  I'm really sorry I can't be of more
 help here!
 
 Paul
 

Most of these test wouldn't throw an exception anyway, since assigning
to a positive out-of-bounds element simply resizes the array.  (This
excludes nonsensically large positive indicies, which should probably
tested for.)  I added exception handling for oob indicies to the one
fixed array test in r30610, which still passes.  I deleted the other
references to this ticket.
It's possible that out-of-bounds refers to negative indicies.  I added
some tests with exception handlers for those cases in r30611.

If there are no objections, I'll mark this resolved after the weekend.

Christoph