[PATCH] reconfigure.pl option 'target' is accessed as 'targets'
Hello folks,
There was a problem in config/gen/makefiles.pm:
$targets = $conf-options-get('targets');
while the option name was 'target'.
I've restored correct access and slightly improved the option
description. Could anyone review and possibly commit the patch? Is the
[PATCH] mail formed correctly?
Thanks, M.
[PATCH] reconfigure.pl option 'target' is accessed as 'targets'
The patch attached.
On 10/10/07, Maria Fedotova [EMAIL PROTECTED] wrote:
Hello folks,
There was a problem in config/gen/makefiles.pm:
$targets = $conf-options-get('targets');
while the option name was 'target'.
I've restored correct access and slightly improved the option
description. Could anyone review and possibly commit the patch? Is the
[PATCH] mail formed correctly?
Thanks, M.
Index: lib/Parrot/Configure/Options/Reconf.pm
===
--- lib/Parrot/Configure/Options/Reconf.pm (revision 22005)
+++ lib/Parrot/Configure/Options/Reconf.pm (working copy)
@@ -48,9 +48,9 @@ General Options:
--help Show this text
--verboseOutput extra information
- --step=(gen::languages)
+ --step=(gen::languages|gen::makefiles)
Execute a single configure step
- --target=(Makefile) Needed if --step=gen::makefiles
+ --target=(Makefile) Regenerate a specific makefile
--languages=list of languages
Specify a list of languages to process
Index: config/gen/makefiles.pm
===
--- config/gen/makefiles.pm (revision 22005)
+++ config/gen/makefiles.pm (working copy)
@@ -103,7 +103,7 @@ EOF
sub makefiles {
my ( $self, $conf ) = @_;
-my $targets = $conf-options-get('targets');
+my $targets = $conf-options-get('target');
my @targets =
defined $targets
? split ' ', $targets
Re: Parallel GC for parrot - does it make sense?
Thanks, Will! I succeeded to merge Harmony tree into my local copy: $ svn propget svn:externals src/gc gen http://svn.apache.org/repos/asf/harmony/enhanced/drlvm/trunk/vm/gc_gen/src Then I fixed Manifest.pm to process external entries correctly and started to understand that MANIFEST is used mainly for bundling of the product. It seems to me that it is not used for Makefile generation. Is it true that config/gen/makefiles/root.in is hand-written? Thanks! On 10/6/07, Will Coleda [EMAIL PROTECTED] wrote: On Oct 5, 2007, at 1:35 PM, Maria Fedotova wrote: Hello folks, I wonder if the community would be interested in attaching another garbage collector to the parrot VM. For example, Apache Harmony contains implementation of a parallel garbage collector [1] which is quicker on modern multi-core and SMP systems. If you think this may be technically feasible, I wonder if there are any legal issues which prevent Apache-licensed component to be used with the code licensed under artistic license. I'm currently looking at tools/dev/mk_manifest_and_skip.pl to add GC files to the build process. I'm also trying to dig up how --gc=config option of Configure.pl works. This script automatically generates MANIFEST and MANIFEST.SKIP based on what's checked into the repository; If files are added to the repo, running this tool automatically adds them. [1] http://svn.apache.org/viewvc/harmony/enhanced/drlvm/trunk/vm/ gc_gen/ With best regards, Masha -- Will Coke Coleda [EMAIL PROTECTED] externals_fix.patch Description: Binary data
Parallel GC for parrot - does it make sense?
Hello folks, I wonder if the community would be interested in attaching another garbage collector to the parrot VM. For example, Apache Harmony contains implementation of a parallel garbage collector [1] which is quicker on modern multi-core and SMP systems. If you think this may be technically feasible, I wonder if there are any legal issues which prevent Apache-licensed component to be used with the code licensed under artistic license. I'm currently looking at tools/dev/mk_manifest_and_skip.pl to add GC files to the build process. I'm also trying to dig up how --gc=config option of Configure.pl works. [1] http://svn.apache.org/viewvc/harmony/enhanced/drlvm/trunk/vm/gc_gen/ With best regards, Masha
