Re: [COMMIT] Array type

2002-01-29 Thread Simon Glover


 You forgot to declare the class_init function in global_setup.h
 Enclosed patch fixes.

 Simon

--- global_setup.h.old  Tue Jan 29 12:11:59 2002
+++ global_setup.h  Tue Jan 29 12:12:29 2002
@@ -15,6 +15,7 @@
 #define PARROT_GLOBAL_SETUP_H_GUARD
 
 /* Needed because this might get compiled before pmcs have been built */
+void Parrot_Array_class_init(void);
 void Parrot_PerlUndef_class_init(void);
 void Parrot_PerlInt_class_init(void);
 void Parrot_PerlNum_class_init(void);




[COMMIT] Array type

2002-01-28 Thread Jeff G

I've just added a new 'Array' type alongside the current PerlArray. Some
target languages may not like to use Perl's array style, so they now can
use the basic Array type. As the test (t/op/pmc_array.t) indicates, no
preallocation is done. I probably need to support exceptions at some
future date, but as there are (currently) only 6 vtable entries which
would care, I've temporarily put it off.

Soon, the 6 vtable entries will collapse into 2 entries. The
get_{foo}_index and set_{foo}_index members will be collapsed into
'get_index' and 'set_index' members. I've also done some initial work on
Unicode integration, but I think these changes take precedence for the
time being. Problems still exist in PerlArray that I'll root out over
the next week and fix.

--
Jeff [EMAIL PROTECTED]



Re: [COMMIT] Array type

2002-01-28 Thread Steve Fink

On Mon, Jan 28, 2002 at 11:34:22PM -0500, Jeff G wrote:
 I've just added a new 'Array' type alongside the current PerlArray. Some
 target languages may not like to use Perl's array style, so they now can
 use the basic Array type. As the test (t/op/pmc_array.t) indicates, no
 preallocation is done. I probably need to support exceptions at some
 future date, but as there are (currently) only 6 vtable entries which
 would care, I've temporarily put it off.

Seems like one of these should inherit from the other.

  class PerlArray extends Array { ... }