Re: [perl #57090] [TODO]: make smolder_test should report test report number

[Michael Peters]

James Keenan (via RT) wrote:

I'm beginning to enjoy 'make smolder_test'.  Here is a wishlist item  
for its ongoing development.


[snip]

I would prefer make smolder_test instead (or additionally) printed  
out something like this:


http://smolder.plusthree.com/app/public_projects/report_details/2310


Take this patch for spin and see if it's more to your liking.

--
Michael Peters
Plus Three, LP

Index: lib/Parrot/Harness/Smoke.pm
===
--- lib/Parrot/Harness/Smoke.pm (revision 29611)
+++ lib/Parrot/Harness/Smoke.pm (working copy)
@@ -75,10 +75,13 @@
 );
 
 if ($response-code == 302) {
-print Test report successfully sent to Smolder at\n
-  . $SMOLDER_CONFIG{server}
+my ($report_id) = $response-content =~ /Reported #(\d+) added/i;
+my $report_url = 
$SMOLDER_CONFIG{server}/app/public_projects/report_details/$report_id;
+my $project_url = $SMOLDER_CONFIG{server}
   . '/app/public_projects/smoke_reports/'
-  . $SMOLDER_CONFIG{project_id} . \n;
+  . $SMOLDER_CONFIG{project_id};
+print Test report successfully sent to Smolder at\n$report_url
+. \nYou can see other recent reports at\n$project_url.\n\n;
 }
 else {
 die Could not upload report to Smolder at $SMOLDER_CONFIG{server}

[perl #57090] [TODO]: make smolder_test should report test report number

[James Keenan via RT]

My wish was your command!  Applied in r29617.  Thank you very much.

kid51

[perl #57090] [TODO]: make smolder_test should report test report number

[via RT]

# New Ticket Created by  James Keenan 
# Please include the string:  [perl #57090]
# in the subject line of all future correspondence about this issue. 
# URL: http://rt.perl.org/rt3/Ticket/Display.html?id=57090 


I'm beginning to enjoy 'make smolder_test'.  Here is a wishlist item  
for its ongoing development.

When the test run concludes, it prints out this message:

Test report successfully sent to Smolder at
http://smolder.plusthree.com/app/public_projects/smoke_reports/8
Finished

That's nice, but what you see when you click on that link are the 8  
most recently submitted reports.  Suppose you walk away from your  
keyboard and come back long after make smolder_test has concluded.   
You go to the site and may have difficulty searching for your  
particular report -- particularly if it's on an OS that's getting a  
lot of Smolder testing.

I would prefer make smolder_test instead (or additionally) printed  
out something like this:

http://smolder.plusthree.com/app/public_projects/report_details/2310

... so you'd know precisely which report is yours.

Thank you very much.
kid51