Re: [perl #44457] [TODO] make sure files match test files for DYNPMCs and DYNOPs etc
--- El vie 12-sep-08, Rafael Sanchez <[EMAIL PROTECTED]> escribió:
De:: Rafael Sanchez <[EMAIL PROTECTED]>
Asunto: Re: [perl #44457] [TODO] make sure files match test files for DYNPMCs
and DYNOPs etc
A: "Christoph Otto" <[EMAIL PROTECTED]>
Cc: [EMAIL PROTECTED]
Fecha: viernes, 12 septiembre, 2008, 2:49 pm
--- El vie 12-sep-08, Christoph Otto <[EMAIL PROTECTED]> escribió:
De:: Christoph Otto <[EMAIL PROTECTED]>
Asunto: Re: [perl #44457] [TODO] make sure files match test files for DYNPMCs
and DYNOPs etc
A: [EMAIL PROTECTED], [EMAIL PROTECTED]
Fecha: viernes, 12 septiembre, 2008, 6:56 am
[EMAIL PROTECTED] via RT wrote:
>
> --- El mié 10-sep-08, Rafael Sanchez <[EMAIL PROTECTED]>
escribió:
> De:: Rafael Sanchez <[EMAIL PROTECTED]>
> Asunto: Re: [perl #44457] [TODO] make sure files match test files for
DYNPMCs and DYNOPs etc
> A: "Christoph Otto via RT"
<[EMAIL PROTECTED]>
> Cc: perl6-internals@perl.org
> Fecha: miércoles, 10 septiembre, 2008, 6:26 pm
> On Mon Aug 06 06:08:54 2007, pcoch wrote:
>> In the file t/distro/test_file_coverage.t there is the todo item:
>>
>> # TODO: DYNPMC, DYNOPS, etc
>>
>> This is in the context of making sure that the files match the test
>> files. This needs to be implemented.
>
> Is this as simple as writing a test to make sure every src/dynpmc/*.pmc
> and src/dynoplibs/*.ops has a matching
> t/dynpmc/*.t and t/dynoplibs/*.t ? If so, this would be an ideal task
> for one of our recent volunteers, since the code would be pure Perl.
>
>> Also, the test will fail without an exception for
src/dynpmc/rotest.pmc.
>> I don't know if a test should be written for this PMC or not.
>
>> I'm working in the script.
>
>> Igor
>
> I have a working script(with testing variables only).
>
> I have to filter de input (there are other types of files), and improbe
the reporting part.
>
> I don't know if I forgeting something.
>
> Igor
>
> The script is:
>
> #!/usr/bin/perl -w
>
> # Copyright (C) 2007-2008, The Perl Foundation.
> # $Id: Match.pl 2008-09-10 igor $
>
> =head1 NAME
>
> Match.pl
>
> =head1 DESCRIPTION
>
> Reports if doesn't mach a pmc file with a test file, there is not test
file
>
> =cut
>
> sub find_files {
> my ($base_dir,$dirpmc,$dirtest) = @_;
> opendir(DIRPMC, $base_dir.$dirpmc);
> opendir(DIRTEST,$base_dir.$dirtest);
>
> my @filespmc = grep { $_ ne '.' and $_ ne '..' }
readdir DIRPMC;
> my @filest = grep { $_ ne '.' and $_ ne '..' }
readdir DIRTEST;
>
> my @pmc_values = @{strip_ext([EMAIL PROTECTED])};
> my @t_values = @{strip_ext([EMAIL PROTECTED])};
>
> my %hash_t = map { $_ => $_ } @t_values;
>
> for (0 .. $#pmc_values) {
> if ( exists $hash_t{ $pmc_values[$_] } ) {
> print "element exist
".$pmc_values[$_]."\n";
> } else {
> print "element do not exist
".$pmc_values[$_]."\n";
> }
> }
>
> }
>
> sub strip_ext {
> my @ref_t = @{$_[0]};
> my @arr_stripped = ();
> for (my $i=0;$i<$#ref_t+1; $i++) {
> if ($ref_t[$i] =~ m/(\w+)[.]\w+/) { #Obtain names of
files without extension
> $arr_stripped[$i] = $1;
> } else {
> print "error";
> }
> }
> return [EMAIL PROTECTED];
> }
>
> my $base_dir = "/home/raf/parrot/";
> my $dirpmc = "src/dynpmc/";
> my $dirtest = "t/dynpmc/";
>
> #find_files($base_dir,$dirpmc,$dirtest);
>
>Hi Igor,
>First, thank you for taking the time to write this script.
>Unfortunately, the test needs to be added to t/distro/test_file_coverage.t
in
>Parrot. This ensures that it is run every time Parrot's test suite is
run
>via
>make test. It should be fairly easy to copy and modify the existing code
in
>t/distro/test_file_coverage.t to make it match dynpmc and dynops source
code
>to test files, but I'll be glad to help if you run into any issues.
>While you're working on the test, you can run it directly as a Perl
script
>or
>with prove. Note that you have to run perl Configure.pl before this test
will
>work.
>To learn how to contribute, I highly recommend the documentation in
>docs/project, especially cage_cleaners_guide.pod and committer_guide.pod.
>When modifying existing tests, it's best to work against svn trunk and
>update
>often. This avoids conflicts and makes it easy to generate patches.
>Once you have t/distro
Re: [perl #44457] [TODO] make sure files match test files for DYNPMCs and DYNOPs etc
--- El mar 30-sep-08, Christoph Otto <[EMAIL PROTECTED]> escribió: De:: Christoph Otto <[EMAIL PROTECTED]> Asunto: Re: [perl #44457] [TODO] make sure files match test files for DYNPMCs and DYNOPs etc A: "Igor ;" <[EMAIL PROTECTED]> Cc: [EMAIL PROTECTED] Fecha: martes, 30 septiembre, 2008, 5:49 am Igor wrote: > > Hi Christoph, > I send you the patch attached. > Sincerely, > Igor Hi Igor, Thanks again for taking the time to contribute. Here are some pointers: First, you're trying too hard. I'm sorry to tell you that after you've spent so much effort, but this change should be fairly minimal. I'm sure you've noticed that there are two tests in t/distro/test_file_coverage.t that almost do what you need done. Try copy/pasting code from those tests in the PMC block and modifying it to check for the files you're interested in. Don't worry about the PMC: label. You can give it a more appropriate name once the rest of the test works. A good rule is to try to use as little code as possible to get the job done.. This doesn't mean that you should use weird one-liners that nobody can understand, but that you should strive to write simple, easily understood code. Line 88 in the file is a fairly good example of what *not* to do, although it'd be ok with a brief explanatory comment. Also, don't worry too much about generalizing beyond what's needed to get the current job done. If the code starts to look ugly, it can be refactored later. I hope that sets you in the right direction. Feel free to email me if you have any questions. Christoph Hi Christoph, I send you the patch attached. I have a question. How I must name the patchs for easy finding. Sincerely, Igor ¡Todo sobre Amor y Sexo! La guía completa para tu vida en Mujer de Hoy. http://mx.mujer.yahoo.com/
Re: [perl #44457] [TODO] make sure files match test files for DYNPMCs and DYNOPs etc
--- El mar 30-sep-08, Christoph Otto <[EMAIL PROTECTED]> escribió: De:: Christoph Otto <[EMAIL PROTECTED]> Asunto: Re: [perl #44457] [TODO] make sure files match test files for DYNPMCs and DYNOPs etc A: "Igor ;" <[EMAIL PROTECTED]> Cc: [EMAIL PROTECTED] Fecha: martes, 30 septiembre, 2008, 5:49 am Igor wrote: > > Hi Christoph, > I send you the patch attached. > Sincerely, > Igor Hi Igor, Thanks again for taking the time to contribute. Here are some pointers: First, you're trying too hard. I'm sorry to tell you that after you've spent so much effort, but this change should be fairly minimal. I'm sure you've noticed that there are two tests in t/distro/test_file_coverage.t that almost do what you need done. Try copy/pasting code from those tests in the PMC block and modifying it to check for the files you're interested in. Don't worry about the PMC: label. You can give it a more appropriate name once the rest of the test works. A good rule is to try to use as little code as possible to get the job done.. This doesn't mean that you should use weird one-liners that nobody can understand, but that you should strive to write simple, easily understood code. Line 88 in the file is a fairly good example of what *not* to do, although it'd be ok with a brief explanatory comment. Also, don't worry too much about generalizing beyond what's needed to get the current job done. If the code starts to look ugly, it can be refactored later. I hope that sets you in the right direction. Feel free to email me if you have any questions. Christoph Hi Christoph, I forgot attach the file. Sincerely, Igor ¡Todo sobre Amor y Sexo! La guía completa para tu vida en Mujer de Hoy. http://mx.mujer.yahoo.com/ patch_test_file_coverage Description: Binary data
Re: New Parrot mailing list
--- El vie 19-sep-08, Allison Randal <[EMAIL PROTECTED]> escribió: De:: Allison Randal <[EMAIL PROTECTED]> Asunto: Re: New Parrot mailing list A: "Andy Dougherty" <[EMAIL PROTECTED]> Cc: "Perl6 Internals" Fecha: viernes, 19 septiembre, 2008, 2:33 pm Andy Dougherty wrote: > > I use NNTP. I much prefer the command-line news interface to Google > Groups, but I guess I wouldn't go so far as to say I would have > "difficulty" switching to a regular email subscription. Or, to put it > another way: If there were an NNTP interface, I would definitely use it, > but I wouldn't want anyone else to be stuck implementing and maintaining > it just for my occasional use. >I wonder why no one has developed a command-line NNTP-like interface for >email? Maybe following mailing lists via RSS and feed readers has >satisfied the need enough that no one got around to it? >This looks interesting, if anyone's motivated: > http://www.methodize.org/nntprss/ >Allison I liked the idea of making a nntp-rss reader. The first aproach(version) is to improve the way I read parrot mail in my e-mail account. I've thought in some chatacteristics: The project's name is Ruddy (It's a kind of dove or pigeon). It will have "The parrot foundation" copyright. It will be a perl aplication(server side). The client side will be ajax using jquery. The application will be web based. The database will be SQLite or PostgreSQL. The webserver will be apache. It will be installed on the client computer. I will use a technical blog(in construccion) for writing what I am building, and I will post the link here in a few days. Sincerely, Igor ¡Todo sobre Amor y Sexo! La guía completa para tu vida en Mujer de Hoy. http://mx.mujer.yahoo.com/
Re: [perl #44457] [TODO] make sure files match test files for DYNPMCs and DYNOPs etc
--- El mié 8-oct-08, Christoph Otto <[EMAIL PROTECTED]> escribió:
De:: Christoph Otto <[EMAIL PROTECTED]>
Asunto: Re: [perl #44457] [TODO] make sure files match test files for DYNPMCs
and DYNOPs etc
A: "Igor" <[EMAIL PROTECTED]>
Cc: [EMAIL PROTECTED]
Fecha: miércoles, 8 octubre, 2008, 11:17 pm
[EMAIL PROTECTED] via RT wrote:
>
> --- El mar 30-sep-08, Christoph Otto <[EMAIL PROTECTED]>
escribió:
> De:: Christoph Otto <[EMAIL PROTECTED]>
> Asunto: Re: [perl #44457] [TODO] make sure files match test files for
DYNPMCs and DYNOPs etc
> A: "Igor ;" <[EMAIL PROTECTED]>
> Cc: [EMAIL PROTECTED]
> Fecha: martes, 30 septiembre, 2008, 5:49 am
>
> Igor wrote:
>>
>> Hi Christoph,
>> I send you the patch attached.
>> Sincerely,
>> Igor
>
> Hi Igor,
>
> Thanks again for taking the time to contribute.
>
> Here are some pointers:
> First, you're trying too hard. I'm sorry to tell you that after
> you've spent
> so much effort, but this change should be fairly minimal. I'm sure
> you've
> noticed that there are two tests in t/distro/test_file_coverage.t that
almost
> do what you need done. Try copy/pasting code from those tests in the PMC
> block and modifying it to check for the files you're interested in.
> Don't
> worry about the PMC: label. You can give it a more appropriate name once
the
> rest of the test works.
>
> A good rule is to try to use as little code as possible to get the job
done..
> This doesn't mean that you should use weird one-liners that nobody
can
> understand, but that you should strive to write simple, easily understood
> code. Line 88 in the file is a fairly good example of what *not* to do,
> although it'd be ok with a brief explanatory comment.
>
> Also, don't worry too much about generalizing beyond what's needed
to
> get the
> current job done. If the code starts to look ugly, it can be refactored
later.
>
> I hope that sets you in the right direction. Feel free to email me if you
> have any questions.
>
> Christoph
>
> Hi Christoph,
>
> I forgot attach the file.
>
> Sincerely,
>
> Igor
>Hi Igor,
>Patch naming depends on personal preferences, but patches are easier to review
>when their filenames end in either .patch or .diff. Naming different versions
>of a patch with successive numbers (i.e. too_many_frobs_1.patch,
>too_many_frobs_2.patch, etc) makes it easier to see which patch is the most
>recent when using RT, but this isn't critical.
>Also, you only need to reply to [EMAIL PROTECTED] I'm on
>the
>list and will see your message.
>This is a much better patch. It was a good idea to refactor the find commands
>into a separate sub. The code is cleaner and a little bit more obvious, which
>is a good thing.
>My only concern is that it looks like you deleted the tests that matches
>non-dynamic PMCs to their respective tests. Those tests did fail but they
>should be kept in test_file_coverage.t TODO'd, so they can eventually be
>addressed. I may end up doing this myself, so be sure to check if the tests
>actually need to be TODO'd before sending the updated patch.
>Apart from that change, the patch looks good. If you can make those changes
>and resubmit, I'll be glad to apply it.
>Thanks,
>Christoph
Hi Christoph,
I send you the patch atached.
The script with TODO block works equal without it(with TODO
gives more information and adds the "not yet implemented" leyend).
Sincerely,
Igor
¡Todo sobre Amor y Sexo!
La guía completa para tu vida en Mujer de Hoy.
http://mx.mujer.yahoo.com/Index: test_file_coverage.t
===
--- test_file_coverage.t (revision 31535)
+++ test_file_coverage.t (working copy)
@@ -29,44 +29,58 @@
## make sure PMC files match test files
PMC: {
-my $pmc_dir= 'src/pmc';
-my $pmc_suffix = '.pmc';
-my $test_dir= 't/pmc';
-my $test_suffix = '.t';
+# Set variables for pmc
+my $pmc_dir= 'src/pmc';
+my $pmc_suffix = '.pmc';
+my $test_pmc_dir = 't/pmc';
+my $test_pmc_suffix= '.t';
+my ( $pmc_miss, $test_pmc_miss ) = find_files($pmc_dir,$pmc_suffix,$test_pmc_dir,$test_pmc_suffix);
-my ( @pmc_files, @test_files );
+# Set variables for dynpmc
+my $dynpmc_dir = 'src/dynpmc';
+my $dynpmc_suffix = '.pmc';
+my $test_dynpmc_dir= 't/dynpmc';
+my $test_dynpmc_suffix = '.
Re: New Parrot mailing list
--- El mar 7-oct-08, Igor <[EMAIL PROTECTED]> escribió: De:: Igor <[EMAIL PROTECTED]> Asunto: Re: New Parrot mailing list A: "Allison Randal" <[EMAIL PROTECTED]> Cc: "Perl6 Internals" Fecha: martes, 7 octubre, 2008, 11:27 pm --- El vie 19-sep-08, Allison Randal <[EMAIL PROTECTED]> escribió: De:: Allison Randal <[EMAIL PROTECTED]> Asunto: Re: New Parrot mailing list A: "Andy Dougherty" <[EMAIL PROTECTED]> Cc: "Perl6 Internals" Fecha: viernes, 19 septiembre, 2008, 2:33 pm Andy Dougherty wrote: > > I use NNTP. I much prefer the command-line news interface to Google > Groups, but I guess I wouldn't go so far as to say I would have > "difficulty" switching to a regular email subscription. Or, to put it > another way: If there were an NNTP interface, I would definitely use it, > but I wouldn't want anyone else to be stuck implementing and maintaining > it just for my occasional use. >I wonder why no one has developed a command-line NNTP-like interface for >email? Maybe following mailing lists via RSS and feed readers has >satisfied the need enough that no one got around to it? >This looks interesting, if anyone's motivated: > http://www.methodize.org/nntprss/ >Allison >I liked the idea of making a nntp-rss reader. >The first aproach(version) is to improve the way I read parrot >mail in my e-mail account. >I've thought in some chatacteristics: >The project's name is Ruddy (It's a kind of dove or pigeon). >It will have "The parrot foundation" copyright. >It will be a perl aplication(server side). >The client side will be ajax using jquery. >The application will be web based. >The database will be SQLite or PostgreSQL. >The webserver will be apache. >It will be installed on the client computer. >I will use a technical blog(in construccion) >for writing what I am building, and I will post the link >here in a few days. >Sincerely, >Igor Hi, I have the first prealpha version of Ruddy It only saves the text written in the page(to a text file) using ajax and perl and refresh the textarea html tag(the writing area) with ajax and perl too. The blog is in http://ruddy-dove.blogspot.com/ and the sources are in ftp://pause.perl.org/pub/PAUSE/authors/id/Q/QU/QUEVLAR/Ruddy/ Sincerely, Igor ¡Todo sobre Amor y Sexo! La guía completa para tu vida en Mujer de Hoy. http://mx.mujer.yahoo.com/ ¡Todo sobre Amor y Sexo! La guía completa para tu vida en Mujer de Hoy. http://mx.mujer.yahoo.com/
