Jenkins build is back to normal : pgadmin4-master-python33 #286

[pgAdmin 4 Jenkins]

See 

Re: pgAdmin4: Random failure of FTS test cases due to improper random string creation

[Ashesh Vashi]

On Fri, Aug 11, 2017 at 1:24 PM, Navnath Gadakh <
navnath.gad...@enterprisedb.com> wrote:

> Hi Dave,
>
> Please find the attached patch for UUID creation issues with test
> objects for FTS configurations, FTS dictionaries and FTS parsers.
> Previously(refer email with subject "Build failed in Jenkins:
> pgadmin4-master-python27 #279" and "Build failed in Jenkins:
> pgadmin4-master-python33 #207"), test cases were randomly failing due to
> repetitions of the test object names.
>
> In the old code we used some part of the string for creating a UUID
> string, but it seems that at some point that created string gets repeated
> and due to which test cases were failing as this was a random behavior, now
> it is fixed.
>
Navnath,

We're still not removing the temporary objects, created by test-cases, in
the tear-down function.
We should have removed them in the tear-down function to fix the issue in
proper way.

Dave - thoughts?

-- Thanks, Ashesh

>
> Thanks.
>
>
>
>
>
> --
> Regards,
> Navnath Gadakh
>
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>
>

Build failed in Jenkins: pgadmin4-master-python26 #408

[pgAdmin 4 Jenkins]

See 


Changes:

[Ashesh Vashi] Fixes #2567 - Use the proper database connection to fetch the 
default

--
[...truncated 339.82 KB...]
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.5:

157 tests passed
0 tests failed
15 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.4:

157 tests passed
0 tests failed
15 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)

PostgreSQL 9.3:

157 tests passed
0 tests failed
15 tests skipped:
SynonymGetTestCase (Fetch synonym Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Detach partition from existing list 
partitioned table,
Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
  

Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.

[Ashesh Vashi]

On Tue, Aug 8, 2017 at 3:46 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Patch looks good to me.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> [image: https://community.postgresrocks.net/]
> 
>
> On Tue, Aug 8, 2017 at 3:25 PM, Atul Sharma 
> wrote:
>
>> makes sense. Thanks for the solution.
>>
>> Please find attached revised patch.
>>
> Committed with minor change in existing logic.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>
>> Thanks,
>> Atul
>>
>> On Tue, Aug 8, 2017 at 2:12 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Atul,
>>>
>>> Better solution to solve this issue is to use self.conn instead of
>>> creating new conn using did, we already checking for "datallowconn"
>>> flag in check_precondition decorator.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> [image: https://community.postgresrocks.net/]
>>> 
>>>
>>> On Tue, Aug 8, 2017 at 12:42 PM, Atul Sharma <
>>> atul.sha...@enterprisedb.com> wrote:
>>>
 ok, Lemme check and I will get back to you.

 Thanks,
 Atul

 On Tue, Aug 8, 2017 at 12:40 PM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Atul,
>
> The given patch breaks RM#1801
> .
> After applying the patch, Now I'm not able to see the properties of a
> database of which "datallowconn" is set to False.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> [image: https://community.postgresrocks.net/]
> 
>
> On Tue, Aug 8, 2017 at 12:08 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Murtuza,
>>
>> Please review this one.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> 
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> 
>>
>> On Tue, Aug 1, 2017 at 3:23 PM, Atul Sharma <
>> atul.sha...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch that fixes Default privileges don't show on Properties tab
>>> for database
>>>
>>> Thanks,
>>> Atul
>>>
>>
>>
>

>>>
>>
>

pgAdmin 4 commit: Fixes #2567 - Use the proper database connection to f

[Ashesh Vashi]

Fixes #2567 - Use the proper database connection to fetch the default
prileges in the properties tab of the database.

Reviewed by: Murtuza Zabuawala

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e6223c9a490ead577e5c6f3058e6db51d0d2c5b7
Author: Atul Sharma 

Modified Files
--
.../server_groups/servers/databases/__init__.py| 25 ++
1 file changed, 11 insertions(+), 14 deletions(-)

Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js

[Violet Cheng]

Great! Thanks a lot.

Violet

On Fri, Aug 18, 2017 at 12:13 AM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:

> On Wed, Aug 16, 2017 at 4:20 PM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> The patch looks good to me.
>>
>>> Thanks,
>> Khushboo
>>
>> On Fri, Aug 11, 2017 at 12:08 PM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> On Thu, Aug 10, 2017 at 1:15 PM, Violet Cheng  wrote:
>>>
 Hi hackers,

 We tried to extract and refactor generate_url function in node.js and
 collection.js. Please see the patch attached.

>>> Thanks - committed!
>
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>> Khushboo,
>>>
>>> Please review this one.
>>>
>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>> 
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>> 
>>>

 Thanks,
 Violet & Sarah

>>>
>>>
>>
>

Build failed in Jenkins: pgadmin4-master-python33 #285

[pgAdmin 4 Jenkins]

See 


Changes:

[Ashesh Vashi] Extract the generate_url(..) function from node.js, and 
collection.js

--
[...truncated 337.36 KB...]
159 tests passed
0 tests failed
13 tests skipped:
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
PackageGetTestCase (Fetch Package Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
PackagePutTestCase (Fetch Package Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL connection)

EDB Postgres AS 9.6:

169 tests passed
0 tests failed
3 tests skipped:
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Create partitions of existing list 
partitioned table,
Detach partition from existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing range 
partitioned table)
TestSSLConnection (Test for SSL connection)

PostgreSQL 9.3:

157 tests passed
0 tests failed
15 tests skipped:
PackagePutTestCase (Fetch Package Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
PackageGetTestCase (Fetch Package Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
ResourceGroupsAddTestCase (Add resource groups)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
SynonymDeleteTestCase (Fetch synonym Node URL)
TableUpdateTestCase (Create partitions of existing list 
partitioned table,
Detach partition from existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Create partitions of existing range 
partitioned table)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL connection)

PostgreSQL 9.2:

149 tests passed
0 tests failed
23 tests skipped:
SynonymPutTestCase (Fetch synonym Node URL)
ResourceGroupsPutTestCase (Put resource groups)
EventTriggerAddTestCase (Fetch Event Trigger Node URL)
ViewsAddTestCase (Add materialized view under schema node)
PackageDeleteTestCase (Fetch Package Node URL)
ResourceGroupsAddTestCase (Add resource groups)
SynonymAddTestCase (Default Node URL)
ViewsDeleteTestCase (Delete materialized view under schema node)
PackagePutTestCase (Fetch Package Node URL)
ResourceGroupsGetTestCase (Get resource groups)
ViewsGetTestCase (Get materialized view under schema node)
TestSSLConnection (Test for SSL connection)
EventTriggerPutTestCase (Fetch Event Trigger Node URL)
PackageGetTestCase (Fetch Package Node URL)
EventTriggerGetTestCase (Fetch Event Trigger Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
PackageAddTestCase (Fetch Package Node URL)
EventTriggerDeleteTestCase (Fetch Event Trigger Node URL)

pgAdmin 4 commit: Extract the generate_url(..) function from node.js, a

[Ashesh Vashi]

Extract the generate_url(..) function from node.js, and collection.js

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d527769bf8251595bf3adfcbd9c2a58e0ab1cc92
Author: Violet Cheng 

Modified Files
--
web/pgadmin/browser/static/js/collection.js| 51 
web/pgadmin/browser/static/js/node.js  | 49 +++
web/pgadmin/static/js/browser/generate_url.js  | 23 ++
.../javascript/browser/generate_url_spec.js| 95 ++
4 files changed, 147 insertions(+), 71 deletions(-)

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

[Wenlin Zhang]

Awesome, thanks!

Akshay Joshi 于2017年8月17日 周四下午8:24写道：

> Thanks patch applied.
>
> On Wed, Aug 16, 2017 at 11:30 AM, Violet Cheng  wrote:
>
>> Thanks Surinder! Hope it could be committed soon :)
>>
>> On Wed, Aug 16, 2017 at 1:34 PM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Hi Violet,
>>>
>>> I have already reviewed this patch. Here is the link
>>> 
>>> .
>>>
>>> Thanks,
>>> Surinder
>>>
>>> On Wed, Aug 16, 2017 at 8:57 AM, Violet Cheng  wrote:
>>>
 Hi,

 Any update on this patch? Could it be committed soon?

 Thanks,
 Violet

 On Fri, Aug 11, 2017 at 1:40 PM, Sarah McAlear 
 wrote:

> Hi!
>
> We fixed that issue and created a new patch
> 
> .
>
> Thanks!
>
> On Thu, Aug 10, 2017 at 4:10 PM, Violet Cheng 
> wrote:
>
>> Here's the Redmine link
>>
>> https://redmine.postgresql.org/issues/2644
>>
>> On Thu, Aug 10, 2017 at 4:03 PM, Violet Cheng 
>> wrote:
>>
>>> Hi Surinder!
>>>
>>> Are you referring to the green message popup? If so, it also appears
>>> to be happening on master. We'll log a bug in our backlog and Redmine 
>>> and
>>> prioritize it. We agree that it needs to be fixed, but don't think it's
>>> unrelated to this patch.
>>>
>>> Thanks!
>>> Violet & Sarah
>>>
>>> On Thu, Aug 10, 2017 at 2:32 PM, Surinder Kumar <
>>> surinder.ku...@enterprisedb.com> wrote:
>>>
 Please find attached screenshot.

 On Thu, Aug 10, 2017 at 11:30 AM, Surinder Kumar <
 surinder.ku...@enterprisedb.com> wrote:

> Hi Sarah,
>
> We noticed that due to this patch, the alert style of "Database
> connected" message is changed.
> Can you please look into this?
>
> Thanks,
> Surinder
>
> On Wed, Aug 9, 2017 at 4:43 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> ​Hi,
>>
>> ​The updated patch looks good to me.
>>
>> On Wed, Aug 9, 2017 at 4:15 PM, Sarah McAlear <
>> smcal...@pivotal.io> wrote:
>>
>>> As discussed with Surinder, we have created a Redmine ticket for
>>> his 4th comment regarding the error message not showing up when the 
>>> app
>>> can't be reached. This issue existed prior to this patch and should 
>>> be
>>> prioritized.
>>>
>>> https://redmine.postgresql.org/issues/2640
>>>
>>> Thanks!
>>> Matt & Sarah
>>>
>>> On Wed, Aug 9, 2017 at 4:06 PM, Sarah McAlear <
>>> smcal...@pivotal.io> wrote:
>>>
 Hi Surinder!

 I am not able to see anything different from what I see on
 Master with or without the patch applied. I tried adjusting the
 preferences. I did update the dashboard.js to instantiate a new 
 object,
 great idea!

 Thanks,
 Sarah



 On Wed, Aug 9, 2017 at 1:42 PM, Surinder Kumar <
 surinder.ku...@enterprisedb.com> wrote:

> Hi Wenlin,
>
> On Tue, Aug 8, 2017 at 3:15 PM, Wenlin Zhang <
> wzh...@pivotal.io> wrote:
>
>> Hi Surinder,
>>
>>Thanks for your review.
>>
>>We have changed the indentation for _dashboard.scss file
>> and also removed the style about icon-postgres:before, like
>> margin-top,etc, but we are not sure if it is perfectly aligned 
>> now, you can
>> add further change to it.
>>
>> As the second comment, I'm sorry I'm not sure what's the
>> problem, could you please clarify it? Because we replace css 
>> with scss
>> right now, dashboard.css doesn't exist. So maybe you are looking 
>> at the css
>> file that are complied by the scss?
>>
> ​Sorry I​ typed 'dashboard.css' instead of 'dashboard.js'.
> ​In dashboard.js can we change `return DashboardAlert;` to
> `return new DashboardAlert();`
> and then we can remove the instances being created(var
> alertDashboard = new AlertDashboard();) from dashboard.js, and 
> simply
> use `AlertDashboard.info('message')`.
>
>

Build failed in Jenkins: pgadmin4-master-python36 #280

[pgAdmin 4 Jenkins]

See 


Changes:

[akshay.joshi] User can not add New Server through Quick links. Fixes #2634

--
[...truncated 335.99 KB...]
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)
ViewsAddTestCase (Add materialized view under schema node)
ViewsDeleteTestCase (Delete materialized view under schema node)
ViewsGetTestCase (Get materialized view under schema node)
ViewsUpdateTestCase (Update materialized view under schema node)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL connection)

PostgreSQL 9.3:

157 tests passed
0 tests failed
15 tests skipped:
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL connection)

PostgreSQL 9.4:

157 tests passed
0 tests failed
15 tests skipped:
PackageAddTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
TableAddTestCase (Create Range partitioned table with 2 
partitions,
Create List partitioned table with 2 
partitions)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Attach partition to existing list 
partitioned table)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)
TestSSLConnection (Test for SSL connection)

PostgreSQL 9.5:

157 tests passed
0 tests failed
15 tests 

Re: [pgAdmin4][PATCH] To fix the add New Server through Quick links on Dashboard

[Akshay Joshi]

Thanks patch applied.

On Tue, Aug 8, 2017 at 1:55 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA updated patch for the same.
>
> Thanks Surinder for pointing that out, I assumed that we had a typo in
> that file.
>
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> [image: https://community.postgresrocks.net/]
> 
>
> On Tue, Aug 8, 2017 at 12:18 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi Murtuza,
>>
>> As type server-group is renamed to server_group, I can see there are
>> other occurrences of string server-group which needs to be replaced when
>> I perform search in pgAdmin4.
>>
>> Can you please take care of those occurrences?
>>
>> Thanks,
>> Surinder
>>
>> On Tue, Aug 8, 2017 at 12:02 PM, Murtuza Zabuawala
>> [murtuza.zabuaw...@enterprisedb.com](mailto:murtuza.
>> zabuaw...@enterprisedb.com)
>> 
>> wrote:
>>
>> Hi,
>>>
>>> PFA minor patch to fix the issue where add new server functionality
>>> through Quick link on Dashboard is broken.
>>> RM#2634
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> [image: https://community.postgresrocks.net/]
>>> 
>>>
>> ​
>>
>
>


-- 
*Akshay Joshi*
*Principal Software Engineer *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: User can not add New Server through Quick links. Fixe

[Akshay Joshi]

User can not add New Server through Quick links. Fixes #2634

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e9b80dae9c0dc3e054512c16b4c38a98c8980c93
Author: Murtuza Zabuawala 

Modified Files
--
.../browser/server_groups/servers/roles/static/js/role.js  |  3 +--
web/pgadmin/browser/templates/browser/js/utils.js  |  2 +-
web/pgadmin/dashboard/static/js/dashboard.js   | 10 ++
web/pgadmin/static/js/check_node_visibility.js |  2 +-
4 files changed, 9 insertions(+), 8 deletions(-)

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

[Akshay Joshi]

Thanks patch applied.

On Wed, Aug 16, 2017 at 11:30 AM, Violet Cheng  wrote:

> Thanks Surinder! Hope it could be committed soon :)
>
> On Wed, Aug 16, 2017 at 1:34 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi Violet,
>>
>> I have already reviewed this patch. Here is the link
>> 
>> .
>>
>> Thanks,
>> Surinder
>>
>> On Wed, Aug 16, 2017 at 8:57 AM, Violet Cheng  wrote:
>>
>>> Hi,
>>>
>>> Any update on this patch? Could it be committed soon?
>>>
>>> Thanks,
>>> Violet
>>>
>>> On Fri, Aug 11, 2017 at 1:40 PM, Sarah McAlear 
>>> wrote:
>>>
 Hi!

 We fixed that issue and created a new patch
 
 .

 Thanks!

 On Thu, Aug 10, 2017 at 4:10 PM, Violet Cheng 
 wrote:

> Here's the Redmine link
>
> https://redmine.postgresql.org/issues/2644
>
> On Thu, Aug 10, 2017 at 4:03 PM, Violet Cheng 
> wrote:
>
>> Hi Surinder!
>>
>> Are you referring to the green message popup? If so, it also appears
>> to be happening on master. We'll log a bug in our backlog and Redmine and
>> prioritize it. We agree that it needs to be fixed, but don't think it's
>> unrelated to this patch.
>>
>> Thanks!
>> Violet & Sarah
>>
>> On Thu, Aug 10, 2017 at 2:32 PM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Please find attached screenshot.
>>>
>>> On Thu, Aug 10, 2017 at 11:30 AM, Surinder Kumar <
>>> surinder.ku...@enterprisedb.com> wrote:
>>>
 Hi Sarah,

 We noticed that due to this patch, the alert style of "Database
 connected" message is changed.
 Can you please look into this?

 Thanks,
 Surinder

 On Wed, Aug 9, 2017 at 4:43 PM, Surinder Kumar <
 surinder.ku...@enterprisedb.com> wrote:

> ​Hi,
>
> ​The updated patch looks good to me.
>
> On Wed, Aug 9, 2017 at 4:15 PM, Sarah McAlear  > wrote:
>
>> As discussed with Surinder, we have created a Redmine ticket for
>> his 4th comment regarding the error message not showing up when the 
>> app
>> can't be reached. This issue existed prior to this patch and should 
>> be
>> prioritized.
>>
>> https://redmine.postgresql.org/issues/2640
>>
>> Thanks!
>> Matt & Sarah
>>
>> On Wed, Aug 9, 2017 at 4:06 PM, Sarah McAlear <
>> smcal...@pivotal.io> wrote:
>>
>>> Hi Surinder!
>>>
>>> I am not able to see anything different from what I see on
>>> Master with or without the patch applied. I tried adjusting the
>>> preferences. I did update the dashboard.js to instantiate a new 
>>> object,
>>> great idea!
>>>
>>> Thanks,
>>> Sarah
>>>
>>>
>>>
>>> On Wed, Aug 9, 2017 at 1:42 PM, Surinder Kumar <
>>> surinder.ku...@enterprisedb.com> wrote:
>>>
 Hi Wenlin,

 On Tue, Aug 8, 2017 at 3:15 PM, Wenlin Zhang  wrote:

> Hi Surinder,
>
>Thanks for your review.
>
>We have changed the indentation for _dashboard.scss file
> and also removed the style about icon-postgres:before, like
> margin-top,etc, but we are not sure if it is perfectly aligned 
> now, you can
> add further change to it.
>
> As the second comment, I'm sorry I'm not sure what's the
> problem, could you please clarify it? Because we replace css with 
> scss
> right now, dashboard.css doesn't exist. So maybe you are looking 
> at the css
> file that are complied by the scss?
>
 ​Sorry I​ typed 'dashboard.css' instead of 'dashboard.js'.
 ​In dashboard.js can we change `return DashboardAlert;` to
 `return new DashboardAlert();`
 and then we can remove the instances being created(var
 alertDashboard = new AlertDashboard();) from dashboard.js, and 
 simply
 use `AlertDashboard.info('message')`.


> For the fourth comment, we tried the steps you suggested
> on master branch, the error is not shown either. So it should be 
> an
> existing issue. But if you want to see the error message, 

pgAdmin 4 commit: Fixed alertify notification messages where checkmark

[Akshay Joshi]

Fixed alertify notification messages where checkmark box disconnected from 
frame. Fixes #2644

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dee5186f655b46ac239a504d676c571e1e071d20
Author: Sarah McAlear 

Modified Files
--
web/pgadmin/static/scss/_alertify.overrides.scss | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Unset compression ratio if it is an empty string in B

[Akshay Joshi]

Unset compression ratio if it is an empty string in Backup module. Fixes #2582

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c7686dee054ef8a77ace02c1c4e4eed65a475602
Author: Surinder Kumar 

Modified Files
--
web/pgadmin/tools/backup/__init__.py | 4 
web/pgadmin/tools/backup/static/js/backup.js | 6 ++
2 files changed, 10 insertions(+)

Re: [pgAdmin4][Patch]: RM_ 2582 - Backup : Fix compression value

[Akshay Joshi]

Thanks patch applied. I have adding server side validation too.

On Wed, Aug 16, 2017 at 6:11 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi
>
> *Issue:*
> In Backup, compression field can only accept values between 0 to 9. But if
> the field is clicked, an empty value is set into the model, So, added a
> check to remove the model attribute if the field is an empty string before
> data is sent to the server.
>
> Please find attached patch.
>
> Thanks,
> Surinder
>



-- 
*Akshay Joshi*
*Principal Software Engineer *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgAdmin4][Patch]: RM_2646 - Spinner icon not found error when a server node is connected

[Akshay Joshi]

Thanks patch applied.

On Fri, Aug 11, 2017 at 12:35 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi
>
> Since Acitree is removed from vendor directory, but when a server is
> connected, the load-node.gif file is still referencing tovendor directory
> instead of referencing to static/js/generated/load-node.gif.
>
> Fixed the reference path, now it points to static/js/generated/laod-node.
> gif.
>
> Please find attached patch and review.
>
> Thanks,
> Surinder
> ​
>



-- 
*Akshay Joshi*
*Principal Software Engineer *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Fixed the path reference of load-node.gif which was r

[Akshay Joshi]

Fixed the path reference of load-node.gif which was referencing to vendor 
directory. Fixes #2646

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bff48e0b2de6ba7e63f1f3ee8ae6cadfabf75938
Author: Surinder Kumar 

Modified Files
--
web/pgadmin/browser/server_groups/servers/templates/css/servers.css | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Re: [pgAdmin4][PATCH] To fix pgAgent job step issues

[Akshay Joshi]

Thanks patch applied with one minor change.

On Wed, Aug 16, 2017 at 6:12 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> Please find attached patch to fix below given issues from pgAgent Jobs
> Steps module.
> 1) 'Connection Type' cell was not honouring to 'Kind' option in Subnode
> control.
> 2) Kind option was not saved properly
> 3) User was not be able to update Kind option in edit mode.
> RM#2633
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> [image: https://community.postgresrocks.net/]
> 
>



-- 
*Akshay Joshi*
*Principal Software Engineer *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: 1) Connection Type cell was not honouring to 'Kind' o

[Akshay Joshi]

1) Connection Type cell was not honouring to 'Kind' option in Subnode control.
2) Kind option was not saved properly
3) User was not be able to update Kind option in edit mode.

Fixes #2633

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2df4625ce01847e840d00661010d8ac130ed093d
Author: Murtuza Zabuawala 

Modified Files
--
.../servers/pgagent/steps/static/js/pga_jobstep.js | 43 +-
.../pgagent/templates/macros/pga_jobstep.macros|  9 -
2 files changed, 48 insertions(+), 4 deletions(-)

Jenkins build is back to normal : pgadmin4-master-python27 #280

[pgAdmin 4 Jenkins]

See 

Re: Unified server/desktop config

[Dave Page]

Thanks. Out of interest, what changes were required?

All, this reinforces to me that this should be a v2.0 change. Other
thoughts?

On Mon, Aug 14, 2017 at 4:59 AM, Bing Xu  wrote:

> Hi hackers,
>
> We've reviewed this patch and it need us changing our own config_local.py
> file. It's ok and we'll do the change in our configuration.
>
> Thanks,
> Bing & Violet
>
> On Wed, Aug 9, 2017 at 8:49 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi
>>
>> This patch includes the fix where this patch breaks when feature tests
>> are run.
>>
>> Set builtins.SERVER_MODE if it is present in globals()['SERVER_MODE']
>> else set to None.
>>
>> Please find updated patch.
>> Thanks,
>> Surinder
>> ​
>>
>> On Wed, Aug 9, 2017 at 11:57 AM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Sure, I will update.
>>>
>>> On Wed, Aug 9, 2017 at 11:17 AM, Dave Page  wrote:
>>>
 Please update the patch :-)

 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK:http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 On 9 Aug 2017, at 05:53, Surinder Kumar  wrote:

 Hi,

 I noticed that test cases don’t run and I got an error:

 (pgAdmin_27)Laptop195:regression surinder$ python runtests.py --pkg 
 feature_tests
 
 Traceback (most recent call last):
   File "runtests.py", line 45, in 
 import config
   File "/Users/surinder/Documents/Projects/pgadmin4/web/config.py", line 
 121, in 
 if builtins.SERVER_MODE is None:
 AttributeError: 'module' object has no attribute'
 SERVER_MODE
 '

 I think this is because we are setting​ ​first​ ​builtins.SERVER_MODE​ in​ 
 ​pgAdmin4.py
 but in test cases pgAdmin4.py is not being called.​


 On Tue, Aug 8, 2017 at 4:03 PM, Dave Page  wrote:

>
>
> On Tue, Aug 8, 2017 at 11:27 AM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> On Tue, Aug 8, 2017 at 1:47 PM, Dave Page  wrote:
>>
>>
>>>
>>> On Tue, Aug 8, 2017 at 7:18 AM, Surinder Kumar <
>>> surinder.ku...@enterprisedb.com> wrote:
>>>
 Hi

 On Ubuntu-14.04, I got error Application Server couldn't be
 contacted:

 *Steps performed:*

- I have already installed pgAdmin4-1.4 which come with
PostgreSQL-9.6 installer.
then I run root@ubuntu:/opt/PostgreSQL/9.6/pgAdmin 4/bin#
./pgAdmin4./.
- Now took latest git pull from HEAD
- Apply unified_config.diff patch.
- Then compiled pgAdmin4 in runtime and then run ./pgAdmin.
- Got error Application Server couldn't be contacted.

 But when I ran ./pgAdmin4 for the second time. pgAdmin4 runs
 without any issue.
 I didn’t get any error on the terminal and log file.
 ​ I couldn't find why it gives this error.​

>>>
>>> I know Fahar has run into this with existing releases on Ubuntu. If
>>> you enable debugging, can you see any clues? I assume it's going round 
>>> the
>>> retry loop before aborting?
>>>
 *Another issue related to Alembic:*

 If I am running pgAdmin4 already installed on my machine, then I
 upgrade pgAdmin4 using Python wheel:

 (test_p27) surinder@ubuntu:~/virtualenvs/test_p27$ python
 ~/virtualenvs/test_p27/lib/python2.7/site-packages/pgadmin4/
 pgAdmin4.py

 *I am getting error:*

 alembic.util.exc.CommandError: Can't locate revision identified by
 'd85a62333272'

 To fix this, I have to delete existing pgadmin4.db file. I don’t
 know if it is a valid case or should I log an RM if it is?

>>> That's an annoying side-effect of the move to Alembic. The previous
>>> DB code would quite happily (and intentionally) run with a newer 
>>> version of
>>> the database, however, the new code does not. You'll see this issue
>>> whenever you've run a newer version of pgAdmin and then go back to an 
>>> older
>>> version that uses an older schema version.
>>>
>>> It would be nice to change this so it doesn't complain - but we'd
>>> have to be cautious to only break compatibility on major releases.
>>>
>>>
>>>
 Apart for this, I didn’t see any functionality break. It works!!
 ​

 I liked the approach to set SEVER_MODE in runtime using built-ins.

>>> Thanks. Do you think it warrants a 2.0 version number, given the
>>> potential for breaking existing installations (I do, but would like 
>>> other
>>> feedback)? If we do that - and thus allow a 

Re: [pgAdmin4][Patch]: Use the correct resultset type for Type module

[Akshay Joshi]

Thanks patch applied.

On Wed, Aug 9, 2017 at 4:25 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

>
> On Wed, Aug 9, 2017 at 8:57 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Thu, Aug 3, 2017 at 2:41 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> PFA minor patch to use fetch dict based data instead of 2d-array based
>>> in Type module as we are adding keys on the fly.
>>> There is no RM just a minor enhancement.
>>>
>> Harshal,
>>
>> Please review this one.
>>
> I tested this and it's working fine.
>
>
>
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> 
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> 
>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>


-- 
*Akshay Joshi*
*Principal Software Engineer *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Use dict based data instead of 2d-array in Type modul

[Akshay Joshi]

Use dict based data instead of 2d-array in Type module as we are adding keys on 
the fly.
Reviewed By: Harshal Dhumal

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2c6c4a16cecd8586c9ee5c9fa8456b6074813f46
Author: Murtuza Zabuawala 

Modified Files
--
.../browser/server_groups/servers/databases/schemas/types/__init__.py   | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)